Record UMA once during startup only for the browser process.
Bug: 768497
Change-Id: I24fa3eebe812ee4dc423390535e7b52ab8c6fcd1
Reviewed-on: https://chromium-review.googlesource.com/699697
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506595}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d0431dbd64a4c7f45125f9f23779cce1ec57d021
This reverts commit 1dd22ad042686bbf63b2f89efb466528cc682ffe.
Reason for revert:
Breaks when lint_suppressions_file is assigned within
//build_overrides/build.gni
Original change's description:
> Android: Allow per-target lint suppression configuration
>
> This change allows for Android lint suppression configurations
> to be defined on a per-target basis (assuming said target is
> "Android lint capable") rather than having one global config.
> This will allow embedders to keep upstream's lint config for
> Chromium targets (w/o patching), while using a separate config
> for the embedding application.
>
> Bug: 737897
> Change-Id: Ieccb95767e0ce541522d7a53edbe734c5bbfe6dc
> Reviewed-on: https://chromium-review.googlesource.com/698297
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506393}
TBR=agrieve@chromium.org,justmoto@amazon.com
Change-Id: Ib15a61731179cc9ffc8d415844cfe8fbbc8e68eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 737897
Reviewed-on: https://chromium-review.googlesource.com/701014
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506475}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2898491636d1bfc1bfddee39f07c7b8a6e1c6eb8
I've been testing the changes on net_parse_cookie_line_fuzzer,
which is a fuzz target of average size written in C++.
Improvements step by step:
0) Original configuration, Coverage + ASan:
158 MB 1,000 exec/s
1) Prohibit ASan (and other sanitizers), use only Coverage instrumentation:
132 MB same speed
The following change hasn't been applied, but let's keep it in the description FTR:
- 2) Disable sanitizer coverage (which is different from clang source-based coverage):
- 90 MB 1,088 exec/s (speed +8-10%)
3) Avoid optimize_for_fuzzing config (i.e. use -O3 instead of -O1 for coverage build):
Same size 1,773 exec/s (speed +60-65% on top of the previous change)
4) Disable coverage for libFuzzer source code:
88 MB 3,988 exec/s (speed +125% on top of previous changes)
5) Disable coverage for libc++ and libc++abi sources
(https://chromium-review.googlesource.com/#/c/chromium/buildtools/+/693570):
86 MB 4,110 exec/s (speed +3% on top of previous changes)
In total, for that particular target:
- build size reduced by ~45%
- execution speed increased by ~310%
I've also tested the changes with zlib_uncompress_fuzzer (a tiny fuzz target for C-library):
- build size reduced by ~83%
- execution speed increased by ~120%
I haven't measured impact on the other fuzz targets, so it may vary a lot,
but the result seems to be quite significant anyway.
Bug: 759794
Change-Id: Icf61c979e38d0f7849ab7281bd9e24cf2b7a7d02
Reviewed-on: https://chromium-review.googlesource.com/693564
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506454}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c8fee977deb6f47aaf602813b00428adfe7baa74
We have not shipped Windows Ash for years. There is a 1:1 mapping
between USE_ASH and OS_CHROMEOS, so consolidate them.
The BUILD.gn files will be cleaned up separately.
Bug: 673826
Test: compiles, gn check on Chrome OS, Linux and Linux Ozone
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5ebf64a133d1032f0d7864ed1a180d0f0b170da1
Reviewed-on: https://chromium-review.googlesource.com/692699
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506410}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9d34d23b29effc1aacc57463cabe47f30dc08b3
LLD is not applicable when using a different compiler (GCC at least)
Bug: chromium:607968
Change-Id: I5f4f53a5c91c52cc5ff9a0b9c5f2c5043c7add46
Reviewed-on: https://chromium-review.googlesource.com/700456
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506409}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7cc7a4d697d18f6d2755196f30a42131aa1616c2
This change allows for Android lint suppression configurations
to be defined on a per-target basis (assuming said target is
"Android lint capable") rather than having one global config.
This will allow embedders to keep upstream's lint config for
Chromium targets (w/o patching), while using a separate config
for the embedding application.
Bug: 737897
Change-Id: Ieccb95767e0ce541522d7a53edbe734c5bbfe6dc
Reviewed-on: https://chromium-review.googlesource.com/698297
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506393}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1dd22ad042686bbf63b2f89efb466528cc682ffe
Previous attempt: https://chromium-review.googlesource.com/c/chromium/src/+/698292
This time, the use_lld default uses current_{os,cpu} instead of
target_{os,cpu}, which prevents it from defaulting to true when
targeting NaCl.
Bug: 607968, 682777
Change-Id: Iedf5b2f9850df249172b7b543af312318e9beae9
Reviewed-on: https://chromium-review.googlesource.com/699741
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506313}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5581f58e288ebc2a6963dd434335d224b8f6297f
Was broken in several ways:
1. Permissions were not being granted upon install.
2. Needed custom logic to look at instrumentation name in meta-data.
3. BootstrapApplication logic needed to use the correct component name.
This logic has always been wrong, but never an issue until now.
4. BaseChromiumAndroidJUnitRunner needs to tell the Junit TestRequestBuilder
the location of all incremental dex files. This would actually also
be an issue when using AndroidJUnitRunner directly, except that
test_runner.py passes an explicit list of classes gleaned via
proguard, so no "find all classes" logic is needed in this case.
Bug: 762024
Change-Id: Ibc3880fdff14829d74926d1c576114b8551a5c9f
Reviewed-on: https://chromium-review.googlesource.com/688715
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506296}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca127560828fdaa1f72d81d7b81c2eabe61b2cd2
This reverts commit dd160677bc6cd8a5ab468c187f61902a8fbf4b41.
Reason for revert:
Broke Linux Builder (dbg)
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/116417
Original change's description:
> Switch to LLD as the default linker on Linux/x64.
>
> Until recently the main feature that we needed that was not fully
> implemented in LLD was --gdb-index; this feature has now been
> implemented, so we can start using LLD in more build modes than just
> official builds. LLD's implementation of --gdb-index requires all
> translation units to be compiled with -ggnu-pubnames, so this patch
> does that.
>
> Also enable --gdb-index in official builds; the corrupt debug info
> error no longer appears when using LLD.
>
> Perf numbers as follows, median of 10 runs.
>
> Release build (is_debug=false use_goma=true): gold 19.73s, lld 10.22s.
> Debug build (is_debug=true use_goma=true): gold 26.27s, lld 18.38s
>
> Bug: 607968, 682777
> Change-Id: Ia63abc15e61d77202d2ca738e6a8bdb0cfe98144
> Reviewed-on: https://chromium-review.googlesource.com/698292
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506224}
TBR=thakis@chromium.org,dpranke@chromium.org,pcc@chromium.org
Change-Id: Ic10bd05e43be064b66dbb6ef48063689d55dc85a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 607968, 682777
Reviewed-on: https://chromium-review.googlesource.com/699534
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506231}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6de9affa7a1bef1728d883462f44cbbae5326e6a
Until recently the main feature that we needed that was not fully
implemented in LLD was --gdb-index; this feature has now been
implemented, so we can start using LLD in more build modes than just
official builds. LLD's implementation of --gdb-index requires all
translation units to be compiled with -ggnu-pubnames, so this patch
does that.
Also enable --gdb-index in official builds; the corrupt debug info
error no longer appears when using LLD.
Perf numbers as follows, median of 10 runs.
Release build (is_debug=false use_goma=true): gold 19.73s, lld 10.22s.
Debug build (is_debug=true use_goma=true): gold 26.27s, lld 18.38s
Bug: 607968, 682777
Change-Id: Ia63abc15e61d77202d2ca738e6a8bdb0cfe98144
Reviewed-on: https://chromium-review.googlesource.com/698292
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506224}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd160677bc6cd8a5ab468c187f61902a8fbf4b41
This reverts commit f7b7b5ab8c2fc32d87928e131ec64cd213ee46b8.
Reason for revert: Will update when ready.
Change-Id: I5478e9a738b64a6a34a9937e080b59583f7c3f16
Reviewed-on: https://chromium-review.googlesource.com/698544
Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506174}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0904ce15333a33f85ead565625d2099406e1adc3
This output format is no longer supported by Telemetry.
Bug: 770700
Change-Id: I4f41e2a3d6cd102ccc680365449d6e4b0caa58b1
Reviewed-on: https://chromium-review.googlesource.com/697964
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506084}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e9de3fa38f92fb78d9f98d0461ea5a49463ff1d9
I used this to debug test listing in the instrumentation test runner.
This is nicer that using set-debug-app separately, because it disables
all timeouts (or else the process gets killed as you're debugging).
Change-Id: I7cd58c747534b3b539afcc84fcbae48475c4d9c3
Reviewed-on: https://chromium-review.googlesource.com/693218
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#506049}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d77bb0d5597845d282f38df6dbc9a8207cae0b84
In gn files, only both were checked, so combine them to a single
use_pangocairo flag.
Also run
ack -l skia::NativeDrawing printing/ | \
xargs sed -i 's/skia::NativeDrawing/printing::NativeDrawing/g'
since NativeDrawingContext got moved from skia/ to printing/
a while ago.
No intended behavior change.
Bug: none
Change-Id: Iba0a205b0026164bf434b7ad0ed246eff1f2c6f8
Reviewed-on: https://chromium-review.googlesource.com/693159
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505905}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8e55956b8552d57ca2c25686e621088de83c61e7
std::stack is a wrapper that defaults to std::deque. As part of our
std::deque removal, an implementation of stack that uses base::circular_deque
is provided.
Rewrites trace_event_argument.cc usage of stack to use indices and a
circular_deque since it was relying on storage stability across updates.
Changes the PPAPI/V8 variable conversion code to avoid unstable usage
of a stack. Fixes a use-after-free in V8VarConverter::ToV8Value where
the reference to the top of the stack was dereferenced after popping it
off.
BUG=757232
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4f3ff9b4c4403dafd809f7a6a77902a9cb59e5a0
Reviewed-on: https://chromium-review.googlesource.com/682761
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505705}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1f07f20e2cf89c72ea4c4948d73f386d7337ece3
GetPids() was returning org.chromium.chrome.tests.support for package
org.chromium.chrome.
Apparently DeviceUtils.d.GetMemoryUsageForPid() is deprecated, so moving
away from it.
NOTRY=true # tests flaked
Change-Id: Idfa85811d70f080a9fb0ea1190df95a1aba17f63
Reviewed-on: https://chromium-review.googlesource.com/695566
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505690}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4d0accee963b4dad848e6c5404bb47c3ee61071e
More targeted suppressions don't seem sufficient and there's not
a lot of stack to go on, so lets add a blanket suppression for
pulseaudio, since our bots and dev machines are running ancient
versions.
BUG=244856,757162
TEST=none
Change-Id: Ife022ff1584296279dde9bc4a9831fba01138f83
Reviewed-on: https://chromium-review.googlesource.com/690578
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505661}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bef716c8e4935748cd5a5f226786608401bbfc1c
* Color PID same as message
* Color ActivityManager as "dim"
* Color TID bright if it's the UI thread.
* Ignore most dalvikvm messages on pre-L
Bug: 758670
Change-Id: I6a7400615b2e521113d2f3f78834145092937f5e
Reviewed-on: https://chromium-review.googlesource.com/693081
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505628}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92c3534535bfcf65639b9e99748528f03d995f0d
If a file is removed from an asset catalog, it must be removed
from the copy in $target_gen_dir so convert the target to use
//build/config/ios/hardlink.py script to do the copy (it delete
the target before doing the copy).
Bug: 770634
Change-Id: Ib23df700cb1d553038306c546aa1fc04628bbf89
Reviewed-on: https://chromium-review.googlesource.com/695402
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505611}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d5d3e332166dc2bfad12c4947d8e59499a93e565
As application need to have their icon in the asset catalog
when built with Xcode 9.1+ remove the option to not compile
the assets.
Bug: 770634
Change-Id: If3bd3bb8dd412e359d4ec7c99915cec98d87b49e
Reviewed-on: https://chromium-review.googlesource.com/695303
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505605}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9750494f01342b4d28f89a9f4b5fad09f60b627
There are also some security updates for some of the packages.
Bug: 768027
Change-Id: Ibd2160d43e4f43f5344db8567c280cb154a96fc5
Reviewed-on: https://chromium-review.googlesource.com/693305
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505500}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95ecb913508e3dfc32afb93f6b930dc8d8514de9
Test: Manually installed packages to make sure no conflict
This is a reland of 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21
Original change's description:
> Add libdconf-dev to to install-build-deps.sh
>
> This is the first step in moving from using gconf to dconf.
>
> Bug: 768027
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}
Bug: 768027
Change-Id: I151d1c1e708fa763f3d2d5a4a18b44bfdbe351fd
Reviewed-on: https://chromium-review.googlesource.com/692616
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505437}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 357bdbf7f33061d9ecf3052813cced0e9da45498
bertholdherrmann08@googlemail.com reported this issue for WebRTC
and it seems easy to just add
r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise'
to the predefined paths.
BUG=webrtc:8299
Change-Id: I3bec73e2ef48e1a2b7e05a4df38faed2efc5ebfc
Reviewed-on: https://chromium-review.googlesource.com/691730
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505419}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 84e6c2d657fc4b56d6736eaacae55342058729c1
Script is failing on goobuntu-trusty_desktop-stable-amd64 due to packages conflict:
The following packages have unmet dependencies:
libdconf-dev : Conflicts: libdconf-dev:i386 but 0.20.0-1 is to be installed
libdconf-dev:i386 : Depends: libglib2.0-dev:i386 (>= 2.25.7) but it is not going to be installed
Recommends: libdconf-doc:i386 but it is not installable
Conflicts: libdconf-dev but 0.20.0-1 is to be installed
This reverts commit 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Add libdconf-dev to to install-build-deps.sh
>
> This is the first step in moving from using gconf to dconf.
>
> Bug: 768027
> Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
> Reviewed-on: https://chromium-review.googlesource.com/691097
> Commit-Queue: Tim Brown <timbrown@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505183}
TBR=dpranke@chromium.org,thomasanderson@chromium.org,timbrown@chromium.org
Change-Id: Icec37c78711a2016667ee7f134d5db49b918b7d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 768027
Reviewed-on: https://chromium-review.googlesource.com/692974
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505391}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3cd469287f3ce7290d3bfe3f1971aa529b6b1303
Ideally //build/config/features.gni would be empty (or, at least,
would only reference features defined inside of //build).
This CL moves the `enable_nacl` flag out of that file, and into
its own dedicated file, so that it has a much smaller scope and
we can help ensure that it is not referenced or needed by other
projects that are using //build but aren't building Chromium.
This work will be useful as part of the work we're doing to
make NaCl something that can be disabled directly in DEPS
(without needing to depend on GYP_DEFINES to do so).
TBR=bradnelson@chromium.org
R: brettw@chromium.org, bradleynelson@chromium.org, dschuff@chromium.org, phajdan.jr@chromium.org
Bug: 756688
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3af65646803912db67d421d35b4dfe9c2e0b703e
Reviewed-on: https://chromium-review.googlesource.com/688314
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505188}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ccc0c36006da95b6c8a681abd48609180eafdfcf
This is the first step in moving from using gconf to dconf.
Bug: 768027
Change-Id: Ifb05a6679c38e115b322e0a7caa6c3aad309389e
Reviewed-on: https://chromium-review.googlesource.com/691097
Commit-Queue: Tim Brown <timbrown@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505183}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5b267c0c4ffb22f07bea43853567c0b8a2ab9c21
On some machines - perhaps those which had VS 2015 installed, or perhaps
those that had early Windows 10 SDKs installed - an older version of
midl.exe ends up earlier in the path than the latest version and this
leads to spurious mismatch errors in midl.py. The ideal fix may be
tricky so this change disables the result checking temporarily to
unblock developers who have DEPOT_TOOLS_WIN_TOOLCHAIN=0.
Bug: 756607
Change-Id: I6d71f10939a65b629de58bb8646fa6f7c703e9de
Reviewed-on: https://chromium-review.googlesource.com/688836
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504935}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7fc9bf24c9bd2bc6bebb14e9cd7bd5167d83b990
There is an increasing need to use Windows features that only exist in
Windows 10 Creators Update or later. This is most conveniently done by
requiring that SDK. The packaged toolchain used by Google build machines
and Google employees has been using the Creators Update SDK for several
months - this CL only changes the requirement for those who are not
using the packaged toolchain. This update would have been done earlier
but several broken versions of the Creators Update SDK necessitated a
delay.
This change was triggered by crrev.com/c/649026 which had to be reverted
due to its dependence on the Creators Update SDK. This change will let
that change be relanded. Requiring the Creators Update SDK will also
allow ENABLE_HDR_DETECTION to be unconditionally defined.
After this change developers will get an informative error message if
they do not have the Creators Update SDK or later installed.
Note that Chrome, of course, still needs to *run* on versions of Windows
before Windows 10 Creators Update - this just covers *build*
requirements.
Bug: 760977
Change-Id: Ice36177e25cedb80555a3ebedaf9f710cafb1a88
Reviewed-on: https://chromium-review.googlesource.com/666023
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504773}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb0b9d315f449c822f61de545a67b4c3b14c6e60
Also fix logcat -v showing all logcat lines from before launch
Change-Id: I375c520bdc89a5d8b0f1e7b4cdcfbc739a7bdacc
Reviewed-on: https://chromium-review.googlesource.com/687557
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504762}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8fade5ff5cf0ce54530d26dfea9364233fbc5398
Seems the signature for this has changed slightly for some reason.
BUG=244856,757162
TEST=no more race
Change-Id: Ia733eb93e65e27a93d978c2b15e5901549335e5b
Reviewed-on: https://chromium-review.googlesource.com/683156
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504713}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4419eeffc1defc72a1c1cab8404f43e7af95316d
Proguard complains that there are two classes of the same name.
NOTRY=true # Passed all bots except win_chromium_rel_ng
Bug: 695304
Change-Id: If58bb871060dc073585ff9fc2b02e285602a5633
Reviewed-on: https://chromium-review.googlesource.com/685459
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504648}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0e888988728873892321b65bc1b6b148427a6b6e
GMS v11_3 (a.k.a. 11.0.4) is the last version available via sdkmanager.
Newer versions are available only through Maven.
BUG=751754
Change-Id: Ieabcb8f30302c932188562f877b53b25d0e0f1a3
Reviewed-on: https://chromium-review.googlesource.com/683217
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504515}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 46725b759b26fe270863580c4a0dd6bd164ded24
Should improve logdog stream visibility in the event of a timeout.
Bug: 768409
Change-Id: I94497c1b3fed557983c0d36112319fe2cb1bf282
Reviewed-on: https://chromium-review.googlesource.com/684055
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504505}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 438c6ab463a2c46857ecddd955a8f5d0eae58d3c
Expected to save ~700kb of .text on Android
Bug: 738155
Change-Id: I58886003c259a65cd2e66baa71e38bfa962a2b3d
Reviewed-on: https://chromium-review.googlesource.com/682647
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504283}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8a218af5c68598645675d76980984777c8429bb3
Tom Anderson
Eric Stevenson
Max Moroz
Andrew Grieve
James Cook
Oleh Prypin
Justin Okamoto
Peter Collingbourne
Evan Stade
Justin Cohen
Peter Mayo
Juan A. Navarro Perez
Sylvain Defresne
Nico Weber
Brett Wilson
Dale Curtis
Tim Brown
Henrik Kjellander
Dmytro Golovchenko
Lei Zhang
Sergey Berezin
Dirk Pranke
Bruce Dawson
Paweł Hajdan Jr.
Paul Miller
John Budorick
Edward Lemur