Reason for revert:
This breaks the asan build. See comments on the original CL.
Original issue's description:
> Non-SFI mode: Build nacl_helper_nonsfi_unittests
>
> This CL starts to build nacl_helper_nonsfi_unittests.
> The binary is not yet enabled to run on bots. It will be done in a following CL.
>
> TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests.
> BUG=358465
>
> Committed: https://crrev.com/72c418b09bbf90505f54df2b76285650acd97960
> Cr-Commit-Position: refs/heads/master@{#330069}
TBR=mseaborn@chromium.org,mdempsky@chromium.org,thakis@chromium.org,jln@chromium.org,hidehiko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=358465
Review URL: https://codereview.chromium.org/1145593002
Cr-Original-Commit-Position: refs/heads/master@{#330147}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aad01297ee28c48a3021339568cacaf16f37fdc0
This CL starts to build nacl_helper_nonsfi_unittests.
The binary is not yet enabled to run on bots. It will be done in a following CL.
TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests.
BUG=358465
Review URL: https://codereview.chromium.org/1137553003
Cr-Original-Commit-Position: refs/heads/master@{#330069}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 72c418b09bbf90505f54df2b76285650acd97960
This CL adds a unit testing harness for ui/gl tests.
In order to ensure that the bots do not break once they start running
these unit tests, gl_unittests currently it does not run any tests.
Once the bots successfully run gl_unittests, we can safely add tests
using the trybots to make sure the added tests actually work.
R=danakj@chromium.org, sievers@chromium.org
BUG=482067
Review URL: https://codereview.chromium.org/1121353002
Cr-Original-Commit-Position: refs/heads/master@{#328407}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 781489a282f6f7e19d7d449500cd2e91b2bc46a5
Changes from the first coommit.
- Define right dependencies to xdisplaycheck
- Fix build rules for midi_unittests_apk to run on Android
- Rebase error fixes (build rule deopendency adjustments)
Original commit is:
https://crrev.com/31624cad1a3b5cf26950b864837ba44b3aa38331
Original description follows:
Split MIDI related stuffs from media as a component in build files.
Also, MIDI related unit tests are split into midi_unittests.
BUG=475869
TEST=git cl try
TEST=ninja midi_unittests_apk && ./build/android/test_runner.py gtest midi_unittests
Review URL: https://codereview.chromium.org/1065743003
Cr-Original-Commit-Position: refs/heads/master@{#327712}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c6475779990f6ffdfa33d42b0bd97818df5e8d3c
Reason for revert:
Very sorry to have to revert this after so much work, but midi_unittests has been consistently broken on Android Tests bot e.g. https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/25597
Original issue's description:
> Web MIDI: split build rules for media/midi
>
> Split MIDI related stuffs from media as a component in build files.
> Also, MIDI related unit tests are split into midi_unittests.
>
> BUG=475869
> TEST=git cl try
>
> Committed: https://crrev.com/31624cad1a3b5cf26950b864837ba44b3aa38331
> Cr-Commit-Position: refs/heads/master@{#326247}
TBR=phajdan.jr@chromium.org,dalecurtis@chromium.org,dpranke@chromium.org,boliu@chromium.org,damienv@chromium.org,jam@chromium.org,thestig@chromium.org,lcwu@chromium.org,gunsch@chromium.org,toyoshim@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475869
Review URL: https://codereview.chromium.org/1085843003
Cr-Original-Commit-Position: refs/heads/master@{#326343}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 60006f2c430e17fc8338ff370a1c88cdc61b7f07
Split MIDI related stuffs from media as a component in build files.
Also, MIDI related unit tests are split into midi_unittests.
BUG=475869
TEST=git cl try
Review URL: https://codereview.chromium.org/1065743003
Cr-Original-Commit-Position: refs/heads/master@{#326247}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 31624cad1a3b5cf26950b864837ba44b3aa38331
WebViewShell used to live in the android repository. This patch
upstreams it to the chromium repository and adds a new target
android_webview_shell_apk. That way both the AndroidWebViewShell.apk
and SystemWebViewGoogle.apk can be built at the same time using one
checkout.
In particular this patch does the following:
- copy the relevant files residing in the android repository under
frameworks/webview/chromium/tools/WebViewShell/
- add necessary gyp files
- rename the package name to org.chromium.webview_shell
- some import clean ups and formatting
- replace license headers
BUG=475084
Review URL: https://codereview.chromium.org/1070563005
Cr-Original-Commit-Position: refs/heads/master@{#325854}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 86221dd2181ee4e29a0c30a8674ae263007e165f
A recent change set linux_dump_symbols=1 on the trybots
and was then reverted:
https://codereview.chromium.org/1081103005
The causes the ARM/Linux builder to fail since it was
attempting to run the target (ARM) dump_syms binary on
x86. This change makes dump_syms a host binary so that
it can run at build time.
BUG=476781
TEST=linux_arm_compile trybot
Review URL: https://codereview.chromium.org/1061473003
Cr-Original-Commit-Position: refs/heads/master@{#325661}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fe4acac6ff5547d7674e6681c9b556528520fdf7
This involves restructuring the remoting conditionals in gn_all and
gyp_remaining a fair amount, but otherwise no real surprises here.
There are a few chromeos-specific unittest targets in content that
we still need to port, but otherwise the port is as complete as desktop
linux.
BUG=433082
Review URL: https://codereview.chromium.org/1069903002
Cr-Original-Commit-Position: refs/heads/master@{#325097}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6293d2503965332696a292ff8a8da0a8f2a7ecc5
Use the same condition as chromium_builder_tests.
The targets are already in all_gn, and run on the trybots
via the chromium_builder_tests target. Putting them in All
just helps developers spot compile errors locally, before
they're caught by the bots.
Review URL: https://codereview.chromium.org/1053563004
Cr-Original-Commit-Position: refs/heads/master@{#324739}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f42e70932de69422378f3fef25df8afc4f2bb8e1
Reason for revert:
Seems to have broken the Win x64 debug builder:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20(dbg)/builds/7600
Original issue's description:
> Get gn_all/gyp_remaining working for Windows.
>
> This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before.
>
> A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL.
>
> R=brettw@chromium.org
> BUG=354261
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
>
> Committed: https://crrev.com/eaef8f504d6e2a55626e2fb8b6c233f1d756d65c
> Cr-Commit-Position: refs/heads/master@{#324285}
TBR=brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=354261
Review URL: https://codereview.chromium.org/1071603005
Cr-Original-Commit-Position: refs/heads/master@{#324291}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2fbb13254941a8a0c33695cbfde0389c53828e3b
This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before.
A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL.
R=brettw@chromium.org
BUG=354261
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1064333002
Cr-Original-Commit-Position: refs/heads/master@{#324285}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eaef8f504d6e2a55626e2fb8b6c233f1d756d65c
Initial configuration of GYP to enable building the
device_unittests target. USB, Serial, and HID disabled as
they currently do not compile, and are not blocking the
dependent issues of this change (enabling Web Bluetooth).
BUG=471536
Review URL: https://codereview.chromium.org/1028833002
Cr-Original-Commit-Position: refs/heads/master@{#322889}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b63d1ea55c453615dc19ab4212a4909d1580f79c
Renaming chrome_shell_unit_tests to chrome_junit_tests as it tests code in the directory of the chrome_java target (and not the chrome_shell_java target). Same thing for content_shell_unit_tests. And adding chrome_junit_tests and content_junit_tests to the all.gyp file so we can run the tests on some of the bots.
BUG=
Review URL: https://codereview.chromium.org/1039733002
Cr-Original-Commit-Position: refs/heads/master@{#322813}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e240ab4e9c5841de8cb65226a80008600416c365
Crashpad is always compiled in to Chrome and its handler is always
enabled. It is only possible to enable uploads in official builds.
Crashpad talks to the existing Breakpad server. There should be no
noticeable changes to crash reporting on the server side, except the
client IDs will all change to a new ID and will no longer be
synchronized with UMA client IDs. This is a one-time change. After this,
the client ID will remain stable within a single --user-data-dir.
BUG=386208,390217,415547,427611,crashpad:12
R=rsesek@chromium.orgTBR=cpu@chromium.org,jochen@chromium.org
Review URL: https://codereview.chromium.org/1001103002
Cr-Original-Commit-Position: refs/heads/master@{#320466}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d413b2dcb54d523811d386f1ff4084f677a6d089
Per the explanation in the bug, ui/ios should not have been created in
the first place; this code belongs in the ui/gfx subcomponent.
BUG=446643
Review URL: https://codereview.chromium.org/983413004
Cr-Original-Commit-Position: refs/heads/master@{#319720}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 018f5c02de9fc3e41c273b19e8eb60a503b05d57
This patch re-lands the original change plus the fixes I
had to introduce the 'gn_all' and 'gyp_remaining' targets
in the GYP build. This patch is thus reverting
378e940e (#318636).
The code was actually correct at #318636 but was failing
on the iOS bots due to problems w/ their recipes that have
since been fixed.
TBR=brettw@chromium.org
BUG=461019
Review URL: https://codereview.chromium.org/977703003
Cr-Original-Commit-Position: refs/heads/master@{#318960}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5b90c6fdbd3097080752fcf15f2f0e5ae4d3aec3
It looks like these patches might be confusing the
analyze step on the ios bots. I don't understand
the errors I'm seeing on them, but they seem to
have started when the first of these patches landed,
so I'm going to try reverting them and see what happens.
This reverts:
"Rework how the gn migration targets are included from all.gyp."
commit 91cb1747a84d80acc9fc5045c971986f1799e02b (#318599).
"Fix a build failing in the x86 linux builds ..."
commit 425ba073036f96f04aea09c9836826ccb2e124e4. (#318626)
"Fix nacl-only targets in gn_migration.gypi"
commit ad333257fe8e7d9b632f728de5fe6db9feb9a64d. (#318631)
TBR=brettw@chromium.org
BUG=461019
NOTRY=true
Review URL: https://codereview.chromium.org/971633002
Cr-Original-Commit-Position: refs/heads/master@{#318636}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 378e940e74d07896695b6bd1582de760bab7c3b1
If NaCl is disabled, we get a build failure in the
x86 Linux builds when trying to build monacl_shell
(which isn't defined).
This patch fixes the issue by not trying to include
the gn_migration targets *and* by not trying to
build monacl_shell when nacl is disabled, both of
which were wrong.
Also, this patch fixes an issue in 'analyze' where it
was trying to analyze build_utf8_validator_tables
and not #host.
TBR=brettw@chromium.org
BUG=462945, 461019
Review URL: https://codereview.chromium.org/966223002
Cr-Original-Commit-Position: refs/heads/master@{#318626}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 425ba073036f96f04aea09c9836826ccb2e124e4
This change splits out the targets being used to track the gn
migration from all.gyp into a separate, new file
(gn_migration.gypi), and reworks their structure to
1) better match the gn_all target in src/BUILD.gn,
2) identify the targets built by 'all' in gyp that
are not yet explicitly listed in the gn_all target
(the new 'add_to_gn_all' target),
3) identify the targets left to be converted.
The 'add_to_gn_all' targets will simply be moved to gn_all in
a follow-up CL.
Right now these targets will be linux-only, but follow-up CLs
will expand them to the other configurations.
This CL should produce no actual changes in the builds.
R=brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/962343002
Cr-Original-Commit-Position: refs/heads/master@{#318599}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 91cb1747a84d80acc9fc5045c971986f1799e02b
The gn_all target in all.gyp is attempting to build ':image_diff#host',
which I think may not work correctly in a chromeos==1 build. I think
the '...#host' syntax should probably only be used on the android port
(looks like that's what content_shell.gypi does). Though, given that
we're building content_shell, we shouldn't need the image_diff
dependency at all, so I'm just deleting it outright.
TBR=abodenha@chromium.org, brettw@chromium.org, hshi@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=461602
Review URL: https://codereview.chromium.org/951553004
Cr-Original-Commit-Position: refs/heads/master@{#317953}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 88ba00883a3d5f9b8b9fbc498d444d4f61b7560f
The take #2 attempt had a typo that produced an invalid gyp file.
I'm not real sure how that got through as I was fairly certain
I had testing this locally.
TBR=brettw@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=
Review URL: https://codereview.chromium.org/954853002
Cr-Original-Commit-Position: refs/heads/master@{#317919}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a9c0402809eded6bcf7d8a9d2e5eddbd80324a34
The prior fix -- #317907 -- used "iOS" instead of "ios".
The initial change disabled the "blink_tests" target, and also had a redundant conditions block.
My first attempt at a fix fixed blink_tests, but typo'ed "iOS" instead of "ios", causing the iOS bots to pick up stuff that couldn't build, and fail.
TBR=brettw@chromium.org
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/953803004
Cr-Original-Commit-Position: refs/heads/master@{#317914}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2f69645f3a92b8386435a17b13ff3b9e52bf01c8
In order to be able to make sure we are building the same list of targets
in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all'
targets.
Eventually, we should make sure that if one builds 'gn_all', then building
'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this
is a start.
The 'gn_all' target replaces the //:root target in the GN builds.
TBR=brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/953463003
Cr-Original-Commit-Position: refs/heads/master@{#317893}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e2ef382dd208417056acbd579620a428fa1b7af4
Reason for revert:
Suspecting this breaks Mac builds.
http://build.chromium.org/p/chromium/builders/Mac/builds/33993
Original issue's description:
> add gn_all, gyp_all targets to the build files, remove GN's //:root
>
> In order to be able to make sure we are building the same list of targets
> in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all'
> targets.
>
> Eventually, we should make sure that if one builds 'gn_all', then building
> 'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this
> is a start.
>
> The 'gn_all' target replaces the //:root target in the GN builds.
>
> R=brettw@chromium.org
> BUG=461019
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
>
> Committed: https://crrev.com/ff30e3de333305ccdaa103aa7f9e46765da83e99
> Cr-Commit-Position: refs/heads/master@{#317760}
TBR=brettw@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461019
Review URL: https://codereview.chromium.org/944573003
Cr-Original-Commit-Position: refs/heads/master@{#317763}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6d374cf7ead69b3ff110f9d7dfba0dee921e6b7
In order to be able to make sure we are building the same list of targets
in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all'
targets.
Eventually, we should make sure that if one builds 'gn_all', then building
'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this
is a start.
The 'gn_all' target replaces the //:root target in the GN builds.
R=brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/936193004
Cr-Original-Commit-Position: refs/heads/master@{#317760}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff30e3de333305ccdaa103aa7f9e46765da83e99
In order to be able to use it in places other than content (e.g. handles
for unified touch selection controller), ImageWindowDelegate is moved to
a new ui module called aura_extra.
Also, to make it more useful, ImageWindowDelegate can now be customized
by setting background color and image offset.
COLLABORATOR=mfomitchev
BUG=399721
Review URL: https://codereview.chromium.org/880703002
Cr-Original-Commit-Position: refs/heads/master@{#315344}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 166a918168791ad0f62ee28862ef520c5d7fbf35
On Windows, this moves it to chrome_child.dll. Overall binary sizes is 4.5 MB smaller (chrome_child.dll gets 3.6 MB larger while we drop the 8.1 MB pdf.dll). On Mac, the binary is 6.6 MB smaller. On Linux, it's 7MB smaller. This is from official release builds, after stripping on Linux.
The size savings are because we don't ship duplicate versions of V8, and also the PDF plugin uses some of base and net.
This depends on OOP PDF, since otherwise the V8 isolates for the plugin and Blink interact badly. That got turned on a few weeks ago.
BUG=453844
Review URL: https://codereview.chromium.org/799643004
Cr-Original-Commit-Position: refs/heads/master@{#314575}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dc0e4390c0364515fa360c5292a4389784580a48
"by default" = whenever we build Chromoting.
This is a re-land of crrev.com/878793003, which failed on
the Official builds.
The build problem has been fixed in crrev.com/886543002.
BUG=
Review URL: https://codereview.chromium.org/875463004
Cr-Original-Commit-Position: refs/heads/master@{#314160}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 108f744ccea14feb5019f1f8787fa3c265e83d0e
This target provides Chromium embedders with an elegant way to include
additional targets for all platforms.
BUG=453606
Review URL: https://codereview.chromium.org/882253007
Cr-Original-Commit-Position: refs/heads/master@{#313831}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 25c9c6c9b35147b4d3e9bababade01d9fe444968
mnaganov
hans
hidehiko
dyen
toyoshim
jaekyun
aboxhall
dpranke
timvolodine
sbc
tapted
gunsch
scheib
mikecase
sebmarchand
jmadill
mark
stuartmorgan
tfarina
dcastagna
hiroshige
jam
mohsen
garykac
daniimms
brettw