We would like to use app_shell as the basis for all
content-browser integration tests within the
extensions layer.
This simply moves the test target up to the parent
//extensions path and renames it to
extensions_browsertests
BUG=388893
R=yoz@chromium.org
Review URL: https://codereview.chromium.org/797023006
Cr-Original-Commit-Position: refs/heads/master@{#312669}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ea9df2af195b5b08909dc30e05bab95f6cfcd66f
This CL move //mojo/public and //mojo/edk to live in the following locations:
- //third_party/mojo/src/mojo/public
- //third_party/mojo/src/mojo/edk
It moves the related gypfiles from //mojo to //third_party/mojo and updates
them as necessary to account for the file moves. It also updates clients of the
mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK
and EDK build systems are maintained in the Mojo repo and designed to be
flexible wrt the location of the SDK/EDK in a client repo, so no changes are
needed.
This CL does not update include paths to the code being moved to limit the
number of moving parts, instead relying on the include_dirs that the SDK and
EDK targets supply to their direct dependents to ensure that include paths
continue to resolve correctly.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/814543006
Cr-Original-Commit-Position: refs/heads/master@{#312129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 70fb54767b472a5edfb859e489beeeec7abdb0e4
This should be a lightweight test suite that should allow a dev changing
something in skia/ext to test it much more quickly than having to build
all 'unit_tests' target just to run the tests from skia/ext.
It was reverted because it broke Mac GN with error like:
duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in:
obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o
obj/skia/ext/skia.skia_utils_mac.o
(and more similar issues).
BUG=444058
TEST=skia_unittests links and runs fine.
R=danakj@chromium.org,thakis@chromium.org,glider@chromium.org,sky@chromium.org
TBR=glider@chromium.org (already reviewed tools/valgrind - and no changes were made at that directory).
Review URL: https://codereview.chromium.org/837243002
Cr-Original-Commit-Position: refs/heads/master@{#310688}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0f9c5eed19153d16a29a206356ff581e003f514a
Reason for revert:
Fails linking on the Mac GN builder:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/2094
duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in:
obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o
obj/skia/ext/skia.skia_utils_mac.o
(and more similar issues)
Original issue's description:
> skia: Add 'skia_unittests' test suite for this directory.
>
> This should be a lightweight test suite that should allow a dev changing
> something in skia/ext to test it much more quickly than having to build
> all 'unit_tests' target just to run the tests from skia/ext.
>
> BUG=444058
> TEST=skia_unittests links and runs fine.
> R=danakj@chromium.org,thakis@chromium.org
>
> Committed: https://crrev.com/c87c3d2d949f9ba4f17627dc023b303c75b7635f
> Cr-Commit-Position: refs/heads/master@{#310310}
TBR=danakj@chromium.org,thakis@chromium.org,glider@chromium.org,sky@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=444058
Review URL: https://codereview.chromium.org/816803003
Cr-Original-Commit-Position: refs/heads/master@{#310314}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 164a39b1806a6261868bc6b2103e24b543251669
This should be a lightweight test suite that should allow a dev changing
something in skia/ext to test it much more quickly than having to build
all 'unit_tests' target just to run the tests from skia/ext.
BUG=444058
TEST=skia_unittests links and runs fine.
R=danakj@chromium.org,thakis@chromium.org
Review URL: https://codereview.chromium.org/815023003
Cr-Original-Commit-Position: refs/heads/master@{#310310}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c87c3d2d949f9ba4f17627dc023b303c75b7635f
mojo_nacl.gyp has to be split into two gyp files:
* One that provides "normal" targets, and
* one that provides "untrusted" targets.
This is because build/common_untrusted.gypi sets clang=1 for all ARM builds.
For untrusted targets, this is reasonable, but this can break ARM builds of
chrome for normal targets (by passing clang flags to g++).
BUG=445489
Review URL: https://codereview.chromium.org/826393003
Cr-Original-Commit-Position: refs/heads/master@{#309784}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39a76697e0fe1769e2ebbcf2c302b02aeedd5ed5
Very basic support for app_shell on Mac cocoa. It allows building and running app_shell, app_shell_unittests, and app_shell_browsertests on Mac. It introduces app_shell_framework and app_shell_helper targets. Much of the work is based on the content_shell equivalents.
The above targets build as part of 'all' on Mac, but are not yet covered by trybots.
Shortcomings compared to Aura:
- The AppShell desktop controller doesn't support tracking multiple app windows.
- Running App Shell --load-apps works (at least for the Calculator sample) but can only be exited via ^C at the command line, and there is no Mac menu.
BUG=399363
Review URL: https://codereview.chromium.org/745093002
Cr-Original-Commit-Position: refs/heads/master@{#309256}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 289ee7c3b41766e6996b6a7d6ecd5a574b2a147e
These files are owned by chromium now. It would not only be weird
to inject them into the rolled mojo directory structure, but doing
so would unnecessarily complicate the mojo up-rev procedure.
BUG=None
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/807773002
Cr-Original-Commit-Position: refs/heads/master@{#308622}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 829dc9ae81e2ad2f6b890dde15cbe2fc299bc711
Some blink performance suites need content_shell. To enable the suites,
add content_shell to dependency list of chromium_builder_perf.
This will increase the build time for compiling several C++ files and
linking content_shell, which should be a small addition to the current
build time.
BUG=426599
TBR=dtu
Review URL: https://codereview.chromium.org/783813004
Cr-Original-Commit-Position: refs/heads/master@{#307538}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 80e0ecb4181d786815db04b21e76032ad932e5a2
This patch is only moving new unified touch selection files from
content/ to ui/touch_selection/. This is the first step to allow Aura
use the new unified TouchSelectionController.
The only change to TouchSelectionController needed for this move is
replacing use of cc::ViewportSelectionBound with ui::SelectionBound.
The actual use of the new touch selection for Aura will happen in future
CL(s). After that, we can remove current touch selection code from
ui/base/touch/.
BUG=399721
Committed: https://crrev.com/29fd405ca491a6fcf0dde6277d92d44300cb2926
Cr-Commit-Position: refs/heads/master@{#307336}
Review URL: https://codereview.chromium.org/759433002
Cr-Original-Commit-Position: refs/heads/master@{#307514}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f837da7c7807d4dc84733b201ac74a6bab9ae3a5
When unit_tests was turned down on iOS, no chrome.gyp target was added
to replace it in all.gyp, so nothing has been exercising that part of
the build system on iOS.
This adds 'browser', and fixes issues that have crept in since then.
Most notably:
- Removes chrome_browser_non_android_sources, moving everything that
was there to ..._non_mobile_sources
- Removes an iOS-only class that was removed downstream, and had
rotted upstream.
This won't find link issues, but will at least ensure that the gyp
files continue working on iOS for as long as they are necessary.
BUG=None
Review URL: https://codereview.chromium.org/785233002
Cr-Original-Commit-Position: refs/heads/master@{#307496}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d39fdf1a95d374fe589c7f5accff4384f6cf352
Reason for revert:
Suspected of causing Win8 GN failure
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/1552/steps/compile/logs/stdio#error1
FAILED: ninja -t msvc -e environment.x86 -- "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/ui/base/dragdrop/ui_base_unittests.os_exchange_data_provider_aurax11_unittest.obj.rsp /c ../../ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc /Foobj/ui/base/dragdrop/ui_base_unittests.os_exchange_data_provider_aurax11_unittest.obj /Fdobj/ui/base/ui_base_unittests_cc.pdb
c:\b\build\slave\win8_gn\build\src\ui\base\dragdrop\os_exchange_data_provider_aurax11.h(8) : fatalerror C1083: Cannot open include file: 'X11/Xlib.h': No such file or directory
Original issue's description:
> Move TouchSelectionController from content to ui
>
> This patch is only moving new unified touch selection files from
> content/ to ui/touch_selection/. This is the first step to allow Aura
> use the new unified TouchSelectionController.
>
> The only change to TouchSelectionController needed for this move is
> replacing use of cc::ViewportSelectionBound with ui::SelectionBound.
>
> The actual use of the new touch selection for Aura will happen in future
> CL(s). After that, we can remove current touch selection code from
> ui/base/touch/.
>
> BUG=399721
>
> Committed: https://crrev.com/29fd405ca491a6fcf0dde6277d92d44300cb2926
> Cr-Commit-Position: refs/heads/master@{#307336}
TBR=jdduke@chromium.org,mfomitchev@chromium.org,sadrul@chromium.org,boliu@chromium.org,jam@chromium.org,mohsen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399721
Review URL: https://codereview.chromium.org/754963007
Cr-Original-Commit-Position: refs/heads/master@{#307344}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6b150518257d898af57991939f9481bc3e95b5e7
This patch is only moving new unified touch selection files from
content/ to ui/touch_selection/. This is the first step to allow Aura
use the new unified TouchSelectionController.
The only change to TouchSelectionController needed for this move is
replacing use of cc::ViewportSelectionBound with ui::SelectionBound.
The actual use of the new touch selection for Aura will happen in future
CL(s). After that, we can remove current touch selection code from
ui/base/touch/.
BUG=399721
Review URL: https://codereview.chromium.org/759433002
Cr-Original-Commit-Position: refs/heads/master@{#307336}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 29fd405ca491a6fcf0dde6277d92d44300cb2926
This patch mostly consists of testing environment for web WebClient. While
WebClient intended to be base for a new DeviceProvider in DevTools frontend
(https://codereview.chromium.org/720133002/) it is convinient to run
tests on android. It lets to test the client directly against server
counterpart avoiding flakiness of network and cloud services.
TBR=jochen@chromium.org
BUG=383418
Review URL: https://codereview.chromium.org/736363002
Cr-Original-Commit-Position: refs/heads/master@{#305131}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff7a801dfddaa22643accaf3e0df192470fb7a7b
Includes updates to ipc/mojo/ipc_channel_mojo.cc for mojo::embedder API
changes and updates to use mojo::Binding<> in ui/keyboard and
device/battery.
Review URL: https://codereview.chromium.org/728133002
Cr-Original-Commit-Position: refs/heads/master@{#304731}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a9125266d3fc89ff0bfd4c3a05bf2f31ffaeff1f
This pulls some code out of app_installer_main into app_installer_util
and adds a new app_installer_unittests target.
BUG=430790
Review URL: https://codereview.chromium.org/689903003
Cr-Original-Commit-Position: refs/heads/master@{#303955}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9f3e1fba3e060a0e7317ea1231a10a21afaaa39e
Reason for revert:
Breaks Linux ChromiumOS Ozone Builder
http://goo.gl/oHjcNA
________ running '/usr/bin/python src/build/gyp_chromium' in '/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build'
Updating projects from gyp files...
Traceback (most recent call last):
File "src/build/gyp_chromium", line 318, in <module>
gyp_rc = gyp.main(args)
File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 525, in main
return gyp_main(args)
File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 501, in gyp_main
params, options.check, options.circular_check)
File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 129, in Load
params['parallel'], params['root_targets'])
File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/input.py", line 2745, in Load
RemoveLinkDependenciesFromNoneTargets(targets)
File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/input.py", line 1489, in RemoveLinkDependenciesFromNoneTargets
if targets[t].get('variables', {}).get('link_dependency', 0):
KeyError: '/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/remoting/remoting.gyp:remoting_host#target'
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /b/build/slave/Linux_ChromiumOS_Ozone_Builder/build
Hook '/usr/bin/python src/build/gyp_chromium' took 14.48 secs
Original issue's description:
> Add remoting_host target to chromium_builder_webrtc dependencies.
>
> This will make it possible for us to catch compile failures in the
> remoting_host component when rolling the WebRTC and libjingle revisions
> in Chromium DEPS using the bots in
> http://build.chromium.org/p/chromium.webrtc.fyi/waterfall
>
> Committed: https://crrev.com/32e1bf6e3fcc38662eb1dd1b0a1a2739a95992ec
> Cr-Commit-Position: refs/heads/master@{#303436}
TBR=perkj@chromium.org,kjellander@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/713023002
Cr-Original-Commit-Position: refs/heads/master@{#303453}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9bc77cc968237f28405aa16a1d8f50a9e39760a9
As we discussed in the email thread DevTools Bridge must not depend on libjingle_peerconnection_so.so
for several reasons. To aheive that we need implementation of SessionDependencyFactory
on top of libjingle's C++ API. This CL adds dummy SessionDependencyFactoryNative and
introduces additional test APK. Both testing APKs will coexist for a while. When
SessionDependencyFactoryNative be ready to replace Java API counterpart additional APK
also won't be needed.
BUG=383418
Review URL: https://codereview.chromium.org/704613003
Cr-Original-Commit-Position: refs/heads/master@{#303421}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3c76b33f9d02ffc9b386cbbd0351e9957fd8ef66
The NSS dependency should be guarded by a use_openssl check. BoringSSL and NSS
cannot be linked together as they define some of the same symbols. Update BUILD.gn
analogously by depending on //crypto:platform.
Also condition nss in build/all.gyp on use_openssl in preparation for
https://codereview.chromium.org/694643002/ which will disable the nss and nspr
targets altogether.
BUG=429021
Review URL: https://codereview.chromium.org/686693004
Cr-Original-Commit-Position: refs/heads/master@{#302325}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d1be6eac818a2f9b35973814c9ff1740fdca2863
Pair of ClientSession and ServerSession holds WebRTC connection which tunnels DevTools UNIX socket.
Once cloud based signaling channel doesn't exist at the moment connections work on a single android device. For manual testing the testing APK has launch activity which lets to start service which tunnels Chrome Shell socket to another local socket (only works when Chrome Shell signed with the same certificate).
BUG=383418
TEST=Automatic: LocalSessionBridgeTest, SessionControlMessagesTest. See description for manual testing.
R=mnaganov@chromium.org
Review URL: https://codereview.chromium.org/537253003
Cr-Original-Commit-Position: refs/heads/master@{#299871}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a25a26c53da3c9ee6bce24cf5ce9a60e81d97c39
The targets in the mojo public SDK, i.e. those in mojo/public/, should
be free of dependencies outside of mojo/public/ and usable in a
standalone fashion. This moves the gyp definitions from
mojo/mojo_base.gyp, which also contains a number of non-public targets,
to mojo/public/mojo_public.gyp.
R=viettrungluu@chromium.orgTBR=darin@chromium.org for updating various gyp entries to point to new target location
Review URL: https://codereview.chromium.org/632853002
Cr-Original-Commit-Position: refs/heads/master@{#298422}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b83f9dcb4940d4700632fe9e925abec779ad84ef
the gles2 conformance tests in the khronos GL-CTS test
suite using its new drawElements APIs.
Requires the khronos GL-CTS source to be available in
src/third_party/khronos_glcts. This support targets the
Khronos 3.X branch of ogles/conform at rev 26950.
Define the build option internal_khronos_glcts_tests=1
to build the tests.
Initial support is for Chromium on ChromiumOS. Other targets
may need to be ported for build support as well.
v2: Fix AUTHORS. Change naming convention from khronos_conform
to khronos_glcts. (piman, kbr)
v3: Ran git cl format on egl_native_windowless.cc so it matches
the chromium style. (piman)
v4: Use AppendArg instead of AppendSwitch to hopefully
circumvent a repeat of chromium:408251. (kbr)
v5: Handle FilePath's correctly for Windows compatibility.
v6: Rebase; Remove -fno-exceptions from cflags_cc
BUG=chromium:412865
R=piman@chromium.org, kbr@chromium.org, darin, brettw, cpu
TEST=Build and run the khronos_glcts_test binary
Review URL: https://codereview.chromium.org/556333003
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Review URL: https://codereview.chromium.org/556333003
Cr-Original-Commit-Position: refs/heads/master@{#297567}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ffbb37ebec861db6e93471a5837727ea8d974f91
This is in preparation for updating the buildbot code. First we need to
make sure we build those targets, otherwise buildbot will fail.
BUG=331829,373148,299841,103304
TEST=None
R=sky@chromium.org,maruel@chromium.org
Review URL: https://codereview.chromium.org/600833002
Cr-Original-Commit-Position: refs/heads/master@{#296877}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 430fc906824927713d5a318afb50654e95b699b0
Reason for revert:
Didn't help. We probably got scheduled on other, flakier Android devices which caused tests to start flaking, or something else is the root cause.
Original issue's description:
> Revert of [Android] JUnit runner + gyp changes. (patchset #15 id:280001 of https://codereview.chromium.org/574433003/)
>
> Reason for revert:
> Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905.
>
> Original issue's description:
> > [Android] JUnit runner + gyp changes.
> >
> > This adds Java code for running junit tests, as well as gyp targets for
> > both runnable and non-runnable host-side JARs.
> >
> > BUG=316383
> >
> > Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174
> > Cr-Commit-Position: refs/heads/master@{#296340}
>
> TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=316383
>
> Committed: https://crrev.com/54b9408f8b18e3bf3a33343e375186e1949e8e86
> Cr-Commit-Position: refs/heads/master@{#296384}
TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=316383
Review URL: https://codereview.chromium.org/596303002
Cr-Original-Commit-Position: refs/heads/master@{#296406}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6e9dc50aecf078d7826fe8e4611b2c238aab3f23
Reason for revert:
Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905.
Original issue's description:
> [Android] JUnit runner + gyp changes.
>
> This adds Java code for running junit tests, as well as gyp targets for
> both runnable and non-runnable host-side JARs.
>
> BUG=316383
>
> Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174
> Cr-Commit-Position: refs/heads/master@{#296340}
TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=316383
Review URL: https://codereview.chromium.org/597123002
Cr-Original-Commit-Position: refs/heads/master@{#296384}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 54b9408f8b18e3bf3a33343e375186e1949e8e86
Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.
This CL doesn't care of a few known issues:
1. Data channel buffer overflow. Data channel automatically closed in this case.
2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).
To keep this CL reasonably simple this issues will be addressed later.
TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
BUG=383418
Committed: https://crrev.com/15044609893faf9b2c2a533aa9a136f288ea20a1
Cr-Commit-Position: refs/heads/master@{#296360}
Review URL: https://codereview.chromium.org/517233002
Cr-Original-Commit-Position: refs/heads/master@{#296377}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6c788d675dba4ec185375863cbc53c0803cc4b3e
Reason for revert:
Fails to compile on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20(dbg)/builds/2163
devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/SocketTunnelServerTest.java:291: cannot find symbol
symbol: method sleep()
sleep();
^
Original issue's description:
> Implementation of DevTools socket tunneling service for remote debugging.
>
> Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.
>
> This CL doesn't care of a few known issues:
> 1. Data channel buffer overflow. Data channel automatically closed in this case.
> 2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
> 3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).
>
> To keep this CL reasonably simple this issues will be addressed later.
>
> TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
> BUG=383418
>
> Committed: https://crrev.com/15044609893faf9b2c2a533aa9a136f288ea20a1
> Cr-Commit-Position: refs/heads/master@{#296360}
TBR=mnaganov@chromium.org,tedchoc@chromium.org,erikwright@chromium.org,serya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418
Review URL: https://codereview.chromium.org/597063002
Cr-Original-Commit-Position: refs/heads/master@{#296361}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cf0900dae461d90af8ed7604da098690d7c744c3
Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.
This CL doesn't care of a few known issues:
1. Data channel buffer overflow. Data channel automatically closed in this case.
2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).
To keep this CL reasonably simple this issues will be addressed later.
TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
BUG=383418
Review URL: https://codereview.chromium.org/517233002
Cr-Original-Commit-Position: refs/heads/master@{#296360}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 15044609893faf9b2c2a533aa9a136f288ea20a1
This adds Java code for running junit tests, as well as gyp targets for
both runnable and non-runnable host-side JARs.
BUG=316383
Review URL: https://codereview.chromium.org/574433003
Cr-Original-Commit-Position: refs/heads/master@{#296340}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2e56d4508e33de5fc60bbbb41c5a5d5534e88174
Reason for revert:
This is slowing down the trybots because it's uploading these files even though they're not used on trybots. look at how gpu isolates that are only used on the GPU builders are handled (there's a gyp variable which is only set by the builders which run these tests)
Original issue's description:
> Swarming configuration files for chromoting integration tests.
>
> BUG=
>
> Committed: https://crrev.com/d90ba4c4e4ddf5c4cbb6cf812c9571d628e30567
> Cr-Commit-Position: refs/heads/master@{#292785}
TBR=maruel@chromium.org,anandc@chromium.org,chaitali@chromium.org,anandc@google.com,leilei@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/591163002
Cr-Original-Commit-Position: refs/heads/master@{#295980}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b2c1542b0239e06c2dcc764af156054b5d5b8680
Also depend on chromium_builder_perf instead of chromium_builder_qa
since it's likely we'll start running Telemetry tests on our bots
in the near future.
BUG=
Review URL: https://codereview.chromium.org/587173004
Cr-Original-Commit-Position: refs/heads/master@{#295968}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 88f639b44ae2bb400ce3407c127ed57565662ef0
This CL adds support for the mojo_base target on iOS that will be required to
implement the Mojo support that is feasible on iOS (namely, C++-C++
communication via Mojo and mojom interfaces).
Review URL: https://codereview.chromium.org/528763002
Cr-Original-Commit-Position: refs/heads/master@{#294580}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 475263c6949bad244ed906d92b349a32843c351e
Create a standalone executable that plumbs public Mojo API calls into a NaCl
sandbox. This allows the public Mojo unit tests to run inside NaCl.
BUG=401761
Review URL: https://codereview.chromium.org/385983008
Cr-Original-Commit-Position: refs/heads/master@{#294484}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95d2d4025c767fbc5669377aae457a4bfb5ca46b
We checkout the Android WebView glue layer (frameworks/webview)
into a new third_party directory (android_webview_glue)
which is checked out via gclient.
This is built against a jar containing frameworks/base
(in android_platform/webview/frameworks.jar).
We have to work around a few other issues:
- Change build/java_apk.gypi to bypass the hardcoded
'src' path.
- Move libwebviewchromium to an include so we can make both
the prefixed and un-prefixed version in the same build.
BUG=391488
R=mkosiba@chromium.org
Review URL: https://codereview.chromium.org/477903003
Cr-Original-Commit-Position: refs/heads/master@{#293921}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aefb27936dcf9694777440b8a2752b3c12300520
Following the steps done in https://codereview.chromium.org/323163003/
Not sure how to test this, any guidance?
I want the sync_integration_tests binary to be stored in
official Chrome build gs:// drops just like
browser_tests and other test binaries already are. Then
I can set up automation to approve new releases of Sync
server.
BUG=411389
Review URL: https://codereview.chromium.org/545103003
Cr-Original-Commit-Position: refs/heads/master@{#293775}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de3a5e8b35ad6b7452acb0502b27fb77b37e9a7c
The iOS6-style APIs have been deprecated, but the replacements are
more verbose and brittle so this category wraps the replacements in
methods similar to the iOS6-style APIs.
This category lives in a new target and directory: src/ui/ios, so
this CL sets up all the gyp/DEPS stuff and only adds a single
method. There will be more methods added in subsequent CLs.
BUG=364419
Review URL: https://codereview.chromium.org/497503004
Cr-Original-Commit-Position: refs/heads/master@{#293193}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c018ddc14ace7181edda4d4be225cf6e88e44d2c
Original description from commit 63e36e6bdaa65d1152dd62f9831128c752bc0408:
ui: Move ui_unittests.gyp into ui/base.
ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate
Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.
It was reverted in commit 6297a2f1e441c46d6f8ca37a3798fe6fbdd6cc4c,
because a test from ui_unittests in ios_dbg_simulator started to
failing.
BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org,rohitrao@chromium.org
Review URL: https://codereview.chromium.org/518423002
Cr-Original-Commit-Position: refs/heads/master@{#293134}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2148b92f9cc676bf2b64dc7e47ef65daac393031
Remove a bunch of code that is already longer used or
will become unused when https://review.webrtc.org/22149004/
and https://codereview.chromium.org/505153002/ are landed.
Remove hardcoded paths to the WebRTC isolate files to make
it easier for us to make changes to them, since we can pass
the path to the .isolate file on test execution instead
(keeping the configuration in the WebRTC buildbot recipe instead).
Previously we had to roll our Chromium revision in WebRTC DEPS
every time a change was made before it became used.
Add support for a CHECKOUT_SOURCE_ROOT environment variable
used to make it possible to override the hardcoded path traversal
that is done to find the src/ directory (since it's different for
WebRTC bots). I considered passing a flag into the test_runner.py
scripts instead of using an environment variable, but my opinion is
that it would pollute the code too much since
constants.DIR_SOURCE_ROOT is used in 70 different places.
BUG=webrtc:3741
TEST=local building and test execution using command lines like this:
cd /path/to/webrtc/src
export CHECKOUT_SOURCE_ROOT=`pwd`
build/android/test_runner.py gtest -s tools_unittests --isolate-file-path=webrtc/tools/tools_unittests.isolate
R=navabi@chromium.org
Review URL: https://codereview.chromium.org/500423004
Cr-Original-Commit-Position: refs/heads/master@{#292861}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f0a439da1aba8e22b30ede87087418e806f7fa75
ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate
Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.
BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org
Review URL: https://codereview.chromium.org/506483002
Cr-Original-Commit-Position: refs/heads/master@{#292146}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 63e36e6bdaa65d1152dd62f9831128c752bc0408
heap_profiler_unittests was previously a native executable target.
It turns out that we don't have the harness in place to run native
executable tests reliably on all Android versions due to the PIE
vs non-PIE issue (L vs ICS, see crbug.com/373219).
This caused a revert in crrev.com/416003005.
This change is making heap_profiler_unittests an apk target, following
the same pattern of the other tests we have in the codebase.
This change is also re-adding the tests to the the bot list.
BUG=393964
Review URL: https://codereview.chromium.org/465223005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@291197 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
These files provide the implementations of the public Blink API that
bind to the cc implementation. This moves them out of content/ into a
subdirectory of cc/ so that we can reuse these files in mojo which
can depend on cc/ and on blink but not on content/. To make sure we
don't introduce dependencies from cc/ on blink proper, cc/DEPS forbids
including cc/blink/ and cc/blink/DEPS allows using the blink headers.
cc_blink is built as a separate component to avoid linking anything from
blink into targets that don't care about the blink bindings (such as
the browser compositor).
R=darin@chromium.org
Review URL: https://codereview.chromium.org/470983004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@290464 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This lets us build the WebViewShell via ninja using the
target android_webview_telemetry_shell_apk.
the licence information was updated to use the Chromium
licence and the package was changed to: org.chromium.telemetry_shell
This meant updating:
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
to use the new package name.
BUG=
Review URL: https://codereview.chromium.org/443953002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@288698 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Any leak of boringssl.gyp (which included unittests) ends up pulling in base/
and breaks the WebRTC build.
However, switching targets to boringssl_lib.gypi:boringssl breaks GYP because
then there are two targets with the same name (boringssl.gyp:boringssl and
boringssl_lib.gypi:boringssl).
This change gives up and splits the unittests into a different .gyp file.
BUG=none
Review URL: https://codereview.chromium.org/447213004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@288251 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL introduces ChannelMojo IPC::Channel implementation
and optionally applies it for renderer-browser IPC channel.
Current stability is like 5-seconds browser and There are rough edges.
It often closes the channel so needs to be more robust.
Even though the level of stability, having it in the tree will helps
team to try and improve it.
BUG=377980
R=darin@chromium.org,jam@chromium.org,viettrungluu@chromium.org
TEST=ipc_channel_mojo_unittest.cc
Review URL: https://codereview.chromium.org/382333002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@287402 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
garykac
rockot
inferno
cpu
pkotwicz
noyau
blundell
oshima
tfarina
mek
teravest
yoz
stuartmorgan
serya
jaekyun
wangxianzhu
mohsen
rsleevi
jbudorick
glider
jamesr
thakis
kjellander
jackhou
derat
mohan.reddy
nkostylev
vitalybuka
davidben
ripp
skuhne
mikhal
henrika
ullysses.a.eoff
jmadill
perkj
phoglund
leilei
jam
Balazs Engedy
resetswitch
msarda
ncbray
hjd
lliabraa
mikecase
primiano@chromium.org
jamesr@chromium.org
ncbray@chromium.org
joaodasilva@chromium.org
hjd@chromium.org
agl@chromium.org
morrita@chromium.org
engedy@chromium.org
zhaoqin@google.com
jam@chromium.org
yoz@chromium.org