The targets in the mojo public SDK, i.e. those in mojo/public/, should
be free of dependencies outside of mojo/public/ and usable in a
standalone fashion. This moves the gyp definitions from
mojo/mojo_base.gyp, which also contains a number of non-public targets,
to mojo/public/mojo_public.gyp.
R=viettrungluu@chromium.orgTBR=darin@chromium.org for updating various gyp entries to point to new target location
Review URL: https://codereview.chromium.org/632853002
Cr-Original-Commit-Position: refs/heads/master@{#298422}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b83f9dcb4940d4700632fe9e925abec779ad84ef
the gles2 conformance tests in the khronos GL-CTS test
suite using its new drawElements APIs.
Requires the khronos GL-CTS source to be available in
src/third_party/khronos_glcts. This support targets the
Khronos 3.X branch of ogles/conform at rev 26950.
Define the build option internal_khronos_glcts_tests=1
to build the tests.
Initial support is for Chromium on ChromiumOS. Other targets
may need to be ported for build support as well.
v2: Fix AUTHORS. Change naming convention from khronos_conform
to khronos_glcts. (piman, kbr)
v3: Ran git cl format on egl_native_windowless.cc so it matches
the chromium style. (piman)
v4: Use AppendArg instead of AppendSwitch to hopefully
circumvent a repeat of chromium:408251. (kbr)
v5: Handle FilePath's correctly for Windows compatibility.
v6: Rebase; Remove -fno-exceptions from cflags_cc
BUG=chromium:412865
R=piman@chromium.org, kbr@chromium.org, darin, brettw, cpu
TEST=Build and run the khronos_glcts_test binary
Review URL: https://codereview.chromium.org/556333003
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Review URL: https://codereview.chromium.org/556333003
Cr-Original-Commit-Position: refs/heads/master@{#297567}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ffbb37ebec861db6e93471a5837727ea8d974f91
This is in preparation for updating the buildbot code. First we need to
make sure we build those targets, otherwise buildbot will fail.
BUG=331829,373148,299841,103304
TEST=None
R=sky@chromium.org,maruel@chromium.org
Review URL: https://codereview.chromium.org/600833002
Cr-Original-Commit-Position: refs/heads/master@{#296877}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 430fc906824927713d5a318afb50654e95b699b0
Reason for revert:
Didn't help. We probably got scheduled on other, flakier Android devices which caused tests to start flaking, or something else is the root cause.
Original issue's description:
> Revert of [Android] JUnit runner + gyp changes. (patchset #15 id:280001 of https://codereview.chromium.org/574433003/)
>
> Reason for revert:
> Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905.
>
> Original issue's description:
> > [Android] JUnit runner + gyp changes.
> >
> > This adds Java code for running junit tests, as well as gyp targets for
> > both runnable and non-runnable host-side JARs.
> >
> > BUG=316383
> >
> > Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174
> > Cr-Commit-Position: refs/heads/master@{#296340}
>
> TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=316383
>
> Committed: https://crrev.com/54b9408f8b18e3bf3a33343e375186e1949e8e86
> Cr-Commit-Position: refs/heads/master@{#296384}
TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=316383
Review URL: https://codereview.chromium.org/596303002
Cr-Original-Commit-Position: refs/heads/master@{#296406}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6e9dc50aecf078d7826fe8e4611b2c238aab3f23
Reason for revert:
Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905.
Original issue's description:
> [Android] JUnit runner + gyp changes.
>
> This adds Java code for running junit tests, as well as gyp targets for
> both runnable and non-runnable host-side JARs.
>
> BUG=316383
>
> Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174
> Cr-Commit-Position: refs/heads/master@{#296340}
TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=316383
Review URL: https://codereview.chromium.org/597123002
Cr-Original-Commit-Position: refs/heads/master@{#296384}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 54b9408f8b18e3bf3a33343e375186e1949e8e86
Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.
This CL doesn't care of a few known issues:
1. Data channel buffer overflow. Data channel automatically closed in this case.
2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).
To keep this CL reasonably simple this issues will be addressed later.
TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
BUG=383418
Committed: https://crrev.com/15044609893faf9b2c2a533aa9a136f288ea20a1
Cr-Commit-Position: refs/heads/master@{#296360}
Review URL: https://codereview.chromium.org/517233002
Cr-Original-Commit-Position: refs/heads/master@{#296377}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6c788d675dba4ec185375863cbc53c0803cc4b3e
Reason for revert:
Fails to compile on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20(dbg)/builds/2163
devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/SocketTunnelServerTest.java:291: cannot find symbol
symbol: method sleep()
sleep();
^
Original issue's description:
> Implementation of DevTools socket tunneling service for remote debugging.
>
> Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.
>
> This CL doesn't care of a few known issues:
> 1. Data channel buffer overflow. Data channel automatically closed in this case.
> 2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
> 3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).
>
> To keep this CL reasonably simple this issues will be addressed later.
>
> TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
> BUG=383418
>
> Committed: https://crrev.com/15044609893faf9b2c2a533aa9a136f288ea20a1
> Cr-Commit-Position: refs/heads/master@{#296360}
TBR=mnaganov@chromium.org,tedchoc@chromium.org,erikwright@chromium.org,serya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418
Review URL: https://codereview.chromium.org/597063002
Cr-Original-Commit-Position: refs/heads/master@{#296361}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cf0900dae461d90af8ed7604da098690d7c744c3
Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.
This CL doesn't care of a few known issues:
1. Data channel buffer overflow. Data channel automatically closed in this case.
2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).
To keep this CL reasonably simple this issues will be addressed later.
TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
BUG=383418
Review URL: https://codereview.chromium.org/517233002
Cr-Original-Commit-Position: refs/heads/master@{#296360}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 15044609893faf9b2c2a533aa9a136f288ea20a1
This adds Java code for running junit tests, as well as gyp targets for
both runnable and non-runnable host-side JARs.
BUG=316383
Review URL: https://codereview.chromium.org/574433003
Cr-Original-Commit-Position: refs/heads/master@{#296340}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2e56d4508e33de5fc60bbbb41c5a5d5534e88174
Reason for revert:
This is slowing down the trybots because it's uploading these files even though they're not used on trybots. look at how gpu isolates that are only used on the GPU builders are handled (there's a gyp variable which is only set by the builders which run these tests)
Original issue's description:
> Swarming configuration files for chromoting integration tests.
>
> BUG=
>
> Committed: https://crrev.com/d90ba4c4e4ddf5c4cbb6cf812c9571d628e30567
> Cr-Commit-Position: refs/heads/master@{#292785}
TBR=maruel@chromium.org,anandc@chromium.org,chaitali@chromium.org,anandc@google.com,leilei@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/591163002
Cr-Original-Commit-Position: refs/heads/master@{#295980}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b2c1542b0239e06c2dcc764af156054b5d5b8680
Also depend on chromium_builder_perf instead of chromium_builder_qa
since it's likely we'll start running Telemetry tests on our bots
in the near future.
BUG=
Review URL: https://codereview.chromium.org/587173004
Cr-Original-Commit-Position: refs/heads/master@{#295968}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 88f639b44ae2bb400ce3407c127ed57565662ef0
This CL adds support for the mojo_base target on iOS that will be required to
implement the Mojo support that is feasible on iOS (namely, C++-C++
communication via Mojo and mojom interfaces).
Review URL: https://codereview.chromium.org/528763002
Cr-Original-Commit-Position: refs/heads/master@{#294580}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 475263c6949bad244ed906d92b349a32843c351e
Create a standalone executable that plumbs public Mojo API calls into a NaCl
sandbox. This allows the public Mojo unit tests to run inside NaCl.
BUG=401761
Review URL: https://codereview.chromium.org/385983008
Cr-Original-Commit-Position: refs/heads/master@{#294484}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95d2d4025c767fbc5669377aae457a4bfb5ca46b
We checkout the Android WebView glue layer (frameworks/webview)
into a new third_party directory (android_webview_glue)
which is checked out via gclient.
This is built against a jar containing frameworks/base
(in android_platform/webview/frameworks.jar).
We have to work around a few other issues:
- Change build/java_apk.gypi to bypass the hardcoded
'src' path.
- Move libwebviewchromium to an include so we can make both
the prefixed and un-prefixed version in the same build.
BUG=391488
R=mkosiba@chromium.org
Review URL: https://codereview.chromium.org/477903003
Cr-Original-Commit-Position: refs/heads/master@{#293921}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aefb27936dcf9694777440b8a2752b3c12300520
Following the steps done in https://codereview.chromium.org/323163003/
Not sure how to test this, any guidance?
I want the sync_integration_tests binary to be stored in
official Chrome build gs:// drops just like
browser_tests and other test binaries already are. Then
I can set up automation to approve new releases of Sync
server.
BUG=411389
Review URL: https://codereview.chromium.org/545103003
Cr-Original-Commit-Position: refs/heads/master@{#293775}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de3a5e8b35ad6b7452acb0502b27fb77b37e9a7c
The iOS6-style APIs have been deprecated, but the replacements are
more verbose and brittle so this category wraps the replacements in
methods similar to the iOS6-style APIs.
This category lives in a new target and directory: src/ui/ios, so
this CL sets up all the gyp/DEPS stuff and only adds a single
method. There will be more methods added in subsequent CLs.
BUG=364419
Review URL: https://codereview.chromium.org/497503004
Cr-Original-Commit-Position: refs/heads/master@{#293193}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c018ddc14ace7181edda4d4be225cf6e88e44d2c
Original description from commit 63e36e6bdaa65d1152dd62f9831128c752bc0408:
ui: Move ui_unittests.gyp into ui/base.
ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate
Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.
It was reverted in commit 6297a2f1e441c46d6f8ca37a3798fe6fbdd6cc4c,
because a test from ui_unittests in ios_dbg_simulator started to
failing.
BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org,rohitrao@chromium.org
Review URL: https://codereview.chromium.org/518423002
Cr-Original-Commit-Position: refs/heads/master@{#293134}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2148b92f9cc676bf2b64dc7e47ef65daac393031
Remove a bunch of code that is already longer used or
will become unused when https://review.webrtc.org/22149004/
and https://codereview.chromium.org/505153002/ are landed.
Remove hardcoded paths to the WebRTC isolate files to make
it easier for us to make changes to them, since we can pass
the path to the .isolate file on test execution instead
(keeping the configuration in the WebRTC buildbot recipe instead).
Previously we had to roll our Chromium revision in WebRTC DEPS
every time a change was made before it became used.
Add support for a CHECKOUT_SOURCE_ROOT environment variable
used to make it possible to override the hardcoded path traversal
that is done to find the src/ directory (since it's different for
WebRTC bots). I considered passing a flag into the test_runner.py
scripts instead of using an environment variable, but my opinion is
that it would pollute the code too much since
constants.DIR_SOURCE_ROOT is used in 70 different places.
BUG=webrtc:3741
TEST=local building and test execution using command lines like this:
cd /path/to/webrtc/src
export CHECKOUT_SOURCE_ROOT=`pwd`
build/android/test_runner.py gtest -s tools_unittests --isolate-file-path=webrtc/tools/tools_unittests.isolate
R=navabi@chromium.org
Review URL: https://codereview.chromium.org/500423004
Cr-Original-Commit-Position: refs/heads/master@{#292861}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f0a439da1aba8e22b30ede87087418e806f7fa75
ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate
Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.
BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org
Review URL: https://codereview.chromium.org/506483002
Cr-Original-Commit-Position: refs/heads/master@{#292146}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 63e36e6bdaa65d1152dd62f9831128c752bc0408
heap_profiler_unittests was previously a native executable target.
It turns out that we don't have the harness in place to run native
executable tests reliably on all Android versions due to the PIE
vs non-PIE issue (L vs ICS, see crbug.com/373219).
This caused a revert in crrev.com/416003005.
This change is making heap_profiler_unittests an apk target, following
the same pattern of the other tests we have in the codebase.
This change is also re-adding the tests to the the bot list.
BUG=393964
Review URL: https://codereview.chromium.org/465223005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@291197 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
These files provide the implementations of the public Blink API that
bind to the cc implementation. This moves them out of content/ into a
subdirectory of cc/ so that we can reuse these files in mojo which
can depend on cc/ and on blink but not on content/. To make sure we
don't introduce dependencies from cc/ on blink proper, cc/DEPS forbids
including cc/blink/ and cc/blink/DEPS allows using the blink headers.
cc_blink is built as a separate component to avoid linking anything from
blink into targets that don't care about the blink bindings (such as
the browser compositor).
R=darin@chromium.org
Review URL: https://codereview.chromium.org/470983004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@290464 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This lets us build the WebViewShell via ninja using the
target android_webview_telemetry_shell_apk.
the licence information was updated to use the Chromium
licence and the package was changed to: org.chromium.telemetry_shell
This meant updating:
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
to use the new package name.
BUG=
Review URL: https://codereview.chromium.org/443953002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@288698 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Any leak of boringssl.gyp (which included unittests) ends up pulling in base/
and breaks the WebRTC build.
However, switching targets to boringssl_lib.gypi:boringssl breaks GYP because
then there are two targets with the same name (boringssl.gyp:boringssl and
boringssl_lib.gypi:boringssl).
This change gives up and splits the unittests into a different .gyp file.
BUG=none
Review URL: https://codereview.chromium.org/447213004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@288251 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL introduces ChannelMojo IPC::Channel implementation
and optionally applies it for renderer-browser IPC channel.
Current stability is like 5-seconds browser and There are rough edges.
It often closes the channel so needs to be more robust.
Even though the level of stability, having it in the tree will helps
team to try and improve it.
BUG=377980
R=darin@chromium.org,jam@chromium.org,viettrungluu@chromium.org
TEST=ipc_channel_mojo_unittest.cc
Review URL: https://codereview.chromium.org/382333002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@287402 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Broke Android compile:
FAILED: cd ../../net; python ../build/android/gyp/pack_arm_relocations.py "--enable-packing=0" "--stripped-libraries-dir=../out/Release/gen/stripped_libraries" "--packed-libraries-dir=../out/Release/net_unittests_apk/libs/armeabi-v7a" "--libraries-file=../out/Release/net_unittests_apk/native_libraries.json" "--stamp=../out/Release/net_unittests_apk/pack_arm_relocations.stamp"
Traceback (most recent call last):
File "../build/android/gyp/pack_arm_relocations.py", line 108, in <module>
sys.exit(main())
File "../build/android/gyp/pack_arm_relocations.py", line 99, in main
CopyArmLibraryUnchanged(library_path, output_path)
File "../build/android/gyp/pack_arm_relocations.py", line 58, in CopyArmLibraryUnchanged
shutil.copy(library_path, output_path)
File "/usr/lib/python2.7/shutil.py", line 117, in copy
copyfile(src, dst)
File "/usr/lib/python2.7/shutil.py", line 83, in copyfile
with open(dst, 'wb') as fdst:
IOError: [Errno 2] No such file or directory: u'../out/Release/net_unittests_apk/libs/armeabi-v7a/libnet_unittests.so'
ninja: build stopped: subcommand failed.
> Add gyp machinery to build with packed ARM relative relocations.
>
> Add gypi and python files to support packing ARM relative relocations
> during the build process.
>
> Define a use_relocation_packer gyp variable to turn ARM relocation
> packing on and off (currently set to 0).
>
> BUG=385553
>
> Review URL: https://codereview.chromium.org/358863002TBR=simonb@chromium.org
Review URL: https://codereview.chromium.org/370633002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@281303 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add gypi and python files to support packing ARM relative relocations
during the build process.
Define a use_relocation_packer gyp variable to turn ARM relocation
packing on and off (currently set to 0).
BUG=385553
Review URL: https://codereview.chromium.org/358863002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@281286 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- All files from webkit/renderer/compositor_bindings have been moved to content/renderer/compositor_bindings
- Webkit_compositor_support is moved in content_renderer
- Webkit_compositor_bindings_unittests is moved in content_unittests
- A dummy target has been left for webkit_compositor_bindings_unittests so as to not break the build.
TBR=nduca
BUG=265753
Review URL: https://codereview.chromium.org/317163002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@277988 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This splits views_content_client_main_parts_* into versions for
ChromeOS, Mac and Desktop Aura, with a per-platform Create(..) function.
ChromeOS and Desktop Aura sharing a common Aura part.
desktop_test_views_delegate.cc is moved to an _aura version, and a _mac
version added.
views_content_client now loads content_resources.pak to access sandbox
profiles required for mac.
A macviews_builder target is added to expose
views_examples_with_content_exe on Mac, and to give the fyi trybot
something to build.
BUG=366007
Review URL: https://codereview.chromium.org/297143009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274775 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
As a first step to getting a separate target for the display unittests, this CL is adding a simple target with one unittest. All display_unittests currently running under ui_unittests will be migrated under this target when display_unittests is enabled on the main waterfall.
BUG=333413
Review URL: https://codereview.chromium.org/304183010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274332 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Moves targets related to the standalone executables
sync_listen_notifications and sync_client into their own .gyp file.
This will prevent a temporary circular dependency as we attempt to
invert the dependency from components/invalidation -> sync towards
sync -> components/invalidation.
BUG=378024
Review URL: https://codereview.chromium.org/303603004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@273665 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The binary_size tool suit includes tools that are useful when trying
to reduce binary size of a program, and chromium related programs
in particular.
This commit (mostly written by andrewhayden@chromium.org for
Android but ported to generic Linux by bratell@opera.com) adds
a graphical HTML based output for run_binary_size_analysis.py.
In the generated web page it is possible to dynamically and
graphically browse the binary and each part of the source tree
is given a size that reflects its contribution to the binary size.
The run_binary_size_analysis tool is run on compiled binaries
with symbols and uses nm and addr2line to map parts of the
binary to source code. Since addr2line is slow the operation to map
binary symbols to source files takes a while but the output is
well worth it when shrinking programs. See its usage information
for details about how to run it.
This commit also includes the tool explain_binary_size_delta.py
(textual output) which can be used to understand why a binary
changed size and in what way. See its usage information for
details about how to run it.
There are many further improvements possible to to do on these tools.
Search the bug database for Label:Tools-BinarySize for suggestions.
BUG=339059
R=primiano@chromium.org,andrewhayden@chromium.org
Review URL: https://codereview.chromium.org/258633003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272255 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It was reverted in r270600 because it broke compilation:
lib/libgfx.so:error: undefined reference to 'XCreateRegion'
lib/libgfx.so:error: undefined reference to 'XUnionRectWithRegion'
lib/libgfx.so:error: undefined reference to 'XPolygonRegion'
Original description:
This requires to major changes:
1- It requires the introduction of GfxTestSuite to allow us to
initialize the ResourceBundle which is required for some of these tests
to pass.
2- It requires to split gfx_unittests target out of gfx.gyp, into
gfx_tests.gyp. This is necessary because otherwise a circular dependency
between ui_base.gyp and gfx.gyp would arise.
The circular dependency is the form of:
gfx.gyp -> ui_base.gyp -> gfx.gyp
And is created because gfx_unittests now requires ResourceBundle to link
which is in ui_base target.
BUG=331829
TEST=ui_unittests,gfx_unittests
R=sadrul@chromium.org, danakj@chromium.orgTBR=ben@chromium.org
Review URL: https://codereview.chromium.org/291753002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@272088 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Speculative revert: Compilation appears broken on http://chromegw.corp.google.com/i/chromium.linux/builders/Linux%20Builder%20%28dbg%29 after this CL, with libgfx-related errors:
FAILED: /b/build/goma/gomacc c++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -B/b/build/slave/Linux_Builder__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -L. -Wl,-uIsHeapProfilerRunning,-uProfilerStart -Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi -Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl -Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14UnIgnoreObjectEPKv -m64 -Wl,--icf=none -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o gfx_unittests -Wl,--start-group obj/ui/gfx/gfx_unittests.font_unittest.o obj/ui/gfx/image/gfx_unittests.image_family_unittest.o obj/ui/gfx/image/gfx_unittests.image_skia_unittest.o obj/ui/gfx/image/gfx_unittests.image_unittest.o obj/ui/gfx/image/gfx_unittests.image_unittest_util.o obj/ui/gfx/test/gfx_unittests.run_all_unittests.o obj/ui/gfx/gfx_unittests.text_elider_unittest.o obj/ui/gfx/gfx_unittests.text_utils_unittest.o obj/ui/gfx/animation/gfx_unittests.animation_container_unittest.o obj/ui/gfx/animation/gfx_unittests.animation_unittest.o obj/ui/gfx/animation/gfx_unittests.multi_animation_unittest.o obj/ui/gfx/animation/gfx_unittests.slide_animation_unittest.o obj/ui/gfx/animation/gfx_unittests.tween_unittest.o obj/ui/gfx/gfx_unittests.blit_unittest.o obj/ui/gfx/gfx_unittests.break_list_unittest.o obj/ui/gfx/codec/gfx_unittests.jpeg_codec_unittest.o obj/ui/gfx/codec/gfx_unittests.png_codec_unittest.o obj/ui/gfx/gfx_unittests.color_analysis_unittest.o obj/ui/gfx/gfx_unittests.color_utils_unittest.o obj/ui/gfx/gfx_unittests.display_unittest.o obj/ui/gfx/geometry/gfx_unittests.box_unittest.o obj/ui/gfx/geometry/gfx_unittests.cubic_bezier_unittest.o obj/ui/gfx/geometry/gfx_unittests.insets_unittest.o obj/ui/gfx/geometry/gfx_unittests.matrix3_unittest.o obj/ui/gfx/geometry/gfx_unittests.point_unittest.o obj/ui/gfx/geometry/gfx_unittests.point3_unittest.o obj/ui/gfx/geometry/gfx_unittests.quad_unittest.o obj/ui/gfx/geometry/gfx_unittests.r_tree_unittest.o obj/ui/gfx/geometry/gfx_unittests.rect_unittest.o obj/ui/gfx/geometry/gfx_unittests.safe_integer_conversions_unittest.o obj/ui/gfx/geometry/gfx_unittests.size_unittest.o obj/ui/gfx/geometry/gfx_unittests.vector2d_unittest.o obj/ui/gfx/geometry/gfx_unittests.vector3d_unittest.o obj/ui/gfx/image/gfx_unittests.image_util_unittest.o obj/ui/gfx/range/gfx_unittests.range_unittest.o obj/ui/gfx/gfx_unittests.sequential_id_generator_unittest.o obj/ui/gfx/gfx_unittests.shadow_value_unittest.o obj/ui/gfx/gfx_unittests.skbitmap_operations_unittest.o obj/ui/gfx/gfx_unittests.skrect_conversion_unittest.o obj/ui/gfx/gfx_unittests.transform_util_unittest.o obj/ui/gfx/gfx_unittests.utf16_indexing_unittest.o obj/ui/gfx/gfx_unittests.transform_unittest.o obj/ui/gfx/gfx_unittests.interpolated_transform_unittest.o obj/ui/gfx/gfx_unittests.platform_font_pango_unittest.o obj/base/libtest_support_base.a obj/testing/libgtest.a obj/third_party/libpng/libpng.a obj/ui/gfx/libgfx_test_support.a obj/base/allocator/liballocator.a obj/base/libbase_static.a obj/testing/libgmock.a obj/third_party/libxml/libxml2.a obj/third_party/zlib/libchrome_zlib.a obj/base/third_party/dynamic_annotations/libdynamic_annotations.a lib/libui_base.so lib/libgfx.so lib/libicuuc.so lib/libskia.so lib/libbase.so lib/libgfx_geometry.so lib/libbase_i18n.so -Wl,--end-group -lrt -ldl -lfontconfig -lpangocairo-1.0 -lcairo -lpangoft2-1.0 -lpango-1.0 -lfreetype -lgobject-2.0 -lglib-2.0
lib/libgfx.so:error: undefined reference to 'XCreateRegion'
lib/libgfx.so:error: undefined reference to 'XUnionRectWithRegion'
lib/libgfx.so:error: undefined reference to 'XPolygonRegion'
collect2: ld returned 1 exit status
Original issue's description:
> Move a good set of gfx unit tests into gfx_unittests target.
>
> This requires to major changes:
>
> 1- It requires the introduction of GfxTestSuite to allow us to
> initialize the ResourceBundle which is required for some of these tests
> to pass.
> 2- It requires to split gfx_unittests target out of gfx.gyp, into
> gfx_tests.gyp. This is necessary because otherwise a circular dependency
> between ui_base.gyp and gfx.gyp would arise.
>
> The circular dependency is the form of:
> gfx.gyp -> ui_base.gyp -> gfx.gyp
>
> And is created because gfx_unittests now requires ResourceBundle to link
> which is in ui_base target.
>
> BUG=331829
> TEST=ui_unittests,gfx_unittests
> R=danakj@chromium.org
> TBR=ben@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270586TBR=ben@chromium.org,danakj@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331829
Review URL: https://codereview.chromium.org/290453002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270600 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This requires to major changes:
1- It requires the introduction of GfxTestSuite to allow us to
initialize the ResourceBundle which is required for some of these tests
to pass.
2- It requires to split gfx_unittests target out of gfx.gyp, into
gfx_tests.gyp. This is necessary because otherwise a circular dependency
between ui_base.gyp and gfx.gyp would arise.
The circular dependency is the form of:
gfx.gyp -> ui_base.gyp -> gfx.gyp
And is created because gfx_unittests now requires ResourceBundle to link
which is in ui_base target.
BUG=331829
TEST=ui_unittests,gfx_unittests
R=danakj@chromium.orgTBR=ben@chromium.org
Review URL: https://codereview.chromium.org/280973003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270586 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Speculative revert because we think this might have caused Mac Build bot
failure "gyp: Call to 'python ../../../build/mac/find_sdk.py 10.6' returned exit status -9."
> ozone: Add egltest platform
>
> This supports testing rendering using EGL. Creation of the
> EGLNativeWindowType is punted to a separate library, which has an
> interface defined in eglplatform_shim.h.
>
> TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist
> BUG=none
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/288603002TBR=spang@chromium.org
Review URL: https://codereview.chromium.org/288013002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270474 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This supports testing rendering using EGL. Creation of the
EGLNativeWindowType is punted to a separate library, which has an
interface defined in eglplatform_shim.h.
TEST=content_shell --ozone-platform=egltest --ignore-gpu-blacklist
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/288603002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270471 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This removes all the code that we used for talking to the
peerconnection_server. I also cleaned up tons of dead code from the
test javascript (most of which was used in the old manual test page,
which is now completely self-contained and doesn't use this javascript
anymore).
In place of the peerconnection_server, we'll send signaling information
through the test using ExecuteJavascript calls from the browser test.
This was a bit tricky to design since the javascript can't talk back
to the browser test without the browser test initiating the talking.
The basic design became
1. Test asks tab 1 to get user media and create an offer with audio
and video. The offer is returned to the test as a JSON encoded
session description.
2. The test asks tab 2 to get user media and create a peer connection.
3. The test passes the offer to tab2 and asks it to create an answer,
and the answer is returned to the test like the offer in 1.
4. The test asks tab 1 to accept the answer.
5. Both tabs are now gathering ICE candidates.
6. The test asks tab 1 to return its ICE candidates (waiting for
gathering to complete if necessary). The candidates are then sent
to tab 2 which processes them. The ICE candidates are passed as
JSON encoded RTCIceCandidate instances.
7. 6) is repeated, but from tab 2 to tab 1.
8. We wait for video / audio to start playing.
In general this is a more synchronous design compared to the
peerconnection_server design as the test used to merely arbitrate
connections to the server and then let the javascript in the two tabs
talk to each other asynchronously as far as the test was concerned.
This seems to work though, and the test has full control over what
happens. Hopefully it makes the negotiation flow clearer rather than
having this magical out-of-band signaling channel that the server
enabled previously.
BUG=369469
Review URL: https://codereview.chromium.org/271653002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@269311 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Broke windows compile:
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_wrapper.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj /Fdobj\net\hpack_fuzz_wrapper.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_wrapper.cc(38) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_example_generator.cc /Foobj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj /Fdobj\net\hpack_example_generator.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(51) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(52) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &'
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(68) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(69) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_mutator.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj /Fdobj\net\hpack_fuzz_mutator.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(53) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(56) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(57) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &'
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(72) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(73) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
> Add hpack_fuzz_wrapper to chromium_builder_asan.
>
> BUG=353237
>
> Review URL: https://codereview.chromium.org/266003005TBR=jgraettinger@chromium.org
Review URL: https://codereview.chromium.org/268863002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@268024 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This moves app_shell GYP entries from a chrome.gyp include into
a new apps/shell/app_shell.gyp.
It also breaks down dependencies with more granularity and separates
temporary undesirable app_shell_lib dependencies from acceptable ones.
This was reverted due to a bug in the gyp file breaking a builder.
app_shell_temporary_deps should not have been a static_library target.
BUG=359678
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/225023002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261800 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When running gyp_chromium with the following diff:
diff --git a/build/gyp_chromium b/build/gyp_chromium
index 63e8671..ca9b6a4 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -509,8 +509,6 @@ if __name__ == '__main__':
# option. http://crbug.com/35878.
# TODO(tc): Fix circular dependencies in ChromiumOS then add linux2
# list.
- if sys.platform not in ('darwin',):
- args.append('--no-circular-check')
These cycles are found:
gyp: Cycles in .gyp file dependency graph detected:
Cycle: content/content_shell_and_tests.gyp ->
ui/views/controls/webview/webview.gyp -> ui/views/views.gyp ->
content/content_shell_and_tests.gyp
Cycle: ui/views/controls/webview/webview.gyp -> ui/views/views.gyp ->
content/content_shell_and_tests.gyp ->
ui/views/controls/webview/webview.gyp
Cycle: ui/views/views.gyp -> content/content_shell_and_tests.gyp ->
ui/views/controls/webview/webview.gyp -> ui/views/views.gyp
Cycle: ui/views/views.gyp -> content/content_shell_and_tests.gyp ->
ui/views/views.gyp
Cycle: ui/views/controls/webview/webview.gyp -> ui/views/views.gyp ->
ui/views/controls/webview/webview.gyp
Cycle: ui/views/views.gyp -> ui/views/controls/webview/webview.gyp ->
ui/views/views.gyp
Cycle: content/content_shell_and_tests.gyp -> ui/views/views.gyp ->
content/content_shell_and_tests.gyp
By moving '*examples*' targets from views.gyp to examples.gyp we break
most of these cycles.
Then it remains the cycle:
Cycle: content/content_shell_and_tests.gyp -> ui/views/controls/webview/webview.gyp -> content/content_shell_and_tests.gyp
To fix that we introduced a webview_tests.gyp to which we moved the include of
content_shell_and_tests.gyp from webview.gyp, and thus breaking that
cycle and fixing all the circlar dependencies found above.
BUG=331669,35878
TEST=run gyp_chromium with the above diff, gyp should not throw any
cycles output.
R=ben@chromium.org, harrym@chromium.org, tapted@chromium.org
Review URL: https://codereview.chromium.org/201093002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@258758 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Final rename of ChromiumTestShell to ChromeShell.
Now the new targets to build ChromeShell and ChromeShellTest APKs will be:
chrome_shell_apk
chrome_shell_test_apk
This will better align with ContentShell and ContentShellTest APKs' targets:
content_shell_apk
content_shell_test_apk
BUG=348137
TBR=mnaganov@chromium.org
Review URL: https://codereview.chromium.org/189133005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@256382 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
A tool to print out static initializers in the format below.
These static initializers cause problems for some sneakier CRT initialization
tricks we do, and they also were measured to have an appreciable slowdown
on startup time (at least on CrOS) so generally trending towards 0 is
desirable.
The basic approach is looking for symbols that have the magic VS name
`dynamic initializer for ' which is the demangled name that's used for
global C++ initializers. The binary is processed by using the DIA SDK
(some of the code is from the Dia2Dump sample), which means that the
target binary requires being built with symbols for this tool to work.
The intention is that a run of this tool will be hooked into the 'sizes'
step on clobber builders on the waterfall, similar to Linux and Mac.
===
Static initializers in a.exe:
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_Generic_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_Iostream_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_System_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::num_put<char,std::back_insert_iterator<std::basic_string<char,std::char_traits<char>,std::allocator<char> > > >::id''
...
===
See https://code.google.com/p/chromium/issues/detail?id=341941#c7 for logs of those found in Chromium.
R=cpu@chromium.org
BUG=341941
Review URL: https://codereview.chromium.org/66613003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@251144 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
jamesr
mikhal
serya
tfarina
henrika
ullysses.a.eoff
jmadill
yoz
perkj
phoglund
jbudorick
leilei
jam
kjellander
Balazs Engedy
resetswitch
msarda
blundell
ncbray
hjd
lliabraa
mikecase
primiano@chromium.org
jamesr@chromium.org
ncbray@chromium.org
joaodasilva@chromium.org
hjd@chromium.org
agl@chromium.org
morrita@chromium.org
engedy@chromium.org
zhaoqin@google.com
jam@chromium.org
yoz@chromium.org
bauerb@chromium.org
cmumford@chromium.org
spang@chromium.org
simonb@chromium.org
dnicoara@chromium.org
csharp@chromium.org
lcwu@chromium.org
amogh.bihani@samsung.com
cbentzel@chromium.org
anandc@chromium.org
sebmarchand@chromium.org
acolwell@chromium.org
jsbell@chromium.org
tapted@chromium.org
grt@chromium.org
rlarocque@chromium.org
bulach@chromium.org
mbarbella@chromium.org
bratell@opera.com
tfarina@chromium.org
vabr@chromium.org
vrk@chromium.org
oshima@chromium.org
phoglund@chromium.org
loislo@chromium.org
jgraettinger@chromium.org
dbeam@chromium.org
qsr@chromium.org
wangxianzhu@chromium.org
hamaji@chromium.org
rsesek@chromium.org
jochen@chromium.org
erg@chromium.org
jamescook@chromium.org
terry@google.com
jschuh@chromium.org
rockot@google.com
rockot@chromium.org
thestig@chromium.org
zea@chromium.org
binji@chromium.org
aurimas@chromium.org
r.c.ladan@gmail.com
shadi@chromium.org
thakis@chromium.org
kkania@chromium.org
jdduke@chromium.org
maruel@chromium.org
hans@chromium.org
scottmg@chromium.org
aberent@chromium.org