Now that NetworkEventActor uses protocol.js, it can manage child actors it uses.
So instead of hosting the longstring it creates into WebConsoleActor pool,
it can register them it internal pool managed by protocol.js.
MozReview-Commit-ID: 9ekezmqWnME
--HG--
extra : rebase_source : a8888cffb4f284caa08e615f2614dc59730e080b
There are some places where we have a thing which may not even be a node, and
we end up hardcoding the value of DOCUMENT_NODE there, because
"foo.nodeType == foo.DOCUMENT_NODE" will test true if foo is not a node: both
sides will be undefined.
For now, we had taken over the createdTime to new actor from previous actor.
However, if the selected node changed, can not take over that. To resolve this,
hold all animation's createdTime.
MozReview-Commit-ID: 5UcwGaWkcNg
--HG--
extra : rebase_source : e68a4cd9607b2e881e10f3ccfd5441afcd4b0245
The only real change is the sorting inside `devtools/server/actors/inspector/node.js`. The rest is just shuffling tests around to handle the sorted listeners.
MozReview-Commit-ID: 8ql1bRbr4Pl
--HG--
extra : rebase_source : 08b9493d36be667b20dc2d7fc0fb2bcafd94ef79
In this patch fix not only new animation inspector, but also previous one.
MozReview-Commit-ID: KYdaUXXea70
--HG--
extra : rebase_source : f5a240572a0e7655d3c253c07a28e5fa56fccb9c
GeckoView Java tests will be using the promises actor for waiting on JS
promises to settle during a test. However, when examining object grips
that the promises actor returns, devtools often throws an exception due
to getGlobalDebugObject being called on the grip [1]. This patch makes
it return null to avoid the exception.
[1] https://dxr.mozilla.org/mozilla-central/rev/45ec8fd380dd2c308e79dbb396ca87f2ce9b3f9c/devtools/server/actors/promises.js#129
MozReview-Commit-ID: C1nFgNdQn14
--HG--
extra : rebase_source : b854ec32dea179eeafea3979e026ca3dc81754d3
I can land the removal behind a pref first if you want and all that instead.
Again, this doesn't remove the internal usage for getComputedStyle (yet).
MozReview-Commit-ID: LA157ohfLhu
To represent the parent process, we use a ChromeActor/TabActor that
targets a random chrome window. However, if that chrome window later
closes, the ChromeActor will stop working. In that case, we should clear
the cached ChromeActor and create a new one that targets a different
chrome window.
MozReview-Commit-ID: AP8AXEXEgAl
--HG--
extra : rebase_source : 28ccf09c79f23baed5714de281a8dd56bf4ecb4d
Also fixes existing code which fails the rule.
MozReview-Commit-ID: CkLFgsspGMU
--HG--
extra : rebase_source : 86a43837659aa2ad83a87eab53b7aa8d39ccf55b
This commit introduces a new highlighter. This highlighter is specialized in
highlighting text-runs in a page that use a specified font.
The highlighter is based on a platform API that returns Range objects.
Therefore, the approach I chose was to simply feed these objects to the
window Selection object. This way, we get highlighting for free without
having to create any markup in the content page.
The drawback is that the highlighting looks different than in other places
of DevTools.
However it's most probably way better in terms of performance, and will
adapt natively to edge cases like APZ, scrolling, CSS transform, etc.
This commit also has a simple UI: on mouseover of a font name in the font
inspector panel, corresponding text runs are highlighted in the page.
This UI is hidden behind a pref for now, so we can test the feature with
some chosen users and gather feedback to improve the UI before shipping.
Finally, an integration test was added.
MozReview-Commit-ID: Fu3t0b5kbdy
--HG--
extra : rebase_source : 80493e64ad6fdb1ec1963021eb9bd7c3f5398201
Julian Descottes
Yura Zenevich
arthur.iakab
Whitney Meulink
Alexandre Poirot
Boris Zbarsky
Noemi Erli
Daisuke Akatsuka
Michael Ratcliffe
Belén Albeza
Jason Laster
Xidorn Quan
Emilio Cobos Álvarez
Dorel Luca
Patrick Brosset
Csoregi Natalia
Gabriel Luong
Greg Tatum
Brindusan Cristian
yulia
Razvan Caliman
Ciure Andrei
Jim Chen
Brian Birtles
Kris Maglione