This will allow client code to catch errors occuring on the server side when
interacting with old-style actors. Before that change, the call from the client
would just never resume.
MozReview-Commit-ID: Ar6q5KapsDy
--HG--
extra : rebase_source : 041584543737c570957fc8b55148e5a824013f2f
Move and rename the server's worker debugger script that starts DevTools for a
worker from `worker.js` to `startup/worker.js`.
These code paths will likely change more as Site Isolation work continues, but
for now, we have this light cleanup to gather startup-related paths together.
MozReview-Commit-ID: EvzDSGnG1vU
--HG--
rename : devtools/server/worker.js => devtools/server/startup/worker.js
extra : rebase_source : e0b4600a0644e3e8ebb14f3da9c7dcea94d776ad
The `service-worker-child.js` process script is used by actors to control
service workers as needed. This moves it to helper directory near the actors
that make use of it.
MozReview-Commit-ID: LIq1zcU6fBc
--HG--
rename : devtools/server/service-worker-child.js => devtools/server/actors/worker/service-worker-process.js
extra : rebase_source : 8319d60ab2f3ae10d93d063f8932057316325fc3
Move and rename the server's process script (and accompanying JSM) that starts
DevTools for an entire content process from `content-process-debugger-server.js`
to `startup/content-process.js`. `connectToContent` also becomes the more
specific `connectToContentProcess`.
These code paths will likely change more as Site Isolation work continues, but
for now, we have this light cleanup to gather startup-related paths together.
MozReview-Commit-ID: 1evbZMB8T7r
--HG--
rename : devtools/server/content-process-debugger-server.js => devtools/server/startup/content-process.js
rename : devtools/server/content-server.jsm => devtools/server/startup/content-process.jsm
extra : rebase_source : e077dd3dc915ec274f866d53d3539909f8440de1
Move and rename the server's frame script that starts DevTools in remote frames
from `child.js` to `startup/frame.js`. `connectToChild` also becomes the more
generic `connectToFrame`. A few b2g-isms like "app" are also removed.
These code paths will likely change more as Site Isolation work continues, but
for now, we have this light cleanup to gather startup-related paths together.
MozReview-Commit-ID: El8a0OE99gZ
--HG--
rename : devtools/server/child.js => devtools/server/startup/frame.js
rename : devtools/server/tests/mochitest/test_connectToChild.html => devtools/server/tests/mochitest/test_connectToFrame.html
extra : rebase_source : 2735c53587257b215d720204cf7c4581088eba42
On investigation it turns out that no storage types are supported for chrome:// urls.
MozReview-Commit-ID: JZcQg5FvfvN
--HG--
extra : rebase_source : ea3ad83a5b81fb77fedf1ec4707294c45b6a5257
The shims that this rule tests for no longer exist.
MozReview-Commit-ID: DMgP7Hczavc
--HG--
extra : rebase_source : 765ddd5c62c9449c07ed050e44d86a3bd5c0ae64
extra : amend_source : 627a7694ac07182200f876901ded7a34721cd228
Also change eslint-plugin-mozilla's globals.js to use eslint-scope rather than escope as
ESLint 4.x changed to eslint-scope. This avoids dependency issues that were masked by the
depedencies of eslint-plugin-no-unsanitized's previous version.
MozReview-Commit-ID: 6wLY7Oj0am3
--HG--
extra : rebase_source : 863313d7907e8246d1f5b0ee83164cc0f943f8f6
The path service was created to allow us to track resources that were part of
legacy add-ons, and to map URIs ponting to those resources to add-on IDs, so
that we could apply special behavior to them.
We have better ways to track resources belonging to WebExtensions, so this
code does not benefit them in any significant way.
The only remaining legacy extensions are system add-ons, which we control, and
do not need the path service in order to track.
MozReview-Commit-ID: BKXkcaM7jJx
--HG--
extra : rebase_source : c8cb0f7cec919b767bbcfe5433a6838523747676
- Emit shape change events from highlighter
- Wrap shape highlighter with in-context shape editor singleton
- Link text properties from Rule view into in-context shapes editor
- Write changes to corresponding rule instead of inline style
- Hide shape highlighter on node change or TextProperty disabled/overwritten
- Remove functionality to restore shape editor on refresh
- Refactor and consolidate shape point hover behaviour (still to do: internalize remaining logic for point hover from rules.js and highlighter-overlay.js)
- Update unit tests
MozReview-Commit-ID: JiMTqODgcjU
--HG--
extra : rebase_source : abcaaa220d7cfda839daf77af9b5c01d4444d781
extra : histedit_source : 19060681534b800fc9696cc94f995eca7587ee30
Try to comprehend exactly how the original test worked... I dare you!
MozReview-Commit-ID: 5EYOfhw3hVw
--HG--
extra : rebase_source : 4b5a7eb5f16c8ad1d0cca3f4642a87108b9da913
browser_storage_listings.js doesn't use CPOWs and runs just fine with the flag removed.
I would r=me this if ReviewBoard would let me but I can't.
MozReview-Commit-ID: IHoY7qLR3k2
--HG--
extra : rebase_source : 7aa0d5111307e453b1bf17a8433d9b86d8424f73
Instead of filtering light DOM nodes in the actor, return enough information
for the markup-view to filter out the nodes itself. The nodes will be displayed
in a later changeset when the markup view can accommodate several containers
for a single nodeFront.
MozReview-Commit-ID: LFKYU24BLZB
--HG--
extra : rebase_source : 232795c1ee91a41ec667c8bcdc21eb73bcfcbf9a
Light DOM nodes are now returned next to the shadow-root, however they are
skipped if they are found under a slot element, because the markup view
can not handle several containers for a single nodeFront yet.
MozReview-Commit-ID: 1df3VBPT2HX
--HG--
extra : rebase_source : bf3a2d42ddb07b5bac08fc95226e9751874c1f7a
This changeset allows to display a #document-fragment as the child of
a custom element that has a shadowRoot.
MozReview-Commit-ID: 59wbnjz40I3
--HG--
extra : rebase_source : 4e7c5c219e0c7db9324fd363f4597a653bcae109
Remove the last sync promises from the server.
This causes server replies to be sent later than before, potentially later
enough that the connection has since been closed. We now throw errors in such
cases.
MozReview-Commit-ID: 2x213g7poH5
--HG--
extra : rebase_source : 2b83c32aa79e2365159ee20f4839a5ac645559b4
So far, we are drawing the entire line area, and then cutting out the various
margin boxes from each item, in order to show where justify-content applies.
This is dangerous because that means clearing pixels in a canvas where we're
drawing tons of other stuff, and it's easy to accidentally clear unwanted
things.
Instead, now we just draw the justify-content where needed only.
MozReview-Commit-ID: LJN6Fl1by4l
In ContentProcessForward, we listen for console-api-log-event in order
to pass data to the Browser console and Browser toolbox.
But the data is modified and properties are cherry-picked from the original
event, missing some properties probably introduced later like `counter`,
`prefix`, `private`, …
The fix consists in cloning the original event data and only overriding what
needs to be overridden.
MozReview-Commit-ID: 6jSfiRxcHQa
--HG--
extra : rebase_source : 3a4c61c0eb14ccdf584630c508dc439b7718ee45
extra : source : d266983f9cdeba0381f11e00bb6b271ccda561c1
When getting the source for inline scripts in documents, we generally try to use
the cache. However, the toolbox allows you to disable the HTTP cache while open
if you wish.
If the toolbox has disabled the cache, using `fetchFromCache: true` will give
stale data (from the most recent cache-enabled request).
We can avoid stale data here by checking the document's cache state.
MozReview-Commit-ID: J5SJciSyQNj
--HG--
extra : rebase_source : f5fce653f7860b406aa4a580c32e7c15f9cdd0ce
Importing this object is unnecessary after the updates to the WebIDL console from Bug 1425574
and the follow-ups blocking Bug 1430810. There are still callers that access Console.jsm
to create custom ConsoleAPI objects, but those will be handled separately.
MozReview-Commit-ID: 9ojFxtkpPId
--HG--
extra : rebase_source : 971bf99f709b8d2afe300f3693665724f747aa5e
This is enough to get the stylo-enabled build green.
There's still some orange in WPT with stylo disabled (due to interfaces not
exposed and that) that I'll update tomorrow.
Will send a different patch on top of this for that, though I'll land together.
MozReview-Commit-ID: CsN5CM93RUz
The hack caused bytecode for block declaration instantiation to be assigned the
location of the first statement inside the block. Unfortunately it made the
source view of the debugger client seem out of sync with the Scopes panel: when
paused after hitting a breakpoint on that line or stepping there, the source
panel showed our location as being inside the block, but the Scopes panel did
not show a block scope.
Two server tests required fixes (also r=jimb, in a separate patch in the same
bug).
test_stepping-08.js assumes that stepping into a function stops at the first
statement in the function. This is usually true. However, now we are removing a
hack, such that our actual behavior for this *particular* function is to stop
at the opening curly brace. This causes the test to fail, without anything
really being broken.
The test is intended to test the interaction of stepping and breakpoints, so
the fix that stays truest to the purpose of the test is to change the debuggee
here to a function with no prologue instructions, so that we don't stop at the
opening brace.
test_blackboxing-01.js is a similar story.
--HG--
extra : rebase_source : 7afc6cc039f313889ee08cdd93ce114691efa1e9
extra : histedit_source : dc274b7cefbb96574c8207a78db05d80238d291d
The old name no longer makes sense, since it no longer exports an spawn_task
symbol, and add_task is what we really care about.
MozReview-Commit-ID: IE7B8Czv8DH
--HG--
rename : testing/mochitest/tests/SimpleTest/SpawnTask.js => testing/mochitest/tests/SimpleTest/AddTask.js
extra : rebase_source : 03bca5aa69a7625a49b4455a6c96ce4c59de3a5a
Currently, if you open the Inspector on some page, then enter RDM, the Inspector
will "reboot" (reload all panels) because it believes the document has reloaded.
However, it's not really true in this case. Instead, it's an artifact of the
pagehide / pageshow events that are triggered when swapping frames like RDM
does. Bug 1438697 adds a chrome-only property that we then use here to
distinguish this case.
MozReview-Commit-ID: Ks42QayVnij
--HG--
extra : rebase_source : 91739a5db2774073e723b1daf43bc5242755fc43
As well as flipping the pref on, this also moves the pref to the common all.js
prefs file because the pref is used by DevTools server code.
MozReview-Commit-ID: GfkLfXg1EiR
--HG--
extra : rebase_source : 952dcc4bce3f9f2ae598a98be3b63a70ba4068b2
See the comment on "Address test failures caused by bumping timer precision to 2 ms"
for more details.
MozReview-Commit-ID: LrsucEPdZIo
--HG--
extra : rebase_source : 8147c034f7dc93f678eebc80b0afabf55729d804
There are a few different reasons why tests needed updating (not an exhaustive list):
- Tests assume that successive operations take place at different times.
- Tests assume that an operation took a minimum amount of time.
- Tests hardcodes a specific delay.
In most cases we hardcode the preference off. In some cases this is the best approach,
in others, we would like to improve. The bug for tracking those improvements is Bug 1429648
An improvement that is present in some tests is to hardcode a specific precision reduction
that is acceptable based on the confides of the test. (Obviously this needs to be a fix for
the test framework and not a requirement on the feature being tested.)
In a few places, the test itself can be fixed, for example to no longer require the end
time of an operation to be strictly greater than the start time, and allows it to be equal
to it.
MozReview-Commit-ID: J59c7xQtZZJ
--HG--
extra : rebase_source : df8a03e76eaf9cdc9524dbb3eb9035af237e534b
This affects several tests, and in all but one case merely disables timer precision
reduction on those tests.
In the other singular test, it no longer requires the end time of an operation to
be strictly greater than the start time, and allows it to be equal to it.
MozReview-Commit-ID: J59c7xQtZZJ
--HG--
extra : rebase_source : c82310ce0269798a9c5bfffaec1f63a24ddc98e5
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <
Luca Greco
Erica Wright
Julian Descottes
Oriol Brufau
Mark Banner
Noemi Erli
Jason Laster
arthur.iakab
J. Ryan Stinnett
Margareta Eliza Balazs
shindli
Boris Zbarsky
Michael Ratcliffe
Andreea Pavel
Bogdan Tara
Adrian Wielgosik
Kris Maglione
Yura Zenevich
Peter Van der Beken
Jonathan Watt
Razvan Caliman
sean-chen
Dorel Luca
Emilio Cobos Álvarez
Alexandre Poirot
Narcis Beleuzu
Patrick Brosset
Brindusan Cristian
Nicolas B. Pierron
Cosmin Sabou
Gabriel Luong
Shuoyi Ma
Nicolas Chevobbe
Sebastian Hengst
Florian Quèze
Brian Grinstead
Jason Orendorff
Frederik Braun
Jan Odvarko
Brian Birtles
Gurzau Raul
Ciure Andrei
Tom Ritter
Coroiu Cristina
Jim Blandy
Zhenghong Qian
Csoregi Natalia
Cameron McCormack
Andrew McCreight
Zhenghong Qian
Tooru Fujisawa