The writing mode / RTL adjustments performed by `getWritingModeMatrix` needs the
element's content size without margins, borders, or padding.
MozReview-Commit-ID: LsSfNN4fyDR
--HG--
extra : rebase_source : 2c98d6ad0ee7593d542d84e64b65332a6917c7a5
Changes and notes:
- Created `devtools/client/shared/test/telemetry-test-helpers.js`, which
contains test helpers to aid in creating and running telemetry tests.
- Removed any telemetry monkeypatching as it is not dependable and no longer
needed (there is some left in GCLI but the test is now disabled because
we are removing GCLI soon anyhow).
- Because `telemetry-test-helpers.js` is imported by `shared-head.js` I
have had to make it available everywhere that shared-head.js is used.
- All telemetry tests have been rewritten to use the new helper.
- shared-head.js cannot be imported by tests inside
`devtools/client/performance/test/` because perf have custom `once` and
`waitFor` implementations that act differently from the ones inside
`shared-head.js`. This means I had to import the telemetry helpers into
`devtools/client/performance/test/head.js`
- Created `devtools/client/shared/test/browser_telemetry_misc.js` to be sure
to catch `DEVTOOLS_SCREEN_RESOLUTION_ENUMERATED_PER_USER` (we catch a few
others to be thorough).
- Disabled `browser_inspector_menu-02-copy-items.js`, which was failing to
test some expired scalars. I also corrected the way the scalars are logged
because it was completely wrong.
MozReview-Commit-ID: JjQEGM6hT61
--HG--
extra : rebase_source : cd1214d01bd11908f69167839975cd93ecb83421
Take into account node offsets in browser_webconsole_object_inspector_local_session_storage.js.
MozReview-Commit-ID: 73waFejjsF0
--HG--
extra : rebase_source : d34e26c280f777e266ab7f014cfb9b41e07c9a5e
This causes various changes to properties-db.js and also many devtools
tests get updated.
There are two changes affect multiple tests:
* `calc` gets removed from everywhere. We never have it listed in all
properties which deserve it, and doing so without much false positive
(i.e. properties don't deserve but get it) can be pretty tricky.
So they are just removed for now.
* The complete color keyword list is no longer included, and instead,
"COLOR" is prepended to the list directly. We can probably remove
the related code which replaces color keywords with "COLOR" from
devtools. Note that, with stylo enabled, the list is already unrelated
to what the parsing code uses. We should eventually re-enable the
disabled test here after we can get the color list from cssparser
in bug 1456715.
Other changes to properties-db.js seem to be valid, some of them also
affect tests:
* `{-webkit-,}align-{content,items,self}` get `first baseline`, `safe`,
`unsafe`, and lose `left` and `right`.
* `{-moz-,-webkit-,}{animation,transition}{,-timing-function}` has a
new `frame` keyword which is a function value in `<timing-function>`.
* `{background,{-webkit-,}mask}-position-x` lose `top` and `bottom`, and
correspondingly `{background,{-webkit-,}mask}-position-y` lose `left`
and `right`. They don't deserve those values.
* `{background,{-webkit-,}mask}{,-size}` get `auto`.
* `border` shorthand loses `<image>` values as well as other keyword
values for `border-image-*` subproperties, because they aren't parsed
on the shorthand.
* `{-moz-,}border-image{,-width}` get `auto`.
* `-moz-context-properties` gets `none`.
* `cursor` get some -moz-prefixed values as well as `url`.
* `fill` and `stroke` get the color keywords.
* `{-webkit-,}filter` get the keywords and function names.
* `font` shorthand loses values from many of `font-variant-*` properties
because they are not parsed there.
* `font-variant` and `font-variant-alternates` get function values of
the longhand.
* `font-variant-{east-asian,ligatures,numeric}` get `normal`, and
`font-variant-ligatures` in addition gets `none`.
`font-{feature,variation}-settings` also get `normal`.
* `grid` and `grid-template-{areas,columns,rows}` get `none`.
* `grid`, `grid-template`, and `grid-template-{columns,rows}` get
`auto`, `fit-content`, `minmax`, and `repeat`.
* `grid-auto-{columns,rows}` get `auto`, `fit-content` and `minmax`.
* `-moz-image-region` gets `auto` and `rect`.
* `{-webkit-,}justify-content` lose `baseline`, `last baseline`, and
get `safe` and `unsafe`.
* `{justify,place}-items` get `first baseline`, `legacy`, `safe`,
`unsafe` and lose `auto`.
* `{justify,place}-self` and `place-content` get `first baseline`,
`safe`, and `unsafe`.
* `outline{,-style}` get `hidden`.
* `scroll-snap-coordinate` gets `none`, and `scroll-snap-points-{x,y}`
gets `none` and `repeat`.
* `shape-outside`, `text-emphasis{,-style}` get all the keyword values
and function names they deserve.
* `stroke-dasharray` gets `none`.
* `text-combine-upright` drops `digits` which we never implemented.
* `{-moz-,-webkit-,}transform` and `-moz-window-transform` get their
transform function list. `accumulatematrix` and `interpolatematrix`
aren't real CSS value but they have `#[css(function)]` specified.
We should probably remove them at some point.
* `will-change` gets `auto`.
* All properties accept `<image>` value now gets -webkit-prefixed
gradient function names, including
* `background{,-image}`,
* `{-moz-,-webkit-,}border-image{,-source}`, and
* `{-webkit-,}mask{,-image}`.
MozReview-Commit-ID: E7Y0CFUFYgW
--HG--
extra : source : bab732c8c531cfca1bcd233f769c25bb2e373773
This also removes any redundant Ci.nsISupports elements in the interface
lists.
This was done using the following script:
acecb401b7/processors/chromeutils-generateQI.jsm
MozReview-Commit-ID: AIx10P8GpZY
--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
Test changes for removal of PopupBoxObject and popup.xml methods, some reflow tests now have different stacks now that they are not going through popup.xml binding methods, test_popupanchor.xul changes due to need to wait for popuppositioned event after resizing. The old code would just adjust the arrow directly when sizeTo was called, but the new code does this through an asynchronous popuppositioned event. Changes to some places that check for XULElement class.
--HG--
rename : dom/webidl/PopupBoxObject.webidl => dom/webidl/XULPopupElement.webidl
rename : layout/xul/PopupBoxObject.cpp => dom/xul/XULPopupElement.cpp
rename : layout/xul/PopupBoxObject.h => dom/xul/XULPopupElement.h
Navigation events now require a "remoted" target. Add `makeRemote` calls to a
tests which make use of these features.
MozReview-Commit-ID: GJsleBWryCd
--HG--
extra : rebase_source : 37ffaac7215b2458a82b8a7a2a59fa4321e370b8
Navigation events now require a "remoted" target. Add `makeRemote` calls to a
tests which make use of these features.
MozReview-Commit-ID: GJsleBWryCd
--HG--
extra : rebase_source : 2319d43ea29cfa33850295ff2d4c902e22ae3727
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
This is pretty simple... finding the best locations for the probes was the
struggle here.
In order to land these probes before the freeze the test for these events will
be created as part of bug 1456073.
MozReview-Commit-ID: 7hIfbD3wQ1I
--HG--
extra : rebase_source : 990e69e0816742fc306b9313bd113f2d71f00b72
***
Bug 1454202: Part 1a - Auto-replace uses of callback-based AddonManager APIs with Promise-based versions. r=aswan
This was done using the following script:
4cd5ae9597/processors/aom-api-generators.jsm
MozReview-Commit-ID: 8hobLz15a66
***
Bug 1454202: Part 1b - Manually fix eslint errors after auto-rewrite. r=aswan
This also deletes an obsolete test whose xpcshell variant was already deleted.
MozReview-Commit-ID: DM9W9Q2SVIE
***
Bug 1454202: Part 1c - Manually fix non-eslint issues after auto-rewrite. r=aswan
MozReview-Commit-ID: DtMscWZuExc
--HG--
extra : rebase_source : d4c2f80bdf02ec4a07e3713a9ae1823145d25942
There are some extra hoops here because devtools has a lint to prevent Cu.importGlobalProperties, which is the normal way one would import a WebIDL constructor.
MozReview-Commit-ID: 2mdNI6N1z5B
After switching to Stylo, animation is handled by Servo, and thus it no
longer relies on the animation type recorded in nsCSSPropList.h, and
devtools become the only consumer of that information.
This patch puts a map of longhands to animation types into devtools
instead. The map is extracted from nsCSSPropList.h by the script below
based on the logic of nsDOMWindowUtils::GetAnimationTypeForLonghand.
There are two reasons that I don't port this into Servo:
First, Servo doesn't have a concept of property-level animation type.
Animation change in Servo is directly encoded into value types. It means
porting this to Servo would require creating a new concept purely for
devtools. It's not great because that data doesn't reflect how animation
is handled in the engine, and people may keep forgetting to give proper
animation type to new animatable types they add.
Second, the handling of animation type in devtools also looks rather
arbitrary to me. For example, eStyleAnimType_Corner_* types are actually
two coordinate values, bug GetAnimationTypeForLonghand returns "coord"
for them, and devtools just parses the first value and uses it. This
means the animation type here is really more closely related to how
devtools handles the value, rather than how the style engine does so.
Given above, I decided to put the list into devtools rather than encode
the information into Servo code. To encourage people to think about
animation handling in devtools for new properties, there is also a new
test added to ensure every property has a devtools animation type.
The content of ANIMATION_TYPE_FOR_LONGHANDS is generated via running
the following script in layout/style:
```python
#!/usr/bin/env python3
import subprocess
from collections import defaultdict
ANIMTYPE_MAPPING = {
"Custom": "custom",
"Coord": "coord",
"Sides_Top": "coord",
"Sides_Right": "coord",
"Sides_Bottom": "coord",
"Sides_Left": "coord",
"Corner_TopLeft": "coord",
"Corner_TopRight": "coord",
"Corner_BottomRight": "coord",
"Corner_BottomLeft": "coord",
"nscoord": "length",
"float": "float",
"Color": "color",
"ComplexColor": "color",
"PaintServer": "paintServer",
"Shadow": "shadow",
"Discrete": "discrete",
"None": "none",
}
input = b"""
#define CSS_PROP(name, id, method, flags, pref, \\
variant, kwtable, animtype) name, flags, animtype
#include "nsCSSPropList.h"
"""
props = subprocess.check_output(["clang", "-E", "-P", "-"], input=input)
props = props.decode("ascii")
result = defaultdict(list)
for line in props.splitlines():
line = line.strip()
if not line:
continue
name, flags, animtype = line.split(", ")
assert animtype.startswith("eStyleAnimType_")
if "CSS_PROPERTY_PARSE_INACCESSIBLE" in flags:
continue
animtype = ANIMTYPE_MAPPING[animtype[15:]]
result[animtype].append(name)
print("[")
for animtype, names in result.items():
print(' ["{}", new Set(['.format(animtype))
for name in names:
print(' "{}",'.format(name))
print(" ])],")
print("]")
```
MozReview-Commit-ID: BGiGq0jUgG5
--HG--
extra : rebase_source : 54fc15b9ccdb6c11d06160d63b8f4b911b754d5a
- Compute constraints so that a dragged marker stays visible with the viewport.
- Constrain dragging of marker to the viewport of the node's host window.
- If the marker is visible outside of the node host's viewport (ex:
shapes within a smaller iframe nested in a larger document), do not
constrain that marker and allow dragging it outside the viewport.
If dragging starts while the marker is within its intended viewport,
do constrain it to that viewport.
MozReview-Commit-ID: 9JyEfseSLXW
The previous implementation treated any zero coordinate as pixels,
regardless of its unit type. For example, 0% would be converted to 0px.
This changed the shape value resulting in unintentional unit mismatch
after editing a coordinate which started off as 0% or 0em or 0vh, etc.
This patch fixes that and preserves the unit type for zero coordinates.
It changes the implementation of isUnitless() to return false for values
like 0%, 0px, 0em, 0.00000%, etc.
It introduces getUnitToPixelRatio() to get the ratio by which to
multiply a pixel value to convert it to the given unit during shape
editing operations (point move, scale, translate, rotate, etc.)
The ratio is constant by unit type. Previously, this ratio was
calculated in-place for each unit value. Values which started as zero,
always resulted in a ratio equal to zero. This multiplied with a pixel
value resulted zero. So the previous code defaulted to ratio of 1 when
the ratio was zero, but this meant that a 1:1 ratio between pixels and
another unit type (%, em, vh) would result in disproportionate
shape changes (1px of mouse travel would result in 1em). This is why
isUnitless() originally discarded the original unit from a zero
coordinate and replaced it with pixels; to account for this fallback
ratio of 1.
MozReview-Commit-ID: 49tyLfYjkLO
The previous implementation treated any zero coordinate as pixels,
regardless of its unit type. For example, 0% would be converted to 0px.
This changed the shape value resulting in unintentional unit mismatch
after editing a coordinate which started off as 0% or 0em or 0vh, etc.
This patch fixes that and preserves the unit type for zero coordinates.
It changes the implementation of isUnitless() to return false for values
like 0%, 0px, 0em, 0.00000%, etc.
It introduces getUnitToPixelRatio() to get the ratio by which to
multiply a pixel value to convert it to the given unit during shape
editing operations (point move, scale, translate, rotate, etc.)
The ratio is constant by unit type. Previously, this ratio was
calculated in-place for each unit value. Values which started as zero,
always resulted in a ratio equal to zero. This multiplied with a pixel
value resulted zero. So the previous code defaulted to ratio of 1 when
the ratio was zero, but this meant that a 1:1 ratio between pixels and
another unit type (%, em, vh) would result in disproportionate
shape changes (1px of mouse travel would result in 1em). This is why
isUnitless() originally discarded the original unit from a zero
coordinate and replaced it with pixels; to account for this fallback
ratio of 1.
MozReview-Commit-ID: 49tyLfYjkLO
While at it, remove useless charset rule lookups, since charset rules aren't
part of the OM, and have no effect at all anymore.
MozReview-Commit-ID: EefGrOZvmm7
`Infinity` object can't be serialized via structuredclone and so actors
should not communicate such object. Fix this code which meant to prevent that.
MozReview-Commit-ID: 3TpldcSE88F
--HG--
extra : rebase_source : 6116f0b8c32e582de21af37da8fb6b72191252a2
This feature introduced in bug 1036949 is not longer used as it was designed for XUL add-ons.
The setFormProperty method was prevently Node's form from getting correctly
serialized between processes.
MozReview-Commit-ID: AiNnHSkwsEM
--HG--
extra : rebase_source : cf12f05f1de49a37a5d8ff694ef448f452f55a06
Use the getBoxQuads's relativeTo option to avoid having to calculate the offset
due to frames.
Also reduce the precision of numbers used when checking if the highlighter is
correctly displayed.
Finally, for some strange reasons, this patch seems to cause a totally unrelated
events mutation event to be sent during the test. This polutes the mutations
received and made the test fail. So I filtered the list of mutations to only
preserve the ones we care about here.
I could not reproduce this extra mutation when running Firefox. Only during the
test. So I did not investigate further.
MozReview-Commit-ID: 1ZQ6FGULjHG
--HG--
extra : rebase_source : 6406571849afb1d3dcec176f68ef4d3d122a1abf
We create one file per actor, and move the ones that are only used by the ObjectActor
into an object folder.
We also take this as an opportunity to extract utils function used in at least 2
different files into an object/utils.js file.
Furthermore, we extract stringifiers and previewers in their own files for readibility
sake, and rename DebuggerServer.ObjectActorPreviewers to previewers only, as
we don't make any use of putting those into DebuggerServer.
MozReview-Commit-ID: L9ajKrzkC4k
--HG--
rename : devtools/server/actors/object.js => devtools/server/actors/array-buffer.js
rename : devtools/server/actors/object.js => devtools/server/actors/object/long-string.js
rename : devtools/server/actors/object.js => devtools/server/actors/object/previewers.js
rename : devtools/server/actors/object.js => devtools/server/actors/object/property-iterator.js
rename : devtools/server/actors/object.js => devtools/server/actors/object/stringifiers.js
rename : devtools/server/actors/object.js => devtools/server/actors/object/symbol-iterator.js
rename : devtools/server/actors/object.js => devtools/server/actors/object/symbol.js
rename : devtools/server/actors/object.js => devtools/server/actors/object/utils.js
extra : rebase_source : ae332d0a85d9d8bcc306d399fffbd0ec643db49c
New remote profiler protocol uses perfActor, but startProfiler doesn't support
parameters such as interval, So perfActor should support parameters for
startProfiler.
nsIProfiler emit profiler-started event with parameters, but perfActor doesn't
set the parameter yet. For unit test, we should set parameter on
profiler-started event.
MozReview-Commit-ID: 3QiNunLyhnf
--HG--
extra : rebase_source : 836f67d2f161816c9947a47a18f912dad77728bf
Bug 962511 added event loop lag info in DevTools for use via a "jank watcher"
tool on Firefox OS devices.
With the removal of Firefox OS, this is now dead code that can be removed.
MozReview-Commit-ID: IHRozqCviuQ
--HG--
extra : rebase_source : 0429ae3655c30ccf79950cd33153ee0a9223c69c
J. Ryan Stinnett
Michael Ratcliffe
Yura Zenevich
Cosmin Sabou
Razvan Caliman
Xidorn Quan
Kris Maglione
Csoregi Natalia
Gabriel Luong
Boris Zbarsky
yulia
Nicolas Chevobbe
Neil Deakin
Alexandre Poirot
David McCurry
Adrian Wielgosik
Andreea Pavel
Dorel Luca
Tiberius Oros
Brad Werth
Margareta Eliza Balazs
Ciure Andrei
Mats Palmgren
Bogdan Tara
Brindusan Cristian
Greg Tatum
Emilio Cobos Álvarez
Brian Grinstead
Markus Stange
arthur.iakab
Jason Laster
Erica Wright
Martin Balfanz
Nika Layzell
Gurzau Raul
Shuoyi Ma
Nicolas B. Pierron
Noemi Erli
Patrick Brosset
Narcis Beleuzu
Julian Descottes
Mark Banner
Oriol Brufau
Makoto Kato