Automatic update from web-platform-tests
[Element Reflection] explicitly set attr-element should not prevent GC.
An explicitly set attr-element is an internal reference from one element
to other element(s). This internal reference is then only exposed if
that reference relationship is considered valid, otherwise the accessors
will "lie" and pretend that the underlying reference is not set by
returning appropriate default values.
A relationship can only be valid if the referenced element is inserted
into the DOM, in which case the reference from its DOM parent will keep
it alive.
If a referenced element is not inserted into the DOM, the only way it
can later become a valid and exposed reference is if there is another
valid reference somewhere (e.g. inside Javascript) which will be used to
insert the referenced element into the DOM at a later point.
If a referenced element is not currently within the DOM, then the only
way it can later become valid and exposed is by being inserted into the
DOM, which requires another reference somewhere (e.g. within Javascript)
to be used to insert into the DOM.
This means that if no other references exist, then the referenced
element(s) can be safely garbage collected as this reference is in an
invalid state (referenced element not in DOM), and we can never reach a
valid state (no other references).
Updating internal maps to store WeakMember(s) rather than Member(s).
This necessitated a move from HeapVector to HeapLinkedHashSet, as
HeapVector does not support WeakMember(s) as elements.
The array setters/getters perform conversion between HeapVector and
HeapLinkedHashSet to keep the V8 bindings happy.
Change-Id: If9733a8affaf9b0b74b705115909627c1dd8e173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2695010
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#860058}
--
wpt-commits: 166fdd4a0a8db278e825763791055c8d0b1cf6ef
wpt-pr: 27892
Automatic update from web-platform-tests
Add 6 transform / compositing block fragmentation tests.
None of them pass by default in Blink. 3 of them pass with
CompositeAfterPaint enabled, while the other 3 also need
LayoutNGBlockFragmentation in addition to CompositeAfterPaint.
Bug: 1058792, 471333, 829028
Change-Id: I99d31cf67e6c4009b6d29e2520c653658b217d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734794
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859913}
--
wpt-commits: d182ea4fe7920d881213fe418bafd5f86a28ada8
wpt-pr: 27895
Automatic update from web-platform-tests
Fix mouse-events/mousemove-between.html on WebKit Linux MSAN
WPT test uievents/order-of-events/mouse-events/mousemove-between.html
timeout on WebKit Linux MSAN, because the mouse actions are generated
and sent too fast that some mouse moves maybe coalesced, so we missed
some mouse events. I added "pause" action for each mouse move, so that
we will handle each individual mouse move, so we will get the correct
mouse action sequence.
Bug: 1182532
Change-Id: I29e1d4832e9eb5b1ffb362d7c5e7475d1e34faf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2731228
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859834}
--
wpt-commits: c886ddac5b825e70ece4eefa86fecc48597e2fc3
wpt-pr: 27888
Automatic update from web-platform-tests
[AspectRatio] Fix flex-aspect-ratio-026.html in legacy
Implement min/max size transfers for replaced elements:
https://drafts.csswg.org/css-sizing-4/#aspect-ratio-size-transfers
Mark both flex-aspect-ratio-025.html and flex-aspect-ratio-026.html as
passing for legacy and update these tests to take both main and cross
size padding into account.
Add flex-aspect-ratio-027.html to verify that min/max-size transfer does not always happen just because aspect-ratio is present.
Bug: 1164135
Change-Id: I20a26cbe256ae5d6a66c5763c7b12f814a3d7ef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2721723
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859812}
--
wpt-commits: 8cbe46672c1f0ec7e09e0a9ff289d897391d91e0
wpt-pr: 27817
Automatic update from web-platform-tests
Remove unused variable and move reset session to a function (#27805)
--
wpt-commits: b3f0923459b5c08e0d3ffa1f57d2449c86619c3a
wpt-pr: 27805
Automatic update from web-platform-tests
Allow fuzzy matching for replaced-element-003
The exact color value of the green in the video can be slightly different,
allow for that.
--
wpt-commits: 92b7f3d73748d0b8d9a2e8ffe2b05b9d127a6933
wpt-pr: 27896
Automatic update from web-platform-tests
[credentialless]: WPT iframe localStorage
Check whether <iframe> inside a COEP:credentialless document have access
to its localStorage.
This is an adaptation from:
[WPT cookie full credentialless]
https://chromium-review.googlesource.com/c/chromium/src/+/2723531
but checking the localStorage instead of cookies.
Bug: 1175099
Change-Id: I27716c99c9c7301ccd6d8fb4f44fbe67dae68223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2726242
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859749}
--
wpt-commits: 68594ce25726aca27ad81ba3098639fe9f1bed69
wpt-pr: 27842
Automatic update from web-platform-tests
Provide a default object size for VideoFrame from CanvasImageSource.
Some elements won't provide a default object size, since they prefer
to render into a sized destination. As such we need to ask for what
the CanvasImageSource thinks its default size is in some cases.
R=tguilbert
Fixed: 1184128
Test: Updated unittests
Change-Id: I2b3ee6a054925458c2f681621f4f30f9d542d113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2733669
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859646}
--
wpt-commits: eee77f31c78f28d53518f21e168e2c1ad8e7ecf9
wpt-pr: 27890
Automatic update from web-platform-tests
[CSS21] move tests from vendor-imports into the main suite (#27574)
--
wpt-commits: db942aaa4fefc5202e44303e5efe610eeb492ad1
wpt-pr: 27574
Automatic update from web-platform-tests
[GridNG] Fix failing scrollable overflow tests.
There were never passing in legacy, but is relatively trivial to pass
in NG.
Effectively NG has the concept of the "inflow-bounds" which for grid
layout is the size of the grid. Legacy never has this clear separation
(kinda using the intrinsic-block-size as a proxy).
Additionally fixes the tests (these have never passed in any browser
so had some "obvious" mistakes).
Bug: 1045599
Change-Id: I990f450ee7ec00a2fd730d402e25632b8c748cd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727860
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#859503}
--
wpt-commits: a12b65954997fb3aa62aba24128b5cbbabc30e64
wpt-pr: 27846
Automatic update from web-platform-tests
Decode str in check_key_cert (#27880)
Converts to a bytes-like object to eliminate the `TypeError`.
Fixes#27879
--
wpt-commits: 5c496d309c2d31c9867ef7a5023a6f7021ba0751
wpt-pr: 27880
Automatic update from web-platform-tests
usb: Move protected interface class enforcement to the browser process
This change moves the definition and enforcement of the list of USB
interface classes which cannot be claimed by code using the WebUSB API
from the renderer process to the browser process. In addition to the
obvious security benefit this enables the list to be controlled by
policy and other flags which are more easily accessed from the browser
process.
Bug: 1056757
Change-Id: Iea3009e2a4453d0a1bbee496b5a67259ec4099d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2728108
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859436}
--
wpt-commits: 972ca5b6693bffebebc5805e1b9da68a6876e1f6
wpt-pr: 27848
Automatic update from web-platform-tests
[ResourceTiming] Interrogate more attributes in Resource Timing WPT
The Resource Timing spec enumerates the attributes for
PerformanceResourceTiming values as well as rules for what each
attribute must contain.
This changes adds tests to validate the computed attributes match
expectations from the spec.
Bug: 1171767
Change-Id: Ic5d284e7cb4a5d186a7cd8fefab342eac916e4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727516
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859365}
--
wpt-commits: bd23e127fcc1456779eded21dda1c1dac66fc1d9
wpt-pr: 27843
Automatic update from web-platform-tests
WPT: `Sec-Fetch-*` headers aren't accessible in service workers.
As requested in https://github.com/whatwg/fetch/pull/993.
Change-Id: Ie6096154ad9f6af73e2c26e0bb0c8f72a2a7a99a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727263
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859345}
--
wpt-commits: df6a144d964283f2929eeb937af2806d9aafec62
wpt-pr: 27857
Automatic update from web-platform-tests
Apply properties to ::first-line according to spec
Use a cascade filter like we do for ::first-letter.
Remove unnecessary style adjustments for ::first-letter and
::first-line.
Fixes DCHECK failure after not loading a pending image for ::first-line
with display: none.
Bug: 1182504
Change-Id: Iea7c450da46278e8af2f56e169275183c32add1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729816
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859342}
--
wpt-commits: ffc4f58489682aeed9711519be5f9a1967b1ec20
wpt-pr: 27871
Automatic update from web-platform-tests
Fix VideoFrame orientation issues, remove public accessor.
Since we aren't quite sure how we want to expose orientation yet,
remove the public accessor from the IDL. As part of doing this
add a bunch of tests for orientation and fix the bugs they found.
As part of fixing these issues, VideoFrameImageUtil now prefers
soft flips to hard flips. Otherwise when using the non SkImage
path, Canvas 'image-orientation: none' won't work properly.
Bug: 1140137,1182435
Test: Lots of new tests.
Change-Id: Ib86754303db473c5829e6a7cbe682d9847b33b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2730247
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859307}
--
wpt-commits: 4d0922f5e75c2424a68df5d3edc965b21388d740
wpt-pr: 27869
Automatic update from web-platform-tests
Add WPT for referrer policy inheritance to popup
Web platform tests did not cover referrer policy inheritance for a
popup. This CL adds a test for it.
Bug: 1130587
Change-Id: I5005bdf249b707ef1f55b39c717534663a9ecf2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2689774
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859291}
--
wpt-commits: 8a6ff0ac7d37c68a5a27600a12b0622d707f80f4
wpt-pr: 27760
Automatic update from web-platform-tests
[css-layout] Don't let contain-intrinsic-size establish an aspect ratio
contain:size on a replaced element kills its natural aspect ratio. Blink
had been treating contain-intrinsic-size values as establishing a new
aspect ratio, but this was not supposed to happen. E.g. the following
should have no aspect ratio:
<img src="100x100.png" style="contain: size; contain-intrinsic-size: 40px 20px">
This change has the side effect of making HasAspectRatio() logically
imply !GetAspectRatio.IsEmpty().
Flex has a DCHECK enforcing that logical relationship, which was
triggered in the canvas test case in this patch.
Fixed: 1175526
Change-Id: I592820a133bfea88ecdff42aade0814cf96ff922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2691931
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859266}
--
wpt-commits: b964db08565d01d21c778783da8e9b5d403de3d4
wpt-pr: 27602
Automatic update from web-platform-tests
webcodecs: Prevent sporadic timeouts of (audio|video)-encoder.any.js
1. Make the audio test faster by encoding less input and comparing
only every 10th sample.
2. Video test with reset() no longer relies on flooding encoder with
frames which was prone to races and timeouts.
3. Declare the tests as slow, because even in their reduced form
they take about 20 seconds with MSAN enabled.
Bug: 1182691
Change-Id: I21fd08e62866fdcf9b3d2133b8cb82676d93d0b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2728493
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859205}
--
wpt-commits: fd21a6df7feb1c6eaef9bdb3b576b84f66d4b4d3
wpt-pr: 27854
Automatic update from web-platform-tests
[GridNG] Separation of legacy and NG when there is a position change
The logic for invalidating the grid when there is a change in its style
needs to different in legacy and NG. A previous change
https://chromium-review.googlesource.com/c/chromium/src/+/2713389
attempted to change the object that was getting invalidated from the
parent to the containing block. However, this approach will only work
for NG.
Changes in the properties listed in GridStyleChanged already force a
full layout on this box due to how the properties are specified in
third_party/blink/renderer/core/style/computed_style_diff_functions.json5
For out-of-flow elements with grid container as containing block, we
currently need to run the entire algorithm for placing and sizing.
Legacy grid needed the extra invalidation |DirtyGrid()| of the cached
state on LayoutGrid before re-running layout on the grid container.
Bug: 1183122, 1183192
Change-Id: Icc5280e7c25802858b55fc0ace4fc2f16359e09e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2728287
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#859177}
--
wpt-commits: e5b144368951eb417299e38f4aba2cfd125ef6d5
wpt-pr: 27866
Automatic update from web-platform-tests
More changes related to removal of <object usemap>
See [1] and [2] for more context, but this just removes more
of the test cases that assume <object usemap> is a thing.
[1] https://crrev.com/858634
[2] https://github.com/web-platform-tests/wpt/pull/27184
Bug: 1182910
Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859170}
--
wpt-commits: 58a7619139e80cfad0571957031c9872ea89f05f
wpt-pr: 27864
Automatic update from web-platform-tests
[Reland]: Repaint when bgcolor animation is triggered
This CL is the reland of:
https://chromium-review.googlesource.com/c/chromium/src/+/2698847
The above CL was reverted because the layout test added was flaky.
In this CL, PS#1 is the reverted CL, and we need to make sure
that the test is no longer flaky.
It turns out that it was the non-virtual version that was flaky,
and the reason is that double raf doesn't seem to be enough to
make the animation jump into the mid-point. I have tested
locally with 500 runs, and the failure rate is ~99%, Oh, that's
bad...
The reason is that run_web_tests might run with a 1ms raf timer
which would be too fast to guarantee the screenshot would be
after the step change.
The solution is very simple, which is to use triple raf instead
of double raf, I have ran both the virtual and non-virtual version
of the test, each one for 500 times locally, and there is no
failure at all.
Bug: 1177320
Change-Id: I95f576994a5d67bf8319b5b1f33e8e6fca6d4bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2716060
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859050}
--
wpt-commits: 06b9e9a505a800d2f3c66df51bbc066a4ee9c890
wpt-pr: 27801
Automatic update from web-platform-tests
Mark ComputedStyle of DateTimeEditElement as font-metric-dependent
DateTimeEditElement::CustomStyleForLayoutObject() measures text width
with the current font, and then uses the result to set the computed
value of 'width'. Therefore, this patch marks this ComputedStyle as
font-metric-dependent, so that we can properly invalidate it when font
changes.
Bug: 1167555
Change-Id: I50cf068062bf36223de2949cea83c75a834f59d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718492
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859046}
--
wpt-commits: e30d360fe5b37f77753452beb32e794aeca11b0f
wpt-pr: 27766
Automatic update from web-platform-tests
Fix (#27865)
Six of those tests are failing in WebKit because one of the subtests of each test generates two boxes with decimal values for heights which generates some rounding issues due to https://bugs.webkit.org/show_bug.cgi?id=222603
So although the bug in WebKit is valid, the main point of the flexbox test is not to check that but the flexbox behaviour with different types of elements as flex items. By carefully tunning the flex fractions we can end up with decimal values that are properly rounded in WebKit even if bug 222603 is not fixed.
--
wpt-commits: 299d8d9a7f9a17e3753c0f0a120408c03bc817c7
wpt-pr: 27865
Automatic update from web-platform-tests
html: autofocus should work even if the URL contains a non-empty fragment
This CL implements the specification change of [1].
- Check existence of :target instead of a non-empty fragment
- Accept autofocus only if all ancestors are in the same origin
- Fix WPT document-with-fragment-valid.html
[1] https://github.com/whatwg/html/pull/6204
Bug: 1046357
Change-Id: Ic83b00b7b48ee94f087974368b5daec98849fc49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727997
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859029}
--
wpt-commits: 4f0a3ea67ef9134ebe34463faec6ba8f6adbf37c
wpt-pr: 27853
Chris Hall
Stephen McGruer
Lan Wei
Morten Stenshorne
moz-wptsync-bot
Rob Buis
Shengfa
Christian Biesinger
arthursonzogni
Joey Arhar
Dale Curtis
Philip Jägenstedt
Ian Kilpatrick
Don
autofoolip
Reilly Grant
Tom McKee
Mike West
Rune Lillesveen
Titouan Rigoudy
Antonio Sartori
David Grogan
Eugene Zemtsov
Ana SollanoKim
Mason Freed
Hassan Talat
Xida Chen
Xiaocheng Hu
Sergio
Kent Tamura