Граф коммитов

955 Коммитов

Автор SHA1 Сообщение Дата
Alexandre Poirot fc5fb970e7 Bug 1515290 - Instantiate DebuggerServer in dedicated loader when debugging chrome tabs. r=yulia,jdescottes
When debugging contexts running from the system compartment, the debugger has
to be loaded in a dedicated Loader, with invisibleToDebugger flag turned on.
This ensures that the Debugger API is going to be used from a distinct system
compartment. Otherwise it may be used from the same compartment than the page
we are debugging.

Differential Revision: https://phabricator.services.mozilla.com/D14957

--HG--
extra : moz-landing-system : lando
2019-01-30 08:04:50 +00:00
Brian Grinstead b7ba45940c Bug 1522921 - Set the devtools chrome debugging prefs to true by default in mochitests and wpt r=ahal,miker
Differential Revision: https://phabricator.services.mozilla.com/D17671

--HG--
extra : moz-landing-system : lando
2019-01-30 03:25:17 +00:00
Cosmin Sabou 599a15d354 Merge mozilla-inbound to mozilla-central. a=merge 2019-01-29 12:01:56 +02:00
Alexandre Poirot a0066e8731 Bug 1515862 - Remove Front's form argument. r=jdescottes
Now that form argument is no longer used by any front to set its actor ID,
we can remove this argument.

Have a particular look at:
* devtools/client/shared/test/test-actor-registry.js
which was the last Front to be manually instantiated and need some tweaks,
* canvas head.js to create canvas front via getFront,
* RDM manager.js, which requires the EmulationFront to be self managed.

Depends on D17615

Differential Revision: https://phabricator.services.mozilla.com/D17616

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:52 +00:00
Alexandre Poirot 4199139118 Bug 1515862 - Remove detail feature from protocol.js. r=jdescottes
This feature is only used by node and domrulestyle actors and that, only for actor ID.
Instead of this, support this "pass only actor ID rather than full form" feature
in a more dedicated way.

We might followup on that to clarify/simplify doing this: passing only the actor ID
rather than its full form.

Depends on D17613

Differential Revision: https://phabricator.services.mozilla.com/D17614

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:46 +00:00
Alexandre Poirot d028804ade Bug 1515862 - Remove unecessary usages of actorid checks in actor and front's form method. r=jdescottes
Remove all actorid checks in actors and fronts as we never pass a defined `detail` argument in them.
Only domstylerule and node are using detail and that, always with detail="actorid".
Also remove ctx and detail in Front constructor as that's not used by these two actors.

Depends on D17612

Differential Revision: https://phabricator.services.mozilla.com/D17613

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:39 +00:00
Alexandre Poirot 385ac7de96 Bug 1515862 - Remove protocol.js's formType. r=jdescottes
None of our actor define a `formType` in its specification.
This feature has never been used, so remove it and its test.

Differential Revision: https://phabricator.services.mozilla.com/D17612

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:33 +00:00
Timothy Guan-tin Chien c013639646 Bug 1507895 - Part V, Remove dom.ua_widget.enabled pref r=smaug
With all the dependency removed this pref can be safely removed.

Depends on D17574

Differential Revision: https://phabricator.services.mozilla.com/D17575

--HG--
extra : moz-landing-system : lando
2019-01-28 18:33:25 +00:00
Jason Laster f38f25dc45 Bug 1521540 - Replace Frame.source form with Frame.actor. r=lsmyth
Tags:

Differential Revision: https://phabricator.services.mozilla.com/D17439
2019-01-25 18:10:34 -05:00
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
vinoth cc6d429241 Bug 1512949 - Remove eval from tests and flip assertion flag r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D14054

--HG--
extra : moz-landing-system : lando
2019-01-24 09:06:07 +00:00
Alexandre Poirot 9e9978c28d Bug 1521052 - Destroy DebuggerServer in the content process when the last connection drops. r=jdescottes
We never really tried to cleanup the DebuggerServer and so a few tests require some tweaks
to acknowledge that once the last connection drop (typically, we close the toolbox or target),
the server is destroyed and dynamically registered actors are also destroyed.

I think it is great to consider that everything is cleaned up as we may followup to destroy
the whole loader.

Depends on D16961

Differential Revision: https://phabricator.services.mozilla.com/D16962

--HG--
extra : moz-landing-system : lando
2019-01-23 14:46:11 +00:00
Alexandre Poirot 189029e823 Bug 1520782 - Convert inspector tests using chrome documents and using server references directly to browser mochitests. r=pbro
These tests were using chrome mochitest which forces the test page to be running in chrome and in parent process.
This doesn't reflect typical setup where the page runs unprivileged in content process.
Also, with the current bug, the pages running in system principal will be debugged with a special setup.
Actors will be run with modules loaded in a distinct loader in order to be executed
in a distinct compartment, distinct from the shared system principal compartment.
That a prerequisite for the Debugger API. It has to run in a distinct compartment than its debuggee.

Depends on D16825

Differential Revision: https://phabricator.services.mozilla.com/D16826

--HG--
rename : devtools/server/tests/mochitest/animation-data.html => devtools/server/tests/browser/animation-data.html
rename : devtools/server/tests/mochitest/test_inspector-mutations-childlist.html => devtools/server/tests/browser/browser_inspector-mutations-childlist.js
rename : devtools/server/tests/mochitest/inspector-helpers.js => devtools/server/tests/browser/inspector-helpers.js
extra : moz-landing-system : lando
2019-01-23 08:53:03 +00:00
Alexandre Poirot a95993b1d7 Bug 1520782 - Convert memory tests using chrome documents and using server references directly to browser mochitests. r=julienw
This test was using chrome mochitest which forces the test page to be running in chrome and in parent process.
This doesn't reflect typical setup where the page runs unprivileged in content process.
Also, with the current bug, the pages running in system principal will be debugged with a special setup.
Actors will be run with modules loaded in a distinct loader in order to be executed
in a distinct compartment, distinct from the shared system principal compartment.
That a prerequisite for the Debugger API. It has to run in a distinct compartment than its debuggee.

Depends on D16824

Differential Revision: https://phabricator.services.mozilla.com/D16825

--HG--
extra : moz-landing-system : lando
2019-01-23 08:53:01 +00:00
Alexandre Poirot 76f1d25301 Bug 1520772 - Construct the WebExtension target front before instantiating the Target object. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D15829

--HG--
extra : moz-landing-system : lando
2019-01-21 11:04:31 +00:00
Alexandre Poirot a75ca7eaa0 Bug 1520773 - Prevent infinite loops in DebuggerClient.close. r=yulia
If any callback fired by DebuggerClient.close ends up calling close again, it will introduce an infinite loop.

Depends on D15826

Differential Revision: https://phabricator.services.mozilla.com/D15827

--HG--
extra : moz-landing-system : lando
2019-01-21 11:04:08 +00:00
yulia f87d14c8d9 Bug 1519107 - make evaluateJS calls use promise pattern rather than callbacks; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16194

--HG--
extra : moz-landing-system : lando
2019-01-21 13:45:03 +00:00
Margareta Eliza Balazs 0ba2ee586d Backed out changeset 92c56dcf69b8 (bug 1512949) for mochitest failures setup | Login to delete is defined: login0 - false == true - got false, expected true (operator ==) CLOSED TREE 2019-01-18 14:19:05 +02:00
vinoth 5d09ad138e Bug 1512949 - Remove eval from tests and flip assertion flag r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D14054

--HG--
extra : moz-landing-system : lando
2019-01-15 13:11:19 +00:00
Brian Hackett 6229eeec5d Bug 1518961 - Show evaluated frames when pausing on exceptions, r=lsmyth. 2019-01-10 15:09:43 -10:00
Oriol Brufau 69e25dc980 Bug 1515046 - Add receiverId parameter in objectClient.getPropertyValue. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D15788

--HG--
extra : moz-landing-system : lando
2019-01-09 06:42:58 +00:00
Brian Hackett 049a2340a5 Bug 1517167 Part 4 - Test fixes for introduction information in dynamically generated <script> elements, r=lsmyth.
--HG--
extra : rebase_source : f1687de0167824f9137eeb46c44198716d013adb
2019-01-08 09:29:25 -10:00
Timothy Guan-tin Chien bd38b39f8a Bug 1512048 - Convert tabmodalprompt binding to JSM module r=Gijs
This converts the tabmodalprompt binding to a class, to be constructed along side with the element
by TabModalPromptBox.

TabModalPromptBox will keep the instances in a map and pass it to the callers, instead of the element.
The tests and callers can access the class instance by passing the element reference to the map.

Differential Revision: https://phabricator.services.mozilla.com/D15505

--HG--
rename : toolkit/components/prompts/content/tabprompts.xml => toolkit/components/prompts/content/tabprompts.jsm
extra : moz-landing-system : lando
2019-01-04 19:29:34 +00:00
Logan Smyth 7faaacaf3c Bug 1516197 - Delay newSource packet processing to avoid blocking onSources. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D15529

--HG--
extra : moz-landing-system : lando
2019-01-03 16:15:35 +00:00
Alexandre Poirot 10ba88604c Bug 1515116 - Let Front's constructor set the actorID instead of doing it manually. r=jdescottes
Depends on D14915

Differential Revision: https://phabricator.services.mozilla.com/D14916

--HG--
extra : moz-landing-system : lando
2019-01-03 10:20:35 +00:00
Jan de Mooij 9190590e09 Bug 1515590 part 3 - Fix some debugger tests by forcing separate compartments for the debugger and debuggee. r=ochameau
With same-compartment chrome globals these would end up in the same compartment.
We need to prevent that because the debugger doesn't support it.

Differential Revision: https://phabricator.services.mozilla.com/D15093

--HG--
extra : moz-landing-system : lando
2018-12-22 21:39:56 +00:00
Anshul Malik c8aabb0526 Bug 1511061 - Blackbox original sources r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D13429

--HG--
extra : moz-landing-system : lando
2018-12-21 00:31:09 +00:00
Logan Smyth 437d7e5db3 Bug 1515438 - Part 2: Create an API endpoint to query available breakpoint locations. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D15014

--HG--
extra : moz-landing-system : lando
2018-12-19 22:18:53 +00:00
Alexandre Poirot ac13c87f42 Bug 1513565 - Get rid of all target.form usages. r=yulia,nchevobbe
Depends on D14278

Differential Revision: https://phabricator.services.mozilla.com/D14279

--HG--
extra : moz-landing-system : lando
2018-12-18 23:35:57 +00:00
Alexandre Poirot bd9855b903 Bug 1513565 - Always use Target's WebConsoleClient instead of trying to instantiate it manually. r=yulia,nchevobbe
This will help getting rid of another usage of Target.form.
And also helps instantiating only one WebConsole client.
Once WebConsole becomes a front, we can replace all the target.activeTab
to target.getFront("console").

Differential Revision: https://phabricator.services.mozilla.com/D14278

--HG--
extra : moz-landing-system : lando
2018-12-18 23:35:55 +00:00
Alexandre Poirot 9d435e1006 Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes
MozReview-Commit-ID: 4CMHJ3tV7Rc

Depends on D14174

Differential Revision: https://phabricator.services.mozilla.com/D14175

--HG--
extra : moz-landing-system : lando
2018-12-17 11:56:30 +00:00
Alexandre Poirot 0d4cf81b11 Bug 1508285 - Use RootFront.rootForm instead of listTabs to fetch global actors. r=yulia
MozReview-Commit-ID: Ed5SyZbB0kq

Depends on D14173

Differential Revision: https://phabricator.services.mozilla.com/D14174

--HG--
extra : moz-landing-system : lando
2018-12-17 11:56:28 +00:00
yulia 1174ad2f82 Bug 1495389 - adjust test to use new performance front initialization; r=ochameau
Depends on D10564

Differential Revision: https://phabricator.services.mozilla.com/D11293

--HG--
extra : moz-landing-system : lando
2018-12-17 11:54:45 +00:00
Jan de Mooij 32215a7603 Bug 1512029 part 3 - Use freshZone for debuggee sandbox created in devtools xpconnect tests. r=bzbarsky
The debuggee and debugger must be in separate compartments. I tried using a null
principal for the debuggee, but that doesn't work because some of these tests
use Components or do interesting principal-related things with the sandbox (see
test_objectgrips-17.js for an example of this).

Differential Revision: https://phabricator.services.mozilla.com/D14254

--HG--
extra : moz-landing-system : lando
2018-12-16 15:00:10 +00:00
Logan Smyth 207fbf2a4d Bug 1512437 - Part 3: Convert all OriginalLocation instances to GeneratedLocations. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D14629

--HG--
extra : moz-landing-system : lando
2018-12-14 23:31:14 +00:00
Logan Smyth b03057f1e8 Bug 1513655 - Remove source-map module and usage from the debugger server. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D14296

--HG--
extra : moz-landing-system : lando
2018-12-14 19:49:08 +00:00
Cosmin Sabou f292d9f90e Backed out changeset 4d61e1b695c9 (bug 1513655) for ESlint failure on devtools/server/actors/thread.js. CLOSED TREE 2018-12-14 21:37:34 +02:00
Logan Smyth 432ea8fcdc Bug 1513655 - Remove source-map module and usage from the debugger server. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D14296

--HG--
extra : moz-landing-system : lando
2018-12-14 19:09:15 +00:00
Alexandre Poirot 3937fdfc00 Bug 1512220 - Convert debugger server test helper to async functions. r=yulia
This cleanup will help next refactorings.
Note that attachTestThread and attachTestTabAndResume are still using the callback style
as it is still being used by tests that aren't using threadClientTest helper.

MozReview-Commit-ID: 6FvoDtzEBmL

Depends on D13901

Differential Revision: https://phabricator.services.mozilla.com/D13902

--HG--
extra : moz-landing-system : lando
2018-12-11 12:14:59 +00:00
Alexandre Poirot 6448b30e9c Bug 1512220 - Refactor debugger test using testGlobal to threadClientTest helper. r=yulia
This isn't removing listTabs calls as these tests were using attachTestTab,
but all these tests are using testGlobal helper whereas they don't have to if they were using threadClientTest helper.

MozReview-Commit-ID: FPtYlDvYUeD

Depends on D13900

Differential Revision: https://phabricator.services.mozilla.com/D13901

--HG--
extra : moz-landing-system : lando
2018-12-11 15:19:43 +00:00
Alexandre Poirot c1ea0a64c2 Bug 1512220 - Refactor promises tests to use the same test helper than memory actor's tests. r=yulia
This isn't thread client test, but here we could share some more code with the memory tests
and use Target objects to retrieve the fronts.

MozReview-Commit-ID: C9S1VjTLrSF

Depends on D13899

Differential Revision: https://phabricator.services.mozilla.com/D13900

--HG--
extra : moz-landing-system : lando
2018-12-11 15:58:13 +00:00
Alexandre Poirot 2bb751479d Bug 1512220 - Switch devtools/server/tests/unit/test_setBreakpoint* tests to threadClientTest. r=yulia
All these tests are clearly copy pasting existing threadClientTest helper.
They might run as well against workers but today we don't run them there, so I used the doNotRunWorker flag.

MozReview-Commit-ID: 7k1lJ06WeGZ

Differential Revision: https://phabricator.services.mozilla.com/D13899

--HG--
extra : moz-landing-system : lando
2018-12-11 17:46:10 +00:00
Alexandre Poirot 37fcc38aa4 Bug 1510949 - Make protocol.js support es6 classes for fronts. r=yulia
MozReview-Commit-ID: JegR2JsyNrI

Differential Revision: https://phabricator.services.mozilla.com/D13780

--HG--
extra : moz-landing-system : lando
2018-12-11 16:32:41 +00:00
Alexandre Poirot 1b70409821 Bug 1502128 - Migrate promises actor tests to server tests. r=yulia
MozReview-Commit-ID: JobfpedA88C

Differential Revision: https://phabricator.services.mozilla.com/D13823

--HG--
rename : devtools/client/debugger/test/mochitest/doc_promise-get-allocation-stack.html => devtools/server/tests/browser/doc_promise-get-allocation-stack.html
rename : devtools/client/debugger/test/mochitest/doc_promise-get-fulfillment-stack.html => devtools/server/tests/browser/doc_promise-get-fulfillment-stack.html
rename : devtools/client/debugger/test/mochitest/doc_promise-get-rejection-stack.html => devtools/server/tests/browser/doc_promise-get-rejection-stack.html
extra : moz-landing-system : lando
2018-12-11 14:15:54 +00:00
Sylvestre Ledru eaf6089240 Bug 1511900 - Fix some wording r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D13712

--HG--
extra : moz-landing-system : lando
2018-12-05 20:00:57 +00:00
Julian Descottes 614db98a2c Bug 1511778 - Remove skip if verify for test_addon_reload and test_addons_actor;r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D13665

--HG--
extra : moz-landing-system : lando
2018-12-04 13:40:07 +00:00
Yura Zenevich fc3cdac0d8 Bug 1507870 - add support for taking a snapshot of the subtree of the accessible object. r=pbro
MozReview-Commit-ID: JdZe0N3ot4c

Differential Revision: https://phabricator.services.mozilla.com/D12502

--HG--
extra : moz-landing-system : lando
2018-11-30 14:55:12 +00:00
Julian Descottes ca974ee77d Bug 1507125 - Protocol Front should throw when called after destroy;r=ochameau
Depends on D13137.

Differential Revision: https://phabricator.services.mozilla.com/D13138

--HG--
extra : moz-landing-system : lando
2018-11-29 10:00:06 +00:00
Narcis Beleuzu 9529070146 Backed out 2 changesets (bug 1507125) for ESlint failure on runtimes.js . CLOSED TREE
Backed out changeset 2b9aaf2f3b58 (bug 1507125)
Backed out changeset 641de22d6480 (bug 1507125)

--HG--
extra : rebase_source : a8338286873050d9636dc6c801f61c7c456e10fd
2018-11-28 19:58:15 +02:00
Julian Descottes 9c97680ee1 Bug 1507125 - Front should throw when sending packet without actorID or destination;r=ochameau
Depends on D13137. I could use help to write the test in a better.
I believe there is a cleaner way to create the front here?
I also had other suggestions for making the fronts more robust in the bug.
Let me know if you think I should try to investigate them more.

Differential Revision: https://phabricator.services.mozilla.com/D13138

--HG--
extra : moz-landing-system : lando
2018-11-28 17:36:25 +00:00
Alexandre Poirot bec5bd8427 Bug 1509315 - Remove unecessary calls to listTabs. r=yulia
These tests are calling listTabs, but that is no longer necessary thanks to rootForm
being automatically managed within RootFront.

MozReview-Commit-ID: AmC6dTIJjiY

Depends on D12732

Differential Revision: https://phabricator.services.mozilla.com/D12733

--HG--
extra : moz-landing-system : lando
2018-11-27 21:48:03 +00:00
Alexandre Poirot 8436b28fee Bug 1509315 - Remove leftover from debugger head.js file. r=yulia
I also removed the get root form leftover.

MozReview-Commit-ID: DxPwG9a5YAG

Depends on D12731

Differential Revision: https://phabricator.services.mozilla.com/D12732

--HG--
extra : moz-landing-system : lando
2018-11-27 21:48:01 +00:00
Alexandre Poirot ae8986ee28 Bug 1509315 - Use TargetFactory.forTab for creating targets in tests. r=yulia
There is 4 patterns here:
* Tests using attachThreadActorForUrl like event-listeners ones. I augmented this helper method to call TargetFactory.
* Tests using attachTargetActorForUrl like debugger-statement, dbg-navigation and target-scoped-actor. Uses TargetFactory directly.
* Tests using connectDebuggerClient like navigateEvents and spaw_actor_in_parent. Uses TargetFactory directly.
* All the others, where creating DebuggerClient on their own, and calling listTabs+attachTarget. They now use TargetFactory directly.

A note about webconsole-helpers, only consoleClient attribute was used from tests using this helper.
Also, in various tests I remove the call to client.destroy, that's because shared-head will
close all the tabs/toolboxes and it should lead to target/client destruction.
Finally, debugger-statement now request the thread actor via the client instead of manual request,
it should help the refactoring to a front!

MozReview-Commit-ID: 2ah4UmSjuoi

Depends on D12730

Differential Revision: https://phabricator.services.mozilla.com/D12731

--HG--
extra : moz-landing-system : lando
2018-11-27 21:47:59 +00:00
Alexandre Poirot 90639c1f6b Bug 1509315 - Pass the full target form to all BrowsingContextTargetFront instances. r=yulia
For now, we only pass { actor } for all tab target fronts created via DebuggerClient.attachTarget,
whereas parent process target fronts were passing the full form from RootFront.getProcess.

MozReview-Commit-ID: 1H2NxFv8glY

Differential Revision: https://phabricator.services.mozilla.com/D12730

--HG--
extra : moz-landing-system : lando
2018-11-27 21:47:52 +00:00
Alexandre Poirot 2118292883 Bug 1506546 - Refactor listAddons call sites. r=yulia
Adapt to the new returned value of listAddons
and also always call it from RootFront instead of DebuggerClient.
Fix the spec in order to expose reload on the front (it was a miss from a previous patch).

MozReview-Commit-ID: AQ5EOQEqnxX

Depends on D12575

Differential Revision: https://phabricator.services.mozilla.com/D12576

--HG--
extra : moz-landing-system : lando
2018-11-27 19:17:48 +00:00
Alexandre Poirot cca3ec2d57 Bug 1506546 - Implement RootFront.getAddon and use it to retrieve a single AddonTargetFront. r=yulia
MozReview-Commit-ID: nWTkfbF9qb

Depends on D12574

Differential Revision: https://phabricator.services.mozilla.com/D12575

--HG--
extra : moz-landing-system : lando
2018-11-27 19:18:06 +00:00
Andreea Pavel 772607498b Backed out 7 changesets (bug 1506546) fo failing devtools at devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_system_addons.js on a CLOSED TREE
Backed out changeset fbe3f2183f32 (bug 1506546)
Backed out changeset 8972a2f14015 (bug 1506546)
Backed out changeset 00fe26234b3d (bug 1506546)
Backed out changeset 7d8e650e25c2 (bug 1506546)
Backed out changeset a293a37483b9 (bug 1506546)
Backed out changeset 7b75250a4f12 (bug 1506546)
Backed out changeset 23ad29cb776e (bug 1506546)
2018-11-27 14:37:14 +02:00
Alexandre Poirot 1ecba9148a Bug 1506546 - Refactor listAddons call sites. r=yulia
Adapt to the new returned value of listAddons
and also always call it from RootFront instead of DebuggerClient.
Fix the spec in order to expose reload on the front (it was a miss from a previous patch).

MozReview-Commit-ID: AQ5EOQEqnxX

Depends on D12575

Differential Revision: https://phabricator.services.mozilla.com/D12576

--HG--
extra : moz-landing-system : lando
2018-11-27 11:23:22 +00:00
Alexandre Poirot a4a14bea9f Bug 1506546 - Implement RootFront.getAddon and use it to retrieve a single AddonTargetFront. r=yulia
MozReview-Commit-ID: nWTkfbF9qb

Depends on D12574

Differential Revision: https://phabricator.services.mozilla.com/D12575

--HG--
extra : moz-landing-system : lando
2018-11-27 11:23:20 +00:00
Nazım Can Altınova e88550b119 Bug 1476775 - Part 2: Change the profiler usage in devtools after API change r=julienw,gregtatum
Depends on D6267

Differential Revision: https://phabricator.services.mozilla.com/D6268

--HG--
extra : moz-landing-system : lando
2018-11-23 16:10:08 +00:00
Alexandre Poirot c9952b3d09 Bug 1508287 - Refactor server xpcshell tests that do not pass in worker context. r=yulia
MozReview-Commit-ID: 4qGo1ZF7ITC

Depends on D12311

Differential Revision: https://phabricator.services.mozilla.com/D12312

--HG--
extra : moz-landing-system : lando
2018-11-22 15:23:26 +00:00
Alexandre Poirot f1e741b9fd Bug 1508287 - Refactor xpcshell tests using custom principal. r=yulia
MozReview-Commit-ID: 3a9IB4XFjff

Depends on D12310

Differential Revision: https://phabricator.services.mozilla.com/D12311

--HG--
extra : moz-landing-system : lando
2018-11-22 15:23:24 +00:00
Alexandre Poirot 8a6b87edaa Bug 1508287 - Refactor most debugger server test using run_test_with_server to share more code. r=yulia
There is a lot of code being copy paste in all these tests
and as I'm most likely going to change things around them in the near future
regarding fission, it would be better if we start sharing more code.

After this there is still a couple of copy paste code (but way less!):
* breakpoints: wait a paused event and eval a custom script in a sandbox
* object grips: set the security.allow_eval_with_system_principal pref, eval stopMe and wait for paused
* stepping: use executeOnNextTickAndWaitForPause to eval a custom script and wait for pause while doing this only on next tick

There is most likely more to share, but at least this isn't framework code, but now only code specific to the debugger.

MozReview-Commit-ID: JgD389cas2j

Depends on D12309

Differential Revision: https://phabricator.services.mozilla.com/D12310

--HG--
extra : moz-landing-system : lando
2018-11-22 15:23:22 +00:00
yulia 899e52534b bug 1507146 - add await to all target.getFront calls in async callsites; r=ochameau
Depends on D11885

Differential Revision: https://phabricator.services.mozilla.com/D11886

--HG--
extra : moz-landing-system : lando
2018-11-14 15:11:59 +00:00
Alexandre Poirot 78e2ca28f0 Bug 1506549 - Introduce API to listen for new child fronts of a given type. r=yulia
MozReview-Commit-ID: EKWTGhGo0VM

Depends on D11624

Differential Revision: https://phabricator.services.mozilla.com/D11625

--HG--
extra : moz-landing-system : lando
2018-11-15 10:23:00 +00:00
Alexandre Poirot 5eed35c08e Bug 1506549 - Stop returning the actor from Pool.manage. r=yulia
This was only used by test and isn't much useful.

MozReview-Commit-ID: DeIimVmMOOs

Depends on D11623

Differential Revision: https://phabricator.services.mozilla.com/D11624

--HG--
extra : moz-landing-system : lando
2018-11-15 10:22:58 +00:00
Alexandre Poirot 1578b6da37 Bug 1506549 - Return target fronts out of RootFront.getProcess and getMainProcess. r=yulia
MozReview-Commit-ID: EGWYEmAkbtr

Depends on D11693

Differential Revision: https://phabricator.services.mozilla.com/D11622

--HG--
extra : moz-landing-system : lando
2018-11-15 10:22:49 +00:00
Julian Descottes c1bc33b0e9 Bug 1506581 - Listen to all possible AddonManager events in BrowserAddonList;r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D11644

--HG--
extra : moz-landing-system : lando
2018-11-13 14:26:39 +00:00
Timothy Guan-tin Chien 2b5881e46b Bug 1503019 - Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:

* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx, JSObject* aGlobal)
* nsDocument::IsShadowDOMEnabled(const nsINode* aNode)
* nsTextNode::IsShadowDOMEnabled(JSContext* aCx, JSObject* aObject)

This function is renamed and updated to nsDocument::IsCallerChromeOrAddon():

* nsDocument::IsShadowDOMEnabledAndCallerIsChromeOrAddon(JSContext* aCx, JSObject* aObject)

I didn't change the tests that load Shadow DOM tests in an iframe, in the interest of keeping hg annotation history.

Differential Revision: https://phabricator.services.mozilla.com/D11183

--HG--
extra : moz-landing-system : lando
2018-11-15 06:51:07 +00:00
Andreea Pavel d51566f085 Backed out 2 changesets (bug 1503019) for failing crashtests at dom/base/crashtests/1505811.html on a CLOSED TREE
Backed out changeset 06b12fd41ff1 (bug 1503019)
Backed out changeset 7b845eac9dd7 (bug 1503019)
2018-11-15 01:52:30 +02:00
Timothy Guan-tin Chien c0cc4f74e7 Bug 1503019 - Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:

* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx, JSObject* aGlobal)
* nsDocument::IsShadowDOMEnabled(const nsINode* aNode)
* nsTextNode::IsShadowDOMEnabled(JSContext* aCx, JSObject* aObject)

This function is renamed and updated to nsDocument::IsCallerChromeOrAddon():

* nsDocument::IsShadowDOMEnabledAndCallerIsChromeOrAddon(JSContext* aCx, JSObject* aObject)

I didn't change the tests that load Shadow DOM tests in an iframe, in the interest of keeping hg annotation history.

Differential Revision: https://phabricator.services.mozilla.com/D11183

--HG--
extra : moz-landing-system : lando
2018-11-14 19:34:52 +00:00
Andreea Pavel b1857361c4 Backed out 5 changesets (bug 1506549) for failing devtools at devtools/client/aboutdebugging/test/browser_service_workers_status.js on a CLOSED TREE
Backed out changeset 6be66dea928c (bug 1506549)
Backed out changeset da0d76d0e8fc (bug 1506549)
Backed out changeset 490eeba8f9f7 (bug 1506549)
Backed out changeset 97554f465eca (bug 1506549)
Backed out changeset 4f259de6cce0 (bug 1506549)
2018-11-14 21:46:07 +02:00
Alexandre Poirot 84741845ef Bug 1506549 - Introduce API to listen for new child fronts of a given type. r=yulia
MozReview-Commit-ID: EKWTGhGo0VM

Depends on D11624

Differential Revision: https://phabricator.services.mozilla.com/D11625

--HG--
extra : moz-landing-system : lando
2018-11-14 16:20:57 +00:00
Alexandre Poirot 65f24f315e Bug 1506549 - Stop returning the actor from Pool.manage. r=yulia
This was only used by test and isn't much useful.

MozReview-Commit-ID: DeIimVmMOOs

Depends on D11623

Differential Revision: https://phabricator.services.mozilla.com/D11624

--HG--
extra : moz-landing-system : lando
2018-11-14 15:48:20 +00:00
Alexandre Poirot c5b46b077f Bug 1506549 - Return target fronts out of RootFront.getProcess and getMainProcess. r=yulia
MozReview-Commit-ID: EGWYEmAkbtr

Depends on D11693

Differential Revision: https://phabricator.services.mozilla.com/D11622

--HG--
extra : moz-landing-system : lando
2018-11-14 15:48:16 +00:00
Alexandre Poirot fb3dcac40b Bug 1498280 - Introduce RootClient.getMainProcess to fetch ParentProcessTargetActor. r=yulia
MozReview-Commit-ID: E9OiwqDwNk7

Differential Revision: https://phabricator.services.mozilla.com/D11758

--HG--
extra : moz-landing-system : lando
2018-11-13 14:07:36 +00:00
Alexandre Poirot 17bf9d1472 Bug 1505175 - Cleanup head_dbg.js from unecessary usages of rootForm. r=yulia
MozReview-Commit-ID: 2ZfghtMuAH2

Depends on D11153

Differential Revision: https://phabricator.services.mozilla.com/D11154

--HG--
extra : moz-landing-system : lando
2018-11-09 09:38:50 +00:00
Alexandre Poirot 393464d343 Bug 1505175 - Refactor get_parent_process_actors to only create a DebuggerClient. r=yulia
MozReview-Commit-ID: ChcKTEaO80a

Depends on D11152

Differential Revision: https://phabricator.services.mozilla.com/D11153

--HG--
extra : moz-landing-system : lando
2018-11-09 09:38:40 +00:00
Alexandre Poirot 8e6a787c3d Bug 1505172 - Remove references to devtools.debugger.forbid-certified-apps preference. r=jdescottes,jryans
MozReview-Commit-ID: JV8MXvIuXaa

Differential Revision: https://phabricator.services.mozilla.com/D11152

--HG--
extra : moz-landing-system : lando
2018-11-08 16:46:58 +00:00
Alexandre Poirot 70c180d3f8 Bug 1503628 - Remove checks against non-remote targets. r=yulia
MozReview-Commit-ID: 5v9HaEUE9E6

Depends on D11011

Differential Revision: https://phabricator.services.mozilla.com/D11012

--HG--
extra : moz-landing-system : lando
2018-11-08 10:09:06 +00:00
Daisuke Akatsuka 1610592c49 Bug 1497448: Rename closeAllListener to closeAllSocketListeners. r=ochameau,jdescottes
Depends on D10868

Differential Revision: https://phabricator.services.mozilla.com/D11150

--HG--
extra : moz-landing-system : lando
2018-11-07 17:46:05 +00:00
Daisuke Akatsuka 5e8c304c73 Bug 1497448: Rename _addListener/_removeListener of DebuggerServer to addSocketListener/removeSocketListener. r=ochameau,jdescottes
Depends on D10867

Differential Revision: https://phabricator.services.mozilla.com/D10868

--HG--
extra : moz-landing-system : lando
2018-11-07 16:56:34 +00:00
Daisuke Akatsuka 56d22dec55 Bug 1497448: Use SocketListener directly. r=ochameau,jdescottes
Depends on D10865

Differential Revision: https://phabricator.services.mozilla.com/D10867

--HG--
extra : moz-landing-system : lando
2018-11-08 00:41:18 +00:00
Logan Smyth f338c9527d Bug 1503436 - Only add breakpoints to first/last offset of script if column is directly in script. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D10384

--HG--
extra : moz-landing-system : lando
2018-11-07 18:52:45 +00:00
Logan Smyth f991551c31 Bug 1504358 - Ensure that step out always pauses, even when there are no steps. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D10793

--HG--
extra : moz-landing-system : lando
2018-11-06 14:59:00 +00:00
Julian Descottes 2f80da43fe Bug 1505035 - Force dom.ua_widget.enabled to true in inspector server tests for ua widgets;r=test-only
--HG--
extra : rebase_source : d573f1a3958c02c7df26919670148d800f983804
2018-11-06 15:41:53 +01:00
Julian Descottes 9dbd9e5cee Bug 1483660 - Add server test for UA widget support in inspector;r=ladybenko
Depends on D10538

Differential Revision: https://phabricator.services.mozilla.com/D10539

--HG--
extra : moz-landing-system : lando
2018-11-05 17:23:54 +00:00
vinoth e14aa2974e Bug 1504605 - Add Prefs to xpcshell test files for allowing usage of eval. r=ckerschb
Reviewers: ckerschb

Reviewed By: ckerschb

Subscribers: ckerschb

Bug #: 1504605

Differential Revision: https://phabricator.services.mozilla.com/D10850

--HG--
extra : rebase_source : 9abb395224bdfa7795516295babfd847ea2553f4
2018-11-05 16:41:45 +02:00
vinoth 896a7bbbd2 Bug 1504207 - Add Prefs for allowing usage of eval with system principal in test files r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10696

--HG--
extra : moz-landing-system : lando
2018-11-05 13:39:31 +00:00
Andreea Pavel c27a20c873 Backed out changeset 792fd0ab86d1 (bug 1503436) for failing damp at damp | debugger/custom.js on a CLOSED TREE 2018-11-01 23:43:49 +02:00
Logan Smyth c775b4ea23 Bug 1503436 - Only add breakpoints to first/last offset of script if column is directly in script. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D10384

--HG--
extra : moz-landing-system : lando
2018-11-01 19:09:41 +00:00
yulia 19c4784940 Bug 1495388 - Fix test failures associated with async inspector initalization; r=ochameau
Depends on D8707

Differential Revision: https://phabricator.services.mozilla.com/D8992

--HG--
extra : moz-landing-system : lando
2018-10-30 14:51:40 +00:00
Alexandre Poirot 976084a82f Bug 1502910 - Remove TimelineActor. r=Honza
MozReview-Commit-ID: DtmS18EYw12

Depends on D10186

Differential Revision: https://phabricator.services.mozilla.com/D10187

--HG--
extra : moz-landing-system : lando
2018-10-30 10:49:19 +00:00
Alexandre Poirot fc621f477f Bug 1485661 - Rename all "root client" to "root front". r=yulia
MozReview-Commit-ID: Eh7f5DeG73j

Depends on D8828

Differential Revision: https://phabricator.services.mozilla.com/D9072

--HG--
extra : moz-landing-system : lando
2018-10-30 08:08:48 +00:00
Alexandre Poirot 64dcba65e2 Bug 1485661 - Refactor all RootClient usages to use promise API instead of callback style. r=yulia
MozReview-Commit-ID: 2jEjUPHg34t

Depends on D8983

Differential Revision: https://phabricator.services.mozilla.com/D8827

--HG--
extra : moz-landing-system : lando
2018-10-30 08:08:44 +00:00
Alexandre Poirot 8838f52a83 Bug 1485661 - Special test fixes. r=yulia
* browser_two_tabs.js, adapt to protocol.js exception on RDP error.
  protocol.js throws strings instead of { error, message }.
* target-from-url.js, same, it made a test fail.
* browser_toolbox_tool_remote_reopen.js, ignore root front that isn't release on
  toolbox close, but on client close.
* test_protocol_formtype.js, ensure that test root front isn't overridden
  by regular root front's spec.

MozReview-Commit-ID: HCuyZTQpaCt

Depends on D8825

Differential Revision: https://phabricator.services.mozilla.com/D8983

--HG--
extra : moz-landing-system : lando
2018-10-30 08:08:42 +00:00
Alexandre Poirot 2c52a12910 Bug 1485661 - Adapt processListChanged to new front. r=yulia
MozReview-Commit-ID: 1CSeNU9Nfll

Depends on D8821

Differential Revision: https://phabricator.services.mozilla.com/D8822

--HG--
extra : moz-landing-system : lando
2018-10-30 08:08:29 +00:00
Alexandre Poirot 5464dd4264 Bug 1485661 - Adapt addonListChanged to new front. r=yulia
MozReview-Commit-ID: 7BJ9qZYP2YO

Depends on D8820

Differential Revision: https://phabricator.services.mozilla.com/D8821

--HG--
extra : moz-landing-system : lando
2018-10-30 08:08:27 +00:00
Jim Blandy 13191f2ae4 Bug 1426467: Part 5: Mochitest: pause/unpause window while worker sends messages, without breaking run-to-completion. r=baku
Detailed comments in the test itself.

Differential Revision: https://phabricator.services.mozilla.com/D9221

--HG--
extra : moz-landing-system : lando
2018-10-22 15:35:15 +00:00
Julian Descottes 52b85a20e2 Bug 1499096 - Update wrong usage of ok() with todo_is();r=Standard8
Depends on D8739.
This changeset updates calls to ok() that were most likely intended
for is(), but are not working as is.

Differential Revision: https://phabricator.services.mozilla.com/D8740

--HG--
extra : moz-landing-system : lando
2018-10-23 07:13:02 +00:00
Julian Descottes 2fcd6cb020 Bug 1499096 - Update tests using ok() to is();r=Standard8
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.

Differential Revision: https://phabricator.services.mozilla.com/D8739

--HG--
extra : moz-landing-system : lando
2018-10-23 07:12:23 +00:00
Mark Banner ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
yulia c22cefe4e6 Bug 1488375 - Use target.getFront to instantiate MemoryFront; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D7097

--HG--
extra : moz-landing-system : lando
2018-10-17 10:36:33 +00:00
Alexandre Poirot 0f5e860391 Bug 1495551 - Rename all "tab client" occurences to "target front". r=jdescottes
MozReview-Commit-ID: JrEdamUz6Be

Differential Revision: https://phabricator.services.mozilla.com/D8840

--HG--
extra : moz-landing-system : lando
2018-10-16 18:45:33 +00:00
yulia d407fdf975 Bug 1497545 - clean up framerate tests; r=ochameau
Depends on D8542

Differential Revision: https://phabricator.services.mozilla.com/D8543

--HG--
extra : moz-landing-system : lando
2018-10-16 14:18:10 +00:00
yulia 5aecbef59c Bug 1497545 - Use getFront for Framerate Front where possible; r=ochameau
In this patch, I converted the call sites where there was an obvious target. I left out
those where there wasn't one... Should these be converted as well?

Depends on D8369

Differential Revision: https://phabricator.services.mozilla.com/D8374

--HG--
extra : moz-landing-system : lando
2018-10-16 14:17:52 +00:00
yulia ba9f6d1c74 Bug 1497545 - remove client and cleanup from attachURL; r=ochameau
Depends on D8372

Differential Revision: https://phabricator.services.mozilla.com/D8541

--HG--
extra : moz-landing-system : lando
2018-10-15 16:08:53 +00:00
yulia ca44cba877 Bug 1497545 - Use getInspector in devtools/server/tests/mochitest r=ochameau
This patch converts all getInspector locations

Depends on D8369

Differential Revision: https://phabricator.services.mozilla.com/D8372

--HG--
extra : moz-landing-system : lando
2018-10-15 12:56:28 +00:00
yulia ef5919e881 Bug 1497545 - update inspector-helper attachURL to provide a target; r=ochameau
This is part 1 of bug 1497545, and covers the most difficult case, which is migrating
attachURL to something a bit more modern and easier to read. The goal is to make our tests more
consistant with our code base now, and keep these tests maintainable.

UPDATE: I will split this up, as it is too large to review in one pass

Differential Revision: https://phabricator.services.mozilla.com/D8369

--HG--
extra : moz-landing-system : lando
2018-10-12 13:45:27 +00:00
Alexandre Poirot 9c63f6e5ba Bug 1485660 - Special test fixes. r=jdescottes
* browser_addons_debug_webextension_popup: It looks like frame-update events are now fired earlier.
I had to move the listener to an earlier step in order to make it work.
* helper_disable_cache + toolbox.js: this test wasn't correctly listening for reconfigure request's end.
  Not clear how this test was passing before without high rate of intermittent...
* test_webextension-addon-debugging-connect.html: We can no longer listen for frame-update *before* the target object is created.
  (because we now need a TabTarget object or the TargetFront and not just the DebuggerClient)
* Fix reload request in shadereditor which may still be pending after test ends.

MozReview-Commit-ID: 49qvWSCn6nq

Depends on D8066

Differential Revision: https://phabricator.services.mozilla.com/D7460

--HG--
extra : moz-landing-system : lando
2018-10-15 08:36:15 +00:00
Alexandre Poirot bbd1bcdcbe Bug 1485660 - Switch from listening from DebuggerClient to TargetFront. r=jdescottes
* debugger-controller and events.js are special and require to support two cases because this is
the only production codepath that can have a TabTarget or a WorkerTarget.
Thus, leading to either TargetFront or WorkerClient on target.activeTab.
* webide.js doesn't need to listen for tabNavigated, this is redundant with tabListChanged.
* application's initializer. In case you are wondering this code can't be spawn against a WorkerTarget.
The application panel doesn't work in worker toolboxes.
* The code modified in target is in TabTarget, so we don't have to support the WorkerClient case, we always have a TargetFront here.
* I tried to update the doc file the best I can but this all feel outdated.

MozReview-Commit-ID: 2hGchebfIub

Depends on D7458

Differential Revision: https://phabricator.services.mozilla.com/D7459

--HG--
extra : moz-landing-system : lando
2018-10-15 08:36:10 +00:00
Tim Nguyen 53b1b96828 Bug 1497969 - Add a way to emulate :focus-within pseudo-class. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D8275

--HG--
extra : moz-landing-system : lando
2018-10-12 21:56:44 +00:00
Bogdan Tara e1dc69e799 Backed out changeset 94ccc53c61a7 (bug 1488375) for test_memory_allocations_0x.html failures CLOSED TREE 2018-10-12 19:18:18 +03:00
yulia cd546f12d8 Bug 1488375 - Use target.getFront to instantiate MemoryFront; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D7097

--HG--
extra : moz-landing-system : lando
2018-10-12 13:38:21 +00:00
Brindusan Cristian e1f4f3ac73 Backed out changeset 0ff0cb536428 (bug 1497969) for devtools failures on browser_rules_add-rule-pseudo-class.js. CLOSED TREE 2018-10-12 00:00:47 +03:00
Tim Nguyen c74ececee9 Bug 1497969 - Add a way to emulate :focus-within pseudo-class. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D8275

--HG--
extra : moz-landing-system : lando
2018-10-11 18:51:01 +00:00
Brindusan Cristian c328bc1cdf Backed out 8 changesets (bug 1485660) for damp failures on front.hasRequests. CLOSED TREE
Backed out changeset 7a2f29bbe2a8 (bug 1485660)
Backed out changeset 26e82fa62444 (bug 1485660)
Backed out changeset 9bb2f56f219d (bug 1485660)
Backed out changeset 40a3c2dd1b38 (bug 1485660)
Backed out changeset cfb160882db9 (bug 1485660)
Backed out changeset 3642f2d66777 (bug 1485660)
Backed out changeset 9026679753b2 (bug 1485660)
Backed out changeset dccca441b980 (bug 1485660)
2018-10-11 22:33:35 +03:00
Alexandre Poirot 8a6814c2df Bug 1497644 - Ensure that RootClient is used for all requests made to the root actor. r=yulia
MozReview-Commit-ID: HJm7yQCMbkg

Depends on D8141

Differential Revision: https://phabricator.services.mozilla.com/D8142

--HG--
extra : moz-landing-system : lando
2018-10-11 16:25:23 +00:00
Alexandre Poirot cf0d0480eb Bug 1497644 - Always call Root actor's getProcess request via RootClient.getProcess r=yulia
I also made its argument mandatory, so that later in root spec we can use a non-nullable number.

MozReview-Commit-ID: BUPgI1ww1gC

Differential Revision: https://phabricator.services.mozilla.com/D8141

--HG--
extra : moz-landing-system : lando
2018-10-11 16:26:45 +00:00
Alexandre Poirot 99a923c818 Bug 1485660 - Special test fixes. r=jdescottes
* browser_addons_debug_webextension_popup: It looks like frame-update events are now fired earlier.
I had to move the listener to an earlier step in order to make it work.
* helper_disable_cache + toolbox.js: this test wasn't correctly listening for reconfigure request's end.
  Not clear how this test was passing before without high rate of intermittent...
* test_webextension-addon-debugging-connect.html: We can no longer listen for frame-update *before* the target object is created.
  (because we now need a TabTarget object or the TargetFront and not just the DebuggerClient)

MozReview-Commit-ID: 49qvWSCn6nq

Depends on D8066

Differential Revision: https://phabricator.services.mozilla.com/D7460

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:32 +00:00
Alexandre Poirot 8c5e401017 Bug 1485660 - Switch from listening from DebuggerClient to TargetFront. r=jdescottes
* debugger-controller and events.js are special and require to support two cases because this is
the only production codepath that can have a TabTarget or a WorkerTarget.
Thus, leading to either TargetFront or WorkerClient on target.activeTab.
* webide.js doesn't need to listen for tabNavigated, this is redundant with tabListChanged.
* application's initializer. In case you are wondering this code can't be spawn against a WorkerTarget.
The application panel doesn't work in worker toolboxes.
* The code modified in target is in TabTarget, so we don't have to support the WorkerClient case, we always have a TargetFront here.
* I tried to update the doc file the best I can but this all feel outdated.

MozReview-Commit-ID: 2hGchebfIub

Depends on D7458

Differential Revision: https://phabricator.services.mozilla.com/D7459

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:28 +00:00
Yura Zenevich b0746404ef Bug 1492866 - add accessible relations to accessibility panel sidebar. r=pbro
MozReview-Commit-ID: 5u8SRnlnFyN

Differential Revision: https://phabricator.services.mozilla.com/D7208

--HG--
extra : moz-landing-system : lando
2018-10-11 14:51:35 +00:00
Noemi Erli 4e75dfc2f6 Backed out changeset 06f4b6597f74 (bug 1497969) for failures in devtools/client/inspector/rules/test/browser_rules_pseudo_lock_options.js 2018-10-11 15:18:45 +03:00
Tim Nguyen a59e428226 Bug 1497969 - Add a way to emulate :focus-within pseudo-class. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D8275

--HG--
extra : moz-landing-system : lando
2018-10-11 09:23:09 +00:00
Ciure Andrei 255e7e1b04 Backed out changeset 2084a929ec4c (bug 1492866) for browser_accessibility_walker.js faiures CLOSED TREE 2018-10-10 23:46:13 +03:00
Yura Zenevich 0d998fb64c Bug 1492866 - add accessible relations to accessibility panel sidebar. r=pbro
MozReview-Commit-ID: 5u8SRnlnFyN

Differential Revision: https://phabricator.services.mozilla.com/D7208

--HG--
extra : moz-landing-system : lando
2018-10-10 19:18:03 +00:00
Alexandre Poirot f2092025cc Bug 1497292 - Switch RootClient calls from callbacks to promises. r=yulia
MozReview-Commit-ID: B1Z3tCjCHU3

Differential Revision: https://phabricator.services.mozilla.com/D8023

--HG--
extra : moz-landing-system : lando
2018-10-09 08:06:10 +00:00
Alexandre Poirot 687cff632b Bug 1492265 - Use a content process target actor for xpcshell debugging. r=jdescottes
MozReview-Commit-ID: J9XTgC0EBPG

Depends on D7415

Differential Revision: https://phabricator.services.mozilla.com/D7416

--HG--
extra : moz-landing-system : lando
2018-10-09 09:31:08 +00:00
yulia 3b9941d99e Bug 1488377 - Use target.getFront to instantiate CssPropertiesFront; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D7886

--HG--
extra : moz-landing-system : lando
2018-10-08 15:01:45 +00:00
Andreea Pavel 3764388b3e Backed out changeset 26d2f8e018b5 (bug 1492265) for failing xpcshell at devtools/server/tests/unit/test_promises_actor_attach.js a CLOSED TREE
--HG--
extra : amend_source : 05b3fe80cc8b79bebb697cddbe9ad22deb4261fc
2018-10-08 19:16:21 +03:00
Alexandre Poirot 6b9e5a6f3d Bug 1492265 - Use a content process target actor for xpcshell debugging r=jdescottes on a CLOSED TREE
MozReview-Commit-ID: J9XTgC0EBPG

Depends on D7415

Differential Revision: https://phabricator.services.mozilla.com/D7416

--HG--
extra : source : 9259cfe05c4ecd43d5e8ca354fa14ba4b96a6ae3
extra : histedit_source : 25c98064b79fd9c132ad19c874b7a535e8742dc2
2018-10-08 14:26:05 +00:00
Andreea Pavel 43fb61451b Backed out 3 changesets (bug 1492265, bug 1496025) for failing org.mozilla.geckoview.test.AccessibilityTest.testMoveByCharacter on a CLOSED TREE
Backed out changeset 9259cfe05c4e (bug 1492265)
Backed out changeset 1292fd4850a7 (bug 1496025)
Backed out changeset c9a6fdac66bb (bug 1496025)
2018-10-08 18:07:26 +03:00
Alexandre Poirot c61d2c2071 Bug 1492265 - Use a content process target actor for xpcshell debugging r=jdescottes
MozReview-Commit-ID: J9XTgC0EBPG

Depends on D7415

Differential Revision: https://phabricator.services.mozilla.com/D7416

--HG--
extra : moz-landing-system : lando
2018-10-08 14:26:05 +00:00
Alexandre Poirot 5bed7198d7 Bug 1496025 - Remove Promises actor r=gl
MozReview-Commit-ID: 55Y9FrpXCL1

Differential Revision: https://phabricator.services.mozilla.com/D7689

--HG--
extra : moz-landing-system : lando
2018-10-08 11:12:40 +00:00
yulia 7cee761279 Bug 1494605 - Use target.getFront for PerformanceFront in tests; r=ochameau
Depends on D6768

Differential Revision: https://phabricator.services.mozilla.com/D7060

--HG--
extra : moz-landing-system : lando
2018-10-04 14:57:32 +00:00
Narcis Beleuzu 8f9c481c6c Backed out changeset cb8b8676ee77 (bug 1494605) as per Yulia`s request. 2018-10-04 14:12:32 +03:00
yulia cb536a7665 Bug 1494605 - Use target.getFront for PerformanceFront in tests; r=ochameau
Depends on D6768

Differential Revision: https://phabricator.services.mozilla.com/D7060

--HG--
extra : moz-landing-system : lando
2018-10-01 09:43:47 +00:00
Cosmin Sabou d20960ffed Merge mozilla-inbound to mozilla-central. a=merge 2018-10-04 00:56:04 +03:00
Alexandre Poirot a93a6c5cc6 Bug 1492434 - Computes isBrowsingContext from TabTarget out of actor's form r=jdescottes
Instead of requiring all TargetFactory.forRemoteTab to compute isBrowsingContext flag,
we can compute it out of the actor's form as we know which types are browsing context
inherited or not.

MozReview-Commit-ID: H5zLo5nZSm6

Differential Revision: https://phabricator.services.mozilla.com/D7413

--HG--
extra : moz-landing-system : lando
2018-10-03 09:07:18 +00:00
Gurzau Raul b7cb3e6ec9 Backed out changeset c209b1927107 (bug 923975) for failing at mochitest/browser_dbg_rr_stepping-02.js, etc. removed obsolete files. a=backout 2018-10-02 09:16:01 +03:00
Gurzau Raul f74a105ce1 Backed out changeset c209b1927107 (bug 923975) for failing at mochitest/browser_dbg_rr_stepping-02.js, etc. a=backout 2018-10-02 09:11:50 +03:00
Jason Laster 68a4b4feea Bug 923975 - Teach step out to leave the current frame. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D2135

--HG--
extra : moz-landing-system : lando
2018-10-01 20:54:43 +00:00
yulia 9809b1f863 Bug 1488381 - Use target.getFront to instantiate WebExtensionInspectedWindowFront; r=ochameau
Depends on D6768

Differential Revision: https://phabricator.services.mozilla.com/D7063

--HG--
extra : moz-landing-system : lando
2018-09-28 17:52:26 +00:00
yulia 1f713970f4 Bug 1488373 - Use target.getFront to instantiate StyleSheetsFront; r=ochameau
Depends on D6768

Differential Revision: https://phabricator.services.mozilla.com/D7093

--HG--
extra : moz-landing-system : lando
2018-09-27 15:44:54 +00:00
yulia b107324366 Bug 1488374 - Use target.getFront to instantiate StorageFront; r=ochameau
Depends on D7061

Differential Revision: https://phabricator.services.mozilla.com/D7062

--HG--
extra : moz-landing-system : lando
2018-09-30 06:55:23 +00:00
Jason Laster 716f4ecb2b Bug 923975 - Teach step out to leave the current frame. r=jlast 2018-10-03 09:50:44 -04:00
yulia bb6365c720 Bug 1487428 - Use target.getFront in server browser tests; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D6768

--HG--
extra : moz-landing-system : lando
2018-09-28 05:46:29 +00:00
yulia 2324dc62c4 Bug 1485373 - Use client.mainRoot.getFront to fetch all global actors; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D6792

--HG--
extra : moz-landing-system : lando
2018-09-28 07:07:14 +00:00
Bogdan Tara 273a59bcda Backed out changeset e7624782898d (bug 1487428) for test_inspector-insert.html failures CLOSED TREE 2018-09-27 23:38:04 +03:00
yulia 26f84dc0e4 Bug 1487428 - Use target.getFront in server browser tests; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D6768

--HG--
extra : moz-landing-system : lando
2018-09-27 15:18:08 +00:00
Gurzau Raul a8d8876e9e Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-27 19:45:35 +03:00
yulia 72f9e83eb1 Bug 1473513 - move ActorRegistry module to server/actors/utils; r=ochameau
Summary: Depends on D6477

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6479

--HG--
rename : devtools/server/actor-registry.js => devtools/server/actors/utils/actor-registry.js
extra : rebase_source : ae52db7b028b4d866d8a363eae9ae7c124714458
2018-09-26 10:09:15 +02:00
yulia dd29e366ea Bug 1473513 - refactor main.js to use protocol.js pools; r=ochameau
Summary:
MozReview-Commit-ID: FNMK4f553yI

Depends on D6474

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6475

--HG--
extra : rebase_source : c61d394da0a20991def49968f01ee563fea9afde
2018-09-26 10:07:27 +02:00
yulia 9c120b705d Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
Summary:
MozReview-Commit-ID: 3GsXRxcIKfx

Depends on D6473

Reviewers: ochameau

Reviewed By: ochameau

Subscribers: reviewbot

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6474

--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : rebase_source : 3ea4edd91ca8b09ad5e25ae01df885c587bee7b1
2018-09-26 10:06:43 +02:00
yulia e1c0e43fff Bug 1473513 - remove other instances of ActorPool from browsingContext and root; r=ochameau
Summary:
MozReview-Commit-ID: GxkLzvxJgdY

Depends on D6471

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6472

--HG--
extra : rebase_source : 8877be9e01d379375a167c58c61d94efd4997e19
2018-09-26 10:05:31 +02:00
yulia 4a8f74eb3e Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
Summary:
create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor;

Depends on D6468

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6470

--HG--
rename : devtools/server/actors/common.js => devtools/shared/protocol/lazy-pool.js
extra : rebase_source : 09a1c8eac3cbb5856a5e3e61a1c0540efe32e5bd
2018-09-26 10:03:33 +02:00
Alexandre Poirot c4e18d3974 Bug 1494305 - Refactor all tabClient usages to use promise API instead of callback style r=yulia
MozReview-Commit-ID: DZVG1X45sQV

Differential Revision: https://phabricator.services.mozilla.com/D6908

--HG--
extra : moz-landing-system : lando
2018-09-26 18:02:45 +00:00
Logan F Smyth c14f7c8aff Bug 1473996 - Expose fn.apply in the devtools server. r=nchevobbe
Depends on D6722

Differential Revision: https://phabricator.services.mozilla.com/D6723

--HG--
extra : moz-landing-system : lando
2018-09-26 16:23:25 +00:00
Logan F Smyth 11febfa688 Bug 1473996 - Expose getPropertyValue in devtools server to fully evaluate an object property. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D6722

--HG--
extra : moz-landing-system : lando
2018-09-26 16:12:56 +00:00
sreeise 847b33d284 Bug 1423201 - Changed uses of defer to new Promise in devtools/server/tests/mochitest r=nchevobbe
Functions using 'defer' for promises are being switched to the 'new Promise' syntax. This is for changes in devtools/server/tests/mochitest.

Differential Revision: https://phabricator.services.mozilla.com/D6618

--HG--
extra : moz-landing-system : lando
2018-09-26 02:44:56 +00:00
Alexandre Poirot 18a737b18d Bug 1473513 - Backed out changeset 27419719402e for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 43tUMmC1Je0

Depends on D6811

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6812
2018-09-25 19:35:00 +03:00
Alexandre Poirot 67f96eff34 Bug 1473513 - Backed out changeset e56c70bd2f9a for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 9FIL35Nq726

Depends on D6809

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6810
2018-09-25 19:34:43 +03:00
Alexandre Poirot 1255c658b2 Bug 1473513 - Backed out changeset d72f6ff37ca6 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: LKPmFrhaQ5q

Depends on D6807

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6808
2018-09-25 19:34:26 +03:00
Alexandre Poirot 40272ff560 Bug 1473513 - Backed out changeset f9f12b44a3ab for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 8POm9seFrAk

Depends on D6806

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6807
2018-09-25 19:34:18 +03:00
Alexandre Poirot a3c7499a55 Bug 1473513 - Backed out changeset 174fe98999ea for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: GfSX2wYfLrN

Depends on D6803

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6804

--HG--
rename : devtools/server/actors/utils/actor-registry.js => devtools/server/actor-registry.js
2018-09-25 19:33:52 +03:00
Alexandre Poirot 8dac98409f Bug 1473513 - Backed out changeset 950ce58bfb24 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary: MozReview-Commit-ID: 1HAisV9S6ls

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6803
2018-09-25 19:33:43 +03:00
Alexandre Poirot 62fca91459 Bug 1473513 - Fix merge conflict between bug 1473513 and 1485676 against this test. CLOSED TREE
Summary: MozReview-Commit-ID: KyizI0V5pt5

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6778
2018-09-25 17:24:00 +03:00
Margareta Eliza Balazs 5ad86cabda Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-25 12:50:02 +03:00
yulia 04d870f203 Bug 1473513 - move ActorRegistry module to server/actors/utils; r=ochameau
Depends on D6477

Differential Revision: https://phabricator.services.mozilla.com/D6479

--HG--
rename : devtools/server/actor-registry.js => devtools/server/actors/utils/actor-registry.js
extra : moz-landing-system : lando
2018-09-25 08:47:10 +00:00
yulia 1ad50b5afe Bug 1473513 - refactor main.js to use protocol.js pools; r=ochameau
MozReview-Commit-ID: FNMK4f553yI

Depends on D6474

Differential Revision: https://phabricator.services.mozilla.com/D6475

--HG--
extra : moz-landing-system : lando
2018-09-25 08:05:47 +00:00
yulia e857119004 Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
MozReview-Commit-ID: 3GsXRxcIKfx

Depends on D6473

Differential Revision: https://phabricator.services.mozilla.com/D6474

--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : moz-landing-system : lando
2018-09-25 08:05:29 +00:00
yulia 54d3f62aa0 Bug 1473513 - remove other instances of ActorPool from browsingContext and root; r=ochameau
MozReview-Commit-ID: GxkLzvxJgdY

Depends on D6471

Differential Revision: https://phabricator.services.mozilla.com/D6472

--HG--
extra : moz-landing-system : lando
2018-09-25 08:04:41 +00:00
yulia 1cea42cdd7 Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor;

Depends on D6468

Differential Revision: https://phabricator.services.mozilla.com/D6470

--HG--
rename : devtools/server/actors/common.js => devtools/shared/protocol/lazy-pool.js
extra : moz-landing-system : lando
2018-09-25 08:03:42 +00:00
Alexandre Poirot c7a9923fc3 Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-24 09:52:59 -07:00
Alexandre Poirot fc8714580a Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
Summary:
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.

Depends On D4078

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6161

MozReview-Commit-ID: KmFi1LIUBga
2018-09-24 09:52:57 -07:00
Alexandre Poirot 082e20e693 Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-24 09:52:55 -07:00
Gurzau Raul ad28ad0169 Backed out 9 changesets (bug 1485676) for failing at damp inspector/cold-open.js on a CLOSED TREE
Backed out changeset 4de2e71debfe (bug 1485676)
Backed out changeset e63025150c7a (bug 1485676)
Backed out changeset f9ef30ae3f7f (bug 1485676)
Backed out changeset a83636fab16a (bug 1485676)
Backed out changeset b1fd24929e09 (bug 1485676)
Backed out changeset acb27b915742 (bug 1485676)
Backed out changeset ba2157632772 (bug 1485676)
Backed out changeset d1d6b9bc2372 (bug 1485676)
Backed out changeset d7646ea8640b (bug 1485676)
2018-09-22 19:42:04 +03:00
Alexandre Poirot f98d0997fe Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-22 08:34:21 -07:00
Alexandre Poirot 8724260e30 Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
Summary:
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.

Depends On D4078

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6161

MozReview-Commit-ID: KmFi1LIUBga
2018-09-22 08:34:21 -07:00
Alexandre Poirot 48f5790c9b Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-22 08:34:20 -07:00
Zibi Braniecki 83ea94f5ba Bug 1491394 - Update callsites to use new mozILocaleService API. r=jfkthame
Depends on D5924

Differential Revision: https://phabricator.services.mozilla.com/D6339

--HG--
extra : moz-landing-system : lando
2018-09-21 15:30:37 +00:00
arthur.iakab 6877b6a75c Backed out 9 changesets (bug 1485676)for perma failures in devtools/client/canvasdebugger/test/browser_canvas-actor-test-01.js CLOSED TREE
Backed out changeset 9f5ec2aa7109 (bug 1485676)
Backed out changeset 0d530c1316a4 (bug 1485676)
Backed out changeset 03278e6fe685 (bug 1485676)
Backed out changeset 275463260056 (bug 1485676)
Backed out changeset 4c5a956b33f7 (bug 1485676)
Backed out changeset d8fe80bb0e3c (bug 1485676)
Backed out changeset 56240996921f (bug 1485676)
Backed out changeset ec0a322f5cc9 (bug 1485676)
Backed out changeset f0f4f9407970 (bug 1485676)
2018-09-21 12:48:48 +03:00
Alexandre Poirot cffaacada5 Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Differential Revision: https://phabricator.services.mozilla.com/D6162

--HG--
extra : moz-landing-system : lando
2018-09-21 08:08:24 +00:00
Alexandre Poirot c023333832 Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.

Depends On D4078

Differential Revision: https://phabricator.services.mozilla.com/D6161

--HG--
extra : moz-landing-system : lando
2018-09-21 08:08:11 +00:00
Alexandre Poirot 196d295b46 Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D4078

--HG--
extra : moz-landing-system : lando
2018-09-21 08:07:48 +00:00
shindli 51a3c01ced Backed out 9 changesets (bug 1485676) for failures in browser/tools/mozscreenshots/devtools/browser_devtools.js CLOSED TREE
Backed out changeset d358feec4ca1 (bug 1485676)
Backed out changeset ed554dbb062f (bug 1485676)
Backed out changeset 6e78058df94d (bug 1485676)
Backed out changeset 3a6f1b0e71f4 (bug 1485676)
Backed out changeset 16d2403aa787 (bug 1485676)
Backed out changeset 454eddf52157 (bug 1485676)
Backed out changeset 926f725f2183 (bug 1485676)
Backed out changeset fb03f174bd5f (bug 1485676)
Backed out changeset ceb93dd1799a (bug 1485676)
2018-09-24 15:27:27 +03:00
Alexandre Poirot d2897f66aa Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-24 01:25:03 -07:00
Alexandre Poirot 796f22b354 Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
Summary:
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.

Depends On D4078

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6161

MozReview-Commit-ID: KmFi1LIUBga
2018-09-24 01:25:02 -07:00
Alexandre Poirot 631e7bfdf9 Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-24 01:25:01 -07:00
Daisuke Akatsuka b3891b0f8f Bug 1490583: Remove actor related code that no longer used. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D5842

--HG--
extra : moz-landing-system : lando
2018-09-19 02:03:49 +00:00
Noemi Erli 63025fbf18 Backed out changeset 44c69e043cf7 (bug 1490583) for failures in browser_animation_reconstructState.js 2018-09-18 21:44:19 +03:00
Daisuke Akatsuka 55701049ee Bug 1490583: Remove actor related code that no longer used. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D5842

--HG--
extra : moz-landing-system : lando
2018-09-18 12:41:53 +00:00
Bobby Holley eac505cdf4 Bug 1491488 - Mimic the old behavior in devtools test. r=ochameau
MozReview-Commit-ID: 28cQgvxxl0E
2018-09-17 09:24:58 -07:00
Belen Albeza 0bb5316f21 Bug 1488769 - Slotted nodes not being displayed in Shadow DOM tree if the node is a text. r=jdescottes
r=jdescottes

Differential Revision: https://phabricator.services.mozilla.com/D5538

--HG--
extra : moz-landing-system : lando
2018-09-11 15:47:09 +00:00
Julian Descottes 7be03c4f9e Bug 1486703 - Display correct hostOnly values in storage inspector;r=miker
Differential Revision: https://phabricator.services.mozilla.com/D4712

--HG--
extra : moz-landing-system : lando
2018-09-07 10:41:42 +00:00
Tom Schuster 5043294758 Bug 1440468 - Fix devtools test for new Function.prototype.toString behavior. r=yulia
--HG--
extra : rebase_source : cf924cd850c094d782aefc3037a648082f709695
extra : histedit_source : 0055b621cbfbb943eb6229a6ad3800b3deaa99d5
2018-09-03 23:47:56 +02:00
Belén Albeza 2d4733b9f8 Bug 1449955 - Server-side test for walker + shadow DOM r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D4675

--HG--
extra : moz-landing-system : lando
2018-09-01 08:31:35 +00:00
Coroiu Cristina 09d55a3423 Backed out 2 changesets (bug 923975) for devtools failures at devtools/client/debugger/new/test/mochitest/browser_dbg_rr_stepping-04.js on a CLOSED TREE
Backed out changeset e1ac0b6c2ca0 (bug 923975)
Backed out changeset 9f50e3dd7b14 (bug 923975)
2018-10-03 02:38:29 +03:00
Jason Laster d4c53d0048 Revert "Backed out changeset c209b1927107 (bug 923975) for failing at mochitest/browser_dbg_rr_stepping-02.js, etc. removed obsolete files. a=backout"
This reverts commit b7f018206386dab85fb82cbaaf24f15ad60eff14.
2018-10-02 16:40:32 -04:00
Jason Laster 5fad9a20a0 Revert "Backed out changeset 3599e95a53b7 (bug 923975) for build bustage when reverting backout on a CLOSED TREE"
This reverts commit e0e90b5c82d8f05feb9df1e5b675c0680b469524.
2018-10-02 16:40:32 -04:00
Coroiu Cristina 6906561bd6 Backed out changeset 3599e95a53b7 (bug 923975) for build bustage when reverting backout on a CLOSED TREE
--HG--
extra : amend_source : c51eb8caf5417ef49e59444f7f503808f1ac9bff
2018-10-02 22:16:26 +03:00
Jason Laster 58ebb5ae57 Revert "Backed out changeset c209b1927107 (bug 923975) for failing at mochitest/browser_dbg_rr_stepping-02.js, etc. a=backout"
This reverts commit 203706dd9c9fc63ee67e88274ea604ff9a1cd492.
2018-10-02 14:50:52 -04:00
Alexandre Poirot fb4cd85e35 Bug 1222047 - Manage device and preference fronts via client.mainRoot.getFront. r=yulia
Summary: Depends On D3317

Tags: #secure-revision

Bug #: 1222047

Differential Revision: https://phabricator.services.mozilla.com/D3318

MozReview-Commit-ID: 3jaFZbXVLuw
2018-08-23 03:51:40 -07:00
Micah Tigley c449642b76 Bug 1473030 - Show accessible object's name and role information with the info-bar highlighter. r=gl,yzen
MozReview-Commit-ID: HyKIdqsL3u

--HG--
extra : rebase_source : 27d1e59e796debcff010c19d3621c8610ea6b338
2018-08-16 00:35:02 -04:00
Alexandre Poirot e2f52bc542 Bug 1478945 - Test global actors against xpcshell debugger server. r=jdescottes
MozReview-Commit-ID: DqCkWqZJErQ

--HG--
extra : rebase_source : 535f138d2faf4cee76e44f5617d6459d9d8f0705
2018-07-31 10:08:51 -07:00
Alexandre Poirot 3a7f519e53 Bug 1478945 - Refactor test_xpcshell_debugging.js to use async/await instead of callbacks. r=jdescottes
MozReview-Commit-ID: 3QmGlX70BVz

--HG--
extra : rebase_source : bd1fd6ab4455707aadd51738d8e7bb43ff8d7b47
2018-07-31 08:46:07 -07:00
Julian Descottes 9efd634745 Bug 1478261 - Enable browser_perf-allocation-data.js in e10s;r=ochameau
MozReview-Commit-ID: v6UZoSx2tY

--HG--
extra : rebase_source : f58c98db64224fdad11fbac7e54e476edff1581e
2018-07-25 12:16:06 +02:00
Alexandre Poirot 835840ac99 Bug 1477988 - Implements DebuggerServer.spawnActorInParentProcess. r=jryans
This new API allows to instanciate an actor in the parent process from actors running in the parent process.
The created actors are returned to the client from the actors running in content,
but after that, the client communicates directly with the created actors running in the parent process.

MozReview-Commit-ID: 5B3wRQ94UEx

--HG--
extra : rebase_source : 808ea31fe8a467d0185fc27056c6524873cddbce
2018-07-16 09:53:28 -07:00
Alexandre Poirot 6e79972fbe Bug 1478260 - Enable server/tests/browser/browser_navigateEvents.js in e10s. r=jdescottes
MozReview-Commit-ID: 4aFvbOnfrgX

--HG--
extra : rebase_source : 90e3e5b966652c54cb21fc8fef3c23466f5d4c65
2018-07-24 23:56:18 -07:00
Andreea Pavel 8a01d542af Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-07-25 18:10:55 +03:00
Julian Descottes 869c52dfc2 Bug 1478254 - Enable browser_animation_updatedState.js;r=pbro
MozReview-Commit-ID: LoEGC4M7liJ

--HG--
extra : rebase_source : cc7484ba78cee49f269f6f83f66a862a8e75e998
2018-07-25 12:12:22 +02:00
Boris Zbarsky 0e54dc6661 Bug 1476145 part 4. Stop using getInterface(nsIDOMWindowUtils) in devtools. r=bgrins 2018-07-24 19:47:41 -04:00
Alexandre Poirot 09d08ff845 Bug 1474980 - Remove deprecated DebuggerServer.addActors(). r=jryans
MozReview-Commit-ID: 8J1wucp1G0p

--HG--
extra : rebase_source : 4a40b578808667ac45519172686e4237bb61423a
2018-07-11 10:41:27 -07:00
yulia 2dde60b42d Bug 1473569 - fix faulty errors in formatCommand; r=nchevobbe
MozReview-Commit-ID: 9PeQySBxWyx

--HG--
extra : rebase_source : 09ea09170531c0f7fa14e37ecb1e9dd2423ca4b3
2018-07-06 18:03:50 +02:00
Alexandre Poirot aece1534ef Bug 1473578 - Remove deprecated synchronous DebuggerServer.registerModule feature. r=jryans
MozReview-Commit-ID: DTAEJyfICNz

--HG--
extra : rebase_source : 043241ac68dd00f24236e9583dc262bce4d208b7
2018-07-05 07:13:52 -07:00
Mark Banner 96cd033dd3 Bug 1452706 - Fix the expected arguments to be RegExps in test_format_command.js. r=yulia
MozReview-Commit-ID: 24DtFcF9o2F

--HG--
extra : rebase_source : 51fcfacfa538a62a9dd0e3ddd09e3c35b341699e
2018-07-05 14:36:54 +01:00
yulia 47b52c6bb7 Bug 1464461 - implement unix style syntax for console commands; r=nchevobbe,ochameau
MozReview-Commit-ID: 8rQ9IQdsZkm

--HG--
extra : rebase_source : 8f5c302b5eff7d20daf581c7dd904ddcfd30efdd
2018-06-05 17:27:07 +02:00
Cosmin Sabou e092bc3111 Backed out 4 changesets (bug 1464461) for Talos damp failures on webconsole/objectexpand.js. CLOSED TREE
Backed out changeset 001370fe21e3 (bug 1464461)
Backed out changeset 014fa1322e94 (bug 1464461)
Backed out changeset 50f7f633bb7d (bug 1464461)
Backed out changeset 6c9488ed5ebd (bug 1464461)
2018-07-03 15:28:03 +03:00
yulia 2a8a3c6748 Bug 1464461 - implement unix style syntax for console commands; r=nchevobbe,ochameau
MozReview-Commit-ID: 8rQ9IQdsZkm

--HG--
extra : rebase_source : 6a5c17686e0619adbc0499564da2925e84368f8f
2018-06-05 17:27:07 +02:00
Benjamin Bouvier 1c9f5a8af9 Bug 1447591: Stub out a few Debugger APIs for wasm; r=yury
--HG--
extra : rebase_source : b8c8b2afeac3a3bdefa8f412354579f601a3af86
2018-06-20 17:56:19 +02:00
Coroiu Cristina e555bb0ae4 Backed out 2 changesets (bug 1447591) for mochitest failures at dom/base/test/test_postMessages.html
Backed out changeset 0800fdb509d2 (bug 1447591)
Backed out changeset 9b5347dee1f2 (bug 1447591)
2018-06-27 13:09:31 +03:00
Benjamin Bouvier 21b1a66af6 Bug 1447591: Stub out a few Debugger APIs for wasm; r=yury
--HG--
extra : rebase_source : 22a489d5a3d917f18087fba5342207fcb8d59f02
extra : histedit_source : a23c5f7d75cf8b8ffd6d01a3d00536f75d1591d8
2018-06-20 17:56:19 +02:00
Julian Descottes be3f1a69c1 Bug 1078374 - Show content of template tags in markup view;r=bgrins
MozReview-Commit-ID: pbctIItlC9

--HG--
extra : rebase_source : af386c52748c55d518445c0175ac129c101a63da
2018-06-08 18:17:15 +02:00
J. Ryan Stinnett ca90a5ef7b Bug 1465637 - Rename tab-scoped actors to target-scoped actors. r=ochameau
The term "tab actor" was used ambiguously to mean either the "target actor
representing a tab" or "a child actor of the tab target actor" (such as the
console actor).  Here we rename the second case to "target-scoped actor".

Differential Revision: https://phabricator.services.mozilla.com/D1760

--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_tabactor-01.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_tabactor-02.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-02.js
2018-06-26 13:27:57 +00:00
arthur.iakab ff23802cfd Backed out changeset 88960670cf9f (bug 1465637) for failing talos damp tests on server/protocol.js: Error: Can't manage front without an actor ID on a CLOSED TREE
--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-01.js => devtools/client/debugger/test/mochitest/browser_dbg_tabactor-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-02.js => devtools/client/debugger/test/mochitest/browser_dbg_tabactor-02.js
2018-06-25 21:56:27 +03:00
J. Ryan Stinnett 8433b7ff9f Bug 1465637 - Rename tab-scoped actors to target-scoped actors. r=ochameau
The term "tab actor" was used ambiguously to mean either the "target actor
representing a tab" or "a child actor of the tab target actor" (such as the
console actor).  Here we rename the second case to "target-scoped actor".

Differential Revision: https://phabricator.services.mozilla.com/D1760

--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_tabactor-01.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_tabactor-02.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-02.js
2018-06-25 17:53:40 +00:00
Noemi Erli a8bf2cbb53 Backed out 2 changesets (bug 1473996) for failures in devtools/server/tests/unit/test_objectgrips-fn-apply.js on a CLOSED TREE
Backed out changeset dc601e6050f6 (bug 1473996)
Backed out changeset 9ba8a6f1857d (bug 1473996)
2018-07-18 09:33:40 +03:00
Logan F Smyth 0de56634e3 Bug 1473996 - Expose fn.apply in the devtools server. r=nchevobbe
MozReview-Commit-ID: 33Uh8UIuz4g

--HG--
extra : rebase_source : 3811894117519577c048a28b5ca5e009ea707391
2018-07-12 11:09:54 -07:00
Logan F Smyth a0c46ee4c0 Bug 1473996 - Expose getPropertyValue in devtools server to fully evaluate an object property. r=nchevobbe
MozReview-Commit-ID: IYIplkrqQ76

--HG--
extra : rebase_source : 0f35c1ded9923b8a7b35a8af924a3b1cbf53fab9
2018-07-12 11:08:38 -07:00
Dorel Luca e06ba10d0b Merge mozilla-inbound to mozilla-central. a=merge 2018-06-20 00:54:45 +03:00
Yura Zenevich e8835cfdd7 Bug 1467643 - remove 'help' accessibility property from accessibility inspector. r=pbro
MozReview-Commit-ID: LtmD38VC8sN
2018-06-19 10:17:19 -04:00
Yura Zenevich 921285fe26 Bug 1467381 - check Accessible::AccessKey and Accessible::KeyboardShortcut when filling up keyboardShortcut for accessible actor. r=pbro
MozReview-Commit-ID: IkqfyL5cGGh
2018-06-19 09:52:07 -04:00
Mark Banner 5665b1e1bf Bug 1230193 - Finish enabling ESLint rule no-undef for devtools/. r=jdescottes
MozReview-Commit-ID: EVFivqFNy8a

--HG--
extra : rebase_source : b9591567dfdbe8f9d7d959c4ee2d0e5c7f43ea09
2018-06-14 21:36:26 +01:00
Narcis Beleuzu 8aa6325a89 Merge inbound to mozilla-central. a=merge 2018-06-14 00:52:57 +03:00
Joel Maher 1ef32bf5c6 Bug 1405428 - skip-if = verify on xpcshell tests which do not pass test-verify. r=gbrown 2018-06-13 11:34:40 -04:00
Alexandre Poirot f68f33087a Bug 1466691 - Replace callback style in favor of promise for TabClient methods. r=jryans
MozReview-Commit-ID: 6Is4O8KQhgY

--HG--
extra : rebase_source : 8987e85385bd202a8e9100a230eff1c1fcdcb4f9
2018-06-05 01:50:40 -07:00
Alexandre Poirot f9d8e10a27 Bug 1466691 - Replace callback style in favor of promise for SourceClient methods. r=jryans
MozReview-Commit-ID: F78igLUlqn6

--HG--
extra : rebase_source : 193383f22b3d6ac55df69948619ba2a9115e7235
2018-06-05 01:09:43 -07:00
Joel Maher 50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Julian Descottes c6138c2f7e Bug 1467407 - Fix incorrect usage of ok() in server animation test;r=daisuke
MozReview-Commit-ID: 5N1VtTYbZtL

--HG--
extra : rebase_source : 4c04af9fc0c19c0b827ee2ec85743bec1b149568
2018-06-07 12:00:32 +02:00
J. Ryan Stinnett be021da252 Bug 1172897 - Rename BrowserAddonActor to AddonTargetActor. r=ochameau
MozReview-Commit-ID: 4iI6BQaleJS

--HG--
rename : devtools/server/actors/addon.js => devtools/server/actors/targets/addon.js
extra : rebase_source : f48676bdda8b68226a00cb29c164180526389c4a
2018-06-04 18:37:02 -05:00
J. Ryan Stinnett 3133003d18 Bug 1172897 - Move DevTools addon modules to subdir. r=ochameau
MozReview-Commit-ID: D61WJnoYQe3

--HG--
rename : devtools/server/actors/addons.js => devtools/server/actors/addon/addons.js
rename : devtools/server/actors/addon-console.js => devtools/server/actors/addon/console.js
rename : devtools/server/actors/webextension-inspected-window.js => devtools/server/actors/addon/webextension-inspected-window.js
rename : devtools/server/actors/webextension-parent.js => devtools/server/actors/addon/webextension-parent.js
rename : devtools/server/actors/webextension.js => devtools/server/actors/addon/webextension.js
rename : devtools/shared/fronts/addons.js => devtools/shared/fronts/addon/addons.js
rename : devtools/shared/fronts/webextension-inspected-window.js => devtools/shared/fronts/addon/webextension-inspected-window.js
rename : devtools/shared/specs/addons.js => devtools/shared/specs/addon/addons.js
rename : devtools/shared/specs/webextension-inspected-window.js => devtools/shared/specs/addon/webextension-inspected-window.js
rename : devtools/shared/specs/webextension-parent.js => devtools/shared/specs/addon/webextension-parent.js
extra : rebase_source : 7a9038e96f51695f92c3a676aeeaab02fd8ca10a
2018-06-04 18:12:11 -05:00
J. Ryan Stinnett 2d8cc5a3cb Bug 1172897 - Rename ChildProcessActor to ContentProcessTargetActor. r=ochameau
MozReview-Commit-ID: 60kELwh0N3f

--HG--
rename : devtools/server/actors/child-process.js => devtools/server/actors/targets/content-process.js
extra : rebase_source : 87af1aebbeeaf5a0649566a1f7cca37f88a7d5fe
2018-06-04 17:30:06 -05:00
J. Ryan Stinnett 70dc511eef Bug 1172897 - Rename ChromeActor to ParentProcessTargetActor. r=ochameau
MozReview-Commit-ID: JM17h5ArYub

--HG--
rename : devtools/server/actors/chrome.js => devtools/server/actors/targets/parent-process.js
extra : rebase_source : 2eae9440b9fac9ae1b42e910ac6cc5abf14105de
2018-06-01 17:31:48 -05:00
J. Ryan Stinnett 420ead8490 Bug 1172897 - Rename BrowserTabActor to FrameTargetActorProxy. r=ochameau
MozReview-Commit-ID: 4Lho3CLV1t8

--HG--
rename : devtools/server/actors/browser-tab.js => devtools/server/actors/targets/frame-proxy.js
extra : rebase_source : e8d4db9cc6dbd4e301cc4bc39568027a94f16c53
2018-05-31 16:43:18 -05:00
J. Ryan Stinnett ff819eb8ce Bug 1172897 - Remove deprecated eager actor construction path. r=ochameau
MozReview-Commit-ID: ALnbhoh0Nzj

--HG--
rename : devtools/server/tests/unit/registertestactors-03.js => devtools/server/tests/unit/registertestactors-lazy.js
extra : rebase_source : 9d998569e3ffb5ccdd74c3b01a8981c3f68ea656
2018-05-30 19:19:11 -05:00
J. Ryan Stinnett eaa4969e77 Bug 1172897 - Rename TabActor to BrowsingContextTargetActor. r=ochameau
MozReview-Commit-ID: LPTEx2h4F1o

--HG--
rename : devtools/server/actors/tab.js => devtools/server/actors/targets/browsing-context.js
rename : devtools/shared/specs/tab.js => devtools/shared/specs/targets/browsing-context.js
extra : rebase_source : e62720693ad492cdfb68ab21af1f54d78e85123a
2018-05-25 18:20:28 -05:00
Julian Descottes 7fdc2c153f Bug 1454696 - Fix leftover issues for prefer-const;r=yulia
MozReview-Commit-ID: JwOXoqw2mks

--HG--
extra : rebase_source : a3f07665a42c2779a85b7901a07206266a9d1616
extra : source : ae946f375e0d0f4f0f0fc859c54040fef42cbc2c
2018-06-01 12:19:35 +02:00
Julian Descottes 640fe52298 Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4

--HG--
extra : rebase_source : 65de1b0aba412d9044b5196115f74276caa058f2
2018-06-01 12:36:09 +02:00
Emilio Cobos Álvarez aa934dea20 Bug 1465107: Remove isStyledByServo. r=xidorn
MozReview-Commit-ID: 8HWBH9kWyxV
2018-05-30 10:04:18 +02:00
Boris Zbarsky fef0aa2027 Bug 1455676 part 17. Stop using nsIDOMNode in devtools/. r=jdescottes 2018-05-29 22:58:50 -04:00