Part 2 exposed an edge case that would allow the user to have TP enabled but
still have tracking content on a page, bringing our UI into a confused state.
This adds a new element that shows when TP is enabled and no exception is set,
but tracking content is still loaded, and recommends reloading the page.
MozReview-Commit-ID: EYy6xVCjNts
--HG--
extra : rebase_source : 616fe197e8c994448c4eb5f9dfeafd260c2ce084
This commit changes the tracking protection UI to always be present in the
identity popup (control center) UI. Following the UI spec in
https://mozilla.invisionapp.com/share/RSIY1B8GMC2#/screens/297824891,
we are now warning about trackers even when TP is disabled and alter the
button that shows up in this case to open the TP settings in about:preferences.
MozReview-Commit-ID: 6g8rzWVRaua
--HG--
extra : rebase_source : 328ea44b085626cc0266591cc87b17657af888ad
This replaces some old Chromium code that tries to minimally disentangle
an arbitrary file descriptor mapping with simpler algorithm, for several
reasons:
1. Do something appropriate when a file descriptor is mapped to the same
fd number in the child; currently they're ignored, which means they'll
be closed if they were close-on-exec. This implementation duplicates
the fd twice in that case, which seems to be uncommon in practice; this
isn't maximally efficient but avoids special-case code.
2. Make this more generally applicable; the previous design is
specialized for arbitrary code running between fork and exec, but we
also want to use this on OS X with posix_spawn, which exposes a very
limited set of operations.
3. Avoid the use of C++ standard library iterators in async signal safe
code; the Chromium developers mention that this is a potential problem in
some debugging implementations that take locks.
4. In general the algorithm is simpler and should be more "obviously
correct"; more concretely, it should get complete coverage just by being
run normally in a debug build.
As a convenient side benefit, CloseSuperfluousFds now takes an arbitrary
predicate for which fds to leave open, which means it can be used in
other code that needs it without creating a fake fd mapping.
MozReview-Commit-ID: EoiRttrbrKL
--HG--
extra : rebase_source : 336e0ba9f56dc80f7347dc62617b4ad1efea7e7e
This directory has a number of places where files unintentionally depend
on `#include`s and `using` directives and forward declarations in other
files in the same unified build group. Adding a file shifts the group
boundaries and exposes some of those bugs; this patch fixes them (but
there are others).
MozReview-Commit-ID: AqAOdnXniTn
--HG--
extra : rebase_source : ed6030785d9cc5cc0ea1a46707725472de1c0fa9
Calling Cu.importGlobalProperties immediately defines the import
properties and any prototypes that they require. Aside from CPU
overhead, this also tends to consume a lot of memory, especially
for objects with complex prototypes. And it does this once for
every global you call it in. This is especially a problem for
content processes, since we get this memory overhead in each and
every content process.
This patch moves Marionette to use the new
XPCOMUtils.defineLazyGlobalGetters so that symbols are constructed
only when actually needed.
MozReview-Commit-ID: 3RYWTcdO7FM
--HG--
extra : rebase_source : 0c450c8900e5de5446796b34ae4ab6bdf0fe9118
- Fix the implementation to return a numerically correct result
- Change call sites that should have instead been using
CalculateCompositedSizeInCssPixels(), to do so
- Rename and document to emphasize that the returned rect is in the
CSS pixels of the content surrounding the scroll frame
MozReview-Commit-ID: GCPbA1k88rz
--HG--
extra : rebase_source : f5b937936fb84b3ae414d6cf0250add4078a9d53
Automatic update from web-platform-tests[css-contain] Disable size containment for certain elements
Text from the spec
(https://drafts.csswg.org/css-contain/#containment-size):
"... if the element is an internal table element, or if the element
is an internal ruby element, or if the element’s principal box
is a non-atomic inline-level box, size containment has no effect."
The patch disables "contain: size" for internal table elements,
internal ruby elements and non-atomic inline-level boxes.
BUG=843329
TEST=external/wpt/css/css-contain/contain-size-005.html
TEST=external/wpt/css/css-contain/contain-size-006.html
TEST=external/wpt/css/css-contain/contain-size-007.html
TEST=external/wpt/css/css-contain/contain-size-008.html
TEST=external/wpt/css/css-contain/contain-size-009.html
TEST=external/wpt/css/css-contain/contain-size-010.html
TEST=external/wpt/css/css-contain/contain-size-011.html
TEST=external/wpt/css/css-contain/contain-size-012.html
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie3264b5c76eb04ec97064b3da8706d840924597f
Reviewed-on: https://chromium-review.googlesource.com/1080799
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#563586}
--
wpt-commits: e2fe8bbd62a081282326d64dc2e80035799bc9fa
wpt-pr: 11284
Automatic update from web-platform-testsCheck if a type is a sequence through idlType.generic
idlType.sequence was removed in https://github.com/w3c/webidl2.js/pull/175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it.
--
wpt-commits: b1a1415cdf23bb3dc5c2f2ccb58a7abe87b93961
wpt-pr: 11286
Automatic update from web-platform-testsAdd Priority Hints support to link and img elements
This adds Priority Hints support to link and img elements under a
runtime-enabled flag. The support for link elements do not extend
<link rel=modulepreload>s due to the nature of module script fetching.
Support for this as well as script elements in general will come at a
later time due to the significant changes to the module script loading
infrastructure.
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/65lfM2f0eeMR=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws
Bug: 821464
Change-Id: I5ab0a114ee2b2fce9f0df6c4c5e1f7a487980d0a
Reviewed-on: https://chromium-review.googlesource.com/1067245
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563550}
--
wpt-commits: 5aa06e74524c68cf1135dd918699f527449b25c2
wpt-pr: 11263
Automatic update from web-platform-tests[web-animations] Fix timeout/0 tests in unsupporting browsers
Part of #11269.
--
wpt-commits: ee6c9d315b05a2afe40a13cbf26d3126d52c34a0
wpt-pr: 11276
Automatic update from web-platform-testsAvoid uncaught exception in iframe if WebNFC is not supported (#11271)
Part of #11269.
--
wpt-commits: dcdd59c1c0902c1a3fa79ab4ead6321f26ddc4bd
wpt-pr: 11271