The proper fix is to fix the underlying problem. However, I haven't
touched C++ in months and I'm lazy. So I'm going for the quick fix
so Visual Studio 2015 rollout is unblocked.
MozReview-Commit-ID: 14cZCGPkx0V
--HG--
extra : rebase_source : 91ec0d461e4e14e1fa3b641b3ca7f169e0901b11
extra : source : 9e5f9917fe1a7bef9585966959d516636d7ee6ac
- Fixes a crash caused when shutting down the Oculus SDK objects
in a different thread than the one that was used to
initialize them.
MozReview-Commit-ID: DbB2pXVoqxL
--HG--
extra : rebase_source : 1447c4d9fd7f29bc14b8f91c6f5cd10dc1ec1f8b
- ContainerLayerComposite::ContainerRenderVR failed to find
a CanvasLayerComposite and get an inputFrameId as it was
only looking at immediate children layers.
- Initialize Oculus SDK structures with 0 to ensure code is less
brittle when Oculus SDK is updated in the future.
- Added assert and sanity check to ensure that valid inputFrameID's
are used when indexing the Oculus pose buffers.
MozReview-Commit-ID: 136lf8aMWms
--HG--
extra : rebase_source : 14ae32704e6ccd9c6823467a7cb073290cbd5a09
- Generate and pass sequential frame indexes into the ovr_GetTrackingState call and the corresponding call to ovr_SubmitFrame
MozReview-Commit-ID: 5tJl5YJt7Eo
--HG--
extra : rebase_source : 5dbb35ea1451a9f378e28d81a8704b63b1b72b4d
- Removed an unnecessary assertion that was erroneously triggering
on shutdown in B2G Mochitests.
--HG--
extra : rebase_source : 1b0d997bf7610fa62d2647f5003edc47d61e3fa6
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
These are all conditional uses of ALLOW_COMPILER_WARNINGS=True that are no
longer necessary.
--HG--
extra : rebase_source : e654fa940aed18b1d5ef7b2bebb45bbef59cfd84
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
David Anderson
Jonathan Watt
Georgiy Frolov
Bill McCloskey
Chris Peterson
Kyle Huey
Carsten "Tomcat" Book
kearwood
Gregory Szorc
Kearwood (Kip) Gilbert
Jonathan Kew
Nicholas Nethercote
Birunthan Mohanathas
Daosheng Mu
Nathan Froyd
William Chen
Vladimir Vukicevic
Bobby Holley
David Major