718ce69fb7
Backed out changeset c8e5a0703821 (bug 1283395) for bustage on a CLOSED TREE
2016-07-21 08:13:06 +02:00
d2d46ad585
Bug 1283395 - add markup functions for static analysis builds. r=froydnj
...
MozReview-Commit-ID: 1F5GGpQtq4x
2016-07-20 15:45:34 +03:00
e20f0f4551
Bug 1282795 - Silence warnings when MOZ_ALWAYS_{TRUE,FALSE} are passed expressions with embedded side effects, that would ordinarily trigger side effects but don't inside certain unevaluated contexts within MOZ_ASSERT, which then triggers compiler warnings with new-enough clang. You are not expected to understand this. r=froydnj
...
--HG--
extra : rebase_source : ffe6d35af74c50b04dbddc9cc3965292875c64a0
2016-06-28 17:12:14 +01:00
2511b2c327
Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
...
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.
MozReview-Commit-ID: 1VS4Dney4WX
--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
c47a83ce36
Bug 1251769 - Remove remaining references to MOZILLA_XPCOMRT_API from mfbt. r=froydnj
2016-02-27 11:12:07 -08:00
3171200ff5
Bug 1235277 - Define MOZ_FALLTHROUGH_ASSERT to workaround -Wunreachable-code warnings about MOZ_FALLTHROUGH in debug builds. r=botond
2015-12-27 13:27:17 -07:00
47b5adaa34
Bug 1221368 - Change MakeTuple to decay the types of its arguments (r=froydnj)
2015-11-09 10:21:11 -08:00
a764ebee57
Bug 1211979 - Annotate crashes triggered by MOZ_RELEASE_ASSERT, r=froydnj
2015-10-08 17:50:58 -04:00
e4681ea6a5
Bug 1183355 - Annotate crash reports triggered by MOZ_CRASH in release builds, r=froydnj
2015-10-08 10:01:08 -04:00
66779b6bb0
Backout "Bug 1183355 - Annotate crash reports triggered by MOZ_CRASH in release builds, r=froydnj" for OOM concerns
...
This reverts commit 5ca16aeadfea27afc9939e39d8a6f0a39802c066.
2015-09-24 17:58:34 -04:00
3103a27863
Bug 1183355 - Annotate crash reports triggered by MOZ_CRASH in release builds, r=froydnj
2015-09-24 17:12:44 -04:00
5446225d17
Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
...
This leaves alone the AppendElement methods.
2015-09-15 15:30:44 -07:00
c236b48231
Bug 1093934 - Create a XPCOM library that can be used to support standalone WebRTC. r=nfroyd
...
--HG--
extra : rebase_source : 93f11457b16b344e148a6fcb924b286ef8a48051
2015-04-03 15:52:00 +02:00
e226c762ee
Backed out changeset 0f5799df920b (bug 1093934) for various test failures CLOSED TREE
...
--HG--
extra : amend_source : 047ed43008cea68775c544cdf0df2819cfb24589
2015-04-02 13:42:34 -07:00
683155c363
Bug 1093934 - Create a XPCOM library that can be used to support standalone WebRTC r=froydnj
2015-04-02 12:12:37 -07:00
2b846790d1
Back out Bug 1127201 (part 1) for various problems.
2015-02-06 15:05:08 -08:00
5def42d488
Bug 1127201 (part 1) - Let MOZ_ASSERT take a string variable as the second arg. r=Waldo.
...
ASSERT_UNLESS_FUZZING() (which is defined multiple times!) caused problems due
when __VA_ARGS__ was empty which is most of the time. So I just disallowed the
optional string, which was only used in a small fraction of the occurrences.
I don't particularly like this patch. I'm not convinced its any better than
just removing the nsPrintfCString()s like I did earlier, but I've done it to at
least show what's involved.
--HG--
extra : rebase_source : 10b5bcf8509eaf2fca300b0b8ab1fa130e9f8b8c
2015-02-04 19:42:29 -08:00
ebc54d52b9
Bug 1129247 - Introduce MOZ_DIAGNOSTIC_ASSERT. r=Waldo
2015-02-04 13:13:58 -08:00
f233dc0d72
Bug 1125185 - Define MOZ_COLD for marking "cold" functions r=waldo
2015-01-26 17:30:19 -08:00
8fb96ecee4
Bug 1004028 - Enable assertion type validation on MSVC. r=Waldo,terrence
2015-01-24 14:40:27 +01:00
5b86ecf80c
bug 1077549 - remove useless gcc version checks r=glandium
2015-01-15 21:30:05 -05:00
497a2e8e51
Bug 1120622 - Define MOZ_SUPPORT_ASSERT_CONDITION_TYPE_VALIDATION for all gcc versions now that we don't support 4.4 any more; r=froydnj
2015-01-14 09:00:34 -05:00
1228155e06
Backout 73fcb9fa303d
2015-01-12 14:46:01 -08:00
e35cd65485
Bug 1120622 - Define MOZ_SUPPORT_ASSERT_CONDITION_TYPE_VALIDATION for all gcc versions now that we don't support 4.4 any more; r=froydnj
2015-01-12 16:35:09 -05:00
2c2568cc6c
Bug 1119030: Make MOZ_CRASHes unique to prevent compiler folding. r=Waldo
...
--HG--
extra : rebase_source : f8401e3eee6c62545553452e355c8213480a869d
2015-01-08 19:13:04 +13:00
a9b69a841b
Bug 990764 - Remove MOZ_ASSUME_UNREACHABLE and MOZ_NIGHTLY_ASSERT macros. r=Waldo
2014-06-29 19:21:50 -07:00
2e6b85e6f1
Bug 1064451 - Convert assertion-expression-type checking code to not perform a function call. r=froydnj
...
--HG--
extra : rebase_source : d88adf94137dca875444c4aa8c7b3e9ce9c7dedd
2014-09-07 01:04:09 -07:00
2a0942be41
Bug 1036789 - Convert the third quarter of MFBT to Gecko style. r=Ms2ger.
...
--HG--
extra : rebase_source : 668cd394806203ddfa34bd4f226335ff26c846b5
2014-07-10 19:10:17 -07:00
9439ff268e
Bug 1026319 - Convert the second quarter of MFBT to Gecko style. r=froydnj.
...
--HG--
extra : rebase_source : 98d2557c7fe4648d79143c654e7e31767fca2e65
2014-06-12 23:34:08 -07:00
7e98d1c248
Bug 1014377 - Convert the first quarter of MFBT to Gecko style. r=froydnj.
...
--HG--
extra : rebase_source : b3b2da775e2c0e8a6ecbed70e7bd0c8f7af67b47
2014-05-29 22:40:33 -07:00
a611a1764f
Bug 990764 - Add MOZ_ASSERT_UNREACHABLE and MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE. r=Waldo
2014-04-05 18:07:09 -07:00
6e74be8757
Bug 997145 - Add a attribute in order to silent a Clang static analyzer check r=nfroyd
...
--HG--
extra : amend_source : 9ef01d8df4e8797981f770621a3885d456db5801
2014-05-06 16:23:08 +02:00
88fbe13b7d
Bug 1005730 - Print assertion stacks for MOZ_ASSERT and MOZ_CRASH for code that lives inside libxul; r=froydnj
...
The hyphenation changes are necessary because hnjalloc.h #defines FILE to
a custom data structure, which clashes with using |stderr| in Assertions.h.
2014-05-05 22:02:04 -04:00
cf6decae49
Bug 920292 - Check the types of assert conditions - r=froydnj
2014-04-30 22:39:13 -04:00
accb4d62ef
Bug 989460 - Part 1: Add MacroArgs.h for macros related to implementing variadic macros. r=Waldo
...
This also converts MOZ_RELEASE_ASSERT and MOZ_BEGIN_NESTED_ENUM_CLASS to use the new helper macros.
2014-04-24 10:48:00 +02:00
75c5db5a1c
Bug 928636 - Whitespace changes. r=Waldo
2013-11-25 09:37:16 -08:00
8475a010d7
Bug 928636 - Implement MOZ_RELEASE_ASSERT. r=Waldo
2013-11-25 09:37:15 -08:00
eb2da8cf2e
Bug 888658 - Assertions.h fixup for windows. r=jwalden
...
--HG--
extra : rebase_source : 7e7fb741860c2603aa1b838eff7761ddcd50e867
2013-10-15 09:07:00 +02:00
d344af7264
Bug 895322 - Part 5: Stop #defining MOZ_STATIC_ASSERT in C++ code; r=Waldo
...
--HG--
extra : rebase_source : 463c9918228e3f46c909cc7cad45c9d2913b0152
2013-07-18 14:39:20 -04:00
51f391870b
Bug 896341 - Update include guards and modelines in MFBT; r=Waldo
2013-07-24 09:41:39 +02:00
3da6ed220e
Bug 820686 - Follow-up: s/MOZ_ASSUME_NOT_REACHED/MOZ_ASSUME_UNREACHABLE/. rs=waldo
...
I'd meant to do this, but I only got as far as the comment in mfbt. Oops!
--HG--
extra : rebase_source : 3cfe3ef1bf401eb7d9a10fcabcfb39008e9553a4
2013-06-28 19:20:12 -07:00
674bdae8dc
Bug 820686 - Rename MOZ_NOT_REACHED() and JS_NOT_REACHED() to MOZ_ASSUME_NOT_REACHED(). r=waldo
...
This includes a mechanical renaming of MOZ_NOT_REACHED to MOZ_ASSUME_NOT_REACHED in JS. Later patches in this queue clean up whitespace errors and so on.
2013-06-28 18:38:31 -07:00
051c5b560a
Bug 802686 - s/MOZ_NOT_REACHED/MOZ_CRASH/ in Gecko. r=(see below)
...
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else
This is a mechanical change made with sed. Later patches in this queue
clean up the whitespace errors and so on.
2013-06-28 18:38:30 -07:00
c144581d22
Bug 763070 - Give MOZ_CRASH() an optional string argument. r=waldo
2013-06-28 18:38:30 -07:00
4cef91ed01
Bug 822431 - Use MOZ_UNLIKELY in MOZ_ASSERT. r=waldo
2013-04-19 16:20:35 -07:00
f2bef86c4d
Bug 851237 - Mark the static-assert typedef with an unused attribute so it doesn't trigger compiler warnings. r=dholbert
...
--HG--
extra : rebase_source : 20ad6cd988f2cf5ddedfbb7dd99e368b96c2242a
2013-03-21 18:26:06 -07:00
e171e76319
Bug 833254 - Fix MFBT's gcc version checks. r=waldo
2013-01-21 19:42:15 -08:00
801c9b79ba
bug 822717 - remove checks for old gcc r=glandium
2012-12-18 13:22:28 -05:00
b2d449c615
Eliminate Assertions.h's dependency on Types.h, for a narrower interface and minimized dependencies. No bug, r=Ms2ger
...
--HG--
extra : rebase_source : b5c79dc444ef7277f2624ffe2407bca25a1054cd
2012-06-11 16:16:46 -07:00
31edbd7b3b
Bug 426163 - Make MOZ_CRASH() use TerminateProcess on Windows rather than exit so that destructors and atexit handlers aren't called. r=ted
...
--HG--
extra : rebase_source : 0e340516158d36931fd00824a6ff9e665a9f9354
2012-06-11 16:16:46 -07:00
5a59a93dac
Backout 1c5a8d617bff (bug 765990), 617cb36ead59, b3067d05a76a (bug 760995), 79f9a61a1e43 (bug 426163) for bustage
2012-06-21 10:00:36 +01:00
eb986aa0c7
Eliminate Assertions.h's dependency on Types.h, for a narrower interface and minimized dependencies. No bug, r=Ms2ger
...
--HG--
extra : rebase_source : 0d68ef6274ad697bf4ff49038ef19368174dad54
2012-06-11 16:16:46 -07:00
3a7ab6bdea
Bug 426163 - Make MOZ_CRASH() use TerminateProcess on Windows rather than exit so that destructors and atexit handlers aren't called. r=ted
...
--HG--
extra : rebase_source : 631b1707f06852f4c47acbfb9c7401b22507267b
2012-06-11 16:16:46 -07:00
51e0b3e2fb
Bug 761859 - Reinstate a __debugbreak() at the start of MOZ_CRASH() on Windows so that deliberate crashes on Windows appear as breakpoints, not invalid writes. r=bsmedberg
2012-06-18 12:01:57 -07:00
3b720a666b
Bug 763000 - Remove MOZ_Assert. r=Ms2ger, r=terrence, r=ted
2012-06-07 14:41:11 -07:00
af9bf2ebd1
Bug 761857 - Make MOZ_CRASH on Linux crash in such a way that an attached debugger will park on the line containing the assertion. r=ted
...
--HG--
extra : rebase_source : 0628998cb0e2eec047426375c971aac1a84ebed1
2012-06-05 16:49:19 -07:00
986ff95100
Style patrol to make everything conform to mfbt/STYLE. No bug, r=sparky
2012-06-03 20:36:43 -07:00
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
2be70a6cde
Bug 719776 - Part 2: Make MOZ_CRASH and MOZ_ASSERT expand inline. r=waldo
2012-04-12 02:03:07 +02:00
151c28ec53
Back out 4b82f26f8593:2fcf9cbedd48 (bug 743393, bug 719776) for bustage
2012-04-11 09:06:40 -07:00
034108c2de
Bug 719776 - Part 2: Inline MOZ_Assert and MOZ_Crash. r=waldo
2012-04-11 16:55:31 +02:00
dbb5992e2a
Bug 723114 - Need a macro that expands to __builtin_unreachable on release builds. r=jwalden.
2012-02-23 14:32:30 -05:00
87eee40a7e
Bug 728512 - Make MOZ_ASSERT(cond, reason) work correctly on MSVC by hacking around a compiler bug. r=glandium
...
--HG--
extra : rebase_source : f955359300e02b27f0efda63bbb1983d85a56a5a
2012-02-17 18:47:12 -08:00
229a4401e7
Bug 717540 - Remove MFBT dependency on JS_Assert, add MOZ_Assert, and use it for WTF assertions. r=waldo,r=khuey
2012-02-13 15:48:23 +01:00
78f3656b4b
Backout 8eef38643ceb (bug 717540) and 78941a969e20 (bug 725230) because of windows debug bustage
2012-02-13 16:35:13 +01:00
b5d2448f11
Bug 717540 - Remove MFBT dependency on JS_Assert, add MOZ_Assert, and use it for WTF assertions. r=waldo,r=khuey
2012-02-13 15:48:23 +01:00
1f1e0e3e33
Bug 716112 - Add an optional second argument to MOZ_ASSERT to allow explanations to accompany assertions, if desired. r=cjones
...
--HG--
extra : rebase_source : a6be7ef89c91a58df489057ca4ea67791b6881a0
2012-01-06 15:51:27 -06:00
eaa4a32656
Add introductory comments to the files in mfbt/ that aren't copied from elsewhere, to facilitate easier MXR directory skimming. No bug, r=lumpy
...
--HG--
extra : rebase_source : dd834c64e625a0184b64d13e2a2e6fd8960ca832
2011-12-28 10:48:54 -06:00
150afa32c7
Bug 713560 - Make MOZ_STATIC_ASSERT, when it expands to C++11 static_cast(), pass its reason argument along to static_cast in more compilers. r=typo-fix
2011-12-27 12:09:41 -06:00
a158abd5b6
Bug 712129 - Implement MOZ_STATIC_ASSERT and MOZ_STATIC_ASSERT_IF. r=luke
2011-12-19 16:58:30 -05:00
677b43a2b8
Bug 712129 - Add more assertion macro flavors to mfbt, and make the JS engine use mfbt's implementations where appropriate. r=cjones
...
--HG--
extra : rebase_source : 6b94db05e74b18a3938a28cbc0f520eb4e01fbb0
2011-12-19 15:54:12 -05:00
05dcc6d231
Bug 712129 - Move assertion code into a new mfbt/Assertions.h header. r=luke
...
--HG--
extra : rebase_source : 6587b6aa4180493c48b0663bc627543020a21deb
2011-12-19 14:28:35 -05:00
Carsten "Tomcat" Book
Andi-Bogdan Postelnicu
Jeff Walden
Nicholas Nethercote
Eric Rahm
Chris Peterson
Bill McCloskey
Michael Layzell
Andrew McCreight
Randall Barker
Wes Kocher
Andrew McCreight
Bobby Holley
Dan Gohman
Jan de Mooij
Trevor Saunders
Ehsan Akhgari
David Major
Sylvestre Ledru
Benoit Jacob
Birunthan Mohanathas
Vladimir Vukicevic
Ms2ger
Justin Lebar
Jeff Gilbert
Ed Morley
Gervase Markham
Bas Schouten
Phil Ringnalda
Rafael Ávila de Espíndola
Mike Hommey