Automatic update from web-platform-testsRe-plumb backdrop-filter through blink-gen-property-trees
With this CL, backdrop-filter will continue to work when the
--enable-blink-gen-property-trees flag is enabled. Behavior should be
identical to behavior without the flag.
Also, I added a number of layout/WPT tests for backdrop-filter,
some of which currently pass, and some of which need fixing. The ones
that need fixing have been added to TestExpectations. These new tests
should reproduce (at least) these issues:
- https://crbug.com/314867 - respecting isolation
- https://crbug.com/525099 - respecting isolation
- https://crbug.com/547937 - border radius
- https://crbug.com/524689 - filter plus backdrop-filter
- https://crbug.com/745012 - boundary effect problems
I also moved the existing tests out of external/wpt/css/css-filter
into external/wpt/css/filter-effects, where they really should be,
now that filter-effects is being pulled into the tree.
Bug: 497522,314867,525099,547937,524689,745012
Change-Id: I2be33fbc0e17dec2cd138f9796971fb4a9a57216
Reviewed-on: https://chromium-review.googlesource.com/c/1316661
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607447}
--
wpt-commits: e1bde44cb56120f187d326557a681f87b31b43af
wpt-pr: 14008
--HG--
rename : testing/web-platform/tests/css/css-filter/blur-clip-stacking-context-001.html => testing/web-platform/tests/css/filter-effects/blur-clip-stacking-context-001.html
rename : testing/web-platform/tests/css/css-filter/blur-clip-stacking-context-002.html => testing/web-platform/tests/css/filter-effects/blur-clip-stacking-context-002.html
rename : testing/web-platform/tests/css/css-filter/blur-clip-stacking-context-ref.html => testing/web-platform/tests/css/filter-effects/blur-clip-stacking-context-ref.html
rename : testing/web-platform/tests/css/css-filter/filtered-block-is-container-ref.html => testing/web-platform/tests/css/filter-effects/filtered-block-is-container-ref.html
rename : testing/web-platform/tests/css/css-filter/filtered-block-is-container.html => testing/web-platform/tests/css/filter-effects/filtered-block-is-container.html
rename : testing/web-platform/tests/css/css-filter/filtered-html-is-not-container-ref.html => testing/web-platform/tests/css/filter-effects/filtered-html-is-not-container-ref.html
rename : testing/web-platform/tests/css/css-filter/filtered-html-is-not-container.html => testing/web-platform/tests/css/filter-effects/filtered-html-is-not-container.html
rename : testing/web-platform/tests/css/css-filter/filtered-inline-is-container-ref.html => testing/web-platform/tests/css/filter-effects/filtered-inline-is-container-ref.html
rename : testing/web-platform/tests/css/css-filter/filtered-inline-is-container.html => testing/web-platform/tests/css/filter-effects/filtered-inline-is-container.html
Automatic update from web-platform-testsHTMLScriptElement text attributes modified to accept TrustedTypes
HTMLScriptElement::text() and setText() functions modified to accept
TrustedScript as an argument.
Added HTMLScriptElement::innerText and HTMLScriptElement:textContent
attributes to override existing implementations in HTMLElement
and Node, and to accept TrustedScript.
Changed HTMLElement::innerText and Node::textContent .idl definitions
and adjusted setters and getters to accept TrustedScript.
Bug: 739170
Change-Id: I63da5714ffac328c6ae2f76e5da58c05f44a1cbf
Reviewed-on: https://chromium-review.googlesource.com/c/1178046
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607232}
--
wpt-commits: 860091dbc783a678f128328646a519d9891f0838
wpt-pr: 12531
Automatic update from web-platform-testsAdd unit tests for wrapper handlers in tools/serve
Add unit tests for all kinds of wrapper handlers in tools/serve/serve.py.
See #12452
--
Update the unit tests
* Fix the import error
* Improve the code style
--
Read and write files in binary mode
Read and write files in binary mode so the unit tests can pass in
Python3 environment.
--
wpt-commits: 2225031efc850d3b87ea33210b79730b466f5c50, dfbb0fd0cba67a8b0ea261fcfaaa805fe6ed7f03, d0c94e610154d3a7cdf1f2882a7ac74d4dfe3114
wpt-pr: 14004
Automatic update from web-platform-testsSet orphans and widows to 1 in new multicol test.
The test left orphans / widows at their initial value (2), but did
assume that we could freely break wherever we wanted. Blink honors
orphans and widows requirements inside multicol containers, so set
them to 1, to get the behavior that the test expects.
Bug: 904263
Change-Id: Ia138da5c65b1c5da450441f38e033320bc983a94
Reviewed-on: https://chromium-review.googlesource.com/c/1331389
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607211}
--
wpt-commits: 0d4f539f5d4c7272c9fe07bd204674b207e4a979
wpt-pr: 14021
Automatic update from web-platform-testsTypo: "opoacity" should be "opacity" (#14018)
--
wpt-commits: 2f868fae5b43c68e4807f6a4ec9487f13ea39cf4
wpt-pr: 14018
Automatic update from web-platform-testsMIME types: test 0x0B, 0x0C, and newlines
For https://github.com/whatwg/mimesniff/pull/90.
--
wpt-commits: 6aeb68e38a61c2e332a7592f5cad640cf58b73f2
wpt-pr: 13615
Automatic update from web-platform-tests[css-text] Advance width of a tab must be at least 0.5ch
Relates to https://github.com/w3c/csswg-drafts/issues/2883
--
Merge pull request #13336 from frivoal/text-2883
[css-text] Advance width of a tab must be at least 0.5ch
--
wpt-commits: 3e89195978753b5e77a4aa04b420d17eb20dddd8, 67fe8ce363b1e2981d322e0a1a10186062e26e64
wpt-pr: 13336
Automatic update from web-platform-testsRemove ES6 object matching shorthand notation from WebDriver tests (#14015)
This change is to allow older user agents that do not support ES6
constructs to run the WebDriver tests.
--
wpt-commits: fc1a5b73230225faf32bfb85f3928ce154211b0a
wpt-pr: 14015
Automatic update from web-platform-testsSnap at ScrollIntoView.
According to the spec,
https://github.com/w3c/csswg-drafts/issues/2593#issuecomment-386154394
scrollIntoView should
1) Always snap to the target element's snap alignment, and
2) All the affected scrollers should also land on a snap position if
one exists.
This patch does part 2). Before a scrollable_area is added to
the smoothScrollSequencer with its new scroll_offset, we will check if
it has a valid snap offset around, and update the final offset
accordingly.
We'll implement part 1) in a separate patch.
Bug: 842317
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ica22134ed0b1f9d36f5a017c8dd0be54e907dd3d
Reviewed-on: https://chromium-review.googlesource.com/c/1188746
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607019}
--
wpt-commits: a0610cf468e6208e74b2cfda77a565ab90fbd74e
wpt-pr: 13038
Automatic update from web-platform-testsgrid-template-areas serialization
strings in grid-template-areas are normalized, e.g. collapsing
whitespace to a single space, and collapsing repeated periods ('.')
to a single period.
https://github.com/w3c/csswg-drafts/issues/3261#issuecomment-436828363
--
Merge pull request #13977 from ewilligers/grid-template-areas-serialization-2
grid-template-areas serialization
--
wpt-commits: da90a07f543e3307b53230a1f0a2e8b6dc72b42b, a27659a86371bb2d98e622f4e57b85a546898ade
wpt-pr: 13977
Automatic update from web-platform-testsNEL: Generate reports in HTTPNetworkTransaction
Piece by piece, we are moving the Reporting and NEL processing code from
URLRequest and friends into HTTPNetworkTransaction, to make sure that we
produce reports for network requests as defined by the spec.
This patch moves the generation of the actual NEL reports, and includes
some new WPT test cases that verify that we create reports correctly for
redirects and cached responses.
TBR=msramek@chromium.org
Bug: 895823
Change-Id: Ie8e17a2a2b3571a7cdfd39057da486f5ad2c9f6f
Reviewed-on: https://chromium-review.googlesource.com/c/1318169
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606958}
--
wpt-commits: 9902fbae9124fb565389983e49235d82cf429242
wpt-pr: 14007
Automatic update from web-platform-testsbrowser.py code cleanup
Some code cleanup that was recommended in https://github.com/web-platform-tests/wpt/pull/13185
--
wpt-commits: 7c568fdbd98ccdb92152c14521d3cc8c729a45a2
wpt-pr: 13239
Automatic update from web-platform-testsAdd a wpt create command
wpt create makes a file with the required elements for a test, and
optionally opens it in an editor.
--
wpt-commits: 726725be8f98607d521632e595fe5f2054570158
wpt-pr: 13701
Automatic update from web-platform-testswebkitRelativePath preserves common ancestors (#13988)
Drop requirement that webkitRelativePath only provides the shortest common ancestor, which matches behavior in Edge/Safari/Firefox, and soon Chrome.
Spec change: e6b848f4dc
Tracking issue: WICG/entries-api#18
--
wpt-commits: 378b79a9cd09df75403d88828d1793bb720a9488
wpt-pr: 13988
Automatic update from web-platform-testsWire the resizeMode property to the constraints parsing mechanism.
This CL adds resizeMode support for MediaStreamTrack.getConstraints()
and marks resizeMode as a supported constrainable property.
Support for getUserMedia(), applyConstraints() and getCapabilities()
will be added in follow-up CLs in this series.
Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
Bug: 854980
Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
Reviewed-on: https://chromium-review.googlesource.com/c/1309749
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606856}
--
wpt-commits: 055077093043d235040d20ae60458ee5ac6cded5
wpt-pr: 13846
Automatic update from web-platform-testsSetup logging earlier in the wpt run startup.
Curerntly we wait until we're setting up wptrunner kwargs to create the logger.
But that's pretty silly; we should set up the logger first thing and then use it
consistently to log during the setup phase.
--
wpt-commits: 47f0061f15dd2973dab11d87c03f0c8264d32e02
wpt-pr: 13578
Automatic update from web-platform-testsDo not send old capabilities to ChromeDriver
The configuration for Chrome currently sends 'platform' and 'version'
capabilities to ChromeDriver. These capabilities are non-standard and
unnecessary, and will cause errors when ChromeDriver becomes more
standard compliant.
--
wpt-commits: 7d9070444977a83af886d73bf80d57096be70ca5
wpt-pr: 13995
Automatic update from web-platform-testsFetch: CORS and request's Content-Type header
For https://github.com/whatwg/fetch/pull/829.
--
wpt-commits: eed621bc2f995bced9481df2cead4c4632c72cdd
wpt-pr: 13921
Automatic update from web-platform-testshtml: Fix a sanitization issue of type-change-state.html
type-change-state.html assumed sanitized value for " foo\rbar " was
fixed per a input type, and it was specified by 'sanitizedValue' field.
However, it depends on the previous type. For example, the new input
types of the following A and B are same, initial value setter arguments
are same, but sanitized values of A and B should be different due to the
sanitizer difference between 'hidden' and 'url':
A)
input.type = "hidden";
input.value = " foo\rbar ";
// input.value is " foo\rbar "
input.type = "text";
// input.value is " foobar ".
B)
input.type = "url";
input.value = " foo\rbar ";
// input.value is "foobar"
input.type = "text";
// input.value is "foobar".
This CL fixes this issue by replacing 'sanitizedValue' field with
'sanitizer' field, which specifies a simple sanitizer implementation.
This fixes five test cases, which have failed with all major browsers.
Change-Id: I1b5f75e610138b1d117e93723471427ee655c300
Reviewed-on: https://chromium-review.googlesource.com/c/1326203
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606730}
--
wpt-commits: 3cd60908e05beed166359907018c2abe238cb205
wpt-pr: 13993
Automatic update from web-platform-tests[media] Treat cross-origin redirect as TAINTED only for no-cors requests
With https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949,
WebMediaPlayer blindly treats a resource experiencing cross-origin
redirects as TAINTED. In fact, it should be treated as TAINTED only
when its request mode is "no-cors".
The added tests are provided by hongchan@chromium.org.
Bug: 899745, 901383
Change-Id: Idb66407552085b053818f3e4a9d8d5ff3ddeaf45
Reviewed-on: https://chromium-review.googlesource.com/c/1325281
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606681}
--
wpt-commits: d5be80a86d4f938250c075ac12414ad47516969c
wpt-pr: 13980
Automatic update from web-platform-testsReland "Make XR FrameData and Environment mojo associated"
This is a reland of 126a1168e3bcffb43c706822b3aa28695840310f
The fix in this change addresses compile errors on the
Oculus platform.
TBR=dcheng@chromium.org
dcheng@chromium.org: please review, though there are no
new changes to vr_service.mojom
Original change's description:
> Make XR FrameData and Environment mojo associated
>
> The XRFrameDataProvider now returns an associated
> XREnvironmentDataProvider interface so that the
> two share callback queues and thus allow strict
> ordering of the two interfaces. This is critical
> for frame synchronization between frames and the
> associated environment data.
>
> Note: We can't just mark the interfaceptrs for
> XRFrameDataProvider and
> XREnvironmentIntegrationProvider as associated
> in the XRSession struct. XRDevice implementations
> mostly live on separate threads from the
> XRFrameDataProviders, so we'd have extra thread
> hopping. For the VR headsets we explicitly live
> off the main thread to avoid latency, and because
> we do some work that may block the thread the
> XRFrameDataProvider lives on (for example waiting
> for vsync, or submitting frames to headset APIs).
>
> Bug: 867057, 876135, 843376
> Change-Id: If2fb62fcd185825209dec08e421df05f34d41c30
> Reviewed-on: https://chromium-review.googlesource.com/c/1171794
> Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605545}
Bug: 867057, 876135, 843376
Change-Id: If76578ebabbb40d03a21f6f557c5d4c27f69fc38
Reviewed-on: https://chromium-review.googlesource.com/c/1324089
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606643}
--
wpt-commits: a516e7edca11e2efe462d2bfc83b5b88dd9f4072
wpt-pr: 13969
Automatic update from web-platform-testsThe computed value of float with absolute positioning when there is no box should be "none" (#13958)
https://github.com/w3c/csswg-drafts/issues/1436
--
wpt-commits: 4477b9d2fadaca4314a9fc7d88ab6db6ad47a321
wpt-pr: 13958
Automatic update from web-platform-testshtml: Fix an issue of type-change-state.html about selectionDirection="none"
type-change-state.html contains assertions for the following operation in [1]:
> ..., and set its selection direction to "none".
However it had an issue that the assertions checked if
input.selectionDirection was "none". According to [2],
input.selectionDirection can be "forward" on specific platforms.
> update the element's selection direction to the given direction, unless
> the direction is "none" and the platform does not support that direction;
> in that case, update the element's selection direction to "forward".
[1] https://html.spec.whatwg.org/multipage/input.html#the-input-element:set-the-selection-direction
[2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#set-the-selection-direction
Change-Id: Idc1a97fbb2036e351a788a1f758b3239308d8c71
Reviewed-on: https://chromium-review.googlesource.com/c/1322264
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606310}
--
wpt-commits: 603b17f321fe4275050c59c87b1f3a29a33e9c96
wpt-pr: 13978
Automatic update from web-platform-tests[streams] Add tests for aborting pipeTo()
Add tests for aborting ReadableStream.prototype.pipeTo using an
AbortSignal.
Tests correspond to PR whatwg/streams#744.
--
wpt-commits: 349d41838068164e37a1cbd1c8c6ffeba4c72177
wpt-pr: 13358
Automatic update from web-platform-testsWindow onerror is not triggered bug fix
As pointed out in the bug, unhandled errors on worker threads were not
properly being propagated for the parent thread to handle as the spec
requires (https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2).
This fix adds in the code to do that.
Bug: 685303
Change-Id: Ie3e7ec03153a43efdc6e70b874d6b1a1d8ac35ef
Reviewed-on: https://chromium-review.googlesource.com/c/1287208
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605857}
--
wpt-commits: 920e3b1051f7bcb1fff98417cf91c904dbbdd36a
wpt-pr: 13691
Automatic update from web-platform-testswebkit: add support for the WPE port (#13863)
WPE port is closely related to the GTK port, using the same WebDriver
implementation as well as similar testing-purpose browser application.
Much of the capabilities dictionary construction can thus be the same.
--
wpt-commits: 89692eac0360247e56ba1ae4c32ea38cf1b6a9a0
wpt-pr: 13863
Automatic update from web-platform-testsEnsure that lone surrogates don't appear in wptreport json (#13828)
Python will happily handle "string" data containing codepoints in the surrogate
range. In the JSON output these are always escaped and appear as \uD800 or
similar. That's pretty unfortunate for interop since other languages don't
necessarily support such codepoints not representing a character in the
unicode set in their normal string type. Although it's possible to clean this
up on import it seems more reasonable to ensure that our primary interchange
format is unicode-clean. Therefore this change starts escaping lone surrogates
using the U+ notation so that \uD800 becomed U+D800.
Because Python, this requires two implementations. In UCS4 Python we know that
only lone surrogates should appear in string data; characters outside the BMP
will be represented as a single internal character (*technically* this is
untrue since someone may manually create a string containing a sequence of
surrogates that happens to form a pair; we don't care about handling this
case other than as two unpaired surrogates that happen to be adjacent). In
UCS2 Python surrogates appear in the string data literally, so we need to
check each time we encounter one whether it's a low surrogate followed by
a high surrogate and not escape in that case.
--
wpt-commits: 275904c8b770d10a9d67f6786b75dd4461a9a932
wpt-pr: 13828
Automatic update from web-platform-testsupdate wpt feature policy tests, making them long tests
Bug: 829921
Change-Id: Ia2c70c62d4a4235b21996bbd185746080e1efa35
Reviewed-on: https://chromium-review.googlesource.com/c/1320010
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606045}
--
wpt-commits: 1a7cb3deb6c8661e4cf245a7ffc3e324fb6795f2
wpt-pr: 13954
Automatic update from web-platform-testswebkit: provide port name as run info (#13862)
For the WebKit product, include the port name inside the run info, under the
'webkit_port' key. This will come in handy when disabling tests in metadata files
for specific ports.
--
wpt-commits: 9b9cf22d132ce60af8ad1801fd347965a1a96bae
wpt-pr: 13862
Automatic update from web-platform-tests[ci] Complete Docker image update (#13960)
A recent patch updated the Docker image used by Taskcluster when
building the project's `master` branch [1]. Update the corresponding
configuration for tasks triggered by pull requests. This improves parity
between the two processes, and because the new image is based on a more
recent LTS release of Ubuntu, it reduces the likelihood of errors due to
outdated system dependencies.
[1] https://github.com/web-platform-tests/wpt/pull/13676
--
wpt-commits: 3b729257c88fc09f200993317b6b84c9ae0aee3b
wpt-pr: 13960
Automatic update from web-platform-tests[Azure Pipelines] Document "Build pull requests from forks of this repository" (#13952)
--
wpt-commits: e0e8196c242c8fb1d2a62c13f23455a9d03bd4bb
wpt-pr: 13952
Automatic update from web-platform-tests[filter-effects] Parsing of backdrop-filter (#13871)
Test parsing, serialization and computed value for backdrop-filter
https://drafts.fxtf.org/filter-effects-2/#BackdropFilterProperty
--
wpt-commits: 208508bfdb7a8a9692394488bec2237102e16962
wpt-pr: 13871
Automatic update from web-platform-tests[LayoutNG] Fix vertical-align: text-top in quirks mode
When in quirks mode and there are no text siblings; e.g.:
<div><img><span>text</span></div>
and 'vertical-align: text-top' applied to <img> hits
DCHECK failure and results in incorrect position.
The test ensures that results are the same with the standard
mode.
Bug: 901123
Change-Id: I30564c66d5847f09caf3672ba3d456c0eb798d3e
Reviewed-on: https://chromium-review.googlesource.com/c/1320529
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605965}
--
wpt-commits: 48c278aad9f1570f14e47472e7cf304865602192
wpt-pr: 13962
Automatic update from web-platform-testsfix video reference in webvtt rendering tests
--
wpt-commits: c94bfaa0f97be784245d5c5405ebf2cae78df2f7
wpt-pr: 13553
Automatic update from web-platform-testsFix RTCRtpTransceiver direction tests (#13914)
* Update RTCRtpTransceiver setDirection to direction setter
* Fix currentDirection in RTCRtpTransceiver-direction.html
* Add negative test for setDirection
--
wpt-commits: d37a815dbca209eafc8eb71cb59ce59f4e66f975
wpt-pr: 13914
Automatic update from web-platform-testsRemove support for supportedTypes in Payment Request (#13858)
--
wpt-commits: 615bb572c95add74ca4fb9fed4af5269a49cf4ef
wpt-pr: 13858
Automatic update from web-platform-testsAdded mechanisms for default policy
With a default policy defined, assignments implicitly call createXXX on the default policy
Added ScriptState* to the accessors visible from JavaScript
Tests were updated to check string assignment when trusted-types are needed before and after the default policy is defined
Bug: 739170
Change-Id: I9bb841d69f324b841602d41abd71f753a9858af8
Reviewed-on: https://chromium-review.googlesource.com/c/1207530
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605720}
--
wpt-commits: 24373750793a107c28dbfde50d61cfae192fb485
wpt-pr: 12952
Automatic update from web-platform-testsRun py36-flake8 also for tools/wpt/ (#13947)
--
wpt-commits: bfc7ce508b754e84e95830c2186f1fa8eb9f179e
wpt-pr: 13947
Automatic update from web-platform-testsRevert "Make XR FrameData and Environment mojo associated"
This reverts commit 126a1168e3bcffb43c706822b3aa28695840310f.
Reason for revert: Broke compile: https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_Win/39908/+/recipes/steps/compile/0/stdout
Original change's description:
> Make XR FrameData and Environment mojo associated
>
> The XRFrameDataProvider now returns an associated
> XREnvironmentDataProvider interface so that the
> two share callback queues and thus allow strict
> ordering of the two interfaces. This is critical
> for frame synchronization between frames and the
> associated environment data.
>
> Note: We can't just mark the interfaceptrs for
> XRFrameDataProvider and
> XREnvironmentIntegrationProvider as associated
> in the XRSession struct. XRDevice implementations
> mostly live on separate threads from the
> XRFrameDataProviders, so we'd have extra thread
> hopping. For the VR headsets we explicitly live
> off the main thread to avoid latency, and because
> we do some work that may block the thread the
> XRFrameDataProvider lives on (for example waiting
> for vsync, or submitting frames to headset APIs).
>
> Bug: 867057, 876135, 843376
> Change-Id: If2fb62fcd185825209dec08e421df05f34d41c30
> Reviewed-on: https://chromium-review.googlesource.com/c/1171794
> Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605545}
TBR=dcheng@chromium.org,klausw@chromium.org,billorr@chromium.org,lincolnfrog@chromium.org
Change-Id: I7a2408629460f456bf1189acdb0837f7d22a7919
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 867057, 876135, 843376
Reviewed-on: https://chromium-review.googlesource.com/c/1318805
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605551}
--
Merge pull request #13939 from web-platform-tests/chromium-export-0ef86cd598
Revert "Make XR FrameData and Environment mojo associated"
--
wpt-commits: 97ef8fa350d0b1cf5c4692a71b1040d66266e7b7, b306f085d1a008b7636b60efa67a5b89d1fc2f52
wpt-pr: 13939
Automatic update from web-platform-testsFix and re-enable simplecall-no-ssrcs.https.html.
With the changes, the test should pass regardless of if the Chrome or
Firefox behavior is used for what to do when no MSIDs are signaled.
Follow-up work is needed to test both the case of "a=msid:-" and no
"a=msid" line whatsoever, awaiting spec issue to be resolved:
https://github.com/w3c/webrtc-pc/issues/2027
// Relying on fippo's approval to land.
TBR=hta@chromium.org
Bug: 901711
Change-Id: Icaf089d206413510aadad54a0c10b2674450385a
Reviewed-on: https://chromium-review.googlesource.com/c/1319612
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605678}
--
wpt-commits: bce2269d0f17d2a89247895cbee21530ae83c96e
wpt-pr: 13950
Automatic update from web-platform-tests[presentation-api] Revise the test for reconnecting multiple presentations (#13196)
Test closing and reconnecting to multiple connections simultaneously
--
wpt-commits: 7a51b509430cc115df632608356999fa18ac4491
wpt-pr: 13196
Automatic update from web-platform-testswebrtc: rename DTLSTransport.transport to .iceTransport (#13915)
test for https://github.com/w3c/webrtc-pc/pull/2017
--
wpt-commits: c05700b258089fd547808c54707cdc3a64b48344
wpt-pr: 13915
Automatic update from web-platform-testsRemove the "W3C WebSocket API" prefix from websockets/ tests (#13478)
This prefix doesn't add any useful information, and isn't used in all
tests in this directory. Noticed because of the screen real estate it
takes up in a view like this:
https://wpt.fyi/results/websockets/Send-binary-65K-arraybuffer.any.html
In the directory, this command was run, on macOS:
git grep -lF 'W3C WebSocket API - ' | xargs sed -i '' 's/W3C WebSocket API - //g'
--
wpt-commits: 1e747acc90ecdbd23ef3348a144b77696cced55b
wpt-pr: 13478
Automatic update from web-platform-testsUpdate RTCPeerConnection-setRemoteDescription-tracks.https.html as MediaStream has no constraint on the order of the track (#13940)
--
wpt-commits: 89c900d2e2bae0592564dfc5bf06cc4b08b3cac5
wpt-pr: 13940
Automatic update from web-platform-tests[wptrunner] Convert data prior to transmission
A recent improvement to wptrunner modified the way data structures are
transmitted from the browser to the WebDriver server [1]. One
consequence of this change is that the data structures are created in a
JavaScript realm which differs from the realm in which the "Execute
Script" WebDriver command is running. As of version 17, Microsoft Edge
does not correctly serialize cross-realm values, so referenced
improvement unintentionally precluded testing in that browser.
Serialize and deserialize the results data structure from the realm of
the WebDriver command to avoid this problem.
[1] https://github.com/web-platform-tests/wpt/pull/13419
--
wpt-commits: e3738ec2754f0c3fb44a03af3104db1decf9fca7
wpt-pr: 13938
Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type a little more
99f4fdcd906411c036e96c055e28b3e6ca84a1cc was not entirely correct unfortunately.
--
wpt-commits: 47aa8753bba8656899eca2e7c3851a7c75c1d2d7
wpt-pr: 13920
Automatic update from web-platform-testsChange the button type to int in the pointerActionSequence API
In order to match with test_driver Actions API, we need to change the
button type from string to int in the pointerActionSequence API and the
related web platform tests and layout tests.
Bug: 893480
Change-Id: I151849d31038cf40a2a603196e0f616e15d89072
Reviewed-on: https://chromium-review.googlesource.com/c/1297637
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605605}
--
wpt-commits: 41f76e27e00de380d5a100aa0c1065fa202e9c0a
wpt-pr: 13933
Automatic update from web-platform-testsMake XR FrameData and Environment mojo associated
The XRFrameDataProvider now returns an associated
XREnvironmentDataProvider interface so that the
two share callback queues and thus allow strict
ordering of the two interfaces. This is critical
for frame synchronization between frames and the
associated environment data.
Note: We can't just mark the interfaceptrs for
XRFrameDataProvider and
XREnvironmentIntegrationProvider as associated
in the XRSession struct. XRDevice implementations
mostly live on separate threads from the
XRFrameDataProviders, so we'd have extra thread
hopping. For the VR headsets we explicitly live
off the main thread to avoid latency, and because
we do some work that may block the thread the
XRFrameDataProvider lives on (for example waiting
for vsync, or submitting frames to headset APIs).
Bug: 867057, 876135, 843376
Change-Id: If2fb62fcd185825209dec08e421df05f34d41c30
Reviewed-on: https://chromium-review.googlesource.com/c/1171794
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605545}
--
wpt-commits: 2ba8053bfa3946457355fa73d2873144fe4479d2
wpt-pr: 13764
Automatic update from web-platform-testsCope even better with the mess we leave behind after a continuation.
Tried to fix this in https://chromium-review.googlesource.com/c/1309777
but incorrectly assumed that bogus continuation chains were formed by
direct siblings. But they may also be arbitrary-level cousins. Need to
walk through all non-atomic inlines between one continuation object and
the next in the chain, to figure out whether there is an anonymous block
between two objects in the continuation chain. Only then should we
update the positionedness of anonymous blocks. Only perform this check
if positionedness changed, since it's not for free.
Bug: 901598
Change-Id: I3e49a4ce8081a4a3190cc1569480189cbcccdcc4
Reviewed-on: https://chromium-review.googlesource.com/c/1317627
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605465}
--
wpt-commits: fb4466fa28e359a770f6d7007a2a1302fec0c8a2
wpt-pr: 13919
Automatic update from web-platform-testsCorrect inherited feature policy when allow attribute is used.
This fixes an error in the inherited policy calculation where a frame
which was explicitly allowed to use a feature through the Feature-Policy
header would be blocked if the "allow" attribute was also present on
the iframe element.
The behaviour now matches the spec algorithm at
https://wicg.github.io/feature-policy/#define-inherited-policy-in-container
Tests have been added to catch this case.
Change-Id: I7a394202c615be3088fda738d7fc65f16bcadf34
Reviewed-on: https://chromium-review.googlesource.com/c/1293610
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605431}
--
wpt-commits: d5f4dec283def0baeca6e5a88223dac67935e798
wpt-pr: 13717
Automatic update from web-platform-testsCSS: serialize pointer-events keywords in lower case
https://drafts.csswg.org/cssom/#serializing-css-values
"To serialize a CSS component value depends on the component, as follows:
keyword
The keyword converted to ASCII lowercase."
Bug: 901666
Change-Id: Iff579a363de13441c75bbebfc951095b071f6060
Reviewed-on: https://chromium-review.googlesource.com/c/1317300
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605383}
--
wpt-commits: f917e2dfc6649f9217f51dec9fd45eaef16188fc
wpt-pr: 13917
Automatic update from web-platform-testsEnable flake8 for py3 again (#13875)
This was accidentally dropped in https://github.com/web-platform-tests/wpt/pull/13865.
Splitting flake8.ini into two is a bit unfortunate, but after trimming
to just the errors and warnings that are hit, they differ a
bit. Unfortunately using `--append-config` twice doesn't work.
--
wpt-commits: ba70a57943fae3d69055b1c91b083e0d46d1067d
wpt-pr: 13875
Automatic update from web-platform-testsSPV event should have some required init fields
Spec: https://w3c.github.io/webappsec-csp/#dictdef-securitypolicyviolationeventinit
Bug: 897646
Change-Id: Id4c4947455a095c09aa34d16c7ff298ba4ba046e
Reviewed-on: https://chromium-review.googlesource.com/c/1292566
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605300}
--
wpt-commits: 33640efd70eaad4a6b482b98bd4e433d49934a50
wpt-pr: 13685
Automatic update from web-platform-testsServiceWorker: Modernize WPTs for Client.postMessage using async/await etc
This is a preparation for adding more tests for postMessage to worker clients.
Bug: n/a
Change-Id: I9e20b04fd86ad27faaecd7d592cac6dfa5ae16b1
Reviewed-on: https://chromium-review.googlesource.com/c/1317067
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605276}
--
wpt-commits: 1360c83bf9347dd1485b4b0fe63c750da5a0a0c3
wpt-pr: 13891
Automatic update from web-platform-testsFix typo in RTCRtpReceiver-getParameters.html
RTCPeerConnection does not have a `getParameters` method.
--
Merge pull request #13910 from markandrus/patch-1
Fix typo in RTCRtpReceiver-getParameters.html
--
wpt-commits: fb253de548b7b5c5ec2f3056c97a8cf67d245a31, 064f51c50eab34723ef435e80188bde08f718c2c
wpt-pr: 13910
Automatic update from web-platform-tests[css-position] Inheritance and initial values (#13067)
* [css-position] Inheritance and initial values
Test that the CSS Positioned Layout properties do not inherit.
Test their initial values against the spec.
https://drafts.csswg.org/css-position/#property-index
* [css-position] offset-* are now inset-*
--
wpt-commits: c6e3139509dfa0b9acdf575802c8c1834ae06821
wpt-pr: 13067
Automatic update from web-platform-testsLet sender sends some media data so that getStats produce some outbound rtp related stats (#13907)
--
wpt-commits: 8302c59449942bc6f0a422491bd05fc1111dab20
wpt-pr: 13907
Automatic update from web-platform-testsMove onaddstream test to webrtc/legacy
--
Merge pull request #13905 from youennf/move-onaddstream-to-legacy
Move onaddstream test to webrtc/legacy
--
wpt-commits: ff33b7ebc5772eed2bbe415f832cb9173cebb8f5, 5b70f391ac3004e1d98508871ccb036fd19ed393
wpt-pr: 13905
Automatic update from web-platform-testsMove RTCRtpTransceiver tests related to OfferToReceive legacy options to webrtc/legacy (#13903)
--
wpt-commits: 72fa5ddc5bbab969742ead5664021f59aa0ee1e1
wpt-pr: 13903
Automatic update from web-platform-tests Rename generateOffer to generateDataChannelOffer and remove use of legacy optionsRename generateOffer to generateDataChannelOffer and remove use of legacy options (#13893)
Rename generateOffer to generateDataChannelOffer and remove use of legacy options
--
wpt-commits: cd17e3bcc05a5446bcb0f725551be27bafc59751
wpt-pr: 13893
Automatic update from web-platform-testsUse addTransceiver instead of offerToReceive options if possible
--
Merge pull request #13901 from youennf/remove-further-offerToReceiveXX
Use addTransceiver instead of offerToReceive options if possible
--
wpt-commits: 7b1635867dd746977895bfe1bb5a7f2d0afaffe7, c273f76920c9a675c639a049e1e778cfb8c6fbf5
wpt-pr: 13901
Automatic update from web-platform-testsMove peerIdentity test from webrtc-pc to webrtc-identity (#13892)
Move peerIdentity test from webrtc-pc to webrtc-identity
--
wpt-commits: 0ec83a2998156414399e365a4fbe9be7402b0285
wpt-pr: 13892
Automatic update from web-platform-testsMove from offerToReceiveAudio to addTransceiver('audio')
--
Merge pull request #13899 from youennf/move-offerToReceiveAudio-addTransceiver-audio
Move from offerToReceiveAudio to addTransceiver('audio')
--
wpt-commits: 59e5213b74251dbab6597c1dde436e4625530949, 6321ab57a1b7856d338950532ed44dd103d37863
wpt-pr: 13899
This adds a new class for the marquee tag, instead of overloading HTMLDivElement.
It removes some of the XBL that was used to expose properties to web content.
Differential Revision: https://phabricator.services.mozilla.com/D3824
--HG--
extra : moz-landing-system : lando
This resolves the two problems of MediaRecorder:
1. MediaRecorder does not fire pause/resume events when the corresponding methods are called, as mentioned in D7910.
2. The WebIDL for MediaRecorder does not specify onpause/onresume event handler attributes neither.
DispatchSimpleEvent() is used because there are no event attributes needed.
Differential Revision: https://phabricator.services.mozilla.com/D7971
--HG--
extra : moz-landing-system : lando
Rotate accepts rotate axis and angle in any order
(i.e. <number>{3} <angle> or <angle> <number>{3}), so we rewrite the
parser.
Depends on D11401
Differential Revision: https://phabricator.services.mozilla.com/D11417
--HG--
extra : moz-landing-system : lando
The original implementation always returns Rotate::Rotate3D, but it is
not correct, so we have to rewrite it:
1. If both from value and to value are none, we don't have to convert it
into identity value, so just return None.
2. If one of the value is none, we replace it with an identity value based on
the other one's rotate axis.
3. If we only have 2D rotation, we just animate the <angle>.
4. Otherwise, we do interpolation by 3D rotation.
Differential Revision: https://phabricator.services.mozilla.com/D11247
--HG--
extra : moz-landing-system : lando
- Expose FetchEvent.resultingClientId on non-subresource, non-"report"-destination requests.
- Delay Clients.get(FetchEvent.resultingClientId) resolution until the resulting client is execution ready.
- Add WPTs to test for existence of resultingClientId and Clients.get promise resolution values.
Differential Revision: https://phabricator.services.mozilla.com/D5333
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-testsMove offerToReceive tests to webrtc/legacy
--
Add README.txt
--
Fix according comments and also remove webrtc/RTCPeerConnection-createOffer-offerToReceive.html
--
Merge pull request #13897 from youennf/move-offerToReceive-tests-to-webrtc-legacy
Move some offerToReceive tests to webrtc/legacy
--
wpt-commits: 20676f8e4d648ba15f92b34680ec2145f709447b, 9149142688378105c6ee4c55625e9ffe7733d114, c86065e16bff25b1c4ea08a94e4497bb54b26a91, 41851a672e581d5b74e6567d906edf28a9b37c9c
wpt-pr: 13897
Automatic update from web-platform-testsMake video-codecs.https.html use addTransceiver
--
Merge pull request #13895 from youennf/video-codecs-addTransceiver
Make video-codecs.https.html use addTransceiver
--
wpt-commits: ceecc53e022d817d0af6a1b487b82adfa8bc9fe6, 6d93a8a617f4469e62635cf634b626d8b31f94af
wpt-pr: 13895
Automatic update from web-platform-testsSend media content to get inbound rtp stats
--
Merge pull request #13896 from youennf/fix-getStats-addTransceiver
Send media content to get inbound rtp stats
--
wpt-commits: 8d26eb70b3fa17889d52a09239b4bd2903d23814, 18a053a7d5da19a97aa75d2e00c6b8df7631dc64
wpt-pr: 13896
Automatic update from web-platform-testsUse transceiver instead of offerToReceiveVideo in no-media-call
--
Use addTransceiver and if failing, fall back to offerToReceiveVideo
--
Merge pull request #13894 from youennf/no-media-call-addTransceiver
Use transceiver instead of offerToReceiveVideo in no-media-call
--
wpt-commits: ead3edfc872f7e1241f6b3ed50b5ca08dd0527a2, c3be323c4ebb241b6dc867a2a2d056c641bbf609, 2b55923345ecf91bc93a43721231ee9fcaba00e7
wpt-pr: 13894
Automatic update from web-platform-testsBasic test for generated SDP
This adds a protocol test that SDP is generated by createOffer
conforming to JSEP requirements.
--
Update sess-id test
--
Merge pull request #13887 from alvestrand/jsep-basic-sdp
Basic test for generated SDP
--
wpt-commits: 34f7fa7c9a4290d7cf2523fbf221a532f969408e, 79745f4dea4a98e00faa378a5e55d2f989243fc6, da8939da78abfc1397736b6c97306806b1edde71
wpt-pr: 13887
Automatic update from web-platform-testsCheck for AudioContext to enable generating audio tracks with it
--
Merge pull request #13869 from youennf/fix-check-audio-context-for-webrtc
Check for AudioContext to enable generating audio tracks with it
--
wpt-commits: d72af25ff4ea267dcd60991e5b88f7ac4215a6b5, 5b2feb1bdf3ec2571f9d7f877752c6df58e52d10
wpt-pr: 13869
Automatic update from web-platform-tests[LayoutNG] Use cached fragment if size won't change.
Available size may change from one layout pass to another, but that
doesn't have to mean that we need to re-lay out a child. If we can be
sure that its size will remain the same, and that if it will keep the
same size, that won't affect any descendants, we can skip layout and
return the cached fragment.
We cannot ignore initial containing block size changes if there are
orthogonal flow root children, so keep track of that.
Makes perf_tests/layout/many-block-children-fixed-inline-size.html
about 3 times faster.
Update expectations for one invalidation test. The test has some
fixed-width descendants, so when only the window width changes,
there's less work to do, than before.
Update one unit test, and expand it a bit, to provide a case where we
actually still do need layout.
Bug: 897450
Change-Id: I063f650110d5a488de430b938b3d46e713a1433e
Reviewed-on: https://chromium-review.googlesource.com/c/1297367
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605168}
--
wpt-commits: e4821cbf95780723ec4f19546b50c1a4d8774117
wpt-pr: 13843
Automatic update from web-platform-testsUpdate urllib3 from 1.24 to 1.24.1 (#13879)
--
wpt-commits: 6146d600fd84c043ee3ce70e59f9abe1b8252d99
wpt-pr: 13879
Automatic update from web-platform-testsRename RTCIceCandidate ufrag field to usernameFragment
--
Merge pull request #9434 from soareschen/ufrag-rename
Rename RTCIceCandidate ufrag field to usernameFragment
--
wpt-commits: 5b9920aa5c7fa27d5954c032e6283327fb2a2c97, a27f3074d9873753dceb6f59801ecd5d3a558b52
wpt-pr: 9434
Automatic update from web-platform-testsBring RTCCertificate interface up to date with Candidate Recommendation
--
Merge pull request #10271 from aboba/patch-1
Bring RTCCertificate interface up to date with Candidate Recommendation
--
wpt-commits: f31ef37b39dad03d8ba2fcfff0265c662c3bcd8c, 9dd2979bf76aaf62017bc7e9a12706cd64cd2227
wpt-pr: 10271
Automatic update from web-platform-testswebrtc: make a call without announcing SSRCs in the SDP
while testing receiving video still works by listening for
loadedmetadata
--
webrtc: also remove msid lines
--
Merge pull request #13526 from fippo/no-ssrcs
webrtc: make a call without announcing SSRCs in the SDP
--
wpt-commits: 23f4c21d0e21274971d1d3f98e6439fdddb756e7, 716f4c3edba97f07bb125b18ffb73d2f6bb0338b, c18f62e684c7be955b5a5b5a7906836633bea9ed
wpt-pr: 13526
Automatic update from web-platform-testsIndexedDB: fix minor nits in databases() WPTs
Fixing minor nits with IndexedDBFactory databases() WPTs as suggested
by jsbell@ over email
-assert_object_equals is deprecated and shouldn't be used. Prefer to
test the results explicitly, even though it's more code.
-all of the test cases use 1 for the version - we should have tests
for databases at other versions.
-the assertion messages should have the form ".... should be ...",
describing what is being asserted, rather than attempting to diagnose
the problem (it's easier to verify that the assertions match the spec
that way)
-there are a handful of lines missing semicolons
-the trailing done() should not be needed for .any.js tests
Bug: 899085
Change-Id: Ie8831c26fabe0e043ccba8238925ac7f520d1d69
Reviewed-on: https://chromium-review.googlesource.com/c/1313275
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Andreas Butler <andreasbutler@google.com>
Cr-Commit-Position: refs/heads/master@{#605128}
--
wpt-commits: 4ff6f151a21ef885d4e7a41122907862ae5ae037
wpt-pr: 13856
Automatic update from web-platform-tests[css-text] Keep track of the initial offset for each handled text
In order to identify single leading white-spaces as potential line
breaking opportunities we need to know the offset the iterator starts
at for the current text to handle.
When we landed the change in r596406 we incorrectly assumed that
leading white-spaces were always at offset 1. However, this is not
valid when such leading white-spaces are generated by previous broken
lines.
This CL solves the issue by using the stored initial offset to identify
such single leading white-spaces as potential breaking opportunities.
Bug: 900727
Change-Id: Ibc9dda7632d72ed82a61025015489ec3b70d6919
Reviewed-on: https://chromium-review.googlesource.com/c/1311274
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605055}
--
wpt-commits: c583bcd7eb30f38cb2d673031cde245776f1da5a
wpt-pr: 13830
Automatic update from web-platform-testsDon't allow popups during page unloading times.
Precisely, this disallows them when the event loop's
termination nesting level is nonzero.
This is now part of the spec,
https://html.spec.whatwg.org/#apis-for-creating-and-navigating-browsing-contexts-by-name
> The window open steps, given a string url, a string target, and a string features, are as follows:
> 1. If the event loop's termination nesting level is nonzero, return null.
BUG=844455
Change-Id: I85fb003063f5ed051049c7c263391835421902ac
Reviewed-on: https://chromium-review.googlesource.com/c/1180296
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605025}
--
wpt-commits: ffeba23ebd16b9adb2e0e2b5fe6923fef9bb9e5e
wpt-pr: 12577
Automatic update from web-platform-testsUse USB mojo interfaces in WebUsbDetector.
This CL converted USB callings in WebUsbDetector to mojo interfaces
by introducing webusb_landing_page in UsbDeviceInfo.
Bug: 699790
Change-Id: I6352c35a7eb9090ef4d5cb3d2436b30216d76ec9
Reviewed-on: https://chromium-review.googlesource.com/c/1297747
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604923}
--
wpt-commits: 843887c17db71d57a4466599cf42f494bea6af1c
wpt-pr: 13718
Automatic update from web-platform-testsKeep previous_in_flow across shadow boundary.
For some reason we created a new AttachContext entering a ShadowRoot for
AttachLayoutTree. If the shadow host was display:contents we would lose
the previous_in_flow from the shadow tree checking the need for
whitespace LayoutObject for shadow host siblings.
Created a common space-separated words expectation for css.
Bug: 901323
Change-Id: Ib2fa54d55923c0497ff8e96c5010e68b01570881
Reviewed-on: https://chromium-review.googlesource.com/c/1314589
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604910}
--
wpt-commits: 25b7275dd46568b0ba28201940cadac3045616ff
wpt-pr: 13872
Automatic update from web-platform-testschange test order (#13861)
* change test order
Switching order of tests so these click ones can run before canMakePayment() gets upset.
* split up tests
--
wpt-commits: 96d09d3b3b8b8794063e6cd2c5bfe3dd8a4a395c
wpt-pr: 13861
Automatic update from web-platform-testsExtract Safari version from safaridriver (#13467)
--
wpt-commits: bd9dbc0d99bdadc541cd55a0309730d2bf40df1b
wpt-pr: 13467
Automatic update from web-platform-testsConsolidate the flake8 setup into tools/tox.ini and config files (#13865)
flake8 is still run as part of the "tools/ unittests (Python 2)" job in
Travis, because `run_applicable_tox` in tools/ci/ci_tools_unittest.sh
will turn `TOXENV=py27` into `TOXENV=py27,py27-flake8`.
Splitting flake8 into a separate job entirely is left for later.
--
wpt-commits: a54a387e5d474670fbe0431eb8a898df603ec0eb
wpt-pr: 13865
Automatic update from web-platform-tests[css-properties-values-api] Invalidate paint worklet on registration.
Due to how initial values of registered custom properties used to be
handled, the style diff function for custom paint could not discover that
the computed value for some property changed due to a new property
registration.
This meant that, if you used the property '--x' in your paint worklet
(without applying '--x' on any element in the document), and _then_
registered the property '--x' (giving it an initial value), the worklet
would not repaint even though the computed value of --x changed from
"nothing" to the registered initial value.
Now that initial values are returned from ::GetRegisteredVariable, simply
compare those values when diffing for custom paint invalidation.
Note that the second test in this CL is already passing before this CL,
but I'm including it anyway since that case is also mentioned in the bug.
R=ikilpatrick@chromium.org
Bug: 657706
Change-Id: I2b7707d48d73693a70b100fe1121bd7f977b4db1
Reviewed-on: https://chromium-review.googlesource.com/c/1309788
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604607}
--
wpt-commits: 2a5673603f719fed9b3dce2f6bde705057b90599
wpt-pr: 13822
Automatic update from web-platform-testsMake Element#innerText not to emit Tab/Newline for <td>/<tr>/<br> itself
This patch changes |Element#innerText| not to emit Tab/Newline for <td>, <br>,
<tr> itself to follow the spec change[1] for improving interop.
Example:
- <br>.innerText -> "" (was "\n")
- <td>abc</td>.innerText -> "abc" (was "abc\t")
- <tr><td>abc</td></tr>.innerText -> "abc" (was "abc\n")
[1] https://github.com/whatwg/html/pull/4132 Make innerText getter not run the
algorithm on the element itself
Bug: 897373
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I4266ee28df9b44e9044dfa60c2d54257a5f82eeb
Reviewed-on: https://chromium-review.googlesource.com/c/1312436
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604872}
--
wpt-commits: ff0b6d883e558c94a2302985d424606a80ed5200
wpt-pr: 13835
Automatic update from web-platform-tests[css-text] word-break:break-all does not affect punctuation (#13415)
Turns into an proper wpt test case the test discussed in https://github.com/w3c/csswg-drafts/issues/785#issuecomment-374866706
--
wpt-commits: b61f5da2f084542d060e954209a4794f346c789a
wpt-pr: 13415
Automatic update from web-platform-tests[css-text] word-break:keep-all with U+3000 (space) and U+3001 (punctuation) (#13211)
At the time of writing, Chrome passes, but Firefox and Safari fail.
Related to https://github.com/w3c/csswg-drafts/issues/3142
--
wpt-commits: ac65f580b18722c161a59fe1a4436f17f6acda2d
wpt-pr: 13211
Automatic update from web-platform-tests[css-overscroll-behavior] Inheritance, initial (#13677)
Properties inherit or not according to the spec.
Properties have initial values according to the spec.
https://drafts.csswg.org/css-overscroll-behavior/#property-index
--
wpt-commits: 69a295238d917c2438c0029a143757a99768f275
wpt-pr: 13677
Automatic update from web-platform-testslocation.pathname should return "blank" when there is no browsing context (#13854)
The pathname of "about:blank" is "blank", not "".
--
wpt-commits: a6322a0bf9f7b0553dec4c8eee5a673fccf9a91b
wpt-pr: 13854
Automatic update from web-platform-tests[Presentation API] Remove from insecure contexts.
This patch removes the Presentation API from insecure contexts. The number of presentations started on insecure contexts is 0.0001% of page views on desktop and 0.0004 on Android.
In addition it updates layout tests and WPT to use https: for presentation URLs.
Blink-dev thread:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion
chromestatus.com feature entry:
https://www.chromestatus.com/feature/5766218384408576
Bug: 733381
Change-Id: I9ae3025160b0e0bcf987fda0068a0e6bd92c24fd
Reviewed-on: https://chromium-review.googlesource.com/c/1306336
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604621}
--
wpt-commits: 68c63e96b88dfaceb492a8247ea8830484bf8007
wpt-pr: 13794
Automatic update from web-platform-testsFix link markup in signed-exchange/README.md (#13790)
--
wpt-commits: 088f63b9c303e1e3a5be74058c0b81a5d30502f2
wpt-pr: 13790
Automatic update from web-platform-tests[css-properties-values-api] Store initial variables on ComputedStyle.
Initial values are currently not stored at all on ComputedStyle, and we
must refer to the PropertyRegistration to figure out what the initial value
for a given property is.
The problem with this, is that registering a property also has the effect
of giving all styles that are already computed new values (effectively).
For example, if a property '--x' is not registered (and not applied on any
style), the computed value of that property is the "empty value" as
described in css-variables. If the property then becomes registered,
the initial value suddenly becomes whatever is specified by the
registration, even on the ComputedStyle objects that already exist.
This causes problems for calculating transitions, because we incorrectly
consider the previous computed value to be "initialValue" from the
registration rather than what it really was: "empty value".
This CL adds a StyleInitialData class which contains the initial values
for all registered variables. This class is instantiated for the initial
style, and then referenced by all ComputedStyles that inherit from that
style.
This makes it possible to know what the initial value was for a certain
property at the time style calculation took place.
R=futhark@chromium.org
Bug: 848250
Change-Id: I0a44e06608738aab15cb35fbc448a47188932600
Reviewed-on: https://chromium-review.googlesource.com/c/1309736
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604580}
--
wpt-commits: bce35cc67fe84021df94dc52e60522b1f1b46e8b
wpt-pr: 13816
Automatic update from web-platform-testsAdd extra utilities to content::media_constraints
This CL adds:
* NumericRangeSet::Contains().
* NumericRangeSet::EmptySet().
* ResolutionSet::FromNativeResolution().
These utilities are in preparation for supporting the resizeMode
constrainable property in getUserMedia() and applyConstraints().
Drive-by: minor fixes/improvements.
Bug: 854980
Change-Id: I858f406308aa9bba40521d5e740219b72e2c8a48
Reviewed-on: https://chromium-review.googlesource.com/c/1308133
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604574}
--
wpt-commits: 5b699ddb3200ce3abc8a2a5059c52235076bde4f
wpt-pr: 13845
Automatic update from web-platform-tests[Azure Pipelines] Split manifest update into a separate step (#13831)
For some reason, manifest generation is faster this way.
Drive-by: don't use multi-line script where not needed
--
wpt-commits: 46e12063c39422833ea51552e86b200175be0f1a
wpt-pr: 13831
Automatic update from web-platform-testsAdd support for resizeMode in MediaStreamTrack.getSettings()
This CL exposes the current resizeMode setting to the Web Platform.
As of this CL, the resizeMode is 'none' if the track resolution
corresponds to the native resolution of the video source, without any
resolution adjustment. It is 'crop-and-rescale' if rescaling is
necessary.
The resizeMode currently cannot be set explicitly with getUserMedia() or
applyConstraints(), but this functionality will be added in a follow-up
CL.
Drive-by: Add separate WPT tests for all getSettings() properties.
Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
Bug: 854980
Change-Id: Id4c683e6b2f228b17cf2354cb7fc589ca9e593a6
Reviewed-on: https://chromium-review.googlesource.com/c/1307448
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604562}
--
wpt-commits: dcf7730d7300f236459aa20990e14d46f3517916
wpt-pr: 13840
Automatic update from web-platform-tests[css-animations] animation-duration computed value (#13819)
Durations are serialized in seconds.
https://drafts.csswg.org/css-values-4/#time
--
wpt-commits: e92093981dfdba5154fd8c41021f2bf99751e67b
wpt-pr: 13819
Automatic update from web-platform-testsUpdate selenium from 3.14.1 to 3.141.0
--
Update selenium from 3.14.1 to 3.141.0
--
Update selenium from 3.14.1 to 3.141.0
--
Update selenium from 3.14.1 to 3.141.0
--
Update selenium from 3.14.1 to 3.141.0
--
Update selenium from 3.14.1 to 3.141.0
--
Update selenium from 3.14.1 to 3.141.0
--
wpt-commits: 48af82969fefb8d2fe80f8b0e6162dd707bec073, 0caf7b0df499a1a80c582a0aa876f95298bf9563, f6077c770a969300b730e460b0ef6f5164257f93, 4b0226dd1adc95ee1cc50df66fb79f85dc8e05c1, 7f2e42aaa0305df82b2c9094cbfcb1a9c459bce6, 2c4f1aee95cf4878c7644803e25ffb385101a7dc, 751803fa80e835e4afa55f69cc8e87c86a8aaadd
wpt-pr: 13839
Automatic update from web-platform-testsXMLHttpRequest: overrideMimeType and workers
See https://bugzilla.mozilla.org/show_bug.cgi?id=723739 for context.
--
wpt-commits: 046815564b1808dddb4898b18e88607bb52aa13d
wpt-pr: 12181
Automatic update from web-platform-tests[layoutng] Fix setting of fixed_block_is_definite
When a flex item has a definite specified height (e.g. height: 100px),
then percentages in children of the flex item should resolve even
if the flexbox does not have an explicit height, ie. does not match
the condition in https://drafts.csswg.org/css-flexbox/#definite-sizes
Bug: 885185
Change-Id: Iba226f30e1e02e3a11273fa45fcdf1cef897120c
Reviewed-on: https://chromium-review.googlesource.com/c/1311534
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604483}
--
wpt-commits: d77d5561cda3ab330143bdd5fed7a96b84be24e0
wpt-pr: 13829
Automatic update from web-platform-testsNo vertical bars if 'vertical-policy' disabled
When 'vertical-scroll' policy is disabled in a document, the contents
cannot be scrolled (will not be user-input scrollable and targeted
for gesture scroll). However, currently disabling 'vertical-scroll'
still leaves the vertical scrollbars behind; the bars position cannot
be changed however.
This CL fixes the issue by hiding the vertical scrollbars for
scrollable elements inside documents where the policy is enforced
(i.e., disabled).
Bug: 898151
Change-Id: If01925e27184a7370d5b12583dc73bc946f2c6e2
Reviewed-on: https://chromium-review.googlesource.com/c/1305878
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604420}
--
wpt-commits: 8295368c82194ac6c1443571bdd57b464bfc55b4
wpt-pr: 13824
Automatic update from web-platform-tests[url] Properly treat '#' as marking the start of the fragment in data URIs
This CL aligns Chromium with the URL spec, such that we consider '#' to
mark the end of the content and the start of the fragment section only.
GURL::GetContent was updated to reflect this, with a special case for
javascript URLs specifically (as their spec mentions including '#' in
the URL content).
This is a reland of I49c6f4d739a2dd42eecc9947f8e75071b84e9be7. Recent data
shows that kDataUriHasOctothorpe is now rare on WebView, and the Chrome
side data has also shifted to be a long tail of smaller users. Plan is to
land this change again and see if anything breaks.
TBR=rdevlin.cronin@chromium.org,mlamouri@chromium.org,pfeldman@chromium.org,boliu@chromium.org
Bug: 123004
Change-Id: Ib72b8eef4bd61db4f2488e522d3d4cfcfa8a1a14
Reviewed-on: https://chromium-review.googlesource.com/c/1297172
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604399}
--
wpt-commits: 154498e346ade38c8df98a7eb8cc98c012e6af9c
wpt-pr: 13725
Automatic update from web-platform-testsUse the light blue WPT logo for the legacy runner (#13814)
We have a nice logo, let's use it more.
--
wpt-commits: 4c7258c980b59fe051cba91bceb30db61bf63186
wpt-pr: 13814
Automatic update from web-platform-testsCope with the mess we leave behind after a continuation.
When an inline object has a block child, we need to split the inline
into two "continuations", wrap them inside separate anonymous blocks,
and put the actual block child(ren) between those anonymous blocks, also
wrapped inside a designated anonymous block.
If we later on remove that block child, we don't tear down the
continuation chain completely. We get rid of all the anononymous blocks,
but keep the two split inlines, that will suddenly become adjacent
siblings. They should ideally be joined back into one layout object, but
we don't do that. And this fix isn't about that (because I really wish
to do other things than just causing and fixing fuzzer crashers for the
rest of this year and half of the next).
Instead, make sure that we cope with bogus continuation chains. The
problem was when an inline that had a bogus continuation chain became
relatively positioned, and we ended up marking a subsequent anonymous
block as relatively-positioned, although none of its children were DOM
children of the inline. This in turn caused trouble for absolute
positioning, after https://chromium-review.googlesource.com/c/1301457 ,
which expects that there be relatively positioned inlines in the
vicinity if an anonymous container with block children is relatively
positioned.
Bug: 900451
Change-Id: Ibde930b12201c10cdf508733d4d182d731e11ecb
Reviewed-on: https://chromium-review.googlesource.com/c/1309777
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604275}
--
wpt-commits: 7eeaa91c39f8d79f565979023c127c3c7d06c7b6
wpt-pr: 13821
Automatic update from web-platform-testsRemove cors/allow-headers.htm
It's a duplicate of an earlier cors/origin.htm and doesn't actually test Access-Control-Allow-Headers.
--
wpt-commits: 1fb4c5a78d1af72228e9371845aa1bbadbb7b3aa
wpt-pr: 13817
Automatic update from web-platform-testsChange "Web Platform Tests" to web-platform-tests runner
--
Update the runner title to match visible heading
--
wpt-commits: 61063897afe2a7ff93fb9a390ebe41c189629d07, ec7f77f1f13a0c3a5cf030d75c9001c91d5b17c2
wpt-pr: 13793
Automatic update from web-platform-tests[wptrunner] Improve errors from Selenium
The `message` computed by the Selenium executor was mistakenly unused,
and in its place, a Python exception object was used to communicate
information on the failure. The string representation of Exceptions is
generally terse and less helpful during debugging. Replace with the
intended value which includes a complete stack trace and the name of the
exception's class.
--
wpt-commits: 958f49205616916cc683851574eaf03974bf8b06
wpt-pr: 13806
Automatic update from web-platform-testsGive `./wpt test-jobs` an `--all` argument (#13801)
This is useful for testing CI changes.
--
wpt-commits: 3422a5df992675ea3e8478504e8be11ef3494b3d
wpt-pr: 13801
Automatic update from web-platform-testsAdds Self Describibing section to rendering docs
--
made the requested changes
--
removing extra line
--
removing one more extra line
--
making rest words non capitalize
--
wpt-commits: 79a7cb3e24c189a43a3a890fc7796132bbd4fd5a, d08838132faa67d3240eb4048c5d8387a0b927a3, ef5f7b1be322d8ed416c44f333fcec1fa255032c, 24123f32aa98effb22ce755aacc8765c0da4a2f8, 0cd1d2859d28fd15f5483c298e7d54b34b5665f0
wpt-pr: 13809
Automatic update from web-platform-testsCheck slot re-assignment for getComputedStyle.
We only checked if we needed to update v0 shadow distribution before
skipping style recalc for getComputedStyle and friends. Slot re-
assignment for shadow dom v1 also needs to be done as it may affect
inheritance ancestors for the element in question.
This may be the reason for issue 900138, but we have no repro, so hard
to say.
Bug: 900138
Change-Id: Ie2ceae97141aabed0e26de3070b1f170e9eedeed
Reviewed-on: https://chromium-review.googlesource.com/c/1307396
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604187}
--
wpt-commits: 4b8cb25d91bc5961fd484a60be9c6c06b12ab744
wpt-pr: 13786
Automatic update from web-platform-testsHTTP/Fetch: combining header values
Tests for both request and response combining.
--
wpt-commits: ba5fce6d64fcb0812ae23306b29721bb961c8d96
wpt-pr: 13471
Automatic update from web-platform-testswebdriver: remove ES6 construct from in-view center point tests (#13799)
Older user agents (read: "Internet Explorer") do not support the
ES6 "fat arrow" construct. Changing the test event handler to the
older function-based syntax.
--
wpt-commits: b704e37ec97fe90b3a3d59c10f78c21907b5b576
wpt-pr: 13799
Automatic update from web-platform-testsRemove some suggested reviewers who have asked to be removed (#13796)
Part of https://github.com/web-platform-tests/wpt/issues/13702.
--
wpt-commits: 75b0f336c50105c6fea47ad253d57219dfa744d3
wpt-pr: 13796
Automatic update from web-platform-testsEnable unified plan by default for Chrome Dev (#13795)
As documented in https://webrtc.org/web-apis/chrome/unified-plan/.
The plan is to enable this by default in Chrome 72, which is the current Chrome
Dev version. Enabling it now will make wpt.fyi more accurate reflect the likely
status of Chrome 72. (It's expected this will cause more tests to pass.)
--
wpt-commits: ced8eec6f128f8766a54ff767bd8db35c636b7fb
wpt-pr: 13795
Automatic update from web-platform-testsHTML: update innerText getter tests to return *inner* text
See https://github.com/whatwg/html/pull/4132
--
wpt-commits: cf0adc7f3d28a354913e252bc8c6228d699440ca
wpt-pr: 13743
Automatic update from web-platform-testsRemove unused code in tools/wpt/utils.py
These were determined to be unused by grepping for the names and looking
at all matches. Note
--
Restore seekable
--
remove unused import
--
wpt-commits: a066f56ff24036e070391fc8527fe3538aab2219, 70abb3d310edc14a8ac91649271c77b8a9206217, 3361ae5e8e8786ffced2d760785817bb51d05288
wpt-pr: 13643
Automatic update from web-platform-testsCall the tools/wpt/ tests simply "tests" (not "unittests") (#13782)
The job name is wpt_integration, and tools/ci/ci_wpt.sh both writes
/etc/hosts and installs Chrome, so these are integration tests. But just
call them tests, like for resources/ and infrastructure/.
--
wpt-commits: 7452fbc120383dbfeae9759baeb9f2fe68cffc1f
wpt-pr: 13782
Automatic update from web-platform-tests[css-properties-values-api] Validate generate_property argument.
This prevents silently dropping invalid arguments. For example, the
following currently generates a non-inherited property:
let name = generate_property(syntax: '<length>', inherited: true);
This is because 'inherited' is not an option for CSS.registerProperty (the
actual option is 'inherits').
With this change, an exception is thrown if unknown options are provided.
R=futhark@chromium.org
Bug: 641877
Change-Id: I7b639651c331aa705416db95a3de751353648031
Reviewed-on: https://chromium-review.googlesource.com/c/1304522
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603862}
--
wpt-commits: add8843a7da2ab5ee5ba329c0ae052573c23cde2
wpt-pr: 13763
Automatic update from web-platform-tests[css-properties-values-api] Test initial values individually.
Split up the assertions of the initial value test into multiple tests.
This makes it possible to add test expectations for things which are not
supported yet.
R=futhark@chromium.org
Bug: 641877
Change-Id: I8756b2d066a8bc2ae542ca033d98754255aeb2b2
Reviewed-on: https://chromium-review.googlesource.com/c/1304560
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603859}
--
wpt-commits: 6014df860a812202756c59f230e9bfafb2c8332c
wpt-pr: 13774
Automatic update from web-platform-tests[css-properties-values-api] Test computed values individually.
- Having large buckets of assertions in the same test is not great if
one of those assertions fail.
- Running all tests twice with and without inherited font size is not
relevant for a large amount of the tests.
Therefore:
- Use only one assertion per test, allowing fine-grained test
expectations.
- Only test inherited font-size for a few relevant cases.
R=futhark@chromium.org
Bug: 641877
Change-Id: I0a26dc29da4ca3be04f33b86bb063e48cb2f4c08
Reviewed-on: https://chromium-review.googlesource.com/c/1304520
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603850}
--
wpt-commits: 704a0dbc3dd38a81085b7b813b5602532a63cabd
wpt-pr: 13780
Automatic update from web-platform-testsConsistently use `manager` for ManagerGroup.pool entries (#13775)
--
wpt-commits: 8bb642da20e51c1e8cb8f8e23b1adeb444ab26ad
wpt-pr: 13775
Automatic update from web-platform-testsIndent `manager_group` method calls to within the `with` scope (#13778)
While variable binding `manager_group` does survive after the `with`
statement, that will be after `__exit__` has been called. That still
works, but there's no reason for the reader to wonder if there's a
difference, whether indentation is intentional.
--
wpt-commits: e2f346f20d1d165360ae7ca7df4b027113c217b0
wpt-pr: 13778
Automatic update from web-platform-testsRemove unused method `ManagerGroup.is_alive()` (#13777)
It's not used internally, and the only `ManagerGroup` instance is
created at `with ManagerGroup(...) as manager_group` in wptrunner.py,
and the method is also not called there.
--
wpt-commits: 086f4ef0144b35ee125d1edfc478632b6885b1c7
wpt-pr: 13777
Automatic update from web-platform-tests[css-properties-values-api] Compute <resolution> values to 'dppx'.
Unfortunately, calc() in <resolution> values is not yet supported in Blink.
(Such values were not allowed for <resolution> before CSS Values and Units
Level 4).
R=futhark@chromium.org
Bug: 641877
Change-Id: I4b3fdcd24f37018a415489e7d15220dc34698c04
Reviewed-on: https://chromium-review.googlesource.com/c/1304554
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603843}
--
wpt-commits: 9d2432a20edd05076fa49f265adeeb64e78a3aba
wpt-pr: 13776
Automatic update from web-platform-testsServiceWorker: Move WPTs for ServiceWorkerContainer.startMessages() into its own file
This CL moves tests for ServiceWorkerContainer.startMessages() and message
queues from postmessage-to-client.https.html to
postmessage-to-client-message-queue.https.html. This doesn't change test
behavior.
The motivations of this change are as follows:
- Tests for startMessages() are timing out on all web browsers[1]. This hides
the results of typical tests for WindowClient.postMessage(), and makes it
difficult to add new tests for WorkerClient.postMessage().
- Test formats are totally different among them. This makes it difficult to read
test scripts.
[1] https://wpt.fyi/results/service-workers/service-worker/postmessage-to-client.https.html?aligned&label=stable
Bug: 894682
Change-Id: Ia66af523ccff4529f85aac23df5059be099290a2
Reviewed-on: https://chromium-review.googlesource.com/c/1307025
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603837}
--
wpt-commits: 899e3a45f8d628c4a7cfb324e031a99f3a4aefdf
wpt-pr: 13770
Automatic update from web-platform-tests[css-properties-values-api] Compute <time> values to seconds.
The CSSPrimitiveValue::IsTime function (non-static) did for some reason
use GetType() instead of TypeWithCalcResolved(), even though both
ComputeSeconds() and TypeWithCalcResolved() do seemingly handle calculated
time correctly.
R=futhark@chromium.org
Bug: 641877
Change-Id: I0e927265f01855b8262ed9201df9eae647171b8d
Reviewed-on: https://chromium-review.googlesource.com/c/1304481
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603832}
--
wpt-commits: 9082397e214eef1fd04e478e353cd0d19a64f040
wpt-pr: 13771
Automatic update from web-platform-tests[filter-effects] Inheritance and initial values (#13105)
Test that Filter Effects properties inherit.
Test that initial values match the spec.
https://drafts.fxtf.org/filter-effects/#property-index
--
wpt-commits: 7b078f0d6ff82157c57f343838f61b5200686e53
wpt-pr: 13105
Automatic update from web-platform-tests[css-properties-values-api] Proper computed value for <color>.
As of an imminent spec change, <color> values no longer compute to their
specified value, but behave like <color> values in general.
Note that color keywords are parsed as CSSIdentifierValue (holding a
CSSValueID), and custom idents are parsed as CSSCustomIdentValue (holding a
String), which is why the "tomato | <color>" works as it should.
R=futhark@chromium.org
Bug: 641877
Change-Id: I946536a9d54dbaa7af589cb99acdba72f37fe016
Reviewed-on: https://chromium-review.googlesource.com/c/1303365
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603628}
--
wpt-commits: 38bb114c431508bf122a9699869c7a72e4feb5b3
wpt-pr: 13761
Razvan Maries
Andreea Pavel
Valentin Gosu
Sebastian Hengst
Jonathan Kingston
Coroiu Cristina
James Graham
moz-wptsync-bot
Mason Freed
Daniel Vogelheim
qiuzhong
Morten Stenshorne
Antoine Quint
Joshua Bell
Anne van Kesteren
Florian Rivoal
Mark Roberts
jimevans
CYBAI
Sandra Sun
Mike Pennisi
autofoolip
Eric Willigers
Douglas Creager
Dominic Farolino
Ahilya Sinha
Guido Urdaneta
Luke Bjerring
John Chen
Kent Tamura
Yutaka Hirano
Max Rebuschatis
aestes
pyup.io bot
François REMY
L. David Baron
youennf
Adam Rice
Rayan Kanso
Žan Doberšek
Luna Lu
Geoffrey Sneddon
Philip Jägenstedt
Eric Willigers
Hiroki Nakagawa
Koji Ishii
Gary Katsevman
Youenn Fablet
Charles Vazac
Marcos Cáceres
Jan-Ivar Bruaroey
Dmitry Titov
Henrik Boström
Tomoyuki Shimizu
Philipp Hancke
Christian Bromann
Lan Wei
Francois Remy
Emircan Uysaler
Ian Clelland
Zhuoyu Qian
Andy Paicu
Brian Grinstead
Boris Chiou
Blake Kaplan
Nils Ohlmeier [:drno]
Bumsik Kim
Cosmin Sabou
Narcis Beleuzu
Byron Campen [:bwc]
Perry Jiang
Wes Kocher
Emilio Cobos Álvarez
Harald Alvestrand
Jinho Bang
Soares Chen
Bernard Aboba
Philipp Hancke
Andreas Butler
Javier Fernandez
Avi Drissman
Robert Ma
Donna Wu
Rune Lillesveen
YUHAN WU
Anders Hartvoll Ruud
Yoshifumi Inoue
Chris Dumez
mark a. foltz
Wanming Lin
HyeockJinKim
Christian Biesinger
Ehsan Karamad
Stephen McGruer
championshuttler
Simon Pieters