Since we moved to warp, this debug statement was printing the
unprocessed path (i.e `/session/{sessionId}`) because the closure didn't
know about the real path that was called (it only knew about the route
that was triggered and the parameters that were passed).
I added a warp filter to get the unprocessed full path to be able to
make logging useful again. This also fixes the body which had an extra
Result around it when it was debugged.
Differential Revision: https://phabricator.services.mozilla.com/D37156
--HG--
extra : moz-landing-system : lando
This allows for easy support for HEAD requests without any code on our
side.
Differential Revision: https://phabricator.services.mozilla.com/D34631
--HG--
extra : moz-landing-system : lando
In particular:
* trait objects without an explicit `dyn` are deprecated
* `...` range patterns are deprecated
I think these shouldn't really warn by default and should be clippy / opt-in
lints, but anyway, doesn't hurt.
Differential Revision: https://phabricator.services.mozilla.com/D35135
--HG--
extra : moz-landing-system : lando
Add tests that check serialization and deserialization for indefinite script timeout
Differential Revision: https://phabricator.services.mozilla.com/D17148
--HG--
extra : moz-landing-system : lando
It fixes the regression from the transition to Serde (bug 1396821),
which accidentally denied unknown fields.
Differential Revision: https://phabricator.services.mozilla.com/D17634
--HG--
extra : moz-landing-system : lando
It fixes the regression from the transition to Serde (bug 1396821),
which accidentally denied unknown fields.
Differential Revision: https://phabricator.services.mozilla.com/D17634
--HG--
extra : moz-landing-system : lando
As we move away from #ateam we need to make sure we that we point people to
the correct IRC Channel
Differential Revision: https://phabricator.services.mozilla.com/D16547
--HG--
extra : moz-landing-system : lando
The Content-Type header contains the correct MIME type, but the
charset option is "utf8" and invalid: it should be "utf-8".
Differential Revision: https://phabricator.services.mozilla.com/D12116
--HG--
extra : moz-landing-system : lando
This emits a warning when the webdriver library reverts to using the
legacy Selenium-styled capabilities negotiation for new sessions.
It provides a helpful link which will explain to users how to update.
Differential Revision: https://phabricator.services.mozilla.com/D7305
--HG--
extra : moz-landing-system : lando
The refactoring of the webdriver crate to use Serde (bug 1396821)
caused this regression. By instructing Serde to correctly rename
both properties fixes it.
Differential Revision: https://phabricator.services.mozilla.com/D7079
--HG--
extra : moz-landing-system : lando
Removes the non-standard /session/{session id}/element/{element
id}/tap endpoint command from geckodriver.
Differential Revision: https://phabricator.services.mozilla.com/D6879
--HG--
extra : moz-landing-system : lando
The rules in the .gitignore file are duplicated by the root-level
.gitignore file, and the .hgignore file does not take effect because
hg does not subdirectory ignore files.
DONTBUILD
To keep backward compatibility, the legacy "ELEMENT" key for an
instance of PointerOrigin has to be supported, but ignored.
This workaround can be removed once legacy support gets dropped
from geckodriver.
--HG--
extra : rebase_source : 9b098010d6f880eafc8d0223e17f47d8e5d15d7d
Instead of making explicit calls to iterator protocol methods such as
x.iter() or x.into_iter(), we can loop over references to collections.
This is considered better style.
We clone merged_capabilities in the CapabilitiesMatching implementation
for SpecNewSessionParameters::match_browser using x.map(|x| x.clone()),
but this can be simplified to x.cloned().
In some places we pass variables by value unnecessarily. In these
cases it would be more memory efficient to pass a reference so that
we avoid copying.
Instead of using a catch-all that ignores the error cause, we can
print the cause as part of the panic.
Eventually the error handling in this function should be fixed to
not panic at all, obviously.
Bastien Orivel
Emilio Cobos Álvarez
Nupur Baghel
championshuttler
Alexis Beingessner
Henrik Skupin
reimu
Csoregi Natalia
David Burns
Cameron McCormack
Andreas Tolfsen
Ciure Andrei
Kerem Kat