1) Added some comments to firefox.js to explain the relationship between
extensions.blocklist.interval and security.onecrl.maximum_staleness_in_seconds
2) Modified default values in firefox.js and mobile.js to set maximum staleness
to 1.25x blocklist interval
3) modified the tests_ev_certs.js xpcshell test to cope with larger maximum
staleness values to address test failures
This is a Fennec version of about:accounts, cribbed largely from
Desktop's implementation. This implementation serves two purposes:
One, it allows all fxa-content-server pref handling to remain in
Gecko. Java-side consumers redirect to about:accounts?action=... and
have pref munging and parameter addition (like context=fx_fennec_v1,
etc) handled by about:accounts itself.
Two, it handles network connectivity display and error handling. When
a request is started, we display an animated spinner. We transition
smoothly from the spinner to the iframe display if we can, and if not
we hide any network error and offer to retry. This is more important
in Fennec than it is on Desktop. This approach agrees with Firefox
for iOS.
Some additional notes:
The spinner to iframe transition uses the WebChannel listener to send
LOADED messages to the appropriate XUL <browser> element. It's worth
remembering that Fennec's Gecko is single process, so the <browser> in
question is in the same process. None-the-less, we are close to e10s
safe.
There are four actions: signup/signin/force_reauth, and manage. The
first three try to produce a LOGIN message. The last uses the
fxa-content-server to manage the Account settings. *This is not how
this is arranged on Desktop: Desktop redirects to a new tab, not
wrapped in about:accounts.*
--HG--
extra : commitid : F2waTwe355B
extra : rebase_source : f63c96f676d1300c774d091968ec8d88bb7a86dc
This list is not meant to be exhaustive. There are many ways to get
to the Get Started activity; not all of them are interesting. We're
just trying to capture the significant entrypoints, like firstrun and
preferences.
--HG--
extra : commitid : 6NI5PTknABt
extra : rebase_source : bb376e316cf3c68388506e1805ce33b749db324f
Pretty straight-forward. It's possible that getStringExtra is not
safe in the face of malicious data; the worst we might expect is a
crash on the Java side; a large memory allocation on the JS side; or
significant URL data transfer. The first is valuable because we'd see
abusers in crash-stats; and the second two are already possible when
opening any URL.
--HG--
extra : commitid : GZNHCgMWFt5
extra : rebase_source : dfb88da52ef0449246ba54d460a4653170542b69
This also skips the tab queue when opening other links internally,
like the FxA Terms of Service and Privacy Policy.
--HG--
extra : commitid : H9f8Gur7qMg
extra : rebase_source : 21cda6d413871e20b22eca4dd4bc95127250bec6
The spinner itself is 60px square, colored like fennec_ui_orange.
The HTML and CSS was hacked out of
https://github.com/lightningtgc/material-refresh, tree
6b1be0046d.
The original code is licensed MIT. I pruned things we don't use,
adjusted the box model for our use, changed the spinner color, and
simplified the CSS.
--HG--
extra : commitid : yncLSrgF9z
extra : rebase_source : 02dc83cbb189fb8fa7ff5b1f75d6407a4601d1d5
Now Fennec can use the message from Gecko with the zoom constraints and we can
delete a bunch of code that did the equivalent job in browser.js
--HG--
extra : commitid : 20xL8HASMlt
The default zoom value is only used on the Java side to clamp the min/max zoom
values in the case where zooming is disabled. We can do this much earlier in
the flow, when we are computing the metadata, and reduce the amount of
redundant information being passed around.
--HG--
extra : commitid : AdyBXqXiIaW
From browser.js's point of view there's no difference between restricted and guest profiles. Both use the
parental controls API. So there are only two "simple" solutions here:
* 1) Add a method to nsIParentalControlsService to determine whether the current profiles is a restricted or
a guest profile (Something like isGuest()). But then every platform using this interface would require
to at least implement a stub for this method.
* 2) Add a new restriction that controls installing the theme.
This patch implements option 2. While this restriction is not of much use besides deciding whether we need
to install a specialized theme (DISALLOW_DEFAULT_THEME), it still offers the most flexibility. In a
follow-up bug we could decide to make the restriction configurable by the device admin (requires localized
strings).
--HG--
extra : commitid : 1HcJmNLuz7b
extra : rebase_source : d43407713b7d41a546213e75b7d5e4f03a8b3d78
This patch creates a copy of the GeckoAppBase style in v21/themes.xml and removes
the custom icons for copy, cut and paste we use on v11+. Instead the system icons,
that match the look&feel of the ActionBar, will be used.
--HG--
extra : commitid : bb07iANzjF
extra : rebase_source : 3b057830c78f5cac1361474d3c60eeaf86eda1d6
extra : amend_source : 86e0168b47967e3e66cd36b151b33ccefd2e2af7
To do this, I ran:
convert <image> -alpha extract -alpha on <image>
The resultant images were slightly larger than their previous
counterparts so I then compressed them with ImageOptim.
--HG--
extra : commitid : KJ2wVCoGpWp
extra : rebase_source : c53cf14e32c8904e2ed2403f32bc8cb87245c465
DONTBUILD NPOTB
This adds a pass-thru |mach android| command. It's just here to make
it easier to add and remove Android SDK packages: since most folks
don't have the Android tools on their PATH, this saves them having to
root through the object directory to find the path to the tool.
--HG--
extra : commitid : HgCtltLK3V4
extra : rebase_source : 6c7db25c10b643c8fe655976e613c29db7cd0bc4
extra : histedit_source : fd95eb809a901fd3873968117c60966f3f82790c
DONTBUILD NPOTB
Straight from http://stackoverflow.com/a/24751182 and the linked
IntelliJ tickets.
--HG--
extra : commitid : AcbSF0042KW
extra : rebase_source : f67e9eecfdf3f452e4fd55901f8eb42b0f3ed22c
Other 3-dot menu button locations to follow.
I tested that the colors are correct in the various states (e.g. private
browsing).
This patch additionally:
* Restructured the menu button (which allowed the removal of a setVisibility
call
* Removed the now unused tablet assets.
--HG--
extra : commitid : 5AzCA3B3KHo
extra : rebase_source : b2ba9b4052cf94f8af4c4cb39b3f5f1f250d3b17
And replace the older assets.
These are the 36dp icons from Google's material design page:
https://www.google.com/design/icons/#ic_more_vert
Then we trim off the whitespace with image magick:
convert icon.png -trim out.png
And compress with ImageOptim.
--HG--
extra : commitid : 2KxoyvO50be
extra : rebase_source : 23535bb72fa7cc99f9e6a9b1efbf9e4c3f3a84f0
This also involved moving a redundant background declaration to only the
containing style.
--HG--
rename : mobile/android/base/resources/drawable/action_bar_button.xml => mobile/android/base/resources/drawable/menu_item_action_bar_bg.xml
extra : commitid : GFUgNsiZgGb
extra : rebase_source : 4a3c03b50f923e50bf99effea9b9d34813adb40b
These appear to have been added in the initial implementation of this feature.
--HG--
extra : commitid : KIlolzsFEyi
extra : rebase_source : 0351ba974ed6624c6f767146a39443f5704a57ab
On Gingerbread devices (Android API 9 or 10) the ViewHelper.setTranslationY code
doesn't work to move the SurfaceView. In order to acheive that effect I turned
LayerView into a ScrollView with a dummy element at the top, and allow it to
scroll. This allows the SurfaceView to move as desired. A few places in the code
were assuming that the LayerView and SurfaceView were always at the same screen
location (which was true before but not any more) and so those sites needed
some updating as well.
--HG--
extra : commitid : Jpr1k74MOAD
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
The annotated methods were using @JNITarget, which would do the same thing.
However, @ReflectionTarget is clearer (like a good variable name).
proguard.cfg states a class with an annotated member will be kept so we
shouldn't need to worry about not being able to retrieve the class via
reflection.
--HG--
extra : commitid : 9ji4YNIP4GE
extra : rebase_source : 780f1d1dd4fcc95545152d19896db0a376f38d48
This is a clone of @JNITarget and @RobocopTarget.
--HG--
extra : commitid : AhiQ1OmtCY0
extra : rebase_source : 6fb3880e2368a163292b968084991ca965a12211
extra : source : 62dbceeb9f18238ed2725564db03a2a2c6491f94
I previously set this for tablet but didn't (for an unknown reason) set this
for phones as well.
--HG--
rename : mobile/android/base/resources/color-large-v11/action_bar_secondary_menu_item_colors.xml => mobile/android/base/resources/color/action_bar_secondary_menu_item_colors.xml
extra : commitid : 9xV13qVkTCr
extra : rebase_source : f5c310d1ac68096be557a8992ba366bb0c99df0a
This doesn't appear in Fennec builds and I don't know which web apps "quit"
could appear in so I didn't test this in a web app. I can confirm no issues
with a typical Fennec build, however.
--HG--
extra : commitid : LbNepxFEs3P
extra : rebase_source : 687af1c7750c4fb0f3c866dfcaae8291494e146c
This also removes code to set an icon from an addon, which is unused because,
afaik, addons' icons are also hidden. iirc, there was a bug open on whether we
want addons to be able to show icons (e.g. could be used to show status), but
we can reimplement this if that bug is ever decided.
I was not able to test this with an addon that sets an icon but I did test that
the application did not crash with no addons installed.
--HG--
extra : commitid : BI54BWOip3Y
extra : rebase_source : d170349006588ebcecab4817bb5d3388467106e7
On GB devices, ic_menu_new_*tab is in the base menu, unlike the other
configurations, so it stayed on GB.
More complex removals to follow.
I tested this by clicking on all of the base menu items on a Lollipop phone,
KitKat large tablet, and a GB phone.
--HG--
extra : commitid : EBgTEO7y9qt
extra : rebase_source : 30c880c2d36c5f5336af50a5460f3bb1d6578117
Moving speculative connection from CLH to GeckoApp allows us to start
the speculative connection very early in the startup process rather
than later in startup.
One thing we do in the Fennec CLH is to make a speculative connection
based on the URI that's passed in. However, by the time the CLH runs,
we're far along into startup, and the advantage of a speculative
connection is reduced. This patch implements making speculative
connection as a method in GeckoThread, so that Fennec can make a
speculative connection without relying on the Fennec CLH.
Many Gecko operations depend on the profile being available. This
patch adds a PROFILE_READY Gecko state so that we can queue calls
until profile is loaded.
Many calls are associated with a Gecko state when they become available.
For example, calls that only depend on XPCOM become available very early
in startup, at the JNI_READY state. However, calls that depend on JS
components may only be available at the end of startup, at the RUNNING
state.
This patch adds an available state to every queued call, so that calls
can be made as soon as they become available, which is important for
calls like making speculative connections.
The enabled/disabled colors are set via ColorStateLists so the alpha
is unnecessary.
--HG--
extra : commitid : 3u4xoGQlD3E
extra : rebase_source : 0b9868ed14ad54d8de17f2b4cd12185b78e1c22a
This patch has a side effect of changing the color of the forward
button as it animates forward and back, but it's minimal enough
that I'm okay with it, and it cleans up disabled/private state color
management (particularly after the following patch).
--HG--
extra : commitid : B1r30FDcCZv
extra : rebase_source : 1107016d428ac01c6331048b415736b79c634529
Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.
Additionally, fix a bug about using android:tint when drawableTintList was not
used.
--HG--
extra : commitid : AZiAsNQkD4c
extra : rebase_source : c54b361b27aa6b7d14c030409ad86531a9516549
Currently, all versions of Firefox run with the existing native
Firefox Account UI. This flag will opt-in to maintaining that
experience while we transition to a web account UI. Once we're stable
on the web, we'll remove this flag entirely.
--HG--
extra : commitid : CmokCKcYNJQ
extra : rebase_source : eb7e8f136f9a5134f84c8dbe111841b72827146a
Note that this file is auto-generated from generate_themed_views.py.
--HG--
extra : commitid : 2b6fhN8Wts0
extra : rebase_source : bc26ceb131a74434d99695660fd104893a16d5b7
This was originally implemented in bug 1169435 but not carried over to the
template.
--HG--
extra : commitid : 6apREWAyPi2
extra : rebase_source : 31d415df11eae0141df70e03b7c59b6f28aeaa2a
DONTBUILD NPOTB
This means we don't require the directory in the object directory at
gradle-install time. We're not concerned if the resource files are
missing, since we have code to ensure they're fresh already; and if
they are missing, we'll quickly fail as we try to process the resource
set.
--HG--
extra : histedit_source : 04767c8e86c7012ed3c46564e5660b17e1355607
extra : rebase_source : 658cedf4a698d603571153cefb128b87a6ad6a2e
extra : commitid : DIwvp3ib9Z9
extra : source : 00e1cd6d04c03a65433b01cea194edf7c9d7c835
extra : amend_source : 244a950264c0d10cf495a3a7d7d5ef52eab2da14
This means we don't require the directory in the object directory at
gradle-install time. We're not concerned if the source files are
missing, since we have code to ensure they're fresh already; and if
they are missing, we'll quickly fail as we try to compile with missing
sources.
--HG--
extra : commitid : IIuTcQiEJ37
extra : rebase_source : 640e8f2005b71d1c79719dcecc56efb8540341fa
extra : source : f8bc8f04b3c01cf62403f09cc3a4b37826e280bc
extra : histedit_source : 34335f47dd33a07585ef8e8a24bdc7cb43b62239
This allows us to not require dist/fennec/* to exist in the object
directory at gradle-install time. It gets us one small step closer to
being able to sit down to a fresh source tree and open a Fennec
project in IntelliJ.
--HG--
extra : commitid : KNnKth56I1L
extra : rebase_source : b4fae1033335760dd3d6d9b8b71ffb7bbb1a6906
extra : source : 7b5b6adc5ac69fd733f9937dd846c52bff36af0a
extra : histedit_source : cb05d3690f909db51cd6116cc80b070f62338001
This was just an oversight. The Gradle configuration referenced
topsrcdir rather than having a symlink via the objdir. This didn't
impact the Gradle build, but it did make the preprocessed_code Gradle
project appear outside of the root Gradle project in IntelliJ.
--HG--
extra : commitid : As00AcCfYkr
extra : rebase_source : 1d5b79f5e4439306a5a9e7d625e39ef97d37d1eb
extra : source : fcec6d827887e3e64ebd610ef4f893d11dde52ab
extra : histedit_source : 70790f27c201462e5346660f5eb39e39303bdc8d
It's convenient to know that the object directory is up-to-date (after
|make gradle-targets|) before any Gradle project builds.
--HG--
extra : commitid : 2WaqMEqw3mx
extra : rebase_source : 2dea8249b329d82d9c89b5defa7e13d4aff60566
extra : source : eb170abcc91b4714874e97b58b371e242aee9699
extra : histedit_source : 92a62bd75dfa289f3ede4592d4a224ad135d3b6b
We could remove tablet_* and move these values to the values-large
configuration but it's scope creeping for not much gain. The
attributes are prepended with tablet_* so they should be easy to
fix in the future should we choose to.
Refactoring automated w/ Intellij.
--HG--
extra : commitid : 5hpv5cg2MUF
extra : rebase_source : 696b181495e6943effd40f0db5051c647ab54bda
DONTBUILD NPOTB
We're seeing build failures since 6.5.+ doesn't match 6.5.87. This
shouldn't be fuzzy, and it shouldn't be an ancient version of Google
Play Services either. (In moz.build local builds , we're using a much
more recent version. In automation, I'm not certain what we're
using.)
--HG--
extra : commitid : 6EjfXxM9FJy
We were doing this on tablets but I forgot to add the lines to make it work on
phones.
--HG--
rename : mobile/android/base/resources/color-large-v11/action_bar_menu_item_colors.xml => mobile/android/base/resources/color/action_bar_menu_item_colors.xml
extra : commitid : 7mMxelznMN2
extra : rebase_source : 8407550ba68936fcc4eb344680a6c578d18707c5
Michael Comella
Allison Naaktgeboren
Carsten "Tomcat" Book
Martyn Haigh
Prateek Arora
Gian-Carlo Pascutto
Phil Ringnalda
Mark Goodwin
Ms2ger
Ehsan Akhgari
Kartikaya Gupta
Shu-yu Guo
Chenxia Liu
Nick Alexander
Wes Kocher
Fabrice Desré
James Willcox
Florian Quèze
dominique vincent
Sebastian Kaspari
Margaret Leibovic
Ryan VanderMeulen
Mark Finkle
Garvan Keeley
vivek
Mantaroh Yoshinaga
Myk Melez
Nicholas Nethercote
Geoff Brown
Ahmed Khalil
Justin Inouye
Yury Delendik
Jim Chen
Jonathan Almeida [:jonalmeida]
Mike Taylor
William Chen