It's a bit strange for the editor to distrust the parser service in this way.
The double-checking seems unnecessary, especially given that it is *buggy*: it
incorrectly includes `col`, `colgroup`, and `legend` as block elements, but
excludes `pre`. (It must only be called in situations where these
incorrectly-classified elements are not passed in, otherwise it would have
triggered by now.) So this patch removes it.
The patch also removes `li` and `pre` from the IsAnyOfHTMLElements() test in
HTMLEditor::NodeIsBlockStatic. Contrary to what the comment in
NodeIsBlockStatic() says, they *are* identified as block elements by the parser
service.
--HG--
extra : rebase_source : c9bb3c9e07320fafed17942229c316f41ac2a0a6
The patch uses the nsParserService method names (minus the "HTML" prefix)
because they are more descriptive. This will make it easier to replace
nsParserService method calls with nsHTMLTags method calls.
The patch also adds nsHTMLTags::AtomTagToId(), to match up with
nsParserService::HTMLAtomTagToId().
--HG--
extra : rebase_source : 278c53a0787a928de9477dd30a5fd037791d7990
The tint logic for menu icons on different devices is:
Normal mode:
1. Mobile & small tablet -> dark color(#272727)
2. Large tablet -> dark color(#272727)
Private mode:
1. Mobile & small tablet -> dark color(#272727)
2. Large tablet -> light color(#38383D)
MozReview-Commit-ID: 9cz53PieQHY
--HG--
extra : rebase_source : 780a3ae9701d30672153801c88ade56c081a64d1
Currently, Gecko converts lengths in stroke-* properties to numbers when
creating animation values and hence the result of animation is always a unitless
value for these properties.
Servo, on the other hand, converts lengths for these properties to numbers
during interpolation and hence sometimes the result of animation is a unitless
value, and other times (such as when skipping interpolation) it is not.
Other browsers produce lengths with px units and ultimately we should align
with that behavior. As a result, this patch updates various SMIL mochitests to:
* Expect animation values with px unit
* Compare values by stripping px units as a temporary measure until we
correctly serialize these values with px (bug 1379908).
MozReview-Commit-ID: IsT26DKkgiP
--HG--
extra : rebase_source : 8d8dee6ad53d29801096d3affe996e4df1a9388c
When channel registrations aren't explicitly unregistred from JS, they're
instead unregistered when the entry object is cycle collected. When the
entries are created close to shutdown, that can leave some uncertainty as to
the order of destruction, and the WebRequestService might wind up being
destroyed before all of the entries. In that case, the registrations are
cleaned up when the hash entries hash table is being destroyed.
While that isn't strictly a problem, the entries expect to still be present in
the hash table when they're being destroyed, as a basic sanity check. This
patch ensures that we always remove entries from the hash table before it's
destroyed, so those invariants are maintained.
MozReview-Commit-ID: 5jWpFeFyjJZ
--HG--
extra : rebase_source : 9598a628b43208cd7a26c68cb888847429ca4e93
extra : amend_source : 407732f81531b0e1f7bd0a6483cd16b4e60a31b0
Nicholas Nethercote
Franziskus Kiefer
Sebastian Hengst
Christoph Kerschbaumer
Kevin Jones
Rei Colina
Jing-wei Wu
Mantaroh Yoshinaga
Ting-Yu Lin
Kris Maglione
ffxbld
Xidorn Quan
Ryan VanderMeulen
Jean-Yves Avenard
Jeff Gilbert
Steve Armand
Anthony Ramine
davidmurray
Shane Caraveo
Chenxia Liu