Nathan Froyd
27c58cf89f
Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian
2017-06-21 12:59:28 -04:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Wes Kocher
c0e1236f1a
Merge autoland to m-c a=merge
...
MozReview-Commit-ID: LFtpTAueYrF
2017-06-20 18:24:29 -07:00
Carsten "Tomcat" Book
de892834ed
Merge mozilla-central to mozilla-inbound
2017-06-20 11:31:34 +02:00
Doug Thayer
d65c88d3f0
Bug 1166166 - Shrink storage cache off main thread r=mak
...
Per bug: it can take around 200ms to shrink memory for
Places.sqlite. This can end up janking the browser if we hit a
memory-pressure. This patch simply removes the #if DEBUG guards
around the mAsyncExecutionThreadIsAlive boolean which is already
being updated and exposes it so that we can shrink memory off
the main thread when possible.
MozReview-Commit-ID: LoDGKrOXs8u
--HG--
extra : rebase_source : adf03f187e7297835566f3bac92a8be8a6147131
2017-06-01 14:46:53 -07:00
Marco Bonardo
8d20cc6802
Bug 1355561 - Add a new API to spinningly close the database when strictly needed, and ensure Close() does what it's named after. r=asuth
...
Introduce a new SpinningSynchronousClose API that allows to synchronously close
a connection that executed asynchronous statements, by spinning the events loop.
This is expected to be used rarely in particular cases like database corruption.
It is currently [noscript] since the only consumer is cpp, in the future we can
evaluate removing that, if we find more uses for it.
MozReview-Commit-ID: 7SPqutoF9jJ
--HG--
extra : rebase_source : d053e308192f335dfdca089668e56115b068ff8c
2017-04-12 17:44:39 +02:00
Carsten "Tomcat" Book
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405
)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bevis Tseng
d1637b9c5a
Bug 1372453 - Part 2: Name the caller of ProxyReleaseEvent. r=billm
...
MozReview-Commit-ID: LYhSWnZkq0i
2017-06-14 09:27:17 +08:00
Marco Bonardo
1d88de7d2f
Bug 1371945 - Avoid a possible thread-safety problem with unfinalized statements. r=asuth
...
Avoids a thread-safety race condition on shutdown where we could try to finalize a statement twice.
Allows the async thread to be referenced until ShutdownAsyncThread, so async finalizers can make use of it.
Removes the no more useful mAsyncExecutionThreadIsAlive.
Nullifies the sqlite3_mutex pointer when the connection is closed, since it would be a dangling pointer.
Use a ScopeExit to ensure the connection and the mutex pointers are always nullified on failure.
Makes asyncClose bailout early if a Close method was already invoked before.
Makes AsyncInitDatabase not use AsyncClose to just shutdown the async thread.
Fixes various unfinalized statements in consumers code.
Makes mConnectionClosed better follow mDBConn status.
Replaces some mutex locking isClosed() calls with lockless isConnectionReadyOnThisThread.
MozReview-Commit-ID: 6sftFehsQTt
--HG--
extra : rebase_source : 2bf3088b500376e58e62e8f078d9950588adc649
2017-06-16 17:43:23 +02:00
Mark Banner
0ce286101c
Bug 1359011 - Make the mozilla/recommended eslint configuration the default for the whole tree. r=mossop
...
MozReview-Commit-ID: HtUW43tCli1
--HG--
extra : rebase_source : 6496bc47860d9c1ab522a78e73b41550700021cb
2017-04-25 20:12:21 +01:00
Mike Hommey
1a9d4c6f33
Bug 1363992 - Remove support for system jemalloc. r=njn
...
--HG--
extra : rebase_source : 9141402b6f9e84c67afc14303633d328eb5b652c
2017-05-11 13:03:20 +09:00
Nathan Froyd
c1d1748428
Bug 1359490 - add an event loop spinning abstraction function; r=gerald
...
This function is arguably nicer than calling NS_ProcessNextEvent
manually, is slightly more efficient, and will enable better auditing
for NS_ProcessNextEvent when we do Quantum DOM scheduling changes.
2017-05-15 09:34:19 -04:00
Tom Tromey
99f4608655
Bug 1334278 - change mozilla::Smprintf to return a UniquePtr; r=froydnj
...
Change mozilla::Smprintf and friends to return a UniquePtr, rather than
relying on manual memory management. (Though after this patch there are
still a handful of spots needing SmprintfFree.)
MozReview-Commit-ID: COa4nzIX5qa
--HG--
extra : rebase_source : ab4a11b4d2e758099bd0794d5c25d799a7e42680
2017-03-03 08:17:27 -07:00
Florian Queze
f935ddc4b3
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Queze
37ff4fc7cc
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
Sebastian Hengst
738d097aae
Backed out changeset 55f3df15eaa6 (bug 1356569)
2017-04-14 23:39:17 +02:00
Florian Queze
3c564a2b02
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Queze
95d4d20c17
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Mark Banner
585bf398ea
Bug 1342459 - Enable no-undef on browser/base, and clean up unnecessary no-undef references. r=mossop
...
MozReview-Commit-ID: KVrAnAjMD1E
--HG--
extra : rebase_source : 7a9651c055e2c6e959d42d08e5be9de2e2265346
2017-04-03 11:46:56 +01:00
Sajid Ahmed
591da76059
Bug 1007034 - Add console warnings for the deprecated BindXXXParameter methods in mozIStorageBaseStatement and replace calls to the deprecated methods in dom/indexedDB/ActorsParent.cpp. r=mak
...
--HG--
extra : rebase_source : ac32534d36959ff7f3a1c3a382319e6de4225c2f
2017-04-05 14:08:25 -04:00
Randell Jesup
41c4f44c15
Bug 1350752: Cleanup async mozStorage callback management r=layzell
...
MozReview-Commit-ID: 6LS1Strqu6s
2017-03-28 06:54:02 -04:00
Mark Banner
d7d8be9285
Bug 1347712 - Move toolkit/.eslintrc.js rules into a 'recommended' set within eslint-plugin-mozilla. r=jaws
...
MozReview-Commit-ID: Jy4apKnmWcV
--HG--
rename : toolkit/.eslintrc.js => tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
extra : rebase_source : ae0c740c1c2a9cf620c1ac34024622ade12e6fd4
2017-03-22 10:43:00 +01:00
Mark Banner
bd625e4e9f
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
...
MozReview-Commit-ID: LH0CQOPfoe6
--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
David Major
dc67bfc9a3
Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron
...
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());
This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.
I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.
MozReview-Commit-ID: Kh1rUziVllo
--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae
2017-03-14 15:26:27 +13:00
Iris Hsiao
5cece96e1c
Backed out 12 changesets (bug 1344629) for stylo build bustage
...
Backed out changeset cf4273d3ac30 (bug 1344629)
Backed out changeset a96390e044e0 (bug 1344629)
Backed out changeset d9b330f9bc24 (bug 1344629)
Backed out changeset 2b460fe020af (bug 1344629)
Backed out changeset 0ada91b0452e (bug 1344629)
Backed out changeset 083304fcd6bd (bug 1344629)
Backed out changeset 53d7d1ce2c97 (bug 1344629)
Backed out changeset 55eee7078ae4 (bug 1344629)
Backed out changeset 7d3c06b3eca9 (bug 1344629)
Backed out changeset e5df14c3db61 (bug 1344629)
Backed out changeset 636095ff2815 (bug 1344629)
Backed out changeset 0be052ad24c1 (bug 1344629)
2017-03-14 11:52:24 +08:00
David Major
40f4821701
Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron
...
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());
This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.
I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.
MozReview-Commit-ID: Kh1rUziVllo
--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae
2017-03-14 15:26:27 +13:00
Marco Bonardo
34e590459b
Bug 1342441 - Improve the Wrong Sqlite Version message. r=asuth
...
MozReview-Commit-ID: FVFw9XjpzOb
--HG--
extra : rebase_source : ddb91ba2fba1b19927200832a6e0b119f9547b91
2017-02-24 17:39:30 +01:00
Joel Maher
d637db915a
Bug 1341799 - annotate storage/* with BUG_COMPONENT in moz.build files. r=mak
...
MozReview-Commit-ID: 3g7WuMN6hR7
2017-02-23 08:01:50 -05:00
Wes Kocher
8c4ce17711
Merge inbound to m-c a=merge
...
MozReview-Commit-ID: DCUf7VEDrTt
2017-02-17 13:38:51 -08:00
Vedant Sareen
7d4bd52fae
Bug 1330907 - Rename Telemetry::ID to Telemetry::HistogramID. r=dexter
...
Changed |print("enum ID : uint32_t {", file=output)| to |print("enum HistogramID : uint32_t {", file=output)| at line 53 of the file |toolkit/components/telemetry/gen-histogram-enum.py|, and then replaced all the textual occurrences of |Telemetry::ID| to |Telemetry::HistogramID| and |ID| to |HistogramID| in 43 other files.
2017-02-16 00:45:15 +05:30
Tom Tromey
5f8f360823
Bug 1060419 - make log_print use Printf.h, r=froydnj
...
MozReview-Commit-ID: BIZ1GQEZ1vs
--HG--
extra : rebase_source : 2f1f0aa12493c44f352d9a7e8683e7bb72d2d75b
2016-12-15 20:16:31 -07:00
Tom Tromey
42eaec768d
Bug 1060419 - make mozStorageConnection.cpp and mozStorageStatement.cpp use Printf.h, r=froydnj
...
MozReview-Commit-ID: Gy2CLg9AVpG
--HG--
extra : rebase_source : 06f66468d0d11346efab403729a2f62c437c5206
2016-12-09 10:27:17 -10:00
Zibi Braniecki
b8f991e41b
Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame
...
MozReview-Commit-ID: 5GEnL7Kihpj
--HG--
extra : rebase_source : 413d880035b49da82db0530379425d31ac31a82e
2017-02-07 12:52:03 -08:00
Wes Kocher
a9ce32d9a5
Backed out 2 changesets (bug 1335983) for build bustage a=backout
...
Backed out changeset 5a9559ded976 (bug 1335983)
Backed out changeset de2b0d90e2da (bug 1335983)
MozReview-Commit-ID: 377KQDU1QqJ
2017-02-07 12:34:30 -08:00
Zibi Braniecki
6d98bad59d
Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame
...
MozReview-Commit-ID: bJVrVj2dAS
--HG--
extra : rebase_source : f3a28e003415f0c58462a73b5fd987455e102fc5
2017-02-06 14:57:09 -08:00
Nicholas Nethercote
22b6d342d7
Bug 1333296 (part 1) - Rename MOZ_ENABLE_PROFILER_SPS as MOZ_GECKO_PROFILER. r=mstange,glandium.
...
--HG--
extra : rebase_source : 223f3a17f009645369be503392cc1f0cea7f19a1
2017-01-24 14:15:12 +11:00
Bill McCloskey
ef3d0f1c2e
Bug 1331804 - Add more runnable names (r=ehsan)
...
MozReview-Commit-ID: 1QBmqfgY6WI
2017-01-24 16:34:37 -08:00
Wes Kocher
f7ccafcb58
Backed out 8 changesets (bug 1331804, bug 1332100) for windows vm debug dt5 failures a=backout
...
Backed out changeset 8bf7f0e27c6c (bug 1331804)
Backed out changeset 600c0b9026c2 (bug 1331804)
Backed out changeset 3a5b5b9ecace (bug 1331804)
Backed out changeset c76432c9954e (bug 1331804)
Backed out changeset 46a9096745e7 (bug 1332100)
Backed out changeset 8b751230fa23 (bug 1331804)
Backed out changeset 2810212347fd (bug 1331804)
Backed out changeset be72b7763910 (bug 1331804)
MozReview-Commit-ID: Ywdsr4GZ4a
2017-01-24 15:12:21 -08:00
Bill McCloskey
80aaeed2fc
Bug 1331804 - Add more runnable names (r=ehsan)
...
MozReview-Commit-ID: 1QBmqfgY6WI
2017-01-24 10:04:55 -08:00
Nicholas Nethercote
bf48aecf29
Bug 1332172 - Remove XPC_MAP_WANT_*. r=mccr8.
...
nsIXPCScriptable flags handling in xpc_map_end.h is a bit of a mess.
- Half the flags relate to whether various functions are defined (PreCreate,
GetProperty, etc). These are set using the XPC_MAP_WANT_* macros;
for each one xpc_map_end.h inserts the corresponding flag using the
preprocessor (see XPC_MAP_CLASSNAME::GetScriptableFlags()).
- The other half of the flags relate to other things (IS_GLOBAL_OBJECT,
DONT_REFLECT_INTERFACE_NAMES, etc). These are set using the XPC_MAP_FLAGS
macro.
Having two similar but different mechanisms to set the flags for a class is
confusing. (Indeed, until recently we had some classes where a single flag was
redundantly specified via both mechanisms.) Note also that the classes done in
dom/base/nsIDOMClassInfo.h also specify all the flags in a single value,
similar to how XPC_MAP_FLAGS works.
This patch removes the XPC_MAP_WANT_* macros. All flags are now set
via XPC_MAP_FLAGS. This is a significant simplification to xpc_map_end.h and
all the places that use it.
The downside of this change is that I had to change the flag constants from
class constants (i.e. nsIXPCScriptable::FOO) to macros (i.e.
NSIXPCSCRIPTABLE_FOO) because they need to be used in #if statements like this
in xpc_map_end.h:
#if !((XPC_MAP_FLAGS) & NSIXPCSCRIPTABLE_WANT_PRECREATE)
and you can't use a '::'-qualified name inside a #if. I think this downside is
outweighed by the simplification described above.
Overall the patch removes 80 lines of code.
--HG--
extra : rebase_source : 6d5c341d0deba8f1529d81c17bb8819e09620b05
2017-01-23 13:33:58 +11:00
Mark Banner
16e6d381ac
Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
...
MozReview-Commit-ID: 62Hp5ISxowJ
--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
2017-01-18 10:30:39 +00:00
Jan Beich
13885f1a7b
Bug 1330359 - Fix building with -Werror for non-SPS platforms. r=mstange
...
MozReview-Commit-ID: Ifb3zyGHn7U
--HG--
extra : rebase_source : 9b0e06b7f9e984d5c475e59ad7864a039eb8a695
2017-01-11 17:22:19 +00:00
Jared Wein
43bac26d30
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Markus Stange
9c6944dca7
Bug 1323100 - Use nsThreadPoolNaming::GetNextThreadName and NS_NewNamedThread for the mozStorage thread. r=froydnj
...
MozReview-Commit-ID: 145CjwiQawB
--HG--
extra : rebase_source : 81a22eb81ba02ae822e95b6def4b34e112e79abe
2016-12-20 14:20:15 +01:00
Markus Stange
692210bd80
Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
...
MozReview-Commit-ID: 7W1dt2BBKJZ
--HG--
extra : rebase_source : c7e335dac2e0f02782f0eb229a7181c8d01317a2
2016-12-21 11:43:50 +01:00
Mark Banner
80afb72ae6
Bug 1328851
- Enable eslint rule no-undef for storage/. r=mak
...
MozReview-Commit-ID: AemgF8H2ySH
--HG--
extra : rebase_source : dcbc2210fcfc9abf0e96b38b9306fd158f9dcfed
2017-01-05 11:54:49 +00:00
Jared Wein
9141469edf
Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
...
MozReview-Commit-ID: FuVu8skcqOe
--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Wes Kocher
26a1ba5c14
Backed out 27 changesets (bug 1323100) for clipboard leaktest failures a=backout
...
Backed out changeset 84fb749698ab (bug 1323100)
Backed out changeset d6d25e8bd001 (bug 1323100)
Backed out changeset 1b0855bb0c38 (bug 1323100)
Backed out changeset b6953e3f5739 (bug 1323100)
Backed out changeset 5572f3b63215 (bug 1323100)
Backed out changeset 12fb4c533659 (bug 1323100)
Backed out changeset c36524e4e919 (bug 1323100)
Backed out changeset 1e3b3eddbe26 (bug 1323100)
Backed out changeset 061110f1ae12 (bug 1323100)
Backed out changeset 413dbd31725b (bug 1323100)
Backed out changeset 06550f7eca62 (bug 1323100)
Backed out changeset 940933b13b36 (bug 1323100)
Backed out changeset a6d75c1cd724 (bug 1323100)
Backed out changeset 681cacbbaa3b (bug 1323100)
Backed out changeset 3d53787293f6 (bug 1323100)
Backed out changeset c0340dfe4766 (bug 1323100)
Backed out changeset 9f554991549d (bug 1323100)
Backed out changeset 757539e7039a (bug 1323100)
Backed out changeset a3c9b45aa917 (bug 1323100)
Backed out changeset 23d69df98a66 (bug 1323100)
Backed out changeset 1297ded6a01d (bug 1323100)
Backed out changeset f4235b97257f (bug 1323100)
Backed out changeset 93419cb4f29f (bug 1323100)
Backed out changeset 865d1b81c804 (bug 1323100)
Backed out changeset 54acf4ef8e84 (bug 1323100)
Backed out changeset 88d17bcd8205 (bug 1323100)
Backed out changeset 0c466e5e8933 (bug 1323100)
2016-12-29 16:28:36 -08:00
Markus Stange
882a11ecd0
Bug 1323100 - Use nsThreadPoolNaming::GetNextThreadName and NS_NewNamedThread for the mozStorage thread. r=froydnj
...
MozReview-Commit-ID: 145CjwiQawB
--HG--
extra : rebase_source : 9403849151907d2437f6874f8a7bd4d539394417
2016-12-20 14:20:15 +01:00
Markus Stange
1b72f37c98
Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
...
MozReview-Commit-ID: 7W1dt2BBKJZ
--HG--
extra : rebase_source : ad47978ef81d048a90b9803803201eee32974024
2016-12-21 11:43:50 +01:00
Jared Wein
ecab54a7c9
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Nicholas Nethercote
df925b776c
Bug 1321374 - Simplify js::Class handling relating to nsIXPCScriptable. r=mccr8, sr=bholley.
...
This patch removes XPCNativeScriptableShared and XPCNativeScriptableSharedMap,
which results in a net reduction of ~100 lines of code.
2016-12-14 08:33:46 +11:00
Mark Banner
4f94e4bd68
Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop
...
MozReview-Commit-ID: CiIsUjQzp4D
--HG--
extra : rebase_source : 1b98e88673625a52ef82c1fad5d56aec3e2e8e80
2016-11-09 22:06:32 +00:00
Tomislav Jurin
348bfffc19
Bug 1296189 - Replace NS_RUNTIMEABORT("some string literal message") with MOZ_CRASH(). r=froydnj
2016-12-02 13:46:53 -08:00
Phil Ringnalda
feef954874
Merge m-i to m-c, a=merge
...
MozReview-Commit-ID: EDVoIcyWOhi
--HG--
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
2016-11-22 20:03:03 -08:00
Nicholas Nethercote
7e1a8cf56c
Bug 1315138 - gtestify storage/test/*.cpp. r=mak,erahm.
...
This change is mostly straightforward, except for the following.
- It removes all the printing from the do_check_* macros because gtest macros
do appropriate printing.
- test_StatementCache.cpp needs some special gtest magic for the type
parameterization.
- It merges the four tests in test_unlock_notify.cpp because they rely on being
executed in order, and so aren't independent.
- storage_test_harness_tail.h is no longer necessary because gtest provides the
test looping functionality.
- It uses #include and the preprocessor to remove the duplication between
test_deadlock_detector.cpp and xpcom/tests/DeadlockDetector.cpp.
- It makes the test in test_service_init_background_thread.cpp a death test to
force it to be the first storage gtest, because it fails otherwise.
- It adds code to undo the SQLite mutex hooking as necessary, so that tests
don't interfere with each other.
- It de-virtualizes Spinner's destructor (as identified in bug 1318282).
--HG--
rename : storage/test/storage_test_harness.h => storage/test/gtest/storage_test_harness.h
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_StatementCache.cpp => storage/test/gtest/test_StatementCache.cpp
rename : storage/test/test_asyncStatementExecution_transaction.cpp => storage/test/gtest/test_asyncStatementExecution_transaction.cpp
rename : storage/test/test_async_callbacks_with_spun_event_loops.cpp => storage/test/gtest/test_async_callbacks_with_spun_event_loops.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_deadlock_detector.cpp => storage/test/gtest/test_deadlock_detector.cpp
rename : storage/test/test_file_perms.cpp => storage/test/gtest/test_file_perms.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
rename : storage/test/test_service_init_background_thread.cpp => storage/test/gtest/test_service_init_background_thread.cpp
rename : storage/test/test_statement_scoper.cpp => storage/test/gtest/test_statement_scoper.cpp
rename : storage/test/test_transaction_helper.cpp => storage/test/gtest/test_transaction_helper.cpp
rename : storage/test/test_true_async.cpp => storage/test/gtest/test_true_async.cpp
rename : storage/test/test_unlock_notify.cpp => storage/test/gtest/test_unlock_notify.cpp
extra : rebase_source : dbb695c112564efa1945116be1a8435988982e74
2016-11-11 09:59:23 +11:00
Andi-Bogdan Postelnicu
64312a6104
Bug 1318282 - Use C++11's override and remove virtual where applicable in storage/. r=mak
...
MozReview-Commit-ID: AXchuOpF65X
--HG--
extra : rebase_source : 47536d5918bdb66cd467a1c31ca6545817e922d3
2016-11-17 12:36:25 +02:00
Andi-Bogdan Postelnicu
7f5f07c638
Bug 1318282 - Replace string literals containing escaped characters with raw string literals in storage/. r=mak
...
MozReview-Commit-ID: 7iVr1Ug0Oot
--HG--
extra : rebase_source : 7590b2f78454d2497dcc7f9c4275e463a2fe6c81
2016-11-17 12:35:02 +02:00
Andi-Bogdan Postelnicu
e874c4bda7
Bug 1318282 - Replace default bodies of special member functions with = default; in storage/. r=mak
...
MozReview-Commit-ID: DLgi8Oa7X2b
--HG--
extra : rebase_source : b18f05c361469d5d276c8a80b371aa001ec58cd4
2016-11-17 12:34:23 +02:00
Andi-Bogdan Postelnicu
a71b3f4e14
Bug 1318282 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in storage/. r=mak
...
MozReview-Commit-ID: HuudUDUcQYu
--HG--
extra : rebase_source : 2b7591b118fea1e0a1b42ae929106191e2b2e1f6
2016-11-17 12:33:18 +02:00
Dave Townsend
8de07a19a0
Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
...
MozReview-Commit-ID: 2ZvTiZDHchz
--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Marco Bonardo
a587089548
Bug 1313021 - Use a MEMORY SQLITE_TEMP_STORE on Android and 64bit builds. r=asuth
...
MozReview-Commit-ID: IeXOY3tTStq
--HG--
extra : rebase_source : a5457303a07751cc9d3c1861630636b15cce8a9f
2016-11-03 22:11:59 +01:00
Sebastian Hengst
f8c9d72cfd
Bug 1310297 - Remove test annotations using b2g, mulet or gonk: storage. r=RyanVM
...
MozReview-Commit-ID: D3QcehYvTpx
--HG--
extra : rebase_source : 842c9bd007676e1d760eaca67e3eb30cb751d5de
2016-11-05 11:29:21 +01:00
Marco Bonardo
100acd6188
Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. r=asuth
...
MozReview-Commit-ID: 2QR8P7ylg9m
--HG--
extra : rebase_source : 37ed75d0cf724a6c373df6d12df1f36fddc0a646
2016-11-03 21:04:00 +01:00
Marco Bonardo
1dd813abd5
Bug 835796 - Negative value in about:memory storage/sqlite/other due to double-counting of shared-cache connections. r=asuth
...
MozReview-Commit-ID: 2rO5sApv6rn
--HG--
extra : rebase_source : bf1150a3c00b1a8f66cc86ec5fff8d4d1dd24360
2016-11-03 23:14:35 +01:00
Marco Bonardo
462eaac7b8
Bug 1313310 - Use SQLITE_OMIT_DEPRECATED. r=asuth
...
MozReview-Commit-ID: C4pZ6EP799G
--HG--
extra : rebase_source : 5d213471d4d6785abe5ac79a6696b47b6681cc6e
2016-11-03 20:14:03 +01:00
Jared Wein
87b2d4c295
Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
...
MozReview-Commit-ID: HIUTSdkXxbY
--HG--
extra : rebase_source : 2f05e2f275ac7f293f9c650bdec8943189e3ce01
2016-11-03 14:42:06 -04:00
Marco Bonardo
792726a2c3
Bug 1310152 - AsyncClone may try to reuse a freed Critical Section in Sqlite. r=asuth
...
MozReview-Commit-ID: LW0esWlNfQQ
--HG--
extra : rebase_source : 59e2510a9d4c2343dcde91a572a3d354a15c162f
2016-11-03 15:31:31 +01:00
Jared Wein
5040f17e00
Bug 1312486
- Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
...
MozReview-Commit-ID: 7Gx90a5y8t6
--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Jan Varga
1ec718d61d
Bug 964561 - Part 10: Fix a possible leak in BindAdoptedBlobByName()/BindAdoptedBlobByIndex(); r=mak
2016-10-25 21:18:37 +02:00
Mark Banner
56a7b3961a
Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
...
MozReview-Commit-ID: JrbFxQ5rj6I
--HG--
rename : .eslintrc => .eslintrc.js
rename : accessible/.eslintrc => accessible/.eslintrc.js
rename : accessible/tests/browser/.eslintrc => accessible/tests/browser/.eslintrc.js
rename : browser/.eslintrc => browser/.eslintrc.js
rename : browser/base/content/test/alerts/.eslintrc => browser/base/content/test/alerts/.eslintrc.js
rename : browser/base/content/test/chrome/.eslintrc => browser/base/content/test/chrome/.eslintrc.js
rename : browser/base/content/test/general/.eslintrc => browser/base/content/test/general/.eslintrc.js
rename : browser/base/content/test/newtab/.eslintrc => browser/base/content/test/newtab/.eslintrc.js
rename : browser/base/content/test/plugins/.eslintrc => browser/base/content/test/plugins/.eslintrc.js
rename : browser/base/content/test/popupNotifications/.eslintrc => browser/base/content/test/popupNotifications/.eslintrc.js
rename : browser/base/content/test/referrer/.eslintrc => browser/base/content/test/referrer/.eslintrc.js
rename : browser/base/content/test/social/.eslintrc => browser/base/content/test/social/.eslintrc.js
rename : browser/components/contextualidentity/test/browser/.eslintrc => browser/components/contextualidentity/test/browser/.eslintrc.js
rename : browser/components/customizableui/test/.eslintrc => browser/components/customizableui/test/.eslintrc.js
rename : browser/components/dirprovider/tests/unit/.eslintrc => browser/components/dirprovider/tests/unit/.eslintrc.js
rename : browser/components/downloads/test/browser/.eslintrc => browser/components/downloads/test/browser/.eslintrc.js
rename : browser/components/downloads/test/unit/.eslintrc => browser/components/downloads/test/unit/.eslintrc.js
rename : browser/components/extensions/.eslintrc => browser/components/extensions/.eslintrc.js
rename : browser/components/extensions/test/browser/.eslintrc => browser/components/extensions/test/browser/.eslintrc.js
rename : browser/components/extensions/test/xpcshell/.eslintrc => browser/components/extensions/test/xpcshell/.eslintrc.js
rename : browser/components/feeds/test/.eslintrc => browser/components/feeds/test/.eslintrc.js
rename : browser/components/feeds/test/chrome/.eslintrc => browser/components/feeds/test/chrome/.eslintrc.js
rename : browser/components/feeds/test/unit/.eslintrc => browser/components/feeds/test/unit/.eslintrc.js
rename : browser/components/migration/tests/unit/.eslintrc => browser/components/migration/tests/unit/.eslintrc.js
rename : browser/components/newtab/tests/browser/.eslintrc => browser/components/newtab/tests/browser/.eslintrc.js
rename : browser/components/newtab/tests/xpcshell/.eslintrc => browser/components/newtab/tests/xpcshell/.eslintrc.js
rename : browser/components/originattributes/test/browser/.eslintrc => browser/components/originattributes/test/browser/.eslintrc.js
rename : browser/components/places/tests/browser/.eslintrc => browser/components/places/tests/browser/.eslintrc.js
rename : browser/components/places/tests/chrome/.eslintrc => browser/components/places/tests/chrome/.eslintrc.js
rename : browser/components/places/tests/unit/.eslintrc => browser/components/places/tests/unit/.eslintrc.js
rename : browser/components/preferences/in-content/tests/.eslintrc => browser/components/preferences/in-content/tests/.eslintrc.js
rename : browser/components/privatebrowsing/test/browser/.eslintrc => browser/components/privatebrowsing/test/browser/.eslintrc.js
rename : browser/components/safebrowsing/content/test/.eslintrc => browser/components/safebrowsing/content/test/.eslintrc.js
rename : browser/components/search/test/.eslintrc => browser/components/search/test/.eslintrc.js
rename : browser/components/selfsupport/test/.eslintrc => browser/components/selfsupport/test/.eslintrc.js
rename : browser/components/sessionstore/test/.eslintrc => browser/components/sessionstore/test/.eslintrc.js
rename : browser/components/sessionstore/test/unit/.eslintrc => browser/components/sessionstore/test/unit/.eslintrc.js
rename : browser/components/shell/test/.eslintrc => browser/components/shell/test/.eslintrc.js
rename : browser/components/shell/test/unit/.eslintrc => browser/components/shell/test/unit/.eslintrc.js
rename : browser/components/tests/browser/.eslintrc => browser/components/tests/browser/.eslintrc.js
rename : browser/components/translation/test/.eslintrc => browser/components/translation/test/.eslintrc.js
rename : browser/components/translation/test/unit/.eslintrc => browser/components/translation/test/unit/.eslintrc.js
rename : browser/components/uitour/test/.eslintrc => browser/components/uitour/test/.eslintrc.js
rename : browser/experiments/test/xpcshell/.eslintrc => browser/experiments/test/xpcshell/.eslintrc.js
rename : browser/extensions/formautofill/.eslintrc => browser/extensions/formautofill/.eslintrc.js
rename : browser/extensions/formautofill/test/browser/.eslintrc => browser/extensions/formautofill/test/browser/.eslintrc.js
rename : browser/extensions/pdfjs/test/.eslintrc => browser/extensions/pdfjs/test/.eslintrc.js
rename : browser/modules/test/.eslintrc => browser/modules/test/.eslintrc.js
rename : browser/modules/test/unit/social/.eslintrc => browser/modules/test/unit/social/.eslintrc.js
rename : browser/modules/test/xpcshell/.eslintrc => browser/modules/test/xpcshell/.eslintrc.js
rename : devtools/.eslintrc => devtools/.eslintrc.js
rename : devtools/.eslintrc.mochitests => devtools/.eslintrc.mochitests.js
rename : devtools/.eslintrc.xpcshell => devtools/.eslintrc.xpcshell.js
rename : devtools/client/aboutdebugging/test/.eslintrc => devtools/client/aboutdebugging/test/.eslintrc.js
rename : devtools/client/animationinspector/test/.eslintrc => devtools/client/animationinspector/test/.eslintrc.js
rename : devtools/client/animationinspector/test/unit/.eslintrc => devtools/client/animationinspector/test/unit/.eslintrc.js
rename : devtools/client/canvasdebugger/test/.eslintrc => devtools/client/canvasdebugger/test/.eslintrc.js
rename : devtools/client/commandline/test/.eslintrc => devtools/client/commandline/test/.eslintrc.js
rename : devtools/client/debugger/new/test/mochitest/.eslintrc => devtools/client/debugger/new/test/mochitest/.eslintrc.js
rename : devtools/client/debugger/test/.eslintrc => devtools/client/debugger/test/.eslintrc.js
rename : devtools/client/dom/.eslintrc => devtools/client/dom/.eslintrc.js
rename : devtools/client/dom/test/.eslintrc => devtools/client/dom/test/.eslintrc.js
rename : devtools/client/framework/test/.eslintrc => devtools/client/framework/test/.eslintrc.js
rename : devtools/client/inspector/.eslintrc => devtools/client/inspector/.eslintrc.js
rename : devtools/client/inspector/components/test/.eslintrc => devtools/client/inspector/components/test/.eslintrc.js
rename : devtools/client/inspector/computed/test/.eslintrc => devtools/client/inspector/computed/test/.eslintrc.js
rename : devtools/client/inspector/fonts/test/.eslintrc => devtools/client/inspector/fonts/test/.eslintrc.js
rename : devtools/client/inspector/markup/test/.eslintrc => devtools/client/inspector/markup/test/.eslintrc.js
rename : devtools/client/inspector/rules/test/.eslintrc => devtools/client/inspector/rules/test/.eslintrc.js
rename : devtools/client/inspector/shared/test/.eslintrc => devtools/client/inspector/shared/test/.eslintrc.js
rename : devtools/client/inspector/test/.eslintrc => devtools/client/inspector/test/.eslintrc.js
rename : devtools/client/jsonview/.eslintrc => devtools/client/jsonview/.eslintrc.js
rename : devtools/client/jsonview/test/.eslintrc => devtools/client/jsonview/test/.eslintrc.js
rename : devtools/client/memory/test/browser/.eslintrc => devtools/client/memory/test/browser/.eslintrc.js
rename : devtools/client/memory/test/unit/.eslintrc => devtools/client/memory/test/unit/.eslintrc.js
rename : devtools/client/netmonitor/.eslintrc => devtools/client/netmonitor/.eslintrc.js
rename : devtools/client/netmonitor/har/test/.eslintrc => devtools/client/netmonitor/har/test/.eslintrc.js
rename : devtools/client/netmonitor/test/.eslintrc => devtools/client/netmonitor/test/.eslintrc.js
rename : devtools/client/performance/test/.eslintrc => devtools/client/performance/test/.eslintrc.js
rename : devtools/client/performance/test/unit/.eslintrc => devtools/client/performance/test/unit/.eslintrc.js
rename : devtools/client/projecteditor/test/.eslintrc => devtools/client/projecteditor/test/.eslintrc.js
rename : devtools/client/promisedebugger/test/.eslintrc => devtools/client/promisedebugger/test/.eslintrc.js
rename : devtools/client/responsive.html/test/browser/.eslintrc => devtools/client/responsive.html/test/browser/.eslintrc.js
rename : devtools/client/responsive.html/test/unit/.eslintrc => devtools/client/responsive.html/test/unit/.eslintrc.js
rename : devtools/client/responsivedesign/test/.eslintrc => devtools/client/responsivedesign/test/.eslintrc.js
rename : devtools/client/scratchpad/test/.eslintrc => devtools/client/scratchpad/test/.eslintrc.js
rename : devtools/client/shadereditor/test/.eslintrc => devtools/client/shadereditor/test/.eslintrc.js
rename : devtools/client/shared/components/.eslintrc => devtools/client/shared/components/.eslintrc.js
rename : devtools/client/shared/components/test/browser/.eslintrc => devtools/client/shared/components/test/browser/.eslintrc.js
rename : devtools/client/shared/components/test/mochitest/.eslintrc => devtools/client/shared/components/test/mochitest/.eslintrc.js
rename : devtools/client/shared/shim/test/.eslintrc => devtools/client/shared/shim/test/.eslintrc.js
rename : devtools/client/shared/test/.eslintrc => devtools/client/shared/test/.eslintrc.js
rename : devtools/client/shared/test/unit/.eslintrc => devtools/client/shared/test/unit/.eslintrc.js
rename : devtools/client/sourceeditor/.eslintrc => devtools/client/sourceeditor/.eslintrc.js
rename : devtools/client/sourceeditor/test/.eslintrc => devtools/client/sourceeditor/test/.eslintrc.js
rename : devtools/client/storage/test/.eslintrc => devtools/client/storage/test/.eslintrc.js
rename : devtools/client/styleeditor/test/.eslintrc => devtools/client/styleeditor/test/.eslintrc.js
rename : devtools/client/webaudioeditor/test/.eslintrc => devtools/client/webaudioeditor/test/.eslintrc.js
rename : devtools/client/webconsole/net/.eslintrc => devtools/client/webconsole/net/.eslintrc.js
rename : devtools/client/webconsole/net/test/mochitest/.eslintrc => devtools/client/webconsole/net/test/mochitest/.eslintrc.js
rename : devtools/client/webconsole/net/test/unit/.eslintrc => devtools/client/webconsole/net/test/unit/.eslintrc.js
rename : devtools/client/webconsole/new-console-output/test/.eslintrc => devtools/client/webconsole/new-console-output/test/.eslintrc.js
rename : devtools/client/webconsole/test/.eslintrc => devtools/client/webconsole/test/.eslintrc.js
rename : devtools/client/webide/test/.eslintrc => devtools/client/webide/test/.eslintrc.js
rename : devtools/server/tests/browser/.eslintrc => devtools/server/tests/browser/.eslintrc.js
rename : devtools/server/tests/mochitest/.eslintrc => devtools/server/tests/mochitest/.eslintrc.js
rename : devtools/server/tests/unit/.eslintrc => devtools/server/tests/unit/.eslintrc.js
rename : devtools/shared/heapsnapshot/tests/unit/.eslintrc => devtools/shared/heapsnapshot/tests/unit/.eslintrc.js
rename : devtools/shared/platform/content/.eslintrc => devtools/shared/platform/content/.eslintrc.js
rename : devtools/shared/platform/content/test/.eslintrc => devtools/shared/platform/content/test/.eslintrc.js
rename : devtools/shared/security/tests/unit/.eslintrc => devtools/shared/security/tests/unit/.eslintrc.js
rename : devtools/shared/tests/browser/.eslintrc => devtools/shared/tests/browser/.eslintrc.js
rename : devtools/shared/tests/unit/.eslintrc => devtools/shared/tests/unit/.eslintrc.js
rename : devtools/shared/transport/tests/unit/.eslintrc => devtools/shared/transport/tests/unit/.eslintrc.js
rename : devtools/shared/webconsole/test/unit/.eslintrc => devtools/shared/webconsole/test/unit/.eslintrc.js
rename : devtools/shared/worker/tests/browser/.eslintrc => devtools/shared/worker/tests/browser/.eslintrc.js
rename : mobile/android/components/extensions/.eslintrc => mobile/android/components/extensions/.eslintrc.js
rename : mobile/android/components/extensions/test/mochitest/.eslintrc => mobile/android/components/extensions/test/mochitest/.eslintrc.js
rename : security/manager/.eslintrc.json => security/manager/.eslintrc.js
rename : security/manager/ssl/tests/.eslintrc.json => security/manager/ssl/tests/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/browser/.eslintrc.json => security/manager/ssl/tests/mochitest/browser/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/mixedcontent/.eslintrc.json => security/manager/ssl/tests/mochitest/mixedcontent/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/stricttransportsecurity/.eslintrc.json => security/manager/ssl/tests/mochitest/stricttransportsecurity/.eslintrc.js
rename : security/manager/ssl/tests/unit/.eslintrc.json => security/manager/ssl/tests/unit/.eslintrc.js
rename : security/manager/tools/.eslintrc.json => security/manager/tools/.eslintrc.js
rename : storage/.eslintrc => storage/.eslintrc.js
rename : testing/mochitest/browser.eslintrc => testing/mochitest/browser.eslintrc.js
rename : testing/mochitest/chrome.eslintrc => testing/mochitest/chrome.eslintrc.js
rename : testing/mochitest/mochitest.eslintrc => testing/mochitest/mochitest.eslintrc.js
rename : testing/xpcshell/xpcshell.eslintrc => testing/xpcshell/xpcshell.eslintrc.js
rename : toolkit/.eslintrc => toolkit/.eslintrc.js
rename : toolkit/components/aboutmemory/tests/.eslintrc => toolkit/components/aboutmemory/tests/.eslintrc.js
rename : toolkit/components/aboutperformance/tests/browser/.eslintrc => toolkit/components/aboutperformance/tests/browser/.eslintrc.js
rename : toolkit/components/addoncompat/tests/browser/.eslintrc => toolkit/components/addoncompat/tests/browser/.eslintrc.js
rename : toolkit/components/alerts/test/.eslintrc => toolkit/components/alerts/test/.eslintrc.js
rename : toolkit/components/asyncshutdown/tests/xpcshell/.eslintrc => toolkit/components/asyncshutdown/tests/xpcshell/.eslintrc.js
rename : toolkit/components/autocomplete/tests/unit/.eslintrc => toolkit/components/autocomplete/tests/unit/.eslintrc.js
rename : toolkit/components/captivedetect/test/unit/.eslintrc => toolkit/components/captivedetect/test/unit/.eslintrc.js
rename : toolkit/components/commandlines/test/unit/.eslintrc => toolkit/components/commandlines/test/unit/.eslintrc.js
rename : toolkit/components/commandlines/test/unit_unix/.eslintrc => toolkit/components/commandlines/test/unit_unix/.eslintrc.js
rename : toolkit/components/commandlines/test/unit_win/.eslintrc => toolkit/components/commandlines/test/unit_win/.eslintrc.js
rename : toolkit/components/contentprefs/tests/mochitest/.eslintrc => toolkit/components/contentprefs/tests/mochitest/.eslintrc.js
rename : toolkit/components/contentprefs/tests/unit/.eslintrc => toolkit/components/contentprefs/tests/unit/.eslintrc.js
rename : toolkit/components/contentprefs/tests/unit_cps2/.eslintrc => toolkit/components/contentprefs/tests/unit_cps2/.eslintrc.js
rename : toolkit/components/crashes/tests/xpcshell/.eslintrc => toolkit/components/crashes/tests/xpcshell/.eslintrc.js
rename : toolkit/components/crashmonitor/test/unit/.eslintrc => toolkit/components/crashmonitor/test/unit/.eslintrc.js
rename : toolkit/components/ctypes/tests/chrome/.eslintrc => toolkit/components/ctypes/tests/chrome/.eslintrc.js
rename : toolkit/components/ctypes/tests/unit/.eslintrc => toolkit/components/ctypes/tests/unit/.eslintrc.js
rename : toolkit/components/downloads/test/unit/.eslintrc => toolkit/components/downloads/test/unit/.eslintrc.js
rename : toolkit/components/extensions/.eslintrc => toolkit/components/extensions/.eslintrc.js
rename : toolkit/components/extensions/test/mochitest/.eslintrc => toolkit/components/extensions/test/mochitest/.eslintrc.js
rename : toolkit/components/extensions/test/xpcshell/.eslintrc => toolkit/components/extensions/test/xpcshell/.eslintrc.js
rename : toolkit/components/feeds/test/.eslintrc => toolkit/components/feeds/test/.eslintrc.js
rename : toolkit/components/filepicker/test/unit/.eslintrc => toolkit/components/filepicker/test/unit/.eslintrc.js
rename : toolkit/components/filewatcher/tests/xpcshell/.eslintrc => toolkit/components/filewatcher/tests/xpcshell/.eslintrc.js
rename : toolkit/components/formautofill/test/browser/.eslintrc => toolkit/components/formautofill/test/browser/.eslintrc.js
rename : toolkit/components/formautofill/test/chrome/.eslintrc => toolkit/components/formautofill/test/chrome/.eslintrc.js
rename : toolkit/components/formautofill/test/xpcshell/.eslintrc => toolkit/components/formautofill/test/xpcshell/.eslintrc.js
rename : toolkit/components/jsdownloads/test/browser/.eslintrc => toolkit/components/jsdownloads/test/browser/.eslintrc.js
rename : toolkit/components/jsdownloads/test/data/.eslintrc => toolkit/components/jsdownloads/test/data/.eslintrc.js
rename : toolkit/components/jsdownloads/test/unit/.eslintrc => toolkit/components/jsdownloads/test/unit/.eslintrc.js
rename : toolkit/components/lz4/tests/xpcshell/.eslintrc => toolkit/components/lz4/tests/xpcshell/.eslintrc.js
rename : toolkit/components/mediasniffer/test/unit/.eslintrc => toolkit/components/mediasniffer/test/unit/.eslintrc.js
rename : toolkit/components/narrate/.eslintrc => toolkit/components/narrate/.eslintrc.js
rename : toolkit/components/narrate/test/.eslintrc => toolkit/components/narrate/test/.eslintrc.js
rename : toolkit/components/osfile/tests/mochi/.eslintrc => toolkit/components/osfile/tests/mochi/.eslintrc.js
rename : toolkit/components/osfile/tests/xpcshell/.eslintrc => toolkit/components/osfile/tests/xpcshell/.eslintrc.js
rename : toolkit/components/passwordmgr/.eslintrc => toolkit/components/passwordmgr/.eslintrc.js
rename : toolkit/components/passwordmgr/test/.eslintrc => toolkit/components/passwordmgr/test/.eslintrc.js
rename : toolkit/components/passwordmgr/test/browser/.eslintrc => toolkit/components/passwordmgr/test/browser/.eslintrc.js
rename : toolkit/components/passwordmgr/test/unit/.eslintrc => toolkit/components/passwordmgr/test/unit/.eslintrc.js
rename : toolkit/components/perf/.eslintrc => toolkit/components/perf/.eslintrc.js
rename : toolkit/components/perfmonitoring/tests/browser/.eslintrc => toolkit/components/perfmonitoring/tests/browser/.eslintrc.js
rename : toolkit/components/places/tests/.eslintrc => toolkit/components/places/tests/.eslintrc.js
rename : toolkit/components/places/tests/bookmarks/.eslintrc => toolkit/components/places/tests/bookmarks/.eslintrc.js
rename : toolkit/components/places/tests/browser/.eslintrc => toolkit/components/places/tests/browser/.eslintrc.js
rename : toolkit/components/places/tests/chrome/.eslintrc => toolkit/components/places/tests/chrome/.eslintrc.js
rename : toolkit/components/places/tests/expiration/.eslintrc => toolkit/components/places/tests/expiration/.eslintrc.js
rename : toolkit/components/places/tests/favicons/.eslintrc => toolkit/components/places/tests/favicons/.eslintrc.js
rename : toolkit/components/places/tests/history/.eslintrc => toolkit/components/places/tests/history/.eslintrc.js
rename : toolkit/components/places/tests/migration/.eslintrc => toolkit/components/places/tests/migration/.eslintrc.js
rename : toolkit/components/places/tests/network/.eslintrc => toolkit/components/places/tests/network/.eslintrc.js
rename : toolkit/components/places/tests/queries/.eslintrc => toolkit/components/places/tests/queries/.eslintrc.js
rename : toolkit/components/places/tests/unifiedcomplete/.eslintrc => toolkit/components/places/tests/unifiedcomplete/.eslintrc.js
rename : toolkit/components/places/tests/unit/.eslintrc => toolkit/components/places/tests/unit/.eslintrc.js
rename : toolkit/components/promiseworker/tests/xpcshell/.eslintrc => toolkit/components/promiseworker/tests/xpcshell/.eslintrc.js
rename : toolkit/components/prompts/test/.eslintrc => toolkit/components/prompts/test/.eslintrc.js
rename : toolkit/components/remotebrowserutils/tests/browser/.eslintrc => toolkit/components/remotebrowserutils/tests/browser/.eslintrc.js
rename : toolkit/components/satchel/test/.eslintrc => toolkit/components/satchel/test/.eslintrc.js
rename : toolkit/components/satchel/test/browser/.eslintrc => toolkit/components/satchel/test/browser/.eslintrc.js
rename : toolkit/components/satchel/test/unit/.eslintrc => toolkit/components/satchel/test/unit/.eslintrc.js
rename : toolkit/components/search/tests/xpcshell/.eslintrc => toolkit/components/search/tests/xpcshell/.eslintrc.js
rename : toolkit/components/social/test/xpcshell/.eslintrc => toolkit/components/social/test/xpcshell/.eslintrc.js
rename : toolkit/components/sqlite/tests/xpcshell/.eslintrc => toolkit/components/sqlite/tests/xpcshell/.eslintrc.js
rename : toolkit/components/startup/tests/browser/.eslintrc => toolkit/components/startup/tests/browser/.eslintrc.js
rename : toolkit/components/startup/tests/unit/.eslintrc => toolkit/components/startup/tests/unit/.eslintrc.js
rename : toolkit/components/telemetry/tests/unit/.eslintrc => toolkit/components/telemetry/tests/unit/.eslintrc.js
rename : toolkit/components/terminator/tests/xpcshell/.eslintrc => toolkit/components/terminator/tests/xpcshell/.eslintrc.js
rename : toolkit/components/thumbnails/test/.eslintrc => toolkit/components/thumbnails/test/.eslintrc.js
rename : toolkit/components/timermanager/tests/unit/.eslintrc => toolkit/components/timermanager/tests/unit/.eslintrc.js
rename : toolkit/components/url-classifier/tests/mochitest/.eslintrc => toolkit/components/url-classifier/tests/mochitest/.eslintrc.js
rename : toolkit/components/url-classifier/tests/unit/.eslintrc => toolkit/components/url-classifier/tests/unit/.eslintrc.js
rename : toolkit/components/urlformatter/tests/unit/.eslintrc => toolkit/components/urlformatter/tests/unit/.eslintrc.js
rename : toolkit/components/viewsource/test/.eslintrc => toolkit/components/viewsource/test/.eslintrc.js
rename : toolkit/components/viewsource/test/browser/.eslintrc => toolkit/components/viewsource/test/browser/.eslintrc.js
rename : toolkit/components/workerloader/tests/.eslintrc => toolkit/components/workerloader/tests/.eslintrc.js
rename : toolkit/components/xulstore/tests/chrome/.eslintrc => toolkit/components/xulstore/tests/chrome/.eslintrc.js
rename : toolkit/components/xulstore/tests/xpcshell/.eslintrc => toolkit/components/xulstore/tests/xpcshell/.eslintrc.js
rename : toolkit/content/tests/browser/.eslintrc => toolkit/content/tests/browser/.eslintrc.js
rename : toolkit/content/tests/chrome/.eslintrc => toolkit/content/tests/chrome/.eslintrc.js
rename : toolkit/content/tests/unit/.eslintrc => toolkit/content/tests/unit/.eslintrc.js
rename : toolkit/content/tests/widgets/.eslintrc => toolkit/content/tests/widgets/.eslintrc.js
rename : toolkit/crashreporter/test/browser/.eslintrc => toolkit/crashreporter/test/browser/.eslintrc.js
rename : toolkit/crashreporter/test/unit/.eslintrc => toolkit/crashreporter/test/unit/.eslintrc.js
rename : toolkit/crashreporter/test/unit_ipc/.eslintrc => toolkit/crashreporter/test/unit_ipc/.eslintrc.js
rename : toolkit/forgetaboutsite/test/browser/.eslintrc => toolkit/forgetaboutsite/test/browser/.eslintrc.js
rename : toolkit/forgetaboutsite/test/unit/.eslintrc => toolkit/forgetaboutsite/test/unit/.eslintrc.js
rename : toolkit/identity/tests/chrome/.eslintrc => toolkit/identity/tests/chrome/.eslintrc.js
rename : toolkit/identity/tests/unit/.eslintrc => toolkit/identity/tests/unit/.eslintrc.js
rename : toolkit/modules/addons/.eslintrc => toolkit/modules/addons/.eslintrc.js
rename : toolkit/modules/subprocess/.eslintrc => toolkit/modules/subprocess/.eslintrc.js
rename : toolkit/modules/subprocess/test/xpcshell/.eslintrc => toolkit/modules/subprocess/test/xpcshell/.eslintrc.js
rename : toolkit/modules/tests/browser/.eslintrc => toolkit/modules/tests/browser/.eslintrc.js
rename : toolkit/modules/tests/chrome/.eslintrc => toolkit/modules/tests/chrome/.eslintrc.js
rename : toolkit/modules/tests/mochitest/.eslintrc => toolkit/modules/tests/mochitest/.eslintrc.js
rename : toolkit/modules/tests/xpcshell/.eslintrc => toolkit/modules/tests/xpcshell/.eslintrc.js
rename : toolkit/mozapps/downloads/tests/chrome/.eslintrc => toolkit/mozapps/downloads/tests/chrome/.eslintrc.js
rename : toolkit/mozapps/downloads/tests/unit/.eslintrc => toolkit/mozapps/downloads/tests/unit/.eslintrc.js
rename : toolkit/mozapps/extensions/.eslintrc => toolkit/mozapps/extensions/.eslintrc.js
rename : toolkit/mozapps/extensions/test/browser/.eslintrc => toolkit/mozapps/extensions/test/browser/.eslintrc.js
rename : toolkit/mozapps/extensions/test/mochitest/.eslintrc => toolkit/mozapps/extensions/test/mochitest/.eslintrc.js
rename : toolkit/mozapps/extensions/test/xpcshell/.eslintrc => toolkit/mozapps/extensions/test/xpcshell/.eslintrc.js
rename : toolkit/mozapps/extensions/test/xpinstall/.eslintrc => toolkit/mozapps/extensions/test/xpinstall/.eslintrc.js
rename : toolkit/mozapps/update/tests/chrome/.eslintrc => toolkit/mozapps/update/tests/chrome/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_aus_update/.eslintrc => toolkit/mozapps/update/tests/unit_aus_update/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_base_updater/.eslintrc => toolkit/mozapps/update/tests/unit_base_updater/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_service_updater/.eslintrc => toolkit/mozapps/update/tests/unit_service_updater/.eslintrc.js
rename : toolkit/profile/test/.eslintrc => toolkit/profile/test/.eslintrc.js
rename : toolkit/themes/osx/mochitests/.eslintrc => toolkit/themes/osx/mochitests/.eslintrc.js
rename : toolkit/xre/test/.eslintrc => toolkit/xre/test/.eslintrc.js
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc.js
extra : rebase_source : 60affc4b9bf436bba7e0e21a8da3a85d16c9fc06
2016-10-18 08:38:10 +01:00
Tooru Fujisawa
a274ab4345
Bug 1290337 - Part 20: Replace Value parameter to const Value& in storage. r=mak
2016-09-11 18:21:36 +09:00
Tooru Fujisawa
6d493d48ec
Bug 1289050 - Part 1: Use ASCII variant of JS_ReportError in simple case. r=jwalden
2016-08-14 20:39:28 +09:00
Thomas Wisniewski
ba6cb5196e
Bug 1305202 - Use NullString() more and remove superfluous Truncates(). r=smaug
2016-09-23 21:10:01 -04:00
Gijs Kruitbosch
ae4301ef96
Bug 1285041 - ignore locking when trying to read chrome DB file, r=mak
...
MozReview-Commit-ID: 89f0YCxxgC8
--HG--
extra : rebase_source : 53efa0f0258728df54fc17a773cbf74c712b51e4
2016-07-18 16:46:45 +01:00
Phil Ringnalda
7287d4600d
Backed out changeset ef7939c0332e (bug 1285041) for failures in test_storage_connection.js
...
CLOSED TREE
2016-09-15 20:04:30 -07:00
Gijs Kruitbosch
fff8403f8a
Bug 1285041 - ignore locking when trying to read chrome DB file, r=mak
...
MozReview-Commit-ID: 89f0YCxxgC8
--HG--
extra : rebase_source : be3ee58b00b4c8ae6ec41db9459f50abdce816f6
2016-07-18 16:46:45 +01:00
Michael Layzell
60651a924f
Bug 1301127 - Make nsNavHistoryFolderResultNode QueryInterface to mozIStorageStatementCallback, r=smaug
...
MozReview-Commit-ID: 5CPNIz3w4Iy
2016-09-07 14:46:27 -04:00
Michael Layzell
4da0c5f485
Bug 1301124 - Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run(), r=smaug
...
MozReview-Commit-ID: 28K4VmKoqgO
2016-09-07 13:29:17 -04:00
Michael Layzell
36e08437d0
Bug 1018486 - Part 8: Various other changes, r=smaug
...
MozReview-Commit-ID: B0dsomkWgEk
2016-09-07 10:50:45 -04:00
Nicholas Nethercote
b71747b2ac
Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
...
The new name makes the sense of the condition much clearer. E.g. compare:
NS_WARN_IF_FALSE(!rv.Failed());
with:
NS_WARNING_ASSERTION(!rv.Failed());
The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Nicholas Nethercote
c2306345d5
Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
...
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.
The patch also does some associated clean-up.
- Replaces some uses of nsIMemoryReporterCallback with the preferred
nsIHandleReportCallback typedef.
- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
parameter names, for consistency.
- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.
- Uses the MOZ_COLLECT_REPORT macro in all suitable places.
Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.
--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
2016-08-24 15:23:45 +10:00
Kan-Ru Chen
b6d880aca1
Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
...
The patch is generated from following command:
rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,
MozReview-Commit-ID: AtLcWApZfES
--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Akshay CV
dbb1f7d62f
Bug 1296182 - Replace PR_Abort() with MOZ_CRASH("SQLite Version Error"). r=asuth
2016-08-23 21:36:24 -07:00
Nicholas Nethercote
bab6d17ebf
Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj.
...
This patch makes the following changes on many in-class methods.
- NS_IMETHODIMP F() override; --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final; --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...} --> NS_IMETHOD F() final {...}
Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.
--HG--
extra : rebase_source : 386ee4e4ea2ecd8d5001efabc3ac87b4d6c0659f
2016-08-08 10:54:47 +10:00
Nicholas Nethercote
e7f10a07fd
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
...
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
Tom Tromey
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Thomas Zimmermann
67abb05afa
Bug 1287739: Always set 'len' variable in storage test, r=mak
...
MozReview-Commit-ID: 8EpGeakICWY
2016-07-20 16:12:31 +02:00
Chris Peterson
43c2748f66
Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj
2016-07-08 14:39:53 -07:00
Marco Bonardo
949197fdb7
Bug 1283083 - Cloning a connection should re-attach databases to the clone. r=asuth
...
MozReview-Commit-ID: CSZqvJNWthB
--HG--
extra : rebase_source : 9213a9e73052e7d87cf12c64af2ad1a15496ace1
2016-06-29 17:33:15 +02:00
Aidin Gharibnavaz
523608513b
Bug 1247972 - specialize NS_ProxyRelease for nsISupports to be out-of-line; r=erahm
...
NS_ProxyRelease's current implementation requires a lot of code. We can
reduce the impact of this by providing an out-of-line implementation for
classes based on nsISupports. This change reduces codesize by ~60K on
a Linux x86-64 build.
2016-06-29 18:56:41 -04:00
Chris Peterson
6a5ea85fa5
Bug 1278468 - Fix -Wshadow warnings in storage/ directory. r=mak
...
storage/TelemetryVFS.cpp:81:44 [-Wshadow] declaration shadows a field of '(anonymous namespace)::IOThreadAutoTimer'
storage/VacuumManager.cpp:192:25 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:248:13 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:249:14 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:251:19 [-Wshadow] declaration shadows a local variable
storage/mozStorageConnection.cpp:971:15 [-Wshadow] declaration shadows a local variable
storage/mozStorageStatement.cpp:449:19 [-Wshadow] declaration shadows a local variable
storage/variantToSQLiteT_impl.h:97:16 [-Wshadow] declaration shadows a local variable
--HG--
extra : rebase_source : 4e966f23ff352b6f8ea8e992278ab8a952c69e01
2016-06-07 22:08:41 -07:00
Chris Peterson
8a9e2d2bd4
Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium
2016-05-14 00:54:55 -07:00
Chris Peterson
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
Randell Jesup
477adfcd7e
Bug 1271514: clean up threads in test_unlock_notify r=froydnj
...
MozReview-Commit-ID: EbCnWFzLMca
2016-05-11 00:09:53 -04:00