Automatic update from web-platform-tests
[FedCM] Better test disconnect
In particular, use the alt domain where possible, because the regular
may be considered same-origin, which triggers special behavior in
disconnect. See bug 331226129 for some discussion. In particular,
when we have cookie access (as we always do for the same origin),
disconnect does not eventually fail.
This also removes set_fedcm_cookie calls (already called by fedcm_test
for both origins) and adds mark_signed_in calls.
Bug: 331237776
Change-Id: I6ac666aa707e116e38d1a0f111c2a5243f2f78ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5436255
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284119}
--
wpt-commits: 3776d976b20ad1dea0e68be542361173e519d7c8
wpt-pr: 45613
Automatic update from web-platform-tests
[FedCM] Better error handling in OnTokenRequestParsed
If parsing succeeds but there is another error, we had a couple of bugs:
- If a continue_on URL was sent but we had an HTTP error, we did
process the URL but we should not.
- token_result.error was not set but should be. This can trigger the
DCHECK in ClickErrorDialogGotItForDevtools.
In addition, dismiss the error dialog in
fedcm-token-returned-with-http-error so that the test doesn't time out:
https://wpt.fyi/results/credential-management/fedcm-token-returned-with-http-error.https.html?label=master&label=experimental
Bug: 331237776
Change-Id: I4db4b6afb7f8fe22ce6de4613fa528f87dcac554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420032
Reviewed-by: Zachary Tan <tanzachary@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283999}
--
wpt-commits: 82ca18d82a1e27d2d802024bf23f76d3fd09d34e
wpt-pr: 45551
Automatic update from web-platform-tests
[FedCM] Explicitly clear state when needed
The test assumes a clean state, but that's not the case on wpt.fyi:
https://wpt.fyi/results/credential-management/fedcm-auto-selected-flag.https.html?label=experimental&label=master&aligned
Try fixing that using an explicit delete_all_cookies call, which should
also clear FedCM state (AFAIK).
In addition, call set_fedcm_delay_enabled(false).
This is already the default for content_shell, but makes running tests
against chrome faster, such as when using run_wpt_tests or `wpt run`.
Bug: 331237776
Change-Id: Ic81c407c66537e17b25eff6c7eab0f74c763f790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403249
Commit-Queue: Yi Gu <yigu@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279826}
--
wpt-commits: 43ea40c0e9a3d26547ca378bbc71ed0420684b5e
wpt-pr: 45387
Automatic update from web-platform-tests
[digital credential] Move IdentityRequestProvider to a separate dict
In this CL, we further decouple the Digital Credential API [1] from
the FedCM API [2] by moving the protocol/request parameters into its
own dictionary that is only accessible by the Digital Credential API
but not from FedCM, and vice versa, so that the appropriate
parameters are parsed (or discarded) in each of these two APIs.
[1] https://wicg.github.io/digital-identities/
[2] https://fedidcg.github.io/FedCM/
Bug: 1416939
Change-Id: I322bcac9fb38eb52e3466162753e000146d652fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386528
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279609}
--
wpt-commits: 3bfcd2d3f1d691fe9ae88bcf9db5d0eef0c71715
wpt-pr: 45397
Automatic update from web-platform-tests
[FedCM] Always notify opener that we're done loading
If FencedFrameConfig does not exist, we never send the
message to the opener.
That leads to a test timeout, which is unfortunate.
Instead, rearrange this code so that we always add the onload listener.
Noticed this while running
credential-management/fedcm-login-status/cross-origin-status.https.html
Bug: 331237776
Change-Id: Id47677cf591337c3a548c10e33ad29f56985d882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402337
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279256}
--
wpt-commits: b313ed0b09d7b7aca6132707ff8fbec4a0e08890
wpt-pr: 45388
Automatic update from web-platform-tests
[FedCM] Don't use fedcm_get_and_select_first_account
We are expecting a mismatch dialog here, so selecting an account
is not necessary.
R=npm@chromium.org
Change-Id: Ieaf670e204544e866ce3c51cba0d0bbad1b6693f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5397957
Commit-Queue: Nicolás Peña <npm@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1278527}
--
wpt-commits: 6f346b0df5fc952747841fd76d11b3c4d24e5c8d
wpt-pr: 45347
Automatic update from web-platform-tests
[FedCM] Normalize origins
In particular, on wpt.live, "origin" includes a default port of :443
but event.origin does not. Roundtrip both through new URL() so that
they get normalized the same way.
Bug: 331237776
Change-Id: I5a6857bda9d938232879e5da67cdd4fdace1417f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394210
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277940}
--
wpt-commits: c5dbf3e68662f2a9aa1a9c0c39cea6ea5e161cb2
wpt-pr: 45323
Automatic update from web-platform-tests
[FedCM] Close the popup window after setting cookie
This is a bit nicer when running the tests manually.
Change-Id: I6d96e453836ac6534c75cb8c6e1e841bae5a08b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394269
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277945}
--
wpt-commits: 8882ec770f1a84c1c85ae46d467b63a2f4b6745e
wpt-pr: 45325
Automatic update from web-platform-tests
Disable digital credential API when called from cross-origin <iframe>
BUG=325425533
Change-Id: Ib6032b35175072883afaff4806cf5b1e59a5429a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5363035
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275627}
--
wpt-commits: 0d0b0cb4329ca824575f2b0e8ea9a15eca99322c
wpt-pr: 45033
Automatic update from web-platform-tests
[FedCM] Allow specifying an account ID in IdentityProvider.resolve
Syntax:
IdentityProvider.resolve("some_token", {"accountId": "some_id"});
The account ID is optional and will default to whichever account
the user selected.
Bug: 329477527
Change-Id: Idca4640e67b32c1d5fd103cc26460e595f49e2d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374870
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1275140}
--
wpt-commits: f7f5016948c166342371b68dbf0e2c7c72463c62
wpt-pr: 45184
Automatic update from web-platform-tests
[FedCM] Don't send SameSite=Strict cookies for FedCM requests
See https://github.com/fedidcg/FedCM/issues/320#issuecomment-1992358452
This is behind the off-by-default "FedCmSameSiteNone" feature.
Bug: 329145816
Change-Id: I6408255a01118cd5ac4d0d0263a34051796dc301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366009
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273426}
--
wpt-commits: 08c2f13fa0d6bf961ab2e80b0db0a958ef991ee9
wpt-pr: 45066
Automatic update from web-platform-tests
[RWI] Make navigator.identity.get() return DigitalCredential object
This change is documented in this spec
https://wicg.github.io/digital-identities/
BUG=328691361
Change-Id: I40fc6fb01ebad2db6cdb9cddd27003767949fb9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5353751
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271108}
--
wpt-commits: 583a35fd066c46ab7ad2418a843d622f4b43c592
wpt-pr: 45008
Automatic update from web-platform-tests
[FedCM] Split button flow web tests into multiple files
The basic tests file would grow with more tests coming so it makes sense
to split some into a new file. In addition, this helps with debugging
new flaky tests.
Bug: 328129675, 41489720
Change-Id: Ie3cde046b3e13febdb3d57bf8cce7567ddb530dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5352771
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270323}
--
wpt-commits: 92088377f8a8f322333f5ca2efc6f077e5bedeb6
wpt-pr: 44994
Automatic update from web-platform-tests
[FedCM] Fix new_account_idp setup
We should only set the variable when we know there are new accounts, so
that the UI code can safely assume that when there is a new_account_idp,
then there are accounts in such variable.
Bug: 328259260
Change-Id: I0d66416e1191590aebd70b5dd9d762fa92d74e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5353115
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270278}
--
wpt-commits: 85e057d42728b4ecf2c3f660b96e46e836004db5
wpt-pr: 44992
Automatic update from web-platform-tests
[FedCM] Add CORS support in WPTs as well as a no CORS test
The no CORS test fails right now but will pass once the CORS flag is
enabled by default
Bug: 40284123
Change-Id: Iaa864b2d94b4fff5c6258dfc1ba5aa78bce70180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5332937
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1266696}
--
wpt-commits: a0038b4dd3636b518fe268ba097a92b9ad558842
wpt-pr: 44838
Automatic update from web-platform-tests
[FedCM] Handle "unknown" login status in the button flow for single IdP
If the LoginStatus is unknown, in button flow we show the pop-up window
directly instead of failing silently.
Bug: 40284801
Change-Id: Idaf1bb4526e5dd13b889e66bd25d5e0c11ca755e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324620
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1266248}
--
wpt-commits: 17a755e2bbdb59670ce9937ad8b38d90a835dec4
wpt-pr: 44790
Automatic update from web-platform-tests
[FedCM] Fix dom exception type for TooManyRequests
We have the right type in web_identity_requester.cc but not in these two
files.
Bug: None
Change-Id: Iadf6c6ef6cf7fcdfdc69e8abc660d201100918a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323347
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265498}
--
wpt-commits: 2a9fa3b5e2a898141a6373804b2b6e6f1c15957f
wpt-pr: 44793
Automatic update from web-platform-tests
Revert "[FedCM] Allow button flow to replace widget flow"
This reverts commit a2783105732c27a57dd0c3e1100730cc4aec32e0.
Reason for revert: Suspected of causing failures on WebKit Linux Leak: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/60801/overview (and other runs since)
Original change's description:
> [FedCM] Allow button flow to replace widget flow
>
> Since button flow implies stronger user login intention of, it should
> take precedence over the widget flow. In particular:
> 1. If there's an in-flight button request, reject any coming widget request
> 2. If there's an in-flight widget request, replace it with the button request
>
> This patch also fixes an issue where we persisted the rp_mode_ after a
> button flow.
>
> Bug: 41483050
> Change-Id: Ic75ba4ab359a9247f4c41b75ad84f7a3cabeb0c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321982
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1265238}
Bug: 41483050
Change-Id: I82728a8ea02194f46eed086015473975a4017dc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317868
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265306}
--
wpt-commits: 4e124bd215d00032c69d87b499d4e04fa97595b3
wpt-pr: 44791
Automatic update from web-platform-tests
[FedCM] Allow button flow to replace widget flow
Since button flow implies stronger user login intention of, it should
take precedence over the widget flow. In particular:
1. If there's an in-flight button request, reject any coming widget request
2. If there's an in-flight widget request, replace it with the button request
This patch also fixes an issue where we persisted the rp_mode_ after a
button flow.
Bug: 41483050
Change-Id: Ic75ba4ab359a9247f4c41b75ad84f7a3cabeb0c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321982
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265238}
--
wpt-commits: a814608dab5f5df554bdc1f32468fcb67b92f621
wpt-pr: 44756
Automatic update from web-platform-tests
[FedCM] Add `mode` to the POST request sent to the ID assertion endpoint
This patch also adds some basic wpt tests for the button flow.
Bug: 326091153
Change-Id: I5df924a3f82bb45b27e8ff580037433b7585af88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310541
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263621}
--
wpt-commits: 81a33691a856a09d54ed986a17be287d91b49fae
wpt-pr: 44704
Automatic update from web-platform-tests
[FedCM] Add a WPT test for authz
Unlike the browsertest equivalent, this WPT test
tests the full stack.
Fixed: 1489239
Change-Id: Ie54e4c70b00fa706e575030e07295fc0157a2072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5229982
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1251547}
--
wpt-commits: ac9206dbfacda9de2163dabbc8e5fde272661a80
wpt-pr: 44153
Automatic update from web-platform-tests
[FedCM] Check response code in Error API
If an IdP returns unparsable response in the id assertion endpoint,
currently we treat it as a server error. Rather, we should only proceed
with server error if the response code is 500 or the IdP explicitly
uses "server_error" in the Error API.
Bug: 1519671
Change-Id: Ia671c25fdfc17763418b0ea29004137f2413e700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5214925
Auto-Submit: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Zachary Tan <tanzachary@chromium.org>
Commit-Queue: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1249557}
--
wpt-commits: 0ab8387901f7ea14a42ae6d740b8904b0bf1f499
wpt-pr: 44097
Automatic update from web-platform-tests
[FedCM] Allow setting login status from a same-site request
This relaxes the same-origin requirement to same-site for processing
the login status header. This is useful for IDPs who process IDP
logins on a different host than the FedCM endpoint.
This is behind a default-enabled flag so we can easily disable this
in case of issues.
The virtual test suite explicitly enables the flag so that the test
will keep working in case the flag has to be turned off.
Approved by Security & Privacy in
https://docs.google.com/document/d/1vZiEh4Q45gleW0lmtfgxMflqarMkcTk0Itwoo6724Vo/edit?resourcekey=0-WjqaM1SrhAoFbhmGNyyyJA&tab=t.0
Bug: 1516640
Change-Id: I8825e66b43d7d3a6fae7db2447281502fb8015c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5207174
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1249349}
--
wpt-commits: 1e3137a4b3451ddecc15e26193add733bc49d4ff
wpt-pr: 44055
Automatic update from web-platform-tests
[FedCM] Enable FedCmSkipWellKnownForSameSite by default
This skips the .well-known/web-identity checks if the RP and
IDP are in the same eTLD+1.
Approved by security and privacy in:
https://docs.google.com/document/d/1zTJVmW-zAm-pFeLIGV0IhInXVlLwSh9rz08E5QVy4NA/edit?resourcekey=0-LGYUJlxuj15i4phyz46nvQ
Bug: 1511767
Change-Id: I44ee15feb11354c4b58bfab74e69b7d4af97da87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5177812
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1244800}
--
wpt-commits: 0d986788e53b7903b2b7e35444ad85ac06923537
wpt-pr: 43888
Automatic update from web-platform-tests
[FedCM] Add more WPT tests for error API
These tests make use of the newly repurposed webdriver command to click
on buttons in the FedCM error dialog.
Bug: 1496474
Change-Id: I8cdbd271c73d123dd47f62d943148b604412f08a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5021410
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1239840}
--
wpt-commits: c84ca70108c0e0b26b731f16a4c2789040db66e4
wpt-pr: 43750
Automatic update from web-platform-tests
[FedCM] Add more WPT tests for error API
These tests make use of the newly repurposed webdriver command to click
on buttons in the FedCM error dialog.
Bug: 1496474
Change-Id: I8cdbd271c73d123dd47f62d943148b604412f08a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5021410
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1239840}
--
wpt-commits: c84ca70108c0e0b26b731f16a4c2789040db66e4
wpt-pr: 43750
Automatic update from web-platform-tests
[FedCM] Add test for auto reauthentication approved client failure
Adds a test where there is a returning user, but auto reauthentication
fails because approved_clients is present but does not contain the
client ID.
Bug: 1510583
Change-Id: I9801424ee343cc55ad22b96815478fdc90ffe01f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5110442
Commit-Queue: Nicolás Peña <npm@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Auto-Submit: Nicolás Peña <npm@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1236003}
--
wpt-commits: da76d400793d6eabd61ec0c8b70bb780c2d19fde
wpt-pr: 43606
Automatic update from web-platform-tests
[FedCM] Make accountHint required
Also change the error thrown when clientId or configURL are not
present in the disconnect() method. They cannot be marked as required
in the IDL due to prototypes which assume that they are optional.
Bug: 1473134
Change-Id: Ic14c327a63c99eb81058bd64ab9524402ea26539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5100476
Auto-Submit: Nicolás Peña <npm@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234771}
--
wpt-commits: c41d8c520683379b1fbf99cbce610fe80f63988e
wpt-pr: 43567
Automatic update from web-platform-tests
[FedCM] Do not crash for pending disconnect/getUserInfo
If the FederatedAuthRequestImpl is invoked and there are pending
requests, the destructor will clear out the FederatedAuthRequestImpl
members. This will in turn invoke the members' destructors, which then
complete their requests. However, to do so they run the completion
callback which is currently expecting the members to be present. This
CL fixes this by removing that expectation, and adding WPTs that would
have crashed in Chrome before this CL.
Bug: 1504569
Change-Id: I3327398740ee641d43a2a4b93420ac8ff56ae8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085229
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234701}
--
wpt-commits: 29cdefab41a941e0fce230c5475ee1459a390a02
wpt-pr: 43503
Automatic update from web-platform-tests
[FedCM] Rename revoke to disconnect
The feature has not shipped yet so it is OK to rename metrics.
DanglingUntriaged-notes: this CL is just a rename...
Bug: 1473134
Change-Id: I8616fd8b68ab2255897f0cb8b1486d9e17eac5cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5049262
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Brendon Tiszka <tiszka@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1228089}
--
wpt-commits: 0173c88f3b50f33b6f849fc525f6606536261023
wpt-pr: 43292
Nicolás Peña
Christian Biesinger
Sam Goto
Peter Kotwicz
Yi Gu
Stephen McGruer
Zachary Tan
Cristian Tuns