7ae6aea145
Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
01ba28a5dd
Bug 1684711 - Fix canvas ImageData signatures to match the spec. r=nical
...
Spec: https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-createimagedata (and friends)
See https://github.com/whatwg/html/issues/6262 about [EnforceRange],
which isn't technically on the spec but matches all browsers' behavior.
This simplifies a bit the code, moving some conversions to WebIDL, fixes
a few WPT tests, and should throw better error messages too.
Differential Revision: https://phabricator.services.mozilla.com/D100608
2021-01-04 17:48:32 +00:00
f80f706ecb
Bug 1684689 - Check for 0 size after clamping in CanvasRenderingContext2D.createImageData r=emilio
...
Shifted the zero-check after width and height are clamped to int32_t. Fixes the use case where width and height are floats > 0 but < 1. These values are clamped to 0, but no error is thrown, as opposed to the desired behavior. Deleted corresponding test ini file, since it is now expected to PASS.
Now also fixes a test that started failing and checked something against the spec, (credit to @emilio)
Differential Revision: https://phabricator.services.mozilla.com/D100597
2021-01-03 20:58:32 +00:00
f7895c0e34
Bug 1684638 - Remove 'else' after 'return' in dom/canvas/WebGLShaderValidator.cpp. r=jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D100645
2021-01-04 04:51:45 +00:00
2fcab99704
Backed out 2 changesets (bug 1684689) for causing damp failures. CLOSED TREE
...
Backed out changeset f70abb51ec6d (bug 1684689)
Backed out changeset 636bed8f02dc (bug 1684689)
2021-01-03 03:45:02 +02:00
b05032895c
Bug 1684689 - Fix a test that started failing and checked something against the spec.
...
MANUAL PUSH: Orange fix on a CLOSED TREE
2021-01-02 21:52:48 +01:00
3761bb4652
Bug 1684689 - Check for 0 size after clamping in CanvasRenderingContext2D.createImageData r=emilio
...
Shifted the zero-check after width and height are clamped to int32_t. Fixes the
use case where width and height are floats > 0 but < 1. These values are clamped
to 0, but no error is thrown, as opposed to the desired behavior. Deleted
corresponding test ini file, since it is now expected to PASS.
Differential Revision: https://phabricator.services.mozilla.com/D100597
2021-01-02 16:26:07 +00:00
8e8a8fc213
Bug 1627014 - Implement CanvasRenderingContext2D.createConicGradient r=emilio
...
Added an option to use ConicGradient API as a preference and removed the
corresponding expected FAILing test, over @ntim's implementation.
Differential Revision: https://phabricator.services.mozilla.com/D100554
2021-01-01 01:50:52 +00:00
2978aa00a3
Backed out changeset dbed1cdf588f (bug 1684173) for mochitest plain and devtools failures. a=backout DONTBUILD
2020-12-28 00:43:51 +02:00
775cdec032
Bug 1684173 - Add newline character at end of files when missing r=sylvestre
...
Depends on D100443
Differential Revision: https://phabricator.services.mozilla.com/D100484
2020-12-27 11:43:41 +00:00
00c0e09335
Bug 1678909 - mark image bitmap as premult when converted so that we don't repeatedly premultiply it. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100287
2020-12-22 00:13:18 +00:00
039592f4d8
Bug 1682003 - Avoid UTF-8 -> UTF-16 conversion during CSSOM serialization. r=heycam
...
This lifts a bunch of string conversions higher up the stack, but allows
us to make the servo code use utf-8 unconditionally, and seemed faster
in my benchmarking (see comment 0).
It should also make a bunch of attribute setters faster too (like
setting .cssText), now that we use UTF8String for them (we couldn't
because we couldn't specify different string types for the getter and
setters).
Differential Revision: https://phabricator.services.mozilla.com/D99590
2020-12-17 14:04:35 +00:00
7577f527cf
Bug 1666285, try to avoid slow shrinking GC during sync calls r=sfink,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D97783
2020-12-15 10:40:42 +00:00
80ba2a1617
Bug 1681418 - Throw some more useful errors in canvas code. r=nical
...
Differential Revision: https://phabricator.services.mozilla.com/D99265
2020-12-10 17:06:46 +00:00
f9e0de00c8
Bug 1681418 - Remove unreachable error checking codepaths in ImageBitmap. r=nical
...
CreateImageFromSurface never returns null.
Depends on D99260
Differential Revision: https://phabricator.services.mozilla.com/D99261
2020-12-10 17:05:51 +00:00
6f86559e46
Bug 1681418 - Throw a more useful error when a broken image is passed to drawImage. r=nical
...
Much like we do for createPattern().
Differential Revision: https://phabricator.services.mozilla.com/D99260
2020-12-10 17:08:02 +00:00
4cab6ac723
Bug 1677466 - Move ParamTraits specializations with extra dependencies out of IPCMessageUtils.h. r=mccr8
...
This moves parts of IPCMessageUtils.h to two new header files and adapts
the include directives as necessary. The new header files are:
- EnumSerializer.h, which defines the templates for enum serializers
- IPCMessageUtilsSpecializations.h, which defines template specializations
of ParamTraits with extra dependencies (building upon both IPCMessageUtils.h
and EnumSerializer.h)
This should minimize the dependencies pulled in by every consumer of
IPCMessageUtils.h
Differential Revision: https://phabricator.services.mozilla.com/D94459
2020-12-10 11:09:21 +00:00
71e2bbe153
Bug 1680469 - Remove partial std::hash specializations. r=jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D98604
2020-12-09 16:47:13 +00:00
b25e9ba943
Bug 1681147 - Don't IPC_FAIL for context creation failure. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D98835
2020-12-07 19:00:12 +00:00
77070731a2
Bug 1680595 - Point users towards "webgl.disable-fail-if-major-performance-caveat" if failIfMajorPerformanceCaveat: true causes failure. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D98824
2020-12-07 05:35:57 +00:00
1c53236b70
Bug 1679272 - Include ScopeExit.h exactly where used. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D98888
2020-12-07 14:25:59 +00:00
bbb5f8a339
Bug 1519636 - Reformat recent changes to the Google coding style r=andi
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D98301
2020-12-07 10:17:57 +00:00
88c7f3ad66
Bug 1119956 derive from DiscardableRunnable instead of CancelableRunnable when Cancel() is not supported r=asuth,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D98118
2020-12-03 09:04:44 +00:00
47dcac63b7
Bug 1638568 - E.g. uniform1i(null, ...) should check avail len not total len. r=lsalzman
...
Also:
* Propagate null-location UniformDatas to host
* Move transpose validation to host-side
Differential Revision: https://phabricator.services.mozilla.com/D98243
2020-11-30 22:00:23 +00:00
aedaf29bc6
Bug 1679693 - Update WebGL 2 to allow drawArraysInstanced with no non-instanced active attribs. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D98112
2020-11-30 18:19:40 +00:00
637fafc5a7
Bug 1662516 - Enable m-gli on Linux. r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D95096
2020-11-30 18:13:19 +00:00
168c45a7ac
Backed out changeset 951e6717abf4 (bug 1662516) for M-gli failures CLOSED TREE
2020-11-30 09:19:00 +02:00
a10a4ccb9e
Bug 1662516 - Enable m-gli on Linux. r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D95096
2020-11-30 05:44:33 +00:00
26311e778c
Backed out changeset 7137d009d979 (bug 1679693) for webgl2 failure on test_2_conformance2__rendering__instanced-arrays.html. CLOSED TREE
2020-11-29 21:17:11 +02:00
ea9afb914b
Bug 1679693 - Update WebGL 2 to allow drawArraysInstanced with no non-instanced active attribs. r=lsalzman
...
Differential Revision: https://phabricator.services.mozilla.com/D98112
2020-11-29 17:51:10 +00:00
caff5f6125
Bug 1679052 - Mark now-passing test.
...
Differential Revision: https://phabricator.services.mozilla.com/D97897
2020-11-23 21:48:44 +00:00
7c18ab1921
Bug 1679052 - Constrain src and dst rects for eldritch blitFramebuffer rects. r=lsalzman
...
E.g. Blitting 1,1,-1,-1 to 0,2,2,0.
Some drivers have trouble with this.
Primarily tested by:
* conformance2/rendering/blitframebuffer-filter-outofbounds.html
* conformance2/rendering/blitframebuffer-outside-readbuffer.html
Differential Revision: https://phabricator.services.mozilla.com/D97890
2020-11-23 19:54:41 +00:00
dd80614fa0
Bug 1678062 - Remove unnecessary includes. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D97467
Depends on D96561
2020-11-23 16:12:02 +00:00
73d4d57082
Bug 1676357 - Avoid including Layers.h in header files. r=botond
...
Differential Revision: https://phabricator.services.mozilla.com/D96538
Depends on D96537
2020-11-23 16:09:05 +00:00
071c7c035f
Bug 1676356 - Avoid including PresShell.h from header files. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D96534
Depends on D95184
2020-11-23 16:08:23 +00:00
6fac745ea4
Bug 1673931 - Remove dependency of BindingUtils.h on Document.h.
...
Differential Revision: https://phabricator.services.mozilla.com/D95048
Depends on D95047
2020-11-23 16:08:03 +00:00
5bfbb2a572
Bug 1673931 - Avoid including Document.h from header files. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D95046
Depends on D95045
2020-11-23 16:07:43 +00:00
9093e5e1bf
Bug 1673424 - Fix includes around JS/StructuredClone.h.
...
Differential Revision: https://phabricator.services.mozilla.com/D94762
Depends on D93568
2020-11-23 16:06:52 +00:00
c902104cdb
Bug 1660470 - Split ShmemMessageUtils.h from Shmem.h. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D93543
Depends on D93321
2020-11-23 16:05:02 +00:00
c077183836
Bug 1660470 - Avoid including IPCMessageUtils.h from header files. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D93235
Depends on D93234
2020-11-23 16:03:47 +00:00
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
8953086494
Bug 1677284 - Move PackingStrategy::Variant implementation to separate header file. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D97075
2020-11-23 15:49:14 +00:00
6af16546a9
Bug 1675987 - No derogatory language: Remove references to "crazy" in dom module. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D97654
2020-11-20 23:37:01 +00:00
2b7c148c6e
Bug 1671382 - reset() RaiiShmem if its allocator is invalid. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D96297
2020-11-20 00:17:38 +00:00
c8b12f5aa2
Bug 1676299 - Removed the xMajor parameter from BaseMatrix::ScaleFactors() r=botond
...
Differential Revision: https://phabricator.services.mozilla.com/D97449
2020-11-18 18:53:01 +00:00
bebb9f9181
Bug 1519636 - Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp
...
It is bringing some minor changes
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D90795
2020-11-18 09:05:59 +00:00
0129dd3f83
Bug 1519636 - Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D96608
2020-11-16 22:09:25 +00:00
b13291edfd
Bug 1677376 - Set prefs more reliably in test_canvas_focusring.html
...
MANUAL PUSH: Orange in a CLOSED TREE
2020-11-16 19:41:30 +01:00
563e0f4efc
Bug 1677376 - Introduce a pref to determine whether to always show focus rings after key focus. r=edgar
...
See the comments in the pref description for the reasoning, and
https://bugzilla.mozilla.org/show_bug.cgi?id=1445482#c15 and following
for some confusion this patch intends to avoid.
Differential Revision: https://phabricator.services.mozilla.com/D97151
2020-11-16 16:31:09 +00:00
eb6f770a5b
Bug 1674592 - Shrink uploads based on byte size estimates. r=lsalzman
...
For example uploads from WASM heaps would previously copy most of the
heap into shmem.
Differential Revision: https://phabricator.services.mozilla.com/D96287
2020-11-13 23:24:13 +00:00
Kartik Gautam
Emilio Cobos Álvarez
Aryan Agal
nirmay
Butkovits Atila
Cosmin Sabou
Lee Salzman
Olli Pettay
Simon Giesecke
Jeff Gilbert
Sylvestre Ledru
Karl Tomlinson
Bogdan Tara
Narcis Beleuzu
Jon Bauman
coderboncuk