Граф коммитов

1104 Коммитов

Автор SHA1 Сообщение Дата
Nathan Froyd 8a2948e596 Bug 1225923 - part 1 - convert all needs-to-copy instances of AppendElement(nsDependentString(...)); r=erahm
When people write:

  array.AppendElement(nsDependentString(...));

(resp. nsDependentCString), it's not clear whether they expect the newly
constructed dependent string to live in the array, or whether they're
just making a nsString-like holder whose contents can be freely copied
into the array's newly-created nsString.  Sometimes the latter is what
you prefer, and sometimes the former.  In all cases, however, the latter
behavior is what you get.

Let's try to make that behavior more explicit by pre-constructing
nsString elements and then using Assign to show that copying is taking
place.  This patch involves no functional change in behavior (it ought
to be epsilon faster due to using AppendElements, rather than repeatedly
calling AppendElement).
2015-11-18 10:25:19 -05:00
Nicholas Nethercote 8eb10da71a Bug 1186791 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
--HG--
extra : rebase_source : 8fc71420355baa87b63f6c9c817a27395272cb33
2015-10-29 16:43:34 -07:00
Nicholas Nethercote acb6e8f1f1 Bug 1186791 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
--HG--
extra : rebase_source : defddc0f2e490b5b1b41fd71bebedfc8b31a35bb
2015-10-29 16:04:42 -07:00
Nicholas Nethercote 23e7f15036 Bug 1186791 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
--HG--
extra : rebase_source : 5781d353bec6bef4b96a6f4f6c734e10594b5643
2015-10-29 16:04:41 -07:00
Nathan Froyd 4bc7fd6e21 Bug 1219238 - remove AutoArray from mozStorageSQLFunctions.cpp; r=mak
nsAutoTArray is practically the same thing; we should just use that and
avoid code duplications.
2015-10-27 21:22:52 -04:00
Tooru Fujisawa 6fc0b6a576 Bug 1217982 - Remove for-each from storage/. r=mak
--HG--
extra : commitid : JkK4BJvCHax
extra : rebase_source : add04bcdd5f6400e8d20f9fdcd3ce57f48fabae1
2015-10-19 03:53:14 +09:00
Nathan Froyd 01583602a9 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi

--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Eric Rahm 1874580339 Bug 1194023 - Part 2: Only check for sort operations if mozStorage logging is enabled. r=mak 2015-09-25 16:33:22 -07:00
Eric Rahm af00644989 Bug 1194023 - Part 1: Filter out warnings about sort operations on CREATE INDEX statements. r=mak 2015-09-25 15:27:48 -07:00
Tooru Fujisawa ee9f17192c Bug 1207499 - Part 9: Remove use of expression closure from storage/. r=mak
--HG--
extra : commitid : CuirUjswj0A
extra : rebase_source : 4368bcee9edccffb48a99a154b13e4625c20d263
2015-09-23 18:42:19 +09:00
Jeff Walden 4046fe1490 Bug 1179003 - Convert the infallible objectClassIs proxy hook into a fallible getBuiltinClass hook that indicates class type via outparam. r=efaust, r=bz on DOM bits, r=billm on IPC bits
--HG--
extra : rebase_source : 6ddc3727c411fdfced6338e5e383a10572575f0f
2015-08-28 21:55:40 -07:00
Andrew McCreight 5446225d17 Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
This leaves alone the AppendElement methods.
2015-09-15 15:30:44 -07:00
Shu-yu Guo 64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Nicholas Nethercote f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Chris Peterson 1416e566de Bug 1198124 - Enable -Wshadow in directories that have no -Wshadow warnings. r=glandium 2015-08-25 09:14:38 -07:00
Nathan Froyd ca51445d31 Bug 1193022 - clean up reference-counting in storage/; r=mak 2015-07-01 13:11:11 -04:00
Marco Bonardo 3d559535cd bug 1189896 - Do not preallocate Sqlite connections caches for now. r=asuth
--HG--
extra : commitid : 9m1uRdbBAxX
2015-08-05 21:54:20 +02:00
Jan de Mooij 9d74419a90 Bug 1184564 part 2 - Use Value instead of jsval in dom/ and storage/. r=bz 2015-07-18 21:45:35 +02:00
Birunthan Mohanathas a8939590de Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Juan Gomez 258ad59e3f Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 2015-07-03 18:29:00 -07:00
Andrew McCreight 53e8d2ac49 Bug 958641 - De-holder nsIXPConnect::WrapNative. r=gabor 2015-07-01 11:17:17 -07:00
Jan de Mooij 303b210317 Bug 1177892 part 3 - Remove OBJECT_TO_JSVAL. r=evilpie 2015-06-30 21:09:46 -07:00
Jan de Mooij 155b1afd35 Bug 1177892 part 1 - Remove BOOLEAN_TO_JSVAL and STRING_TO_JSVAL. r=evilpie 2015-06-30 11:20:56 -07:00
Ryan VanderMeulen 7483c0563e Backed out changesets ad58c270ce87 and 849151330d60 (bug 1177892) for B2G bustage.
CLOSED TREE
2015-06-30 15:48:11 -04:00
Jan de Mooij 731f441d6e Bug 1177892 part 1 - Remove BOOLEAN_TO_JSVAL and STRING_TO_JSVAL. r=evilpie
--HG--
extra : rebase_source : f7ae63c351c82516e7db48a12c4cfb2048a81805
2015-06-30 11:20:56 -07:00
Jan Varga baba1643c1 Bug 1130775 - Convert synchronized ops and storage registration into unified directory locks; r=bent
--HG--
rename : dom/quota/OriginOrPatternString.h => dom/quota/OriginScope.h
2015-06-30 14:59:27 +02:00
Jan de Mooij 976586cb5f Bug 1177825 - Remove JSVAL_* constants. r=evilpie 2015-06-29 18:36:44 -07:00
Ryan VanderMeulen 5f5c327690 Backed out changeset 8b4e4083639e (bug 1171931) for B2G debug emulator bustage. 2015-06-25 19:48:42 -04:00
Juan Gomez 702a59d135 Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj
--HG--
extra : rebase_source : 2ecbe6c1dd8a7ad8dc529b53349ad431cf1116c9
2015-06-24 14:11:00 -04:00
Ben Turner e4ac5e1134 Bug 1149815 - Pass storage function failure codes through to callers, r=asuth. 2015-06-20 09:08:20 -07:00
Eric Rahm 75c4bebb79 Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-03 15:25:57 -07:00
Eric Rahm f50b813989 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-03 15:22:28 -07:00
Carsten "Tomcat" Book 5471309381 Backed out 14 changesets (bug 1165515) for linux x64 e10s m2 test failures
Backed out changeset d68dcf2ef372 (bug 1165515)
Backed out changeset 7c3b45a47811 (bug 1165515)
Backed out changeset b668b617bef2 (bug 1165515)
Backed out changeset d0916e1283a2 (bug 1165515)
Backed out changeset ac4dc7489942 (bug 1165515)
Backed out changeset e9632ce8bc65 (bug 1165515)
Backed out changeset c16d215cc7e4 (bug 1165515)
Backed out changeset e4d474f3c51a (bug 1165515)
Backed out changeset d87680bf9f7c (bug 1165515)
Backed out changeset b3c0a45ba99e (bug 1165515)
Backed out changeset 9370fa197674 (bug 1165515)
Backed out changeset 50970d668ca1 (bug 1165515)
Backed out changeset ffa4eb6d24b9 (bug 1165515)
Backed out changeset 5fcf1203cc1d (bug 1165515)

--HG--
extra : rebase_source : 6fb850d063cbabe738f97f0380302153e3eae97a
2015-06-02 13:05:56 +02:00
Eric Rahm a9afd68cef Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 22:17:33 -07:00
Eric Rahm 141e0ff4a2 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-01 22:17:19 -07:00
Wes Kocher 4e9f80ed2e Backed out 14 changesets (bug 1165515) for b2g mochitest-6 permafail CLOSED TREE
Backed out changeset 9b97e2aa2ed9 (bug 1165515)
Backed out changeset 150606c022a2 (bug 1165515)
Backed out changeset 4e875a488349 (bug 1165515)
Backed out changeset 467e7feeb546 (bug 1165515)
Backed out changeset d6b6cc373197 (bug 1165515)
Backed out changeset 0615265b593c (bug 1165515)
Backed out changeset fafd1dce9f08 (bug 1165515)
Backed out changeset d1df869245f9 (bug 1165515)
Backed out changeset 6876a7c63611 (bug 1165515)
Backed out changeset b7841c94a9a3 (bug 1165515)
Backed out changeset e5e3617f7c73 (bug 1165515)
Backed out changeset 39be3db95978 (bug 1165515)
Backed out changeset 0ec74176f8de (bug 1165515)
Backed out changeset 5b928dd10d71 (bug 1165515)
2015-06-01 17:57:58 -07:00
Eric Rahm f82c0e7caf Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 14:31:01 -07:00
Eric Rahm dc090e3fe5 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-01 14:31:00 -07:00
Birunthan Mohanathas 470bd9148f Bug 968520 - Add mozilla::fallible to FallibleTArray::AppendElements calls. r=froydnj 2015-05-28 11:07:43 -07:00
Jason Orendorff 112cb52d91 Bug 1140482 - Add JSPROP_RESOLVING. Give NativeDefineProperty standard behavior in cases where a non-resolving define needs to trigger a resolve hook. r=Waldo.
--HG--
extra : rebase_source : c63bb83179ec98e9f93ebb86cb488d65f980a07e
2015-05-01 14:03:17 -05:00
Wes Kocher 72a315a1e1 Backed out changeset 6435d5aab611 (bug 858680) 2015-05-21 16:44:38 -07:00
Eric Rahm 3925a960aa Bug 1165515 - Part 1: Convert PR_LOG to MOZ_LOG. r=froydnj 2015-05-21 13:22:04 -07:00
Ben Turner c769c6825d Bug 858680 - Part 3: Allow mozStorage to access the dbstats virtual table, r=asuth.
--HG--
extra : rebase_source : 250bc47337695abb09e926fb8a21e5df72724fe4
2015-04-30 16:30:57 -07:00
Ben Turner af31caeec8 Bug 1162176, Part 1. r=mak.
--HG--
extra : rebase_source : c980220594475e8c8654802466f9376a11fed616
2015-05-19 09:17:10 -07:00
Birunthan Mohanathas 296aa63730 Bug 1164717 - Flatten storage/src/ directory. r=mak
--HG--
rename : storage/src/FileSystemModule.cpp => storage/FileSystemModule.cpp
rename : storage/src/FileSystemModule.h => storage/FileSystemModule.h
rename : storage/src/IStorageBindingParamsInternal.h => storage/IStorageBindingParamsInternal.h
rename : storage/src/SQLCollations.cpp => storage/SQLCollations.cpp
rename : storage/src/SQLCollations.h => storage/SQLCollations.h
rename : storage/src/SQLiteMutex.h => storage/SQLiteMutex.h
rename : storage/src/StorageBaseStatementInternal.cpp => storage/StorageBaseStatementInternal.cpp
rename : storage/src/StorageBaseStatementInternal.h => storage/StorageBaseStatementInternal.h
rename : storage/src/TelemetryVFS.cpp => storage/TelemetryVFS.cpp
rename : storage/src/VacuumManager.cpp => storage/VacuumManager.cpp
rename : storage/src/VacuumManager.h => storage/VacuumManager.h
rename : storage/src/Variant.h => storage/Variant.h
rename : storage/src/Variant_inl.h => storage/Variant_inl.h
rename : storage/src/mozStorageArgValueArray.cpp => storage/mozStorageArgValueArray.cpp
rename : storage/src/mozStorageArgValueArray.h => storage/mozStorageArgValueArray.h
rename : storage/src/mozStorageAsyncStatement.cpp => storage/mozStorageAsyncStatement.cpp
rename : storage/src/mozStorageAsyncStatement.h => storage/mozStorageAsyncStatement.h
rename : storage/src/mozStorageAsyncStatementExecution.cpp => storage/mozStorageAsyncStatementExecution.cpp
rename : storage/src/mozStorageAsyncStatementExecution.h => storage/mozStorageAsyncStatementExecution.h
rename : storage/src/mozStorageAsyncStatementJSHelper.cpp => storage/mozStorageAsyncStatementJSHelper.cpp
rename : storage/src/mozStorageAsyncStatementJSHelper.h => storage/mozStorageAsyncStatementJSHelper.h
rename : storage/src/mozStorageAsyncStatementParams.cpp => storage/mozStorageAsyncStatementParams.cpp
rename : storage/src/mozStorageAsyncStatementParams.h => storage/mozStorageAsyncStatementParams.h
rename : storage/src/mozStorageBindingParams.cpp => storage/mozStorageBindingParams.cpp
rename : storage/src/mozStorageBindingParams.h => storage/mozStorageBindingParams.h
rename : storage/src/mozStorageBindingParamsArray.cpp => storage/mozStorageBindingParamsArray.cpp
rename : storage/src/mozStorageBindingParamsArray.h => storage/mozStorageBindingParamsArray.h
rename : storage/src/mozStorageConnection.cpp => storage/mozStorageConnection.cpp
rename : storage/src/mozStorageConnection.h => storage/mozStorageConnection.h
rename : storage/src/mozStorageError.cpp => storage/mozStorageError.cpp
rename : storage/src/mozStorageError.h => storage/mozStorageError.h
rename : storage/src/mozStoragePrivateHelpers.cpp => storage/mozStoragePrivateHelpers.cpp
rename : storage/src/mozStoragePrivateHelpers.h => storage/mozStoragePrivateHelpers.h
rename : storage/src/mozStorageResultSet.cpp => storage/mozStorageResultSet.cpp
rename : storage/src/mozStorageResultSet.h => storage/mozStorageResultSet.h
rename : storage/src/mozStorageRow.cpp => storage/mozStorageRow.cpp
rename : storage/src/mozStorageRow.h => storage/mozStorageRow.h
rename : storage/src/mozStorageSQLFunctions.cpp => storage/mozStorageSQLFunctions.cpp
rename : storage/src/mozStorageSQLFunctions.h => storage/mozStorageSQLFunctions.h
rename : storage/src/mozStorageService.cpp => storage/mozStorageService.cpp
rename : storage/src/mozStorageService.h => storage/mozStorageService.h
rename : storage/src/mozStorageStatement.cpp => storage/mozStorageStatement.cpp
rename : storage/src/mozStorageStatement.h => storage/mozStorageStatement.h
rename : storage/src/mozStorageStatementData.h => storage/mozStorageStatementData.h
rename : storage/src/mozStorageStatementJSHelper.cpp => storage/mozStorageStatementJSHelper.cpp
rename : storage/src/mozStorageStatementJSHelper.h => storage/mozStorageStatementJSHelper.h
rename : storage/src/mozStorageStatementParams.cpp => storage/mozStorageStatementParams.cpp
rename : storage/src/mozStorageStatementParams.h => storage/mozStorageStatementParams.h
rename : storage/src/mozStorageStatementRow.cpp => storage/mozStorageStatementRow.cpp
rename : storage/src/mozStorageStatementRow.h => storage/mozStorageStatementRow.h
rename : storage/src/variantToSQLiteT_impl.h => storage/variantToSQLiteT_impl.h
2015-05-19 10:47:33 -07:00
Birunthan Mohanathas 11f2166660 Bug 1164717 - Flatten storage/public/ directory. r=mak
--HG--
rename : storage/public/StatementCache.h => storage/StatementCache.h
rename : storage/public/mozIStorageAggregateFunction.idl => storage/mozIStorageAggregateFunction.idl
rename : storage/public/mozIStorageAsyncConnection.idl => storage/mozIStorageAsyncConnection.idl
rename : storage/public/mozIStorageAsyncStatement.idl => storage/mozIStorageAsyncStatement.idl
rename : storage/public/mozIStorageBaseStatement.idl => storage/mozIStorageBaseStatement.idl
rename : storage/public/mozIStorageBindingParams.idl => storage/mozIStorageBindingParams.idl
rename : storage/public/mozIStorageBindingParamsArray.idl => storage/mozIStorageBindingParamsArray.idl
rename : storage/public/mozIStorageCompletionCallback.idl => storage/mozIStorageCompletionCallback.idl
rename : storage/public/mozIStorageConnection.idl => storage/mozIStorageConnection.idl
rename : storage/public/mozIStorageError.idl => storage/mozIStorageError.idl
rename : storage/public/mozIStorageFunction.idl => storage/mozIStorageFunction.idl
rename : storage/public/mozIStoragePendingStatement.idl => storage/mozIStoragePendingStatement.idl
rename : storage/public/mozIStorageProgressHandler.idl => storage/mozIStorageProgressHandler.idl
rename : storage/public/mozIStorageResultSet.idl => storage/mozIStorageResultSet.idl
rename : storage/public/mozIStorageRow.idl => storage/mozIStorageRow.idl
rename : storage/public/mozIStorageService.idl => storage/mozIStorageService.idl
rename : storage/public/mozIStorageStatement.idl => storage/mozIStorageStatement.idl
rename : storage/public/mozIStorageStatementCallback.idl => storage/mozIStorageStatementCallback.idl
rename : storage/public/mozIStorageStatementParams.idl => storage/mozIStorageStatementParams.idl
rename : storage/public/mozIStorageStatementRow.idl => storage/mozIStorageStatementRow.idl
rename : storage/public/mozIStorageVacuumParticipant.idl => storage/mozIStorageVacuumParticipant.idl
rename : storage/public/mozIStorageValueArray.idl => storage/mozIStorageValueArray.idl
rename : storage/public/mozStorageHelper.h => storage/mozStorageHelper.h
rename : storage/public/storage.h => storage/storage.h
2015-05-19 10:47:29 -07:00
Birunthan Mohanathas 07e65dcc8f Bug 1165731 - Remove unnecessary SetCapacity call in variant_storage_traits::storage_conversion. r=mak 2015-05-19 10:47:25 -07:00
Eric Rahm 4879ae86f4 Bug 1165518 - Part 2: Replace prlog.h with Logging.h. rs=froydnj 2015-05-19 11:15:34 -07:00
Ryan VanderMeulen 87a9bf8ffd Backed out changesets ba117e790ece and e183bcc18cd3 (bug 1162176) for bustage.
CLOSED TREE
2015-05-19 13:17:01 -04:00
Ben Turner 737bc42a61 Bug 1162176, Part 1. r=mak.
--HG--
extra : rebase_source : 80b7c35704b2a1250ffb5936f367baf6ab424294
2015-05-19 09:17:10 -07:00
Eric Rahm 45167dace5 Bug 1164559 - Part 2: Wrap expensive calls in PR_LOG_TEST. r=froydnj 2015-05-14 10:13:24 -07:00
Eric Rahm 8211d94335 Bug 1164559 - Part 1: Remove instances of #ifdef PR_LOGGING in storage. r=froydnj
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-14 10:13:24 -07:00
Mike Hommey 924c9eb636 Bug 1134923 - Remove NS_Alloc/NS_Realloc/NS_Free. r=nfroyd
They are kept around for the sake of the standalone glue, which is used
for e.g. webapprt, which doesn't have direct access to jemalloc, and thus
still needs a wrapper to go through the xpcom function list and get to
jemalloc from there.
2015-05-01 09:40:30 +09:00
Wes Kocher 10fec54e1c Merge fx-team to m-c a=merge CLOSED TREE 2015-04-29 16:46:00 -07:00
Ben Kelly 81dce6f7c5 Bug 1154325 P1 Add convenience routines to bind and get Blobs as strings. r=asuth 2015-04-29 09:03:15 -07:00
Marco Bonardo 7fea255279 Bug 1159303 - Reduce noise due to sort operations warnings. r=bent 2015-04-28 22:35:48 +02:00
Andrea Marchesini ade2831035 Bug 1156632 - Remove unused forward class declarations - patch 6 - the rest of the tree, r=ehsan 2015-04-22 08:29:24 +02:00
Denis Volk 32e981896d Bug 1095098 - move do_QueryObject templates into their own header; r=froydnj 2015-04-15 12:47:03 -04:00
Ben Kelly 38cbbf3fb9 Bug 1155193 Proxy release the Connection in mozStorageService::unregisterConnection(). r=asuth 2015-04-16 19:12:36 -07:00
Marco Bonardo 9239599394 Bug 1149373 - Ensure mozStorage async threads are shut down. r=bent 2015-04-14 16:11:54 +02:00
Chirag Bhatia 8f1a6fdc91 Bug 1067054 - Remove generic SQLITE_ERROR warning & suppress warning if transaction exists. r=mak
--HG--
extra : rebase_source : 126e1918f828eef3374968cde8ca394a0f856376
2015-04-10 13:16:00 +02:00
Ben Turner 630eacc28d Bug 1131776 - Use WITHOUT ROWID tables for IndexedDB, r=janv. 2015-02-16 09:48:14 -08:00
Ben Turner 04cd5da921 Bug 866846 - Use WAL journal mode for IndexedDB databases, r=janv. 2015-01-24 08:16:26 -08:00
Ben Turner 056431018e Bug 1071360 - Fix async storage connection closing when open fails, r=asuth. 2015-03-27 22:45:28 -07:00
Mike Hommey c39e359c7d Bug 1138293 - Use malloc/free/realloc/calloc instead of moz_malloc/moz_free/moz_realloc/moz_calloc. r=njn
The distinction between moz_malloc/moz_free and malloc/free is not
interesting. We are inconsistent in our use of one or the other, and
I wouldn't be surprised if we are mixing them anyways.
2015-03-31 12:32:49 +09:00
Wes Kocher f8f506a4f1 Backed out changeset 8a8e8efa5d38 (bug 866846) 2015-03-30 19:45:59 -07:00
Wes Kocher 23dabfd770 Backed out changeset 14b9b4827805 (bug 1131776) 2015-03-30 19:45:55 -07:00
Wes Kocher 7a4995bb97 Backed out changeset d4fdf509f242 (bug 1071360) 2015-03-30 19:45:53 -07:00
Ben Turner 89115ceb72 Bug 1071360 - Fix async storage connection closing when open fails, r=asuth. 2015-03-30 13:33:39 -07:00
Ben Turner ad62e4a206 Bug 1131776 - Use WITHOUT ROWID tables for IndexedDB, r=janv. 2015-02-16 09:48:14 -08:00
Ben Turner f9c5b7e194 Bug 866846 - Use WAL journal mode for IndexedDB databases, r=janv. 2015-01-24 08:16:26 -08:00
Andrew McCreight 2f48802ae0 Bug 1147572 - Remove implementation language field from DOM class info. r=jst 2015-03-30 10:45:39 -07:00
Phil Ringnalda 74fbc95715 Backed out 5 changesets (bug 866846, bug 1131776, bug 1131766, bug 1144806, bug 1112702) on suspicion of causing Windows debug devtools-4 storage crashes
CLOSED TREE

Backed out changeset 142d9ae5826c (bug 1131776)
Backed out changeset 0b4de21b759f (bug 1112702)
Backed out changeset 1b4ead852ae0 (bug 1131766)
Backed out changeset cbd862dd036f (bug 866846)
Backed out changeset 178412a2fe8b (bug 1144806)
2015-03-29 12:55:11 -07:00
Andrew McCreight 46dfeaba0b Bug 1148070 - Change nsIClassInfo::getHelperForLanguage() to getScriptableHelper(). r=bholley 2015-03-29 07:52:54 -07:00
Ben Turner 98536af974 Bug 1131776 - Use WITHOUT ROWID tables for IndexedDB, r=janv.
--HG--
extra : rebase_source : 9cba58701e0f6bf4c3d6deb784b5c8340fd895ac
2015-02-16 09:48:14 -08:00
Ben Turner 85be2eae91 Bug 866846 - Use WAL journal mode for IndexedDB databases, r=janv.
--HG--
extra : rebase_source : 6bd130ec0bdbeacde6b725ee16736083775f8ca7
2015-01-24 08:16:26 -08:00
Andrea Marchesini e6f385fb3d Bug 1148527 - Indentation fix after bug 1145631, r=ehsan 2015-03-27 18:52:19 +00:00
Marco Bonardo ae5c54db33 Bug 1005991 - trivial fixes for non-unified builds. r=me 2015-03-24 01:09:13 +01:00
Ehsan Akhgari 883849ee32 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Marco Bonardo fbb580fcfc Bug 1005991 - mozStorage should not use XPCVariant off the main thread. r=asuth 2015-03-12 17:55:56 +01:00
Jon Coppeard a451fdfd83 Bug 963921 - Clients of the JS API should use JS_DefineElement where appropriate r=smaug 2015-03-02 13:31:15 +00:00
Nicholas Nethercote 242708cf72 Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo.
--HG--
extra : rebase_source : 488e401ff87e31a2074c4108c4df0572d9536667
2015-02-09 14:34:50 -08:00
Andrew McCreight d3826daa16 Back out Bug 1127201 (part 2) for various problems. 2015-02-06 15:04:32 -08:00
Nicholas Nethercote d34f0301b8 Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo.
--HG--
extra : rebase_source : 99182e70335d2b5ff95f8c528ae992d37294be3a
2015-02-04 20:05:36 -08:00
Marco Bonardo b04ae3b1d2 Bug 998330 - MinimizeMemory should happen on the opener thread, not on main-thread. r=asuth 2015-01-28 00:00:23 +01:00
Ben Turner afaefae6c7 Bug 1126129 - Only enable SQLite tracing when the right environment variable is set, r=asuth. 2015-01-26 19:38:49 -08:00
Ehsan Akhgari 73e2210610 Bug 1118414 - Mark virtual overridden functions as MOZ_OVERRIDE in storage; r=mak 2015-01-24 14:51:49 -05:00
Ehsan Akhgari 1e88271572 Bug 1119268 - Mark virtual overridden functions as MOZ_OVERRIDE in misc code; r=bsmedberg 2015-01-12 23:26:30 -05:00
Wes Kocher 4a8e595770 Backout c034dba7a417 2015-01-12 14:46:48 -08:00
Ehsan Akhgari d517a30886 Bug 1119268 - Mark virtual overridden functions as MOZ_OVERRIDE in misc code; r=bsmedberg 2015-01-12 16:35:06 -05:00
Tom Schuster 9dfe5c2fd4 Bug 1097267 - Change the enumerate hook usage in XPC and browser. r=bholley 2014-12-11 19:31:10 +01:00
Tom Schuster bc28949aec Bug 993026 - Change XPIDLScriptable NewResolve to simpler Resolve. r=bholley 2014-11-08 01:07:12 +01:00
Mike Hommey 47c853314f Bug 1077148 part 4 - Add and use new moz.build templates for Gecko programs and libraries. r=gps
There are, sadly, many combinations of linkage in use throughout the tree.
The main differentiator, though, is between program/libraries related to
Gecko or not. Kind of. Some need mozglue, some don't. Some need dependent
linkage, some standalone.

Anyways, these new templates remove the need to manually define the
right dependencies against xpcomglue, nspr, mozalloc and mozglue
in most cases.

Places that build programs and were resetting MOZ_GLUE_PROGRAM_LDFLAGS
or that build libraries and were resetting MOZ_GLUE_LDFLAGS can now
just not use those Gecko-specific templates.
2014-10-30 13:06:12 +09:00
Bobby Holley 8e4a68387a Bug 857138 - Add some cx parameters. r=bz 2014-10-23 19:53:31 +02:00
Andrew Halberstadt d292ee73f1 Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester 2014-10-07 18:18:28 -04:00
Shu-yu Guo 59ccd2fecb Bug 1001090 - Part 5: Fix errors in tests throughout the tree. (r=robcee,gavin) 2014-09-15 16:30:47 -07:00
Marco Bonardo 8d53c1682e Bug 1047811 - Part 1 - Allow to commit a main-thread Storage transaction asynchronously. r=asuth 2014-09-10 12:46:14 +02:00
Carsten "Tomcat" Book c70ad543f3 Backed out changeset bc1363a17e0e (bug 1047811) for bustage 2014-09-10 13:08:07 +02:00
Marco Bonardo 681d2c0c88 Bug 1047811 - Part 1 - Allow to commit a main-thread Storage transaction asynchronously. r=asuth 2014-09-10 12:46:14 +02:00
Chris Peterson d126c3c24f Bug 1063962 - Replace jschar typedef with C++11 char16_t type. r=jandem 2014-07-21 21:43:21 -07:00
Ehsan Akhgari 41ee47f38a Bug 1061053 - Fix more bad implicit constructors in storage; r=mak
--HG--
extra : rebase_source : a18eaa1cf7968fb5b8c8923d85bd99d77c427e6e
2014-09-03 18:25:57 -04:00
Mike Hommey 0060683747 Bug 1059090 - Don't require SOURCES to be set for CPP_UNIT_TESTS and SIMPLE_PROGRAMS. r=mshal 2014-09-03 14:16:37 +09:00
Mike Hommey ed70c5f377 Bug 1041941 - Use templates for programs, simple programs, libraries and C++ unit tests. r=gps 2014-09-03 14:10:54 +09:00
Ehsan Akhgari b1b56df2fe Bug 1061254 - Fix more bad implicit constructors in misc. components; r=bsmedberg 2014-09-02 18:24:49 -04:00
Eric Rahm fd41273704 Bug 1049068 - Part 5: Remove unused CallStack params. r=froydnj
--HG--
extra : rebase_source : bb83004815186347253090a334b97f1587997a38
2014-08-08 11:43:58 -07:00
Ehsan Akhgari 23c01b7b38 Bug 1048272 - Fix some bad implicit constructors in storage; r=mak
--HG--
extra : rebase_source : 5fe5099a330cf53fda89f47e76429f1c16f19b06
2014-08-07 19:47:28 -04:00
Mike Hommey 89777800f9 Bug 1047267 - Move remaining OS_LIBS and EXTRA_LIBS to moz.build. r=gps
* * *
Bug 1047267 - To fold with "Move remaining OS_LIBS and EXTRA_LIBS to moz.build"
2014-08-07 14:21:03 +09:00
Mike Hommey d9443ec932 Bug 1045783 - Move most OS_LIBS to moz.build and do some related cleanup. r=mshal 2014-08-06 07:25:33 +09:00
Nathan Froyd 12c76f15f7 Bug 1042878 - part 2 - move MOZ_CAIRO_CFLAGS et al additions to C*FLAGS into moz.build; r=glandium 2014-07-24 11:55:33 -04:00
Mike Hommey 5f6ba110e6 Bug 1043802 - Remove TOOLS_DIRS and TEST_TOOLS_DIRS. r=gps 2014-07-29 08:55:55 +09:00
Mike Hommey 7cab62150a Bug 1041936 part 2 - Directly use the static library "xul" to link into "xul-gtest" instead of having an intermediate library "xul" used by "xul-shared" and "xul-gtest". r=gps 2014-07-23 13:33:09 +09:00
Mike Hommey 95063176fa Bug 1036894 part 9 - Replace all EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS with EXTRA_LIBS, OS_LIBS or OS_LDFLAGS, appropriately. r=gps
OS_LIBS for libraries that are not part of the gecko tree, EXTRA_LIBS for
libraries, such as NSPR, that are in the tree, but are not handled by
moz.build just yet. Those EXTRA_LIBS may also come from a system library.
However, in cases where the expanded variables are always empty for the
in-tree case, OS_LIBS is used (as for, e.g. MOZ_ZLIB_LIBS). OS_LDFLAGS is
used exclusively for non-library linker flags.

Always pass EXTRA_LIBS before OS_LIBS on linker command lines.

Forbid EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS in Makefiles.
2014-07-23 13:31:02 +09:00
Mike Hommey 5fab42fcaf Bug 1036894 part 8 - Move most in-tree library linkage information to moz.build, as USE_LIBS. r=gps 2014-07-23 13:30:52 +09:00
Mike Hommey 6d6d400ea1 Bug 1036894 part 6 - Emit SimplePrograms for CPP_UNIT_TESTs, and make the corresponding moz.build config look like that of SIMPLE_PROGRAMS. r=gps 2014-07-23 13:29:44 +09:00
Mike Hommey 622bf09730 Bug 1041864 - Remove LIBRARY_NAMEs that aren't used. r=mshal 2014-07-23 08:39:56 +09:00
Mike Hommey bc5d6801bb Bug 1041860 - Avoid setting FINAL_LIBRARY to libraries that further use a FINAL_LIBRARY. r=mshal 2014-07-23 08:37:51 +09:00
Mike Hommey d3f990ebdb Bug 1040639 - Remove LIBS_DIR. r=mshal 2014-07-19 08:42:16 +09:00
Andrew McCreight c3a80ae7ac Bug 1038207 - Fix various classes that reimplement nsISupports. r=ehsan 2014-07-14 12:21:34 -07:00
Jan de Mooij 8772025bff Bug 1034689 part 3 - Fix remaining places in Gecko to handle Latin1 strings. r=bz 2014-07-12 09:43:08 +02:00
Benoit Jacob 5c26f530f0 Bug 1035394 - Fix dangerous public destructors in storage - r=bent 2014-07-08 17:23:17 -04:00
Jan de Mooij 44da586636 Bug 1034191 - Make nsDependentJSString users work with Latin1 strings and nursery-allocated strings. r=bz 2014-07-05 17:30:54 +02:00
Jim Blandy 7e20285e70 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Benoit Jacob 666893d878 Bug 1028588 - Fix dangerous public destructors in storage/ - r=bent 2014-06-23 18:40:03 -04:00
Birunthan Mohanathas 51ba75d135 Bug 1016240 - Exterminate CR+LF line endings. r=briansmith,cpearce,ehsan,gavin 2014-06-18 17:56:02 -07:00
Nicholas Nethercote aaf6fb2124 Bug 1010064 - Allow memory reports to be anonymized. r=bsmedberg.
--HG--
extra : rebase_source : 5eb756b17a97e751deb0f47e909fdb35533cb23b
2014-05-20 23:06:54 -07:00
Jan Beich 6cae557a25 Bug 1026828 - Restore MOZ_STORAGE_MEMORY for system jemalloc after bug 938730. r=glandium 2014-06-17 17:55:00 +02:00
Robert O'Callahan cbb8fdebfc Bug 1015664. Part 1: Remove NS_HIDDEN_() usage. r=bsmedberg 2014-06-03 00:08:21 +12:00
Victor Porof 9ce7e9c089 Bug 1007203 - Always add categories when pushing to the pseudostack, r=djvj 2014-05-23 17:12:29 -04:00
Birunthan Mohanathas 59b969f7f4 Bug 869836 - Part 8: Use `Append('c')` instead of `Append("c")`. r=ehsan 2014-05-22 06:48:52 +03:00
Birunthan Mohanathas aea8617b92 Bug 869836 - Part 7: Use AppendLiteral instead of Append where possible. r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas 0e6f3a6562 Bug 869836 - Part 3: Use `Append('c')` instead of `AppendLiteral("c")`. r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas 19bebbc68d Bug 869836 - Part 2: Use AppendLiteral instead of `Append(NS_LITERAL_STRING(...))`. r=ehsan 2014-05-22 06:48:50 +03:00
Daniel Holbert 21f04fddf9 Bug 1003907: Annotate storage/src as FAIL_ON_WARNINGS. r=mak 2014-05-01 09:31:54 -07:00
Daniel Holbert 01e4365085 Bug 1003902: Drop 'const' qualifier from arg in EscapeStringForLIKE() function-decl to make it match the IDL-generated decl. r=mak 2014-05-01 09:31:54 -07:00
Chris Peterson a6ddabc2bf Bug 1002891 - Fix -Wunused-variable warning in storage. r=mak 2014-04-28 19:41:18 -07:00
Daniel Holbert ceb0c0ab11 Bug 1003921: Use NS_WARN_IF_FALSE instead of NS_WARN_IF to fix warning in mozStorageAsyncStatementExecution.cpp. r=mak 2014-04-30 15:41:05 -07:00
Jon Coppeard 1216544376 Bug 959787 - Handlify remaining JS APIs r=terrence r=bz r=bholley 2014-04-30 10:10:33 +01:00
Rodrigo Rodriguez Jr. 3a5329b969 Bug 952650 (part 11) - Remove JSVAL_TO_INT. r=njn.
--HG--
extra : rebase_source : 41923458bbf8fd957c9a57685df4969f1190bd9f
2014-04-27 19:55:08 -07:00
ISHIKAWA, Chiaki f8da2ef72f Bug 963554 - Defining MOZ_STORAGE_SORTWARNING_SQL_DUMP prints the SQL command that invoked sorting in the log. r=mak
The default short warning et al is not *THAT* useful even if one may
be able to dump the original SQL command using environment variable
for later correlation.  Defining MOZ_STORAGE_SORTWARNING_SQL_DUMP will
enable the printout of SQL command directly in the log .
2014-04-28 20:15:00 -04:00
Birunthan Mohanathas 5f1fde8824 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Jason Orendorff 4740c9dea6 Bug 547140, part 4 - Remove flags argument from resolve hooks. r=Waldo. 2014-04-25 16:11:02 -05:00
Marco Bonardo 6fe8efecb8 Bug 914070 - Part 3 - Make async transaction management work with a null mDBConn. r=asuth 2014-04-24 11:54:15 +02:00
Marco Bonardo bf86937455 Bug 914070 - Part 2 - nullify mDBConn at setClosedState and provide an isClosed helper. r=asuth 2014-04-24 11:54:12 +02:00
Marco Bonardo 528ab442ef Bug 914070 - Part 1 - Remove native connection getters from Storage connection. r=asuth 2014-04-24 11:54:09 +02:00
Nochum Sossonko bfd9a489d3 Bug 481178 - mozIStorageConnection createTable and tableExists should support attached databases. r=mak 2014-04-09 09:22:33 -04:00
Jon Coppeard 92f0d66be8 Bug 959787 - Handlify remaining JS APIs r=sfink r=bholley r=smaug 2014-04-02 15:28:03 +01:00
Ehsan Akhgari 186680d83a Bug 798158 - Part 1: Use a pointer-sized type to store refcounts internally; r=bsmedberg 2014-03-27 16:38:33 -04:00
Gabriele Svelto 5f8616903a Bug 411894 - Flush all mozStorageConnections' caches in response to memory pressure events. r=mak 2014-03-27 11:19:49 +01:00
Paolo Amadini c1739b687d Bug 984788 - Convert legacy uses of promise.js to Promise.jsm. rs=Yoric 2014-03-18 15:16:02 +01:00
Neil Rashbrook 604d9a5302 Bug 514280 Stop using nsCOMPtr for concrete types r=bsmedberg
--HG--
extra : rebase_source : f8fb50de9292320eb7589dd28dc566d0f5044da6
2014-03-18 00:23:03 +00:00
Wes Kocher c879b47079 Backed out 2 changesets (bug 514280) for OSX build bustage on a CLOSED TREE
Backed out changeset 2a015b45d808 (bug 514280)
Backed out changeset a01f97c1ed02 (bug 514280)
2014-03-17 15:19:53 -07:00
Neil Rashbrook 3e8915c4b8 Bug 514280 Stop using nsCOMPtr for concrete types r=bsmedberg
--HG--
extra : rebase_source : eaca8b2925eaffb49e29a617cd72c0d6686e6d9e
2014-03-17 19:07:09 +00:00
Aaron Klotz 4ebf28f26c Bug 972577: Consolidate IOInterposer initialization code; r=froydnj,BenWa,jimm
--HG--
rename : tools/profiler/IOInterposer.cpp => xpcom/build/IOInterposer.cpp
rename : tools/profiler/IOInterposer.h => xpcom/build/IOInterposer.h
rename : tools/profiler/NSPRInterposer.cpp => xpcom/build/NSPRInterposer.cpp
rename : tools/profiler/NSPRInterposer.h => xpcom/build/NSPRInterposer.h
rename : toolkit/xre/nsWindowsDllInterceptor.h => xpcom/build/nsWindowsDllInterceptor.h
2014-03-14 16:35:01 -06:00
Wes Kocher a20307b017 Backed out changeset 2bdd2d042847 (bug 972577) for non-unified bustage on a CLOSED TREE
--HG--
rename : xpcom/build/nsWindowsDllInterceptor.h => toolkit/xre/nsWindowsDllInterceptor.h
rename : xpcom/build/IOInterposer.cpp => tools/profiler/IOInterposer.cpp
rename : xpcom/build/IOInterposer.h => tools/profiler/IOInterposer.h
rename : xpcom/build/NSPRInterposer.cpp => tools/profiler/NSPRInterposer.cpp
rename : xpcom/build/NSPRInterposer.h => tools/profiler/NSPRInterposer.h
2014-03-14 15:27:21 -07:00
Aaron Klotz ae4aa8bc28 Bug 972577: Consolidate IOInterposer initialization code; r=froydnj,BenWa,jimm
--HG--
rename : tools/profiler/IOInterposer.cpp => xpcom/build/IOInterposer.cpp
rename : tools/profiler/IOInterposer.h => xpcom/build/IOInterposer.h
rename : tools/profiler/NSPRInterposer.cpp => xpcom/build/NSPRInterposer.cpp
rename : tools/profiler/NSPRInterposer.h => xpcom/build/NSPRInterposer.h
rename : toolkit/xre/nsWindowsDllInterceptor.h => xpcom/build/nsWindowsDllInterceptor.h
2014-03-14 13:47:24 -06:00
Kyle Huey d5f97f50bf Bug 979445: Add API to mozStorage for adopting blob data and use that in IDB to avoid unnecessary copies. r=bent 2014-03-06 13:03:52 -08:00
Kyle Huey 2ffecf71ae Backout bug 979445 due to clang build failures. CLOSED TREE 2014-03-06 11:19:44 -08:00
Kyle Huey 041504b25d Bug 979445: Add API to mozStorage for adopting blob data and use that in IDB to avoid unnecessary copies. r=bent 2014-03-06 11:01:13 -08:00
Ehsan Akhgari 9df66916f4 Bug 973405 - Move some misc LOCAL_INCLUDES to moz.build; r=glandium 2014-02-18 08:49:12 -05:00
Jon Coppeard d0e56d0b88 Bug 969812 - Convert JS_NewArrayObject to use HandleValueArray r=terrence r=bz 2014-02-12 10:50:46 +00:00
Jon Coppeard bfba7b5146 Bug 963167 - Convert JS_SetElement() to take HandleValue rather than MutableHandleValue r=sfink r=bz 2014-01-25 09:31:17 +00:00
Terrence Cole d902eeddc8 Bug 959787 - Handlify several JSAPI interfaces that can GC, Part 4; r=sfink,r=bz
--HG--
extra : rebase_source : 8e1ff566f47795cd82e3f4c0a6fa37b88e7847b4
2014-01-17 10:08:51 -08:00
Tom Schuster f39e81815a Bug 939294 - Change xpidl jsval to handles. r=gabor,bz,khuey,bsmedberg,terrence 2014-01-09 18:39:36 +01:00
Daniel Holbert f0216348aa Bug 945063: Annotate storage/build and storage/test as FAIL_ON_WARNINGS. r=mak 2014-01-08 11:04:03 -08:00
Ehsan Akhgari 1b83407ce9 Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
This patch was automatically generated by the following script:

#!/bin/bash
# Command to convert PRUnichar to char16_t

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*modules/libmar*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name prtypes.h \
       ! -name Char16.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
Ms2ger 561cae4a0e Bug 950130 - Move more INCLUDES / LOCAL_INCLUDES to moz.build; r=mshal 2013-12-31 10:06:11 +01:00
Steve Fink 6fd0c4d072 Bug 952682 - New hazards in storage code, r=terrence 2013-12-20 15:58:36 -08:00
Nicholas Nethercote 8bbe1e2dc1 Bug 947798 (part 2) - Remove MemoryMultiReporter, because it's no longer helpful. r=mccr8.
--HG--
extra : rebase_source : f6f74de69d8c1d79d38b84b19dff5439efc41075
2013-12-07 21:39:47 -08:00
Nicholas Nethercote 6e5e55931d Bug 947798 (part 1) - Rename NS_MEMORY_REPORTER_MALLOC_SIZEOF_FUN as MOZ_DEFINE_MALLOC_SIZE_OF. r=mccr8.
--HG--
extra : rebase_source : ec09d4c31264c15befb020375bf001a1ad1df6b8
2013-12-07 21:38:32 -08:00
Birunthan Mohanathas 3440613a39 Bug 713082 - Part 2: Rename Util.h to ArrayUtils.h. r=Waldo
--HG--
rename : mfbt/Util.h => mfbt/ArrayUtils.h
2013-12-08 21:52:54 -05:00
Birunthan Mohanathas 68b00083fd Bug 713082 - Part 1: Remove unnecessary Util.h includes. r=Waldo 2013-12-08 21:52:33 -05:00
Nicholas Nethercote b413e441cf Bug 943660 (part 2) - Remove remnants of Remove nsIMemoryReporter::name.
--HG--
extra : rebase_source : 900bd1c641b26623cccf14d952b5387223b489eb
2013-12-03 20:01:24 -08:00
Nicholas Nethercote 39004db706 Bug 936964 (part 7, attempt 2) - Make lots of classes report their own memory consumption, instead of using a separate reporter class. r=mccr8,sr=bz.
* * *
Bug 936964 (part 7b) - Fix a use-after-free found by ASan.

--HG--
extra : rebase_source : d38ab6b63e9d576773baf8e55fa4f7182c33915e
2013-11-07 16:35:30 +11:00
Mike Hommey 8fd06cf41b Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal 2013-11-27 22:55:07 +09:00
Mike Hommey b32a4ed166 Backout changeset 3fd4b546eed4 (bug 874266) and changeset a35d2e3a872f (bug 942043) for ASAN build bustage and Windows test bustage
--HG--
extra : amend_source : f20d09aeff1c8b5cbd0f1d24c7ce04e86f3aed1d
2013-11-28 14:24:05 +09:00
Mike Hommey 682364d535 Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal 2013-11-28 13:08:16 +09:00
Ehsan Akhgari a903aefdc0 Backed out 9 changesets (bug 943660, bug 936964) because of ASAN use-after-free crashes on browser-chrome and mochitest-other
Backed out changeset 85486c4aa3d8 (bug 936964)
Backed out changeset 25312eb71998 (bug 936964)
Backed out changeset 6dbb8333960c (bug 936964)
Backed out changeset da6465ad476f (bug 936964)
Backed out changeset a87ffc992f38 (bug 936964)
Backed out changeset 4ae3a61182db (bug 936964)
Backed out changeset 34e9c3137804 (bug 936964)
Backed out changeset fd1459e71585 (bug 936964)
Backed out changeset 3e8a701d8bdc (bug 943660)

Landed on a CLOSED TREE

--HG--
rename : content/canvas/src/WebGLMemoryTracker.h => content/canvas/src/WebGLMemoryReporterWrapper.h
2013-11-27 20:05:00 -05:00
Nicholas Nethercote bc475c75df Bug 936964 (part 7) - Make lots of classes report their own memory consumption, instead of using a separate reporter class. r=mccr8,sr=bz.
--HG--
rename : content/canvas/src/WebGLMemoryReporterWrapper.h => content/canvas/src/WebGLMemoryTracker.h
extra : rebase_source : 611e8d35907959b163aeced1c4ffe1d265048fe6
2013-11-07 16:35:30 +11:00
Ryan VanderMeulen 6777d0901e Merge m-c to inbound. 2013-11-22 15:37:03 -05:00
Peiyong Lin aae3e9745a Bug 939297 - Replace #ifdef DEBUG with mozilla::DebugOnly<nsresult> in mozIStorageValueArray.idl. r=mak 2013-11-22 11:04:49 -05:00
Trevor Saunders 9f254378b2 bug 938025 - part 1 - get rid of some static constructors r=bz r=bjacob 2013-11-22 14:45:50 -05:00
Kai Engert 1961aa2ab2 Bug 938730 - avoid mix of memory allocators (crashes) when using system sqlite, r=asuth 2013-11-20 20:25:12 +01:00
Nicholas Nethercote d43b81a00e Bug 819801 - In DMD builds, check that SQLite's reporting of its total memory consumption are correct. r=asuth.
(NPOTB because it's DMD-only changes.)
2013-11-15 05:11:10 -08:00
Mike Hommey 2812d11fce Bug 939632 - Remove LIBRARY_NAME for leaf libraries. r=gps
Landing on a CLOSED TREE.
2013-11-19 11:50:54 +09:00
Mike Hommey e06d795c71 Bug 939074 - Remove most LIBXUL_LIBRARY. rs=gps 2013-11-19 11:48:10 +09:00
Mike Hommey 26bc04d200 Bug 939044 - Rename remaining MODULE definitions to XPIDL_MODULE. r=mshal 2013-11-19 11:47:43 +09:00
Mike Hommey e80e877ab7 Bug 939044 - Remove most definitions of MODULE. r=mshal 2013-11-19 11:47:39 +09:00
Mike Hommey ffe0380912 Bug 935881 - Use FINAL_LIBRARY for all (fake) libraries that end up linked in a single other library. r=gps 2013-11-19 11:47:14 +09:00
Ehsan Akhgari fe8dfba017 Bug 939611 - Build storage/src in unified mode; r=asuth 2013-11-18 16:26:44 -05:00
Philipp Böhnke 019df31281 Bug 653844 - Remove ifdefs for PR_LOGGING if not needed. r=mak 2013-11-15 21:46:36 -05:00
Nicholas Nethercote 3eae0dfea5 Bug 934321 - Add MemoryMultiReporter, a helper class that reduces some boilerplate, and convert all existing multi-reporters to use it. r=wchen.
--HG--
extra : rebase_source : a6110c3558c571b7908b63e8cc7ca21103098d0d
2013-11-06 14:58:20 +11:00
Jonas Finnemann Jensen 41edf8980c Bug 902587 - Part 2A: Refactor late-write-checks as client of IO Interposer. r=BenWa
--HG--
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/LateWriteChecks.h
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/PoisonIOInterposer.h
rename : xpcom/build/mozPoisonWriteBase.cpp => xpcom/build/PoisonIOInterposerBase.cpp
rename : xpcom/build/mozPoisonWriteMac.cpp => xpcom/build/PoisonIOInterposerMac.cpp
rename : xpcom/build/mozPoisonWriteWin.cpp => xpcom/build/PoisonIOInterposerWin.cpp
2013-11-05 07:45:20 -05:00
Nicholas Nethercote 3b80765894 Bug 925584 - Remove some unnecessary jsapi.h inclusions from .cpp files. r=Ms2ger.
--HG--
extra : rebase_source : 41fcb0e922a519ef679c1c1b6293c2b638e83a48
2013-10-10 15:22:35 -07:00
Carsten "Tomcat" Book d7e4c57fbb Merge Fx-Team to Mozilla-Central 2013-10-25 11:21:15 +02:00
Mike Hommey b000a846c2 Bug 929905 - Consolidate sources in moz.build. r=gps 2013-10-25 08:23:05 +09:00
Paolo Amadini 39efd6c567 Bug 915214 - Fix possible crash when shutting down the database connection in mozStorageConnection.cpp. r=Yoric 2013-10-24 13:25:04 +02:00
Carsten "Tomcat" Book 0e4e01758c Merge mozilla-inbound to Mozilla-Central 2013-10-24 07:05:29 +02:00
Mike Hommey 59a17d0f20 Bug 921492 - Make StrictOrderingOnAppendList use actual alphabetical sorting. r=mshal,r=gps 2013-10-24 08:05:43 +09:00
Marco Bonardo 965e44f08a Bug 918612 - Stop masking the underlying Sqlite VFS version in the Telemetry VFS. r=bent 2013-10-23 14:58:06 +02:00
Birunthan Mohanathas 6f158bc61c Bug 784739 - Switch from NULL to nullptr in miscellaneous directories; r=ehsan
--HG--
extra : rebase_source : 9335e9b4b0ac02e8066fbb79797bbc0d3fd73874
2013-10-23 16:36:09 -04:00
Benjamin Smedberg b5fb993e7f Bug 753687 - nsCategoryCache implementation doesn't free old category entries if their contract mapping is removed using .unregisterFactory. Store the factory objects directly in the map, instead of keeping both a map and a separate list. r=froydnj 2013-10-10 08:48:03 -04:00
Ms2ger f4153f40d4 Bug 900980 - Part a: Move unconditional assignments to EXPORT_LIBRARY to moz.build; rs=gps 2013-10-03 09:11:13 +02:00
Aaron Klotz 44e3459f45 Bug 888534: Add support for Create, Stat and Close operations to IOInterposer. r=jonasfj
--HG--
extra : rebase_source : 6b7e75ae35e3250383f3990dce2680df44f4ec68
2013-10-01 13:53:19 -06:00
Wes Kocher edf79e60e0 Merge fx-team to m-c 2013-09-27 20:32:24 -07:00
Mark Capella faf62388a2 Bug 472963 - TableExists and IndexExists does not work for temporary tables, r=mak 2013-09-27 17:04:17 -04:00
Benjamin Peterson 4c6afe3535 Bug 919830 - Mark a variable only used in an assertion DebugOnly. r=mak
--HG--
extra : rebase_source : d0203b051e011bf9a2d46216f798904db879c49d
2013-09-27 12:14:28 -04:00
Nicholas Nethercote dc5c29f71c Bug 913260 (part 4) - Use distinguished amounts for all the memory measurements done by telemetry. r=mccr8.
CLOSED TREE
2013-09-19 15:52:30 -07:00
Phil Ringnalda 12216d4f00 Backed out 3 changesets (bug 913260)
CLOSED TREE

Backed out changeset 9195be8a50cb (bug 913260)
Backed out changeset 09c71a3e7b85 (bug 913260)
Backed out changeset 8a8691a26012 (bug 913260)
2013-09-24 20:31:00 -07:00
Nicholas Nethercote a51a1d18a4 Bug 913260 (part 4) - Use distinguished amounts for all the memory measurements done by telemetry. r=mccr8.
--HG--
extra : rebase_source : 0e9db51b137770ba7db15a99a4ec1e87071d2f47
2013-09-19 15:52:30 -07:00
Gregory Szorc 7bd3c0ae36 Bug 901990 - Part 2: Upgrade xpcshell manifests; r=ted
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell-unpack/head_unpack.js => toolkit/mozapps/extensions/test/xpcshell/head_unpack.js
2013-09-24 11:50:08 -07:00
Ehsan Akhgari c8d51e9ce2 Bug 919341 - Minimize the #includes in xpcom/ IDL files; r=bsmedberg 2013-09-23 13:29:27 -04:00
Ed Morley 2f579f2c8b Merge latest green inbound changeset and mozilla-central 2013-09-20 10:18:21 +01:00
David Rajchenbach-Teller 3d7fc9629f Bug 914005 - Tweak storage warnings on shutdown. r=mak 2013-09-19 09:19:02 -04:00
Ryan VanderMeulen 77f55ca219 Backed out changeset ad57b713ac46 (bug 914005) for bustage. 2013-09-19 09:18:14 -04:00
David Rajchenbach-Teller 55ac96f9e7 Bug 914005 - Tweak storage warnings on shutdown. r=mak 2013-09-19 08:56:10 -04:00
Benoit Jacob 229d2760cd Bug 913847 - Include MainThreadUtils.h instead of nsThreadUtils.h - r=ehsan 2013-09-19 09:54:42 -04:00
Benoit Jacob ef57b5655b Bug 913847 - stop needlessly including nsThreadUtils.h - r=ehsan 2013-09-19 09:54:39 -04:00
Wes Kocher de3dfc4a8e Backed out changeset 554bfe767519 (bug 913847) for leaking on a CLOSED TREE 2013-09-18 17:21:02 -07:00
Wes Kocher 0b90687d1e Backed out changeset 040522aacba4 (bug 913847) 2013-09-18 17:18:56 -07:00
Benoit Jacob 5526ea7b69 Bug 913847 - Include MainThreadUtils.h instead of nsThreadUtils.h - r=ehsan 2013-09-18 18:50:32 -04:00
Benoit Jacob 1b7e3c520e Bug 913847 - stop needlessly including nsThreadUtils.h - r=ehsan 2013-09-18 18:50:32 -04:00
Jonas Finnemann Jensen 63757ffdc4 Bug 902587 - Fix missing destructor in IOInterposer.cpp ifndef MOZ_ENABLE_PROFILER_SPS. r=aklotz 2013-09-14 22:08:11 -04:00
Ryan VanderMeulen 251d74b55c Bug 902587 - Part 1 follow-up: Remove include of deleted file. 2013-09-12 11:15:04 -04:00
Jonas Finnemann Jensen dac3c3a20c Bug 902587 - Part 1: Refactor IO Interposer with filename support. r=aklotz 2013-09-12 10:47:37 -04:00
Nicholas Nethercote 7983bb2a7f Bug 910517 (3rd attempt) - Remove nsIMemoryReporter, and rename nsIMemoryMultiReporter as nsIMemoryReporter. r=mmcr8.
--HG--
rename : content/canvas/src/WebGLMemoryMultiReporterWrapper.h => content/canvas/src/WebGLMemoryReporterWrapper.h
extra : rebase_source : 2b2a1b2667d6562fcf803ec48b4a8c10fdd519a3
2013-08-27 16:24:51 -07:00
Jan Varga e9492bcd36 Bug 785884 - Implement support for temporary storage (aka shared pool). r=ehsan, r=bent
--HG--
rename : caps/tests/mochitest/test_principal_extendedorigin_appid_appstatus.html => caps/tests/mochitest/test_principal_jarprefix_origin_appid_appstatus.html
rename : dom/quota/UsageRunnable.h => dom/quota/UsageInfo.h
2013-09-11 06:18:36 +02:00
Ehsan Akhgari 354328adc4 Bug 913830 - Remove more unneeded #includes from the xpconnect IDL files; r=bholley 2013-09-09 22:37:37 +02:00
Ed Morley f7bce95a91 Backed out changeset 5c9f3fb14995 (bug 910517) for Android talos failures
--HG--
rename : content/canvas/src/WebGLMemoryReporterWrapper.h => content/canvas/src/WebGLMemoryMultiReporterWrapper.h
2013-09-09 16:07:48 +01:00
Nicholas Nethercote cc604f4854 Bug 910517 - Remove nsIMemoryReporter, and rename nsIMemoryMultiReporter as nsIMemoryReporter. r=mmcr8.
--HG--
rename : content/canvas/src/WebGLMemoryMultiReporterWrapper.h => content/canvas/src/WebGLMemoryReporterWrapper.h
extra : rebase_source : 76bf96ce8d6e16c8573584d9e8e70c80371f66eb
2013-08-27 16:24:51 -07:00
Robert O'Callahan 03e7828db2 Bug 910989. Remove nsTHashtable::Init, fallible allocation, and MT hashtables. r=ehsan,bsmedberg
--HG--
extra : rebase_source : 0787130b1814c74bfb38dc178de94022f0b2e64e
2013-09-02 20:41:57 +12:00
Phil Ringnalda 26ceee4fb5 Back out 4537337759b7 (bug 910517) because nobody expects the talos inquisition
--HG--
rename : content/canvas/src/WebGLMemoryReporterWrapper.h => content/canvas/src/WebGLMemoryMultiReporterWrapper.h
2013-09-04 22:42:06 -07:00
Nicholas Nethercote 1f32372424 Bug 910517 - Remove nsIMemoryReporter, and rename nsIMemoryMultiReporter as nsIMemoryReporter. r=mmcr8.
--HG--
rename : content/canvas/src/WebGLMemoryMultiReporterWrapper.h => content/canvas/src/WebGLMemoryReporterWrapper.h
extra : rebase_source : 9142be547b2eeef37a8073a710ce23070f98cf65
2013-08-27 16:24:51 -07:00
Wes Kocher 545fbb7bd2 Merge m-c to inbound 2013-09-04 18:04:50 -07:00
Mike Hommey f8bc7fa754 Bug 912293 - Remove now redundant boilerplate from Makefile.in. r=gps 2013-09-05 09:01:46 +09:00
David Rajchenbach-Teller 00e7dae5ac Bug 911109 - Statement::internalFinalize now doesn't cause finalization if the connection is already closed. r=asuth 2013-09-04 12:51:45 -04:00
Nicholas Nethercote 01c70c8c97 Bug 911020 - Introduce js/TypeDecls.h, which holds very commonly used type declarations from the JS engine. r=luke.
--HG--
extra : rebase_source : 008ef689989f93b46627b8be8608bdbc544ca3a2
2013-08-27 19:59:14 -07:00
Gregor Wagner 0cdde3eb06 Bug 870951 - VacuumManager asserts when running in a child process. r=bent 2013-08-29 09:10:35 -07:00
Nicholas Nethercote a7c43d2502 Bug 831193 (part 6) - Don't use NS_MEMORY_REPORTER_IMPLEMENT in mozStorageService.cpp. r=mak.
--HG--
extra : rebase_source : e7eb250f4eb64187e025adbc1fc824be29c45b15
2013-01-17 16:45:11 -08:00
David Rajchenbach-Teller 007c70de56 Bug 874814 - Close AsyncClose() off the main thread and loop until all statements are finalized. r=mak 2013-08-27 17:07:04 -04:00
Geoff Brown fd9a8160b1 Bug 865006 - (4) Add more xpcshell tests for android; r=jmaher 2013-08-25 10:58:31 -06:00
Ms2ger f805d8d6eb Merge m-c to inbound 2013-08-22 10:38:48 +02:00
Ms2ger 3a103a7e9f Bug 883284 - Part f: Move LIBXUL_LIBRARY into moz.build (p-z); r=glandium 2013-08-22 08:56:01 +02:00
Nicholas Nethercote 2585de9a07 Bug 905017 (part 1) - Minimize inclusions of JS engine headers in .h and .idl files. r=billm.
--HG--
extra : rebase_source : 984c61ab12f46be0509b1ce0d458d9a6e5841c64
2013-08-17 15:50:18 -07:00
Trevor Saunders e62a12b52f bug 886526 - remove IS_COMPONENT and MODULE_NAME makefile vars for things in libxul r=bsmedberg r=glandium 2013-08-08 20:12:37 -04:00
Nicholas Nethercote 9624be5713 Bug 901750 - Change return type of |JSNative| from |JSBool| to |bool|. code=nnethercote,jandem. r=luke,bz.
--HG--
extra : rebase_source : 5b3d7cc339af6d93bde078322e25c6e740d1b617
2013-08-02 00:41:57 -07:00
Jon Coppeard fb6671743e Bug 900986 - Convert JS_*Element API to use MutableHandleValue for out params r=terrence r=bholley r=smaug 2013-08-05 14:02:47 +01:00
Birunthan Mohanathas 521d66d83e Bug 784739 - Switch from NULL to nullptr in storage/; r=ehsan 2013-07-31 11:44:58 -04:00
Trevor Saunders 108b7dd046 backout bug 886526 because it probably made us use a lot more memory to link on windows 2013-07-29 11:03:21 -04:00
Ms2ger 10d5739f7a Bug 888643 - Part b: Move CPP_UNIT_TESTS definitions into moz.build files; r=gps 2013-07-24 09:23:06 +02:00
Joshua Cranmer 9267a6c925 Bug 884061 - Part 3u: Use NS_DECL_THREADSAFE_ISUPPORTS in storage/, r=mak
--HG--
extra : rebase_source : fdc61fe0dad1e88c33325e32c755ed8f2c389af2
2013-07-18 21:24:15 -05:00