I'm reluctant to mass-delete strings, since that could cause our l10n
team some grief in the event of a rollback. And it's not obviously
easy to get them all back smoothly. I'll delete strings separately.
--HG--
extra : commitid : 1EnkJkSQB0k
extra : rebase_source : 44b5e61b90b41821d35ec8c0f30c7f508e58d716
extra : histedit_source : 285735259af6a7eb6d11f58834e2285f2c9b344b
The web based Activity sub-classes never used the other intent extras,
and in fact, filter them out immediately; so it doesn't hurt to clean
this all up.
--HG--
extra : commitid : KggZGk67ElE
extra : rebase_source : 40ecabce597eb0bb2c6326a14c2153eb969e06ee
extra : histedit_source : 02836f27b4c99c1d294b46c0c47a61f2f59aef0b
I haven't been able to test this, since the patch is relevant to Nightly
but the behaviour doesn't happen.
--HG--
extra : commitid : EQ5qVuEduv1
extra : rebase_source : adfa48984bdab71b22f86394149e78051385ae57
extra : histedit_source : 7dc7262ad08168213d4b11d5015ce1fddb450c6f
This patch leverages broadcasters to keep the various sync UI elements sane.
Rather than adding yet another button ID to browser-syncui, we now just update
the broadcaster and let all the elements automagically get the attributes.
This required us to use the menu button to open the menu and check
if the menu is open by looking at more menu items due to intermittent
issues where the menu would not always be scrolled to the top (I
think Robotium scrolled the menu before it finished appearing so
we couldn't see the first item and failed the isOpen test).
--HG--
extra : commitid : CvdAxG8eqKw
extra : rebase_source : 85b7f795ccc2711d5b2a53d477caeb83484cee9b
We added some Asserts but the robocop tests fail for an unknown reason. The
error was:
E/MessageQueue-JNI( 1972): java.lang.IllegalAccessError: Class ref in pre-verified class resolved to unexpected implementation
I tried a few things but in the end just decided to remove them.
--HG--
extra : commitid : vhLV0zb3vp
extra : rebase_source : 714e35ffada24587636c75cc882757f93a509a17
ic_menu_back was not in the v11 folder so I moved the all-API asset to the v11
folder.
--HG--
rename : mobile/android/base/resources/drawable-hdpi/ic_menu_back.png => mobile/android/base/resources/drawable-hdpi-v11/ic_menu_back.png
rename : mobile/android/base/resources/drawable-xhdpi/ic_menu_back.png => mobile/android/base/resources/drawable-xhdpi-v11/ic_menu_back.png
extra : commitid : ASnzeySsrYa
extra : rebase_source : ede08d251cbcd03a74dfdca02627229e8dd0aa8a
This required us to use the custom menu inflater and panels on GB.
One side effect of this change is that the menu button no longer
closes the menu on GB. I tried to fix this but BrowserApp.onKeyDown
is not fired when the menu is open on GB and I'm not sure why that
is. However, I don't think it's worth my time to fix since it's GB.
--HG--
extra : commitid : D6r3O8bmcqP
extra : rebase_source : ec59d37483da7db42d252ddee672a04de8e9e203
Currently all rules are commented out except eol-last.
--HG--
extra : commitid : LNskOtOlV0S
extra : rebase_source : f58910dde85902a33d0c148df19d18244b7202a4
Instead of having the various positions and sizes of elements of the timeline
defined in pixels, this defines them in % of the total width.
This way the animations, scrubber, etc... adapt as you resize the panel.
The only complex thing here is resizing the header and background. Both of
them are generated via javascript. To do this, they are now positioned and sized
in % too, so they resize when the window is resized, and after a debounced
delay, they get re-generated too.
--HG--
extra : commitid : XRFyYaY2uz
extra : histedit_source : d2ed20a625eaf22672af9c2eb4603189d65a4145%2Cf1153001150848ace5c512e5894c3b72593dfd0d