HLSResourceCallbacksSupport::mDecoder is cleared on main thread too, so
the nullness check already ensures decoder methods won't be called after
shut down. In fact, for OnError() the lock is harmful because the task calls
MediaDecoder::NetworkError(), which triggers decoder shutdown and eventually
HLSResourceCallbacksSupport::Detach(), which tries to lock the mutex again
while the mutex is still locked.
Differential Revision: https://phabricator.services.mozilla.com/D16709
--HG--
extra : moz-landing-system : lando
VIEWPORT_MODE_DESKTOP *forces* the desktop mode viewport everywhere, whereas
VIEWPORT_MODE_MOBILE merely enables <meta> viewport support for pages that have
that tag defined, but still uses the desktop mode viewport for all other pages.
Differential Revision: https://phabricator.services.mozilla.com/D17159
--HG--
extra : moz-landing-system : lando
This patch is similar to Bug 1503420 Part 1.
nsIFrame::List()'s second argument should be a const char*, not an
integer. It'll crash if we pass 0 as const char*. Fix the bug by
omitting the argument because the default value of the argument is an
empty string.
Differential Revision: https://phabricator.services.mozilla.com/D17300
--HG--
extra : moz-landing-system : lando
There are two parts to this:
When the controller receives the first result and the context has an autofill value, then call a new input.autofill() method, which does the actual autofill in the input.
We shouldn't autofill when the user back spaces. Actually back spacing is just one example of deleting text at the end of the input; the user could select text and press delete, or use the delete-previous-word key shortcut, etc. So it's not correct to simply check whether the last keypress was a backspace and skip autofill then. We should copy the logic of the legacy autocomplete controller and check whether the new search string is a prefix of the old string. If so, then don't autofill. So I added that logic to UrlbarInput. I could have added similar logic to the controller or the context instead, but it makes the most sense being in the input since it's the input where the user is interacting with the text value.
Differential Revision: https://phabricator.services.mozilla.com/D17040
--HG--
extra : moz-landing-system : lando
This patch implements a new, preffed-off tab opening/closing animation where the tab slides up and down in place. In addition, it adjusts some tests and code that were relying on the max-width transitionend event happening. The intent of the patch is to land it preffed-off and iterate on the design in the tree
Differential Revision: https://phabricator.services.mozilla.com/D15955
--HG--
extra : moz-landing-system : lando
Files with .h extension are built with the c compiler by default, which makes
the diagnostics useless. If we know this is a cpp file, hint it so that it
builds it with the right mode.
Differential Revision: https://phabricator.services.mozilla.com/D17372
--HG--
extra : moz-landing-system : lando
This includes a new test for the feature and a bit of test cleanup to factor
out all exception related tests into their own test file.
Differential Revision: https://phabricator.services.mozilla.com/D17109
--HG--
rename : browser/base/content/test/about/browser_aboutCertError.js => browser/base/content/test/about/browser_aboutCertError_exception.js
extra : moz-landing-system : lando
We can receive GeckoSession.onCompositorDetached() before
GeckoSession.onCompositorReady() has run, so guard against this
by ensuring the compositor is attached in onCompositorReady().
Differential Revision: https://phabricator.services.mozilla.com/D16983
--HG--
extra : moz-landing-system : lando
As non-promptable permission won't prompt user to ask for their approval, we should use different texts for the cancel button of promptable permissions.
Differential Revision: https://phabricator.services.mozilla.com/D16770
--HG--
extra : moz-landing-system : lando
Profiles show that we do a lot of needless work in response to notifications for
other permissions such as "storageAccessAPI".
Depends on D17362
Differential Revision: https://phabricator.services.mozilla.com/D17155
--HG--
extra : moz-landing-system : lando
John Lin
Zibi Braniecki
Mark Banner
James Willcox
Jan Henning
Mark Striemer
Dale Harvey
Chris Manchester
Ting-Yu Lin
Shane Caraveo
Cosmin Sabou
Michael Kaply
Drew Willcoxon
Aaron Klotz
Johann Hofmann
Arjun Krishna Babu
Lee Salzman
Ed Lee
Ciure Andrei
Sebastian Hengst
Felipe Gomes
Ricky Rosario
Jeff Gilbert
Emilio Cobos Álvarez
Dorel Luca
Nicolas Chevobbe
Andy Wingo
Jared Wein
Andrew McCreight
alwu
Ehsan Akhgari