Also reduce the timeout for terminating the thread to 5 seconds, because 10
seconds is too long to be completely hanging the UI.
Differential Revision: https://phabricator.services.mozilla.com/D33844
--HG--
extra : moz-landing-system : lando
Added defines to mar_extract.c, mar_read.c, bsdiff.c so they use the ISO C and C++ conformant name.
Ran clang format on bspatch.cpp and the files under modules/libmar except for nss_secutil.c and nss_secutil.h since they are copies of nss code.
Make CityHash64, CityHash64WithSeed, and CityHash64WithSeeds usable from C code
Remove unnecessary includes from mar_read.c as well
Add DisableStlWrapping to mar tool's moz.build to fix linkage break when
building in Windows with MSVC
Differential Revision: https://phabricator.services.mozilla.com/D10774
We need to be able to send POST data that's encoded as UTF-8, but the older
version of nsJSON we currently have only support UTF-16.
--HG--
extra : source : 5d5494bb34e57e4ee1b51233bf9f6b86301f900c
Because of a silly logic error I made in bug 1494900, the optional command line
parameter support introduced there doesn't actually work at all; I reversed the
sense of the check for the NSIS stack being empty. This fixes that by just using
the check that the popstring function was already doing.
--HG--
extra : rebase_source : e63b70579810af5774e237c619b29fb71012ea8c
extra : source : 58a29f64dd06d4e66e6faf047e2356decc5904f4
Also take the opportunity to add that change to mozilla_customizations.diff and
to correct the line endings in the files that it contains changes to.
--HG--
extra : rebase_source : 10df36760e1f8cc0e8b2f93b47e76c27dcc912cc
extra : source : 9a448a33f4b43ef8572d80bc7b27c7a831f122c2
Also added line breaks to make the file more readable (while making the diff
harder to review).
--HG--
extra : source : 7b2d3f4315562ef9197b3b22bdb5c9f9f7df1bdf
This simply applies the file other-licenses/7zstub/mozila_customizations.diff,
which did not need to be changed in this patch series because it applies cleanly
to the LZMA SDK code, which is organized in the same way as the 7-zip code.
--HG--
extra : source : a6abc1d22d6c01e3fa07f52e468bb045630a3a1d
Profile-per-install uses a hash of the install directory to identify different
installs of Firefox. This exposes the existing cityhash generated hash from
nsXREDirProvider and makes it available on all platforms.
Differential Revision: https://phabricator.services.mozilla.com/D3852
--HG--
extra : moz-landing-system : lando
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
We occasionally get reports of UI unresponsiveness immediately following the
download phase of the stub installer. The longest operation that runs on the
main thread during this phase is validating the code signature of the full
installer. This patch moves that work (which is done in a native NSIS plugin)
to a separate thread. Hopefully this helps resolve the hangs.
I've also converted the build files for the plugin from Visual C++ 6 to 2017,
just to avoid the inconvenience of needing to pull up VC6 to build it.
MozReview-Commit-ID: CKje2a8M62i
--HG--
extra : rebase_source : ec9a11268eed3c4f9e0783532b0e910289e809f9
I'm also adding a "StartMenuShortcut" option as an alias for "StartMenuShortcuts",
because I could not stop leaving off the 's' while testing this patch, so I
figure I'm not the only one making that mistake and getting frustrated.
MozReview-Commit-ID: Fdsc6CTBJr4
--HG--
extra : rebase_source : c57295e0936b6721bc75d6f11f33bad6691b96de
This fixes a bug which the main bug 986081 patch exposes because it tries to
cancel a download in InetBgDl and then show a dialog box immediately afterward.
Without this patch, doing that very early on in the request (meaning before any
redirect is fully handled) would result in a 10 second UI hang.
MozReview-Commit-ID: 1zBxZrllFC
--HG--
extra : rebase_source : 523b2b37035a7fc6f435acd1f7437fbbbcf2adc6
Tom Prince
Matt Howell
Adam Gashlin
Daniel Varga
Petr Sumbera
Oana Pop Rus
Samuel Thibault
Cosmin Sabou
Robert Strong
June Wilde
Dave Townsend
James Teh
Emilio Cobos Álvarez
Ciure Andrei
Sylvestre Ledru
Tom Ritter