600f91c209
Fixing ill-formedness error.
2001-11-10 20:34:00 +00:00
89a3414cef
fixing perl error
2001-11-10 20:21:38 +00:00
e487a1691b
Switching to proper log-header variable
2001-11-10 19:26:42 +00:00
710a521be4
implemented getFieldNamesByCategory() in the user data source, and used it to fill in the list of contact methods for the loginFailed output handler.
2001-11-10 10:55:33 +00:00
924ea00e2f
Made the phrase 'or to have your password sent to you,' appear regardless of the value of data.tried
2001-11-10 10:51:10 +00:00
c9028cce74
Fix a typo on the To: line which was resulting in a blank To: field, made the Subject: line be dynamically generated, and made the text actually be useful.
2001-11-10 06:26:28 +00:00
1090fd8014
proper checking for scrape_builds data
2001-11-10 06:01:35 +00:00
59c262180b
Oops, syntax error.
2001-11-10 05:21:17 +00:00
387c5bc05c
Use the actual From: address (now that the outputter tells us what it is...).
2001-11-10 05:12:06 +00:00
c5902010d2
Added another set of data to the data hash: the outputter hash. This will be useful for strings that have to embed things like the e-mail address of the application itself. Added hash methods to the Email and Stdout generic outputter modules to support this change. Renamed 'from' to 'address' in the Email outputter to make it easier to reuse the code (hehe). Also, in the same module, changed some of the comments, changed a double quote string literal to a single quote string literal, and added the word 'configure' where it was missing in one of the dump statements.
2001-11-10 05:00:14 +00:00
c7ad8bda1e
Implement some primitive error handling for sending mail.
2001-11-09 21:59:21 +00:00
33d918a98e
Adding scrapebuilds.pl check
2001-11-09 21:37:02 +00:00
e7cfe96b62
Adding scrape_builds
2001-11-09 21:35:25 +00:00
5d5f512a43
Adding scrapebuilds toggle ui
2001-11-09 21:32:41 +00:00
9b2192655b
Adding scrapebuilds.pl
2001-11-09 21:31:19 +00:00
e383d0629d
Removing unnecessary spammy debug output (this code works now... honest\!)
2001-11-09 21:22:32 +00:00
29e9dfc2dc
Decode %XX-encoded strings.
2001-11-09 21:19:59 +00:00
73179ecb4f
Added some more comments that might help people get this working on Apache.
2001-11-09 20:23:42 +00:00
657b6ffe1a
Factored out the connect/disconnect code, added settings for the host and the from address and made them be handled by a setup.configure handler, wrapped the call to Net::SMTP->new() in a warning-free block.
2001-11-09 20:21:11 +00:00
53e6d5ac79
Adding support for generic saving and retrieving of settings.
2001-11-09 20:13:21 +00:00
0c4ffdbd75
Adding a comment on the use of assert()
2001-11-09 20:09:22 +00:00
dcc2097dae
Refactored the Database::DBI code. Added support for default values in the setup code. Added support to create the database and the user (although some of this may need refactoring into separate MySQL submodules).
2001-11-09 17:23:41 +00:00
0bcc147053
Changing the order of loaded modules to make sure they are set up in the right order.
2001-11-09 17:16:50 +00:00
791fc529b1
Added a missing 'return' statement so that the user.fields setup routine doesn't appear to have failed when it hasn't (without a return statement, the value of the last statement is the return value).
2001-11-09 17:15:13 +00:00
b8414702ac
Changed the DESTROY method to make sure it calls its parent.
2001-11-09 17:13:27 +00:00
0cb23ea40f
Added support for printing the default value for requests.
2001-11-09 17:12:18 +00:00
9d7bf3c600
Added the ability to find the length of an array (array.length to go with array.0, array.1, etc). Added assertions to handle the case of invalid order or sort attributes on <set>. Added two new sort types ('default' and 'reverse default').
2001-11-09 17:10:22 +00:00
725d3308e9
Added two assertions to make sure the handle is defined before using it, and added a check that the handle is defined before releasing it. Also changed the DESTROY method to call its parent.
2001-11-09 17:07:18 +00:00
744e2e3847
Removing excess trailing spaces on one line, and moving a warn from level 5 ('important events') to level 8 ('frequent important events').
2001-11-09 17:03:40 +00:00
20f63b1ced
Fixed DESTROY method to make sure it calls its parent.
2001-11-09 17:00:28 +00:00
4da016547c
Removing the @arguments array from a dump statement, because if any of the elements in the array are undef then a runtime warning is printed (undef elements is not always a bug).
2001-11-09 16:58:38 +00:00
7444cd2f92
Added a level 5 dump indicating the completion of the PLIF program.
2001-11-09 16:56:49 +00:00
b8d1bff110
Fixed DESTROY method to make sure it called it's parent.
2001-11-09 16:52:08 +00:00
f939cf3dd2
Change default DEBUG level from 9 to 4, which is what it should be in production releases. Added comments explaining debug levels 6 (reserved for personal use) and 8. Added level 10 debug info to the DESTROY method (makes it easier to track down bugs during shutdown).
2001-11-09 16:50:47 +00:00
fcf68a1cc0
Made it so the setupEnding event is sent out after the setup failure message is printed but before the setup success message is printed (reduces the number of error messages if you cancel during setup). Changed the semantics of the output.progress string's data.component data. It is now a dotted hierarchical string giving progressively more detail about what is being set up. e.g., 'database', 'database.default.settings', 'database.default.settings.connection.port'. If outputters are interpreting data.component then any trailing unknown levels of detail should be ignored. This allows the setup routines to potentially give much more useful output. Fixed the default stdout output string for setup (it has <text variable=""> instead of value="").
2001-11-09 16:39:29 +00:00
749f837a11
Bugzilla Bug 109138 platform detection not working on macintosh
...
r=bbaetz,dkl
2001-11-09 05:32:43 +00:00
d8061828ca
Fix for bug 109048: fixes error when creating attachments without logging in.
...
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv
2001-11-09 01:11:09 +00:00
1b1a10e431
Also send default values to output.
2001-11-08 17:27:07 +00:00
e4827e8055
Implement default values for arguments. getArgument() and createArgument() now take two parameters like setArgument(). Changed the CommandLine module's createArgument() method so that if the user hits enter at the prompt, the default value is used. Added some comments to clarify what is going on with the 'batch' argument. Changed setArgument() and createArgument() in the Arguments module and createArgument() in the CommandLine module to be more efficient (less array copying).
2001-11-08 17:09:11 +00:00
f0f9512da4
Adding comments to clearly indicate that no dump()s, warn()s or error()s should have a level lower than 5 unless they are not expected to occur during normal operation. Also changing the default level at which the user is notified of problems from 3 to 1.
2001-11-08 16:47:25 +00:00
c944fd6100
Added two new hooks into the setup code: a start notification and an end notification. Added the ability to disable the string datasource (causes it to only use the default strings and not the database). Made the string datasource automatically disable itself during configuration, using the two hooks added to the setup code. This removes the warning messages that are output during a clean setup ('could not get string from database', etc).
2001-11-08 16:42:42 +00:00
7555438b4c
Improved error handling for the case where the database configuration doesn't exist and therefore every output attempt raises database errors. Fatal database errors are now fatal, missing database configurations is not. This would be a lot cleaner if Perl exceptions were objects... Also improved some of the error messages.
2001-11-08 16:10:21 +00:00
8c7914277e
Added a little more level 9 verbose debugging feedback to help track down where output is going wrong.
2001-11-08 05:07:42 +00:00
7c20665250
Stop complaining about the configuration file missing -- if it is not there then just assume there is nothing to worry about. This makes the output of the initial run with the 'setup' argument a lot quieter.
2001-11-08 05:06:27 +00:00
00f010f948
Make the STDOUT generic outputter flush everything it outputs -- this fixes a bug whereby sometimes prompts wouldn't appear until after the user had replied to them.
2001-11-08 05:03:57 +00:00
5e6a01c718
Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the
...
bug itself was not always being updated if dependencies or CCs changed.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
2001-11-08 03:38:12 +00:00
32f4159790
Fix for bug 104652: Duplicate bugs in the dependency tree now get marked with the message "This bug appears elsewhere in this tree." so users know why the bug does not appear to have dependencies.
...
Patch by Gerv <gerv@mozilla.org>.
r=jake@acutex.net ,myk@mozilla.org
2001-11-08 02:43:55 +00:00
8343293339
Fix for bug 108822: Prevent any user from changing their own groupset.
...
Patch by Jake <jake@acutex.net>.
r=bbaetz,myk
2001-11-08 00:54:15 +00:00
cba5adf358
Fix for bug 108821: Prevent users with any blessgroupset privileges from blessing any group set.
...
Patch by Jake <jake@acutex.net> and Bradley <bbaetz@cs.mcgill.ca>.
r=jake,myk for Bradley's portion, r=bbaetz,myk for Jake's portion.
2001-11-08 00:52:13 +00:00
faff2bf103
Fix for bug 108812: Prevent users from running queries containing arbitrary SQL.
...
Patch by Jake <jake@acutex.net>
r=bbaetz,myk
2001-11-08 00:49:18 +00:00
67cff5d825
Require (temporarily) mysql >= 3.23.5 for the ~ operator, needed for the
...
fix to bug 107718. This should be removed when the group stuff lands (bug
60822).
r=justdave x 2
2001-11-07 22:42:32 +00:00
8262999a16
Bug 101166 - users seeing a bug via _accessible bits should see that its
...
the group
r=justdave,jake
2001-11-07 16:11:33 +00:00
3cdfdecef1
Bug 108547 - Make the JavaScript use proper DOM
...
Patch by Christopher Aillon <caillon@returnzero.com>
r= timeless@bemail.org , kiko@async.com.br
2001-11-07 14:58:56 +00:00
8d66d47bac
Disambiguate the names of the two methods 'hash' and 'sort'. They are now called 'genericHash' and 'genericSort' so as not to clash with the perl builtins 'CORE::hash' and 'CORE::sort'.
2001-11-07 02:49:21 +00:00
354aaaa6f6
Changing the shebang to point to a more likely location of the perl interpreter.
2001-11-07 02:46:38 +00:00
9afda81c2a
Initial checkin of the first PLIF test application.
2001-11-07 01:42:05 +00:00
85bc7a97ee
Refixing bug 71840 - The name should be the 'name' should be the same as what the 'href' points it too...
...
r= justdave@syndicomm.com
2001-11-06 18:06:02 +00:00
cf93f342f9
SECURITY FIX see bug 108385: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to add a comment to a bug pretending to be someone else if you edited the HTML by hand before submitting. The bug form did not include the field in question, but due to legacy processing code, the field was still trusted if it was present.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake x2
2001-11-05 20:47:17 +00:00
65cddcfd90
SECURITY FIX see bug 108516: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to file a
...
bug pretending to be someone else if you edited the HTML by hand before submitting.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
2001-11-05 20:43:35 +00:00
74ecd5d3e0
scrape comment
2001-11-05 08:50:55 +00:00
8dfc5d01e9
Bugzilla Bug 107672 Browser OS/Platform discrimination alg sucks
...
r=bbaetz, jake
Windows XP references are #'d because of bug 92763
2001-11-05 04:44:34 +00:00
f5ab0d9a21
Bug 107718 - mass changes give all changed bugs the groupset of the first
...
bug in the list.
Do bit fiddling instead of adding groupsets from the first bug.
r=justdave, jake
2001-11-03 05:49:23 +00:00
17cd7b028d
remove unused remove_build sub.
2001-11-03 05:14:10 +00:00
95069efe13
Adding multi-line support.
2001-11-03 02:10:05 +00:00
50e9ba7770
Fix for bug 105773: Email addresses in the CC list are now sorted case-insensitively
...
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2
2001-11-03 02:05:43 +00:00
1a437bdad5
cut&paste bug
2001-11-03 01:18:39 +00:00
2eb5f7fa1c
Adding basic scrape functionality. Pick off TinderboxPrint: token and print the argument in the corresponding build box. Currently limited to one line, multi-line change coming next.
2001-11-03 00:50:13 +00:00
b551cab760
Adding scrape.dat
2001-11-02 22:55:09 +00:00
a7306dfd1f
Switching to TinderboxPrint:aaa,bbb,ccc format. r=pchen
2001-11-02 22:41:40 +00:00
dcfb5d6374
Fix for bug 95615: cosmetic change to clarify error message when trying to use too many votes
...
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2
2001-11-02 20:05:13 +00:00
0699f99205
Adding scrape scan.
2001-11-02 09:43:12 +00:00
62ac6bc208
Tinderbox,aaa,bbb,ccc,ddd format.
2001-11-02 09:37:35 +00:00
05281255b8
General purpose version of bloat.pl
2001-11-02 05:22:00 +00:00
c3dc15ab8b
no warn.pl anymore
2001-11-02 05:20:25 +00:00
4e57ea4f39
Checking in fix for bug #86920 , fix from jake@acutex.net
2001-10-31 04:30:33 +00:00
c5aeb3016c
Checking in patch for bug #44641 , patch from Ian Wells
2001-10-31 04:20:28 +00:00
a84ddb446f
Checking in patch for bug#36597, patch from miri@punknet.cz
2001-10-31 04:07:25 +00:00
811101a3b4
Fixing tinderbox bustage (removing <Tab>s and adding a "use vars" line)
2001-10-31 03:31:00 +00:00
a07f057d55
Have the tests test .pm files as well, yes this creates bustage, this is
...
intentional!
No review needed for tests at this time.
2001-10-31 01:06:31 +00:00
6b4b5c2b1e
Fix test bustage by removing tabs.
2001-10-31 00:21:28 +00:00
e67b38e912
Fix for bug 98602: re-implementation of "create attachment" page.
...
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org ,jake@acutex.net
2001-10-30 23:42:22 +00:00
d3e20732b5
Fix for bug 96675: checksetup should require admin e-mail address satisfy emailregexp. This fix has
...
checksetup.pl use the emailregexp set in params if the params file exists, or ensures that it matches the
default emailregexp from defparams.pl.
r1=justdave, r2=bbaetz.
2001-10-28 03:40:59 +00:00
4d2830186b
A few enhancements to the template test:
...
* If there's a compilation error, report what it is
* Don't try to compile a template if it doesn't exist
- We already tested for that and issued an ERROR
* Define the 'url' FILTER
2001-10-27 15:27:31 +00:00
96664b4739
Bug 105879 - Footer links have an extra | by Sanity Check
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com , jake@acutex.net
2001-10-26 18:49:33 +00:00
e101daceeb
Bug 81594 - SQL error after editing user entry when changing numerous things at once (including the login name).
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com , jake@acutex.net
2001-10-26 18:35:04 +00:00
745a1518eb
Check templates for tabs, also.
2001-10-26 13:21:38 +00:00
85615413b7
Change %f to %d for page load times.
2001-10-26 06:37:31 +00:00
2219cf5bf4
Use ms instead of s for pageloader time.
2001-10-26 06:32:58 +00:00
e41d92589f
Fix for bug 98602: re-implementation of "create attachment" page.
...
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org ,jake@acutex.net
2001-10-25 20:37:53 +00:00
45dc65778f
Bug 104065 - Stop uninitilized string warnings from getting into the error log when the login cookie doesn't exist.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= gerv@mozilla.org , jake@acutex.net
2001-10-25 14:46:58 +00:00
926fc6c1f9
Bug 104540 LXR updates for .idl collaboration diagrams
...
by mozilla@elemental.com (Brian Bramlett)
r=endico
2001-10-25 01:05:07 +00:00
9db53c7a32
Fixed "used only once" warning coming from my patch for bug 97469. The
...
warning was hidden from the tests by bug 106424.
r=Jake, no 2nd review needed.
2001-10-24 20:33:49 +00:00
5f621e5961
Don't rely on the TEST_VERBOSE environment variable (no longer exported from runtests.sh) and instead print to the TESTOUT file handle pulled in from Test::More. This will allow the testing backend to check for verbosity rather than having to handle it in the .t files.
2001-10-24 18:41:53 +00:00
282e2eab08
Bug 106424 - We weren't going orange on warnings such as "used only once". This script now properly outputs the --WARNING and fails on such a condition.
2001-10-24 13:29:49 +00:00
75faca54fd
Fix for bug 106315: Link on bug list for emailing QA contacts.
...
Patch by Dave Miller <justdave@syndicomm.com>.
r=myk@mozilla.org , no second review needed.
2001-10-24 01:31:09 +00:00
afa66d34ff
Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
...
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.
Also fxed bug 101560, by clearing BASH_ENV
r=myk,justdave
2001-10-23 15:44:53 +00:00
d6397d0d5a
Bug 63249 - The Bug Counts report was running very slowly due to unneeded fields/joins in the SQL query.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org , jake@acutex.net
2001-10-23 14:45:45 +00:00
78adb43687
Fix missing description problem for options that required multiple lines for the description.
2001-10-21 19:11:25 +00:00
cd5915781c
Bug 71840 - Make comments referenceable using a #c4 to get the fourth comment.
...
Patch by Gerv <gerv@mozilla.org> and Myself.
r= jake@acutex.net , gerv@mozilla.org , justdave@syndicomm.com
2001-10-20 13:03:14 +00:00
2edcc77a4b
Backing out previous change, the wrong patch got checked in.
2001-10-20 12:59:57 +00:00
2c9c137ea1
Bug 71840 - make comments referenceable. Patch by gerv/jake. r=justdave, jake/gerv.
2001-10-20 01:06:59 +00:00
3b1570750c
Bug 105480 - Use the friendly name from the fielddefs table when reporting strictvalue errors if it's available.
...
Patch by James A. Laska <jlaska@us.ibm.com>
r= justdave@syndicomm.com , jake@acutex.net
2001-10-20 00:50:27 +00:00
d1b5c1f437
Bug 104340 - Changing the UI of the toolbar for hiding bugs in the dependency tree.
...
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com , gerv@mozilla.org
2001-10-20 00:22:52 +00:00
3905de3eb0
Bug 73180 - We now put a notice at the top of the versioncache file saying that it should not be edited.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org , jake@acutex.net
2001-10-19 23:49:37 +00:00
86dccb7385
Bug 103664 - Tests should "use strict;" and not contain any tabs. We should also use the TEST_VERBOSE environment variable instead of VERBOSE.
...
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
Additional edits by myself to add the emacs mode line. Also, the change to runtests.sh was done by me.
2001-10-19 22:39:51 +00:00
1755af2c9d
Fix for bug 105365 - Hacker's Guide should be in SGML. This will make it easier to do other additions to the hacker's guide.
2001-10-19 16:18:10 +00:00
21fe682b44
yet another meaningless whitespace change to test tinderbox with
2001-10-19 13:03:52 +00:00
8febda1bc1
another useless whitespace change to test tinderbox with
2001-10-19 06:19:52 +00:00
dd631f42a6
Adding one more sig fig for startup time.
2001-10-19 06:15:24 +00:00
eda1eed498
switching search token to __avg_startuptime, we are going to iterate the test now and report an average time.
2001-10-19 05:56:38 +00:00
4c8e89a6a6
whitespace change to test tinderbox again.
2001-10-19 05:33:23 +00:00
d7672429e0
whitespace change to do a test checkin to see how tinderbox reacts
2001-10-19 04:36:19 +00:00
c42a036e6b
Bug 72177 - reword checkbox to make it consistent with the others on the page.
2001-10-18 21:41:25 +00:00
b3bcc8e15d
Bug 60818 - make Bugzilla cope with MIME types with parameters. Patch by gerv, r=myk.
2001-10-18 21:28:06 +00:00
4365fe256e
Remove the /var/run/ stuff. I need to think this through more carefully.
...
This only needs to happen on the build script. This needs to happen as
the user root but currently I do not run the build script ever as root.
2001-10-18 16:19:59 +00:00
ab215705d1
bug fixes to get the /var/run stuff to work.
2001-10-18 16:17:24 +00:00
8cfb49fe20
separate the packge output into client and server packages.
2001-10-18 15:59:20 +00:00
8ea3e34f7b
Add support for /var/run/ directory.
2001-10-18 15:05:57 +00:00
5307a7b0c1
Bug 98146 redux - changing URL to relative one. Oops. Patch by jake, r=gerv.
2001-10-16 18:42:05 +00:00
eb5f2b81cf
bug 27506, i messed up. making the changes per cbiesinger@web.de and justdave@syndicomm.com
2001-10-16 08:44:43 +00:00
0409076d01
Bug 30480 - add 'show dependencies as buglist' links. Patch by gerv, r=myk, kiko.
2001-10-16 03:09:52 +00:00
65ba90ca97
Fix for bug 98146.
...
Patch by Gerv <gerv@mozilla.org>.
r=myk, no second review needed.
2001-10-15 23:02:48 +00:00
f53bd26e72
Recompiling docs to pick up last two changes
2001-10-15 19:18:04 +00:00
ceb1a1739a
The recommended style for perl (which is the styleguide Bugzilla will use) specifies that else should not be cuddled. This guide, while not specifically saying it, elluded to cuddling else. Fixing that problem.
2001-10-15 19:12:46 +00:00
18263f8245
Bug 104105 - cosmetic change to make it obvious that you can create an account.
2001-10-15 03:59:19 +00:00
9c91a2926a
Bug 46935 - trivial typo.
2001-10-15 03:46:28 +00:00
ac3a86954b
Bug 99716 - allow query for Attachment is obsolete AND Attachment Status. Patch by myk, r=justdave, jake.
2001-10-15 00:55:50 +00:00
6c2f12179c
Bug 57819 - change the size of the bit we print in the large error case. r=justdave.
2001-10-14 01:34:08 +00:00
29c34fafbd
Tabs are not allowed in Bugzilla source... if we find one, issue a warning.
...
No review needed for tests at this time. NOT PART OF BUILD
2001-10-13 01:44:06 +00:00
3eb400cda4
Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
...
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2
2001-10-13 01:36:17 +00:00
85719e17a4
Fix for bug 19910: Bugzilla installs on the same server would interfere with each others' cookies. Cookies now have a path value that can be set to indicate which bugzilla install they belong to. Browsers will only send the cookie to the appropriate installation. The path can be set in the 'cookiepath' parameter in editparams.cgi.
...
Patch by Dave Lawrence <dkl@redhat.com>
r= myk, justdave
2001-10-13 00:40:41 +00:00
cd0de56d18
Fix for bug 101056: multiple form values of the same name were not getting correctly stashed if the user had to log in as part
...
of a form submit.
Patch by Myk Melez <myk@mozilla.org>
r= gerv, justdave
2001-10-12 21:33:21 +00:00
2996888b17
Bug 100490 - better error message with no JavaScript for QuickSearch. Patch by afranke, r=kiko, gerv.
2001-10-12 20:54:26 +00:00
4f03a1f2f0
If a template doesn't exist, this should be considered a compile failure.
...
No review needed for tests at this time. NOT PART OF BUILD
2001-10-12 20:35:37 +00:00
27984b1bf7
Fix for bug 91486: Add "changed from" option to the boolean chart.
...
Patch by Stephen Lee <slee@uk.bnsmc.com>.
r=myk@mozilla.org
2001-10-12 20:25:57 +00:00
7a98289b8e
Backing out Gerv's checkin for bug 71840. Per the bug report, it did not have proper review first, and myk objected to what
...
got landed on irc.
2001-10-12 03:03:00 +00:00
12f3a98019
Bug 71840 - Make comments referenceable. Patch by gerv; r=myk, jake (ish :-).
2001-10-11 23:07:54 +00:00
261a495480
Bug 83058 - need a way to hide resolved bugs in dependency tree view. Patch by kiko; r=gerv, afranke.
2001-10-11 23:01:44 +00:00
26499b674c
Bug 76161 - Don't select "resolve as dup" radio button when exiting empty dupe field. Patch by justdave, r=jake, caillon.
2001-10-11 22:18:35 +00:00
1a24cca0d5
Bug 57819 - cut down large mysql error strings. Patch by n_hibma@qubesoft.com, r=gerv.
2001-10-11 21:58:07 +00:00
ffee44f25a
Bug 52782 - whineatnews.pl email should use the 'sendmailnow' Param. Patch by e.maryniak@pobox.com, r=gerv.
2001-10-11 21:55:21 +00:00
d811602365
Add MacOS X. Bug 52577. Patch by afranke. r=gerv.
2001-10-11 21:52:28 +00:00
595dc193af
Bug 104247 - make colours in buglists work again. Patch by kiko, r=gerv.
2001-10-11 21:42:07 +00:00
1a40034281
Fix for bug 104180 - should only be used in the display for a saved query w/a space, not in the URL.
...
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net
2001-10-11 19:51:33 +00:00
1b82b56dc3
Fix for bug 103592 - e-mail addresses that are longer than 30 characters will be truncated in the bug list.
...
Patch by Christian Reis <kiko@async.com.br>
r= gerv@mozilla.org , afranke@ags.uni-sb.de , jake@acutex.net
2001-10-11 19:44:46 +00:00
3762e3c0a5
Fix for bug 104117 - The editkeywords.cgi link was broken as a result of the fix for bug 103554.
...
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net
2001-10-11 19:07:00 +00:00
9a8c0e2ac0
Bug 27506 The Bonsai pages contain SCRIPTs which are not enclosed in
...
<!-- -->, greatly confusing some HTML parsers.
r=kiko
2001-10-11 18:44:14 +00:00
a04643f3f2
Fix for bug 97784: comments in attachment update form are now properly word-wrapped. This is a server-side implementation to
...
do the word-wrapping, which will probably eventually be used in the main comments area on the bug form as well.
Patch by Myk Melez <myk@mozilla.org>
r= gerv, justdave
2001-10-11 02:17:58 +00:00
6afb953716
Fix for bug 103554: HTML generated by the PutHeader and GetCommandMenu subroutines now validates as HTML 4.01 at W3C.
...
Patch by Christian Reis <kiko@async.com.br>
r= caillon, gerv, justdave
2001-10-10 23:36:29 +00:00
e2473d392b
Fix for bug 27420: Gives the Component and Target Milestone fields extra space in the long list display of bugs.
...
Patch by Randall Whitman <randall.whitman@solipsa.com>.
r=justdave@syndicomm.com , no second review needed
2001-10-10 19:50:02 +00:00
cb3191580b
better name for default log file
2001-10-10 15:09:06 +00:00
d3b0fbe78d
fix broken usage for process_builds. allow usage to be viewed even if
...
security tests not passed.
2001-10-10 15:08:24 +00:00
782a9645ce
typo in new BT_NAME parameter, did not get default from TinderboxConfig
2001-10-10 15:07:41 +00:00
8f6c524129
allow usage page to be viewed withhout passing security checks.
2001-10-10 15:06:48 +00:00
efb7eb3ab8
Fix for bug 65164 - Bugzilla wasn't sending </html> at the end of its pages.
...
Patch by Christian Reis <kiko@async.com.br>
r= gerv@mozilla.org , jake@acutex.net
2001-10-10 13:26:28 +00:00
52bd262467
partial backout of the checkin from bug 103121, because it collided with the patch from bug 51519. This should satifactorily
...
meet the goals of both patches. patch by kiko, r= justdave
2001-10-10 06:36:45 +00:00
d9d2292794
Bugzilla Bug 103121 editusers.cgi needs an Add link on the query page.
...
patch by dkl. r=kiko
2001-10-10 04:57:30 +00:00
3a5a3ff16d
Bugzilla Bug 97185 make_select should add a newline after each option
...
patch by kiko. r=zach, gerv
2001-10-10 04:52:09 +00:00
bdfb4b81ff
Bugzilla Bug 51521 Broken HTML on user permissions page
...
patchwork by john.beranek@pace.co.uk and kiko. r=zach, kiko, gerv
2001-10-10 04:47:17 +00:00
5cc2a6f34b
wrong format string. I keep using %e instead of %d this puts spaces
...
in the VERSION number which is not allowed.
2001-10-09 19:45:09 +00:00
dbf98eb416
It's also possible to PROCESS another attachment fragment, not just INCLUDE.
...
No review needed for tests at this time. NOT PART OF BUILD.
2001-10-09 19:14:59 +00:00
458dc29162
add new features.
2001-10-09 15:52:43 +00:00
45a82f461f
remove the colons from the tar file name. This was a bad idea because the
...
colons mean something special to tar.
2001-10-09 15:51:35 +00:00
a8ed78963b
clarify the build states.
2001-10-09 15:38:27 +00:00
f04d4b26f4
make BT and VC column heading configurable.
2001-10-09 15:30:16 +00:00
f4e0f57965
*** empty log message ***
2001-10-08 20:36:41 +00:00
546183097a
more discriptions of what program does.
2001-10-08 20:25:52 +00:00
70143c67ca
better usage discription. Index.html does not list itsself and now
...
displays sizes.
2001-10-08 19:25:33 +00:00
e00bb53520
Fix for bug 98074: Attachment manager doesn't html_escape bug titles.
...
r1=caillon <mailto:caillon@returnzero.com>, r2=Jake
<mailto:jake@acutex.net>
2001-10-07 17:50:22 +00:00
442e125a9f
Allow compile tests for files that run in taint mode
...
No review needed for tests at this time. NOT PART OF BUILD
2001-10-06 23:22:48 +00:00
5765f690cb
We also need to look for templates that are INCLUDEd in other templates.
...
No review needed for tests at this time. NOT PART OF BUILD
2001-10-06 21:37:22 +00:00
d1e7019522
Doc type fix, r=kiko
2001-10-06 19:04:08 +00:00
7cfef16aad
Test that scans Bugzilla's code looking for used templates then checks to make sure that:
...
a) All the required templates exist
b) They all have good syntax
No review needed for tests at this time. NOT PART OF BUILD
2001-10-06 18:59:36 +00:00
f284bf6dda
Fixing issue where excluded files aren't excluded if they end in .pl or
...
.cgi.
2001-10-06 03:49:06 +00:00
1bc30500f7
Don't test importxml.pl since you need XML::Parser which is not required,
...
creating a false fail.
No review needed for tests. NOT PART OF BUILD
2001-10-06 03:25:43 +00:00
f8fd2021ed
Get rid of our which causes errors on 5.005.
...
No review needed for tests at this time. NOT PART OF BUILD
2001-10-06 01:23:38 +00:00
644c4d90a3
Fix for bug 76714: correctly nests the FORM and TABLE elements.
...
Patch by Gerv Markham <gerv@mozilla.org>.
r=myk@mozilla.org , no second review needed.
2001-10-06 00:03:00 +00:00
62360e8331
Fix for bug 57821 - Empty regular expression causes a software error.
...
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= jake@acutex.net
2001-10-05 23:06:08 +00:00
cac12b0a1b
fix broken parsing and handing of --help --version
2001-10-05 22:42:12 +00:00
16528766ad
Fix for bug 66651 - Include link to attachment in notification mail
...
Patch by Gavin Shelley <gavins@iplbath.com>
r= jake@acutex.net
2001-10-05 22:38:12 +00:00
490e71db30
Fix for bug 93006 - The mass change page was auto-selecting the wrong radio button.
...
r= caillon@returnzero.com
2001-10-05 22:20:33 +00:00
d2bd4509d0
fix bug in mail processing where errors were not logged. This was a scope
...
error in the LOG glob. Also we now allow users to run tinderbox via setuid wrappers
and no longer exclude certain uid ranges but require tinderbox to be run via the id which
the user specifies explicitly.
2001-10-05 22:11:50 +00:00
d1723cfd09
The index files were not being over written but being appeneded to and the
...
documentation had not been updated.
2001-10-05 22:10:14 +00:00
723c3d4495
add ability to generate index.html files for the directories which are processed
...
this is because most browsers are truncating our long build file names.
2001-10-05 22:05:10 +00:00
4416f18087
Fix for bug 55630 - email-suffix is not shown in createaccount-page
...
Patch by kai morich <mail@kai-morich.de>
r= matty@chariot.net.au
2001-10-05 19:38:26 +00:00
7b18e2d7ac
Fix for bug 83474 - The tables were not being unlocked properly when rebuilding the keyword cache if there were no keywords to rebuild.
...
Patch by Lukasz Engel <Lukasz.Engel@softax.pl>
r= matty@chariot.net.au
2001-10-05 15:18:12 +00:00
0c92d3c1d3
Fix for bug 102032: Fix tinderbox test errors and warnings. Patch to make new_comment.cgi use strict and warnings and make tests run at
...
100%!
Patch by Jake <jake@acutex.net>, r=justdave, no 2nd review needed.
2001-10-05 02:16:34 +00:00
af7c721749
Fix for bug 98095:importxml.pl fails perl -wc test. Simple 1 line addition
...
that makes importxml.pl not fail the tests. We are on our way to 100%!
Patch by Jake <jake@acutex.net>, r=zach@zachlipton.com , no 2nd review required.
2001-10-05 00:42:06 +00:00
d3f6f800ce
Correcting minor typo (extraneous ')'s).
2001-10-04 16:09:32 +00:00
86618bd16b
Bugzilla Bug 69533 enter_bug.cgi does not auto-detect HP-UX as OS
...
patch by gary@radionics.com r=zach
2001-10-04 00:06:54 +00:00
5f7fd584d1
Fix for bug 82809: comments in bugs no longer have 
 where the linefeeds should be.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless@mac.com (no 2nd review needed)
2001-10-03 07:49:19 +00:00
356edd8c39
Fix for bug 102723: If genstats dies trying to change databases it will now include the name of the statistic it was trying to generate in addition to the name of the database it was trying to change to in the error message.
...
Patch by Myk Melez <myk@mozilla.org>.
r=dmose
2001-10-02 22:56:50 +00:00
428f579276
Fix for bug 52885: automatic radio selection for reassign shouldn't
...
trigger if new text is same as original owner or empty.
Patch by Christopher Aillon (caillon@returnzero.com ). R=Bradley Baetz
(bbaetz@cs.mcgill.ca ). No 2nd review needed.
2001-10-02 01:20:52 +00:00
25a870a14d
Fix for bug 98744: No more software error when the user clicks "remove cc" without specifying users to remove.
...
Fix by Jake <jake@acutex.net>.
r=myk@mozilla.org , no second review needed.
2001-09-28 19:49:53 +00:00
ef0940e2f5
Fix for bug 73959: Make buglist.cgi display the "Show Votes" link at the bottom of the screen.
...
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org , no second review needed.
2001-09-28 19:17:27 +00:00
6253da57b9
Fix for bug #53612 : The milestone URL appears correctly when deleting a product or a component.
...
Patch by Jake <jake@acutex.net>.
r=gerv@mozilla.org ,myk@mozilla.org
2001-09-27 23:49:07 +00:00
12be070deb
Partil fix for bug 102032: Fix tinderbox test errors and warnings. This patch adds some -w and use strict; work to clean up
...
most of the '002goodperl.t' errors.
r=Dave Miller <justdave@syndicomm.com> no 2nd review required.
2001-09-27 23:19:33 +00:00
18eab3e1d2
Fix for bug 101659: emailsuffix was missing from the component owner mailto tag on sites that use emailsuffix.
...
Patch by Steve Naldrett <snaldrett@transparentnetworks.com>
r= justdave@syndicomm.com x2
2001-09-26 02:37:29 +00:00
afa2da21cc
Fix for bug 93388: Full name should be trimmed of whitespace before going
...
into database.
r1=Zach Lipton <zach@zachlipton.com> r2=Andreas Franke
<afranke@ags.uni-sb.de>. Patch by Christopher Aillon
<caillon@returnzero.com>.
2001-09-23 17:20:50 +00:00
4d9df09144
Fix for bug 97588: localconfig should mention access.conf as well as
...
httpd.conf (for old apache). Simple 2line comment addition to localconfig
to inform the user they may need to look at access.conf in addition to
httpd.conf if they are using an older version of apache.
Patch by Gavin Shelley <gavins@iplbath.com> r=Zach Lipton
<zach@zachlipton.com> no 2nd review needed for this patch.
2001-09-23 17:07:55 +00:00
be566d9a28
Have checksetup.pl block web-access to runtests.sh (by .htaccess) and
...
chmod +x runtests.sh so that it can be run with ./
r=bbaetz on irc, no 2nd review needed. No bug filed.
2001-09-23 04:28:17 +00:00
e51f621218
Renaming *.t to be 00*.t to solve any sorting issues down the road as per
...
bug 97976.
No review required for tests at this time. NOT_PART_OF_BUILD
2001-09-23 04:08:44 +00:00
027423a2f9
*** empty log message ***
2001-09-23 04:02:19 +00:00
8e3c09a895
The first ContactMethod, namely Email.
2001-09-19 18:56:05 +00:00
d5e036ecd2
Added a hook for installing new user fields so that setupInstall handlers don't have to go through the same process multiple times. Also corrected an obvious error (using a variable after checking that it couldn't be used...).
2001-09-19 18:43:06 +00:00
7c5a6e0734
Correcting the misspelling of the package names ('Components' not 'Component') to match the directory.
2001-09-19 18:29:39 +00:00
f650602a79
Corrected the order of return values (newPassword) and removed the extraneous argument (output).
2001-09-19 18:11:03 +00:00
25c3d3b7f3
Cached the SMTP object to improve performance.
2001-09-19 18:05:28 +00:00
00afd76821
Made the outputter be a simple service rather than a service instance to improve performance.
2001-09-19 18:01:23 +00:00
e18f084c7e
Corrected an oversight in the service instance creation code: if a service acts as both a service instance and a normal service, it needs a special constructor to force the creation of the instance, otherwise if the service is created first it will be used again for the instances.
2001-09-19 17:56:15 +00:00
aaebfe1839
Fix for bug 97971 - Sanity check should check statuses, resolutions, everconfirmed & number of votes.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-09-19 15:06:43 +00:00
a20ddcac97
Adding branch page
2001-09-18 23:24:28 +00:00
9945e649fa
patch from Pavel Hlavnicka pavel@gingerall.cz
...
fix ordering of user footer and menu
2001-09-17 18:58:14 +00:00
fba452acb3
Fix for bug 90333: Bugzilla now displays an appropriate error message if a user hits process_bug.cgi without specifying any bugs to change.
...
Patch by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
2001-09-17 18:55:31 +00:00
592ee5528d
Fixed error messages to be more accurate.
2001-09-17 00:13:16 +00:00
a43434e27e
Fix to make the tests generate the list of files to test instead of having to update the list manually whenever a file is added
...
or removed. The main logic is in t/Support/Files.pm, changes to the test files are needed to allow it to function properly.
NOT_PART_OF_BUILD. No review needed for tests at this time.
2001-09-16 18:35:18 +00:00
6953c1e8f3
Make this file test for exec calls in addition to system calls that are
...
one-argument and are therefore insecure.
NOT_PART_OF_BUILD, no review needed.
2001-09-16 17:52:19 +00:00
13bed907d6
Fix for bug 97877: changed* operators now work for attachment statuses on query form.
...
Fix by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
2001-09-15 07:26:21 +00:00
c524d1adcb
Fix for bug 30731 - Reassigning closed bugs from the mass change page caused their status to be set to new.
...
r= myk@mozilla.org , zach@zachlipton.com
2001-09-14 21:50:08 +00:00
d8400a256e
bugzilla wasn't catching mozilla on 98 which was annoying. r=jake
2001-09-13 20:41:59 +00:00
1b759fae9a
Fix for bug 58436 - javascript strict warnings in query.cgi
...
Patch by Christian Reis <kiko@async.com.br>
r= caillon@returnzero.com , jake@acutex.net
2001-09-13 20:04:40 +00:00
84e5eab357
Bugzilla Bug 99465 FreeBSD not recognized!
...
r=jake
2001-09-13 18:21:07 +00:00
383f5cba05
Make Bugzilla support <link> tag for buglists. Bug 87818. r=jake, caillon.
2001-09-10 21:26:05 +00:00
732604001c
Fix for bug 76140 - Adding some more sanity checks.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= caillon@returnzero.com , jake@acutex.net
2001-09-10 15:20:11 +00:00
831a0dc3ba
Fix for bug 97657 - in defparams.pl, the sillyness sub should be called defparams_pl_sillyness
...
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
r= jake@acutex.net
2001-09-10 14:57:12 +00:00
f9d35d29b3
Fix for bug 71664 - Don't complain about a bad keyword cache for a bug that doesn't exist.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= afranke@ags.uni-sb.de , jake@acutex.net
2001-09-10 14:12:10 +00:00
598b67df77
Fix for bug 95060 - Correct the instructions on how to view your current votes.
...
Patch by Gavin Shelley <gavins@iplbath.com>
r= jake@acutex.net x2
2001-09-10 14:00:48 +00:00
f1977072a4
Fix for bug 8647 - Add an option to the query page to sort by Last Changed date.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net x2
2001-09-10 13:49:26 +00:00
9035927484
First stab at an e-mail output service. Also added support for checking addresses for validity and used that when creating a new account.
2001-09-09 21:02:33 +00:00
eb7921111d
Oops. Forgot to check this is.
2001-09-09 19:48:15 +00:00
1bdb52ce4f
Reduced the ErrorContext from 2 to 1. 2 is too much.
2001-09-09 19:48:14 +00:00
b09d3910bb
corrected a comment, corrected the spelling of a method call, and added a placeholder in 'login.failed' which will eventually have to be replaced by code which finds the list of contact methods.
2001-09-09 19:47:04 +00:00
573aee3d11
Added ErrorContext to the Expat arguments so that well formedness errors are easier to track down.
2001-09-09 19:38:24 +00:00
c128f0735b
Corrected and improved some comments.
...
Corrected a problem with scope and the 'escape' attribute of <text> elements.
Renamed 'shrink' and 'expand' to the slightly more accurate 'flatten' and 'rounden'. (ahem)
Changed the ordering of symbol unescaping in roundening to be less (not?) susceptible to incorrect expansion.
Changed the ordering of symbol escaping in flattening to be consistent with the unescape order when roundening.
Made <text> trim one leading and one trailing newline in text nodes if xml:space="default" (makes COSES files neater).
Added a 'coses: original keys' hash to values whose keys are sanitised
Made the 'escape' values be lower case instead of upper case (makes COSES files neater).
2001-09-09 19:36:23 +00:00
93e947211d
Corrected the SQL for 'SHOW COLUMNS FROM' so that it actually works...
2001-09-09 19:21:17 +00:00
10ba6f53e5
Added a string data source which gets the strings from a file instead of from the database, useful as a fallback.
2001-09-09 19:19:05 +00:00
8a6d55c4de
Made the error message printed when no string expander can be found more explicit (it now mentions the name and type of the string).
2001-09-09 19:08:58 +00:00
2d98944b83
Added a comment clarification.
2001-09-09 19:06:13 +00:00
d571cc1375
Changed the magic piping array so that it is more consistent by removing the special casing of when there is only one return value.
2001-09-09 19:04:37 +00:00
e40dafc029
Added the message level number to the debug output to help gauge what level is useful.
2001-09-09 17:55:21 +00:00
2418906f94
Added header and stylistic note.
...
Clarified some of the text.
Made the use of quotes more consistent.
Wrote Chapter 5, "USING GET SERVICE".
Added an empty Chapter 10, "THE SERVICE REFERENCE".
2001-09-09 17:48:07 +00:00
e4012ce728
Fix for bug 98468: sample email regexp for username-only address changed from ^[^@]*$ to ^[^@]+$ and the default emailregexp changed from ^[^@]*@[^@]*\\.[^@]*$ to ^[^@]+@[^@]+\\.[^@]+$
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net x2
2001-09-07 03:25:33 +00:00
9ec346a74d
refix for bug 91808: previous patch for this bug used an INNER JOIN construct in the SQL, which is not supported by the
...
minimum version of MySQL that we require.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2
2001-09-07 01:32:13 +00:00
c8107279a3
better documentation both internal and external. Reevaluate the steps
...
to make a build each iteration to allow builds to create time stamped output.
catch some errrors using eval so that they will appear in the tinderbox mail and not as fatal errors. Strip a few more 'dangerous variables' from the environment.
2001-09-06 18:15:53 +00:00
2ed0e662aa
Fix for bug 30597 - Hyperlinking the number of votes was causing some confusion because it was such a small link, yet the most useful. Instead, we now have a link labeled "Show votes for this bug".
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= louie@ximian.com , jake@acutex.net
2001-09-06 12:42:47 +00:00
3a1384b065
Fix for bug 42337: Adding the usual red box for errors uploading attachments.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= louie@ximian.com , justdave@syndicomm.com
2001-09-06 03:20:34 +00:00
efcb9c7db1
Fix for bug 69616: If you have tweakparams privs, the "Sanity check" link was listed with a group of items that said "Edit" so
...
it appeared as if you were going to edit the sanity checks if you clicked on it, when in fact you were going to run them.
This patch rewords the links so Sanity check is in a group by itself in the block of links on the right.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2
2001-09-06 02:19:04 +00:00
b91182e74e
Adding a test for safe system and exec calls. Part of this code by Dave.
2001-09-05 01:43:25 +00:00
cbc7b5ba25
Add a little 1; to the end of this.
2001-09-04 04:28:24 +00:00
5b949c45ef
Actually make the strict checking work.
2001-09-03 22:11:43 +00:00
ian%hixie.ch
mcafee%netscape.com
timeless%mac.com
myk%mozilla.org
justdave%syndicomm.com
bbaetz%cs.mcgill.ca
jake%acutex.net
tara%tequilarista.org
zach%zachlipton.com
waterson%netscape.com
seawood%netscape.com
gerv%gerv.net
kestes%walrus.com
terry%mozilla.org
rginda%netscape.com