Граф коммитов

2854 Коммитов

Автор SHA1 Сообщение Дата
gerv%gerv.net 2c9c137ea1 Bug 71840 - make comments referenceable. Patch by gerv/jake. r=justdave, jake/gerv. 2001-10-20 01:06:59 +00:00
jake%acutex.net 3b1570750c Bug 105480 - Use the friendly name from the fielddefs table when reporting strictvalue errors if it's available.
Patch by James A. Laska <jlaska@us.ibm.com>
r= justdave@syndicomm.com, jake@acutex.net
2001-10-20 00:50:27 +00:00
jake%acutex.net d1b5c1f437 Bug 104340 - Changing the UI of the toolbar for hiding bugs in the dependency tree.
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com, gerv@mozilla.org
2001-10-20 00:22:52 +00:00
jake%acutex.net 3905de3eb0 Bug 73180 - We now put a notice at the top of the versioncache file saying that it should not be edited.
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org, jake@acutex.net
2001-10-19 23:49:37 +00:00
jake%acutex.net 86dccb7385 Bug 103664 - Tests should "use strict;" and not contain any tabs. We should also use the TEST_VERBOSE environment variable instead of VERBOSE.
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
Additional edits by myself to add the emacs mode line.  Also, the change to runtests.sh was done by me.
2001-10-19 22:39:51 +00:00
jake%acutex.net 1755af2c9d Fix for bug 105365 - Hacker's Guide should be in SGML. This will make it easier to do other additions to the hacker's guide. 2001-10-19 16:18:10 +00:00
justdave%syndicomm.com 21fe682b44 yet another meaningless whitespace change to test tinderbox with 2001-10-19 13:03:52 +00:00
justdave%syndicomm.com 8febda1bc1 another useless whitespace change to test tinderbox with 2001-10-19 06:19:52 +00:00
mcafee%netscape.com dd631f42a6 Adding one more sig fig for startup time. 2001-10-19 06:15:24 +00:00
mcafee%netscape.com eda1eed498 switching search token to __avg_startuptime, we are going to iterate the test now and report an average time. 2001-10-19 05:56:38 +00:00
justdave%syndicomm.com 4c8e89a6a6 whitespace change to test tinderbox again. 2001-10-19 05:33:23 +00:00
justdave%syndicomm.com d7672429e0 whitespace change to do a test checkin to see how tinderbox reacts 2001-10-19 04:36:19 +00:00
gerv%gerv.net c42a036e6b Bug 72177 - reword checkbox to make it consistent with the others on the page. 2001-10-18 21:41:25 +00:00
gerv%gerv.net b3bcc8e15d Bug 60818 - make Bugzilla cope with MIME types with parameters. Patch by gerv, r=myk. 2001-10-18 21:28:06 +00:00
kestes%walrus.com 4365fe256e Remove the /var/run/ stuff. I need to think this through more carefully.
This only needs to happen on the build script.  This needs to happen as
the user root but currently I do not run the build script ever as root.
2001-10-18 16:19:59 +00:00
kestes%walrus.com ab215705d1 bug fixes to get the /var/run stuff to work. 2001-10-18 16:17:24 +00:00
kestes%walrus.com 8cfb49fe20 separate the packge output into client and server packages. 2001-10-18 15:59:20 +00:00
kestes%walrus.com 8ea3e34f7b Add support for /var/run/ directory. 2001-10-18 15:05:57 +00:00
gerv%gerv.net 5307a7b0c1 Bug 98146 redux - changing URL to relative one. Oops. Patch by jake, r=gerv. 2001-10-16 18:42:05 +00:00
timeless%mac.com eb5f2b81cf bug 27506, i messed up. making the changes per cbiesinger@web.de and justdave@syndicomm.com 2001-10-16 08:44:43 +00:00
gerv%gerv.net 0409076d01 Bug 30480 - add 'show dependencies as buglist' links. Patch by gerv, r=myk, kiko. 2001-10-16 03:09:52 +00:00
myk%mozilla.org 65ba90ca97 Fix for bug 98146.
Patch by Gerv <gerv@mozilla.org>.
r=myk, no second review needed.
2001-10-15 23:02:48 +00:00
jake%acutex.net f53bd26e72 Recompiling docs to pick up last two changes 2001-10-15 19:18:04 +00:00
jake%acutex.net ceb1a1739a The recommended style for perl (which is the styleguide Bugzilla will use) specifies that else should not be cuddled. This guide, while not specifically saying it, elluded to cuddling else. Fixing that problem. 2001-10-15 19:12:46 +00:00
gerv%gerv.net 18263f8245 Bug 104105 - cosmetic change to make it obvious that you can create an account. 2001-10-15 03:59:19 +00:00
gerv%gerv.net 9c91a2926a Bug 46935 - trivial typo. 2001-10-15 03:46:28 +00:00
gerv%gerv.net ac3a86954b Bug 99716 - allow query for Attachment is obsolete AND Attachment Status. Patch by myk, r=justdave, jake. 2001-10-15 00:55:50 +00:00
gerv%gerv.net 6c2f12179c Bug 57819 - change the size of the bit we print in the large error case. r=justdave. 2001-10-14 01:34:08 +00:00
jake%acutex.net 29c34fafbd Tabs are not allowed in Bugzilla source... if we find one, issue a warning.
No review needed for tests at this time. NOT PART OF BUILD
2001-10-13 01:44:06 +00:00
justdave%syndicomm.com 3eb400cda4 Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2
2001-10-13 01:36:17 +00:00
justdave%syndicomm.com 85719e17a4 Fix for bug 19910: Bugzilla installs on the same server would interfere with each others' cookies. Cookies now have a path value that can be set to indicate which bugzilla install they belong to. Browsers will only send the cookie to the appropriate installation. The path can be set in the 'cookiepath' parameter in editparams.cgi.
Patch by Dave Lawrence <dkl@redhat.com>
r= myk, justdave
2001-10-13 00:40:41 +00:00
justdave%syndicomm.com cd0de56d18 Fix for bug 101056: multiple form values of the same name were not getting correctly stashed if the user had to log in as part
of a form submit.
Patch by Myk Melez <myk@mozilla.org>
r= gerv, justdave
2001-10-12 21:33:21 +00:00
gerv%gerv.net 2996888b17 Bug 100490 - better error message with no JavaScript for QuickSearch. Patch by afranke, r=kiko, gerv. 2001-10-12 20:54:26 +00:00
jake%acutex.net 4f03a1f2f0 If a template doesn't exist, this should be considered a compile failure.
No review needed for tests at this time. NOT PART OF BUILD
2001-10-12 20:35:37 +00:00
myk%mozilla.org 27984b1bf7 Fix for bug 91486: Add "changed from" option to the boolean chart.
Patch by Stephen Lee <slee@uk.bnsmc.com>.
r=myk@mozilla.org
2001-10-12 20:25:57 +00:00
justdave%syndicomm.com 7a98289b8e Backing out Gerv's checkin for bug 71840. Per the bug report, it did not have proper review first, and myk objected to what
got landed on irc.
2001-10-12 03:03:00 +00:00
gerv%gerv.net 12f3a98019 Bug 71840 - Make comments referenceable. Patch by gerv; r=myk, jake (ish :-). 2001-10-11 23:07:54 +00:00
gerv%gerv.net 261a495480 Bug 83058 - need a way to hide resolved bugs in dependency tree view. Patch by kiko; r=gerv, afranke. 2001-10-11 23:01:44 +00:00
gerv%gerv.net 26499b674c Bug 76161 - Don't select "resolve as dup" radio button when exiting empty dupe field. Patch by justdave, r=jake, caillon. 2001-10-11 22:18:35 +00:00
gerv%gerv.net 1a24cca0d5 Bug 57819 - cut down large mysql error strings. Patch by n_hibma@qubesoft.com, r=gerv. 2001-10-11 21:58:07 +00:00
gerv%gerv.net ffee44f25a Bug 52782 - whineatnews.pl email should use the 'sendmailnow' Param. Patch by e.maryniak@pobox.com, r=gerv. 2001-10-11 21:55:21 +00:00
gerv%gerv.net d811602365 Add MacOS X. Bug 52577. Patch by afranke. r=gerv. 2001-10-11 21:52:28 +00:00
gerv%gerv.net 595dc193af Bug 104247 - make colours in buglists work again. Patch by kiko, r=gerv. 2001-10-11 21:42:07 +00:00
jake%acutex.net 1a40034281 Fix for bug 104180 - &nbsp; should only be used in the display for a saved query w/a space, not in the URL.
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net
2001-10-11 19:51:33 +00:00
jake%acutex.net 1b82b56dc3 Fix for bug 103592 - e-mail addresses that are longer than 30 characters will be truncated in the bug list.
Patch by Christian Reis <kiko@async.com.br>
r= gerv@mozilla.org, afranke@ags.uni-sb.de, jake@acutex.net
2001-10-11 19:44:46 +00:00
jake%acutex.net 3762e3c0a5 Fix for bug 104117 - The editkeywords.cgi link was broken as a result of the fix for bug 103554.
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net
2001-10-11 19:07:00 +00:00
timeless%mac.com 9a8c0e2ac0 Bug 27506 The Bonsai pages contain SCRIPTs which are not enclosed in
<!-- -->, greatly confusing some HTML parsers.
r=kiko
2001-10-11 18:44:14 +00:00
justdave%syndicomm.com a04643f3f2 Fix for bug 97784: comments in attachment update form are now properly word-wrapped. This is a server-side implementation to
do the word-wrapping, which will probably eventually be used in the main comments area on the bug form as well.
Patch by Myk Melez <myk@mozilla.org>
r= gerv, justdave
2001-10-11 02:17:58 +00:00
justdave%syndicomm.com 6afb953716 Fix for bug 103554: HTML generated by the PutHeader and GetCommandMenu subroutines now validates as HTML 4.01 at W3C.
Patch by Christian Reis <kiko@async.com.br>
r= caillon, gerv, justdave
2001-10-10 23:36:29 +00:00
myk%mozilla.org e2473d392b Fix for bug 27420: Gives the Component and Target Milestone fields extra space in the long list display of bugs.
Patch by Randall Whitman <randall.whitman@solipsa.com>.
r=justdave@syndicomm.com, no second review needed
2001-10-10 19:50:02 +00:00
kestes%walrus.com cb3191580b better name for default log file 2001-10-10 15:09:06 +00:00
kestes%walrus.com d3b0fbe78d fix broken usage for process_builds. allow usage to be viewed even if
security tests not passed.
2001-10-10 15:08:24 +00:00
kestes%walrus.com 782a9645ce typo in new BT_NAME parameter, did not get default from TinderboxConfig 2001-10-10 15:07:41 +00:00
kestes%walrus.com 8f6c524129 allow usage page to be viewed withhout passing security checks. 2001-10-10 15:06:48 +00:00
jake%acutex.net efb7eb3ab8 Fix for bug 65164 - Bugzilla wasn't sending </html> at the end of its pages.
Patch by Christian Reis <kiko@async.com.br>
r= gerv@mozilla.org, jake@acutex.net
2001-10-10 13:26:28 +00:00
justdave%syndicomm.com 52bd262467 partial backout of the checkin from bug 103121, because it collided with the patch from bug 51519. This should satifactorily
meet the goals of both patches.  patch by kiko, r= justdave
2001-10-10 06:36:45 +00:00
timeless%mac.com d9d2292794 Bugzilla Bug 103121 editusers.cgi needs an Add link on the query page.
patch by dkl. r=kiko
2001-10-10 04:57:30 +00:00
timeless%mac.com 3a5a3ff16d Bugzilla Bug 97185 make_select should add a newline after each option
patch by kiko. r=zach, gerv
2001-10-10 04:52:09 +00:00
timeless%mac.com bdfb4b81ff Bugzilla Bug 51521 Broken HTML on user permissions page
patchwork by john.beranek@pace.co.uk and kiko. r=zach, kiko, gerv
2001-10-10 04:47:17 +00:00
kestes%walrus.com 5cc2a6f34b wrong format string. I keep using %e instead of %d this puts spaces
in the VERSION number which is not allowed.
2001-10-09 19:45:09 +00:00
jake%acutex.net dbf98eb416 It's also possible to PROCESS another attachment fragment, not just INCLUDE.
No review needed for tests at this time. NOT PART OF BUILD.
2001-10-09 19:14:59 +00:00
kestes%walrus.com 458dc29162 add new features. 2001-10-09 15:52:43 +00:00
kestes%walrus.com 45a82f461f remove the colons from the tar file name. This was a bad idea because the
colons mean something special to tar.
2001-10-09 15:51:35 +00:00
kestes%walrus.com a8ed78963b clarify the build states. 2001-10-09 15:38:27 +00:00
kestes%walrus.com f04d4b26f4 make BT and VC column heading configurable. 2001-10-09 15:30:16 +00:00
kestes%walrus.com f4e0f57965 *** empty log message *** 2001-10-08 20:36:41 +00:00
kestes%walrus.com 546183097a more discriptions of what program does. 2001-10-08 20:25:52 +00:00
kestes%walrus.com 70143c67ca better usage discription. Index.html does not list itsself and now
displays sizes.
2001-10-08 19:25:33 +00:00
zach%zachlipton.com e00bb53520 Fix for bug 98074: Attachment manager doesn't html_escape bug titles.
r1=caillon <mailto:caillon@returnzero.com>, r2=Jake
<mailto:jake@acutex.net>
2001-10-07 17:50:22 +00:00
jake%acutex.net 442e125a9f Allow compile tests for files that run in taint mode
No review needed for tests at this time. NOT PART OF BUILD
2001-10-06 23:22:48 +00:00
jake%acutex.net 5765f690cb We also need to look for templates that are INCLUDEd in other templates.
No review needed for tests at this time. NOT PART OF BUILD
2001-10-06 21:37:22 +00:00
bbaetz%cs.mcgill.ca d1e7019522 Doc type fix, r=kiko 2001-10-06 19:04:08 +00:00
jake%acutex.net 7cfef16aad Test that scans Bugzilla's code looking for used templates then checks to make sure that:
a) All the required templates exist
 b) They all have good syntax

No review needed for tests at this time. NOT PART OF BUILD
2001-10-06 18:59:36 +00:00
zach%zachlipton.com f284bf6dda Fixing issue where excluded files aren't excluded if they end in .pl or
.cgi.
2001-10-06 03:49:06 +00:00
zach%zachlipton.com 1bc30500f7 Don't test importxml.pl since you need XML::Parser which is not required,
creating a false fail.

No review needed for tests. NOT PART OF BUILD
2001-10-06 03:25:43 +00:00
zach%zachlipton.com f8fd2021ed Get rid of our which causes errors on 5.005.
No review needed for tests at this time. NOT PART OF BUILD
2001-10-06 01:23:38 +00:00
myk%mozilla.org 644c4d90a3 Fix for bug 76714: correctly nests the FORM and TABLE elements.
Patch by Gerv Markham <gerv@mozilla.org>.
r=myk@mozilla.org, no second review needed.
2001-10-06 00:03:00 +00:00
jake%acutex.net 62360e8331 Fix for bug 57821 - Empty regular expression causes a software error.
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= jake@acutex.net
2001-10-05 23:06:08 +00:00
kestes%walrus.com cac12b0a1b fix broken parsing and handing of --help --version 2001-10-05 22:42:12 +00:00
jake%acutex.net 16528766ad Fix for bug 66651 - Include link to attachment in notification mail
Patch by Gavin Shelley <gavins@iplbath.com>
r= jake@acutex.net
2001-10-05 22:38:12 +00:00
jake%acutex.net 490e71db30 Fix for bug 93006 - The mass change page was auto-selecting the wrong radio button.
r= caillon@returnzero.com
2001-10-05 22:20:33 +00:00
kestes%walrus.com d2bd4509d0 fix bug in mail processing where errors were not logged. This was a scope
error in the LOG glob. Also we now allow users to run tinderbox via setuid wrappers
and no longer exclude certain uid ranges but require tinderbox to be run via the id which
the user specifies explicitly.
2001-10-05 22:11:50 +00:00
kestes%walrus.com d1723cfd09 The index files were not being over written but being appeneded to and the
documentation had not been updated.
2001-10-05 22:10:14 +00:00
kestes%walrus.com 723c3d4495 add ability to generate index.html files for the directories which are processed
this is because most browsers are truncating our long build file names.
2001-10-05 22:05:10 +00:00
jake%acutex.net 4416f18087 Fix for bug 55630 - email-suffix is not shown in createaccount-page
Patch by kai morich <mail@kai-morich.de>
r= matty@chariot.net.au
2001-10-05 19:38:26 +00:00
jake%acutex.net 7b18e2d7ac Fix for bug 83474 - The tables were not being unlocked properly when rebuilding the keyword cache if there were no keywords to rebuild.
Patch by Lukasz Engel <Lukasz.Engel@softax.pl>
r= matty@chariot.net.au
2001-10-05 15:18:12 +00:00
zach%zachlipton.com 0c92d3c1d3 Fix for bug 102032: Fix tinderbox test errors and warnings. Patch to make new_comment.cgi use strict and warnings and make tests run at
100%!

Patch by Jake <jake@acutex.net>, r=justdave, no 2nd review needed.
2001-10-05 02:16:34 +00:00
zach%zachlipton.com af7c721749 Fix for bug 98095:importxml.pl fails perl -wc test. Simple 1 line addition
that makes importxml.pl not fail the tests. We are on our way to 100%!

Patch by Jake <jake@acutex.net>, r=zach@zachlipton.com, no 2nd review required.
2001-10-05 00:42:06 +00:00
ian%hixie.ch d3f6f800ce Correcting minor typo (extraneous ')'s). 2001-10-04 16:09:32 +00:00
timeless%mac.com 86618bd16b Bugzilla Bug 69533 enter_bug.cgi does not auto-detect HP-UX as OS
patch by gary@radionics.com r=zach
2001-10-04 00:06:54 +00:00
justdave%syndicomm.com 5f7fd584d1 Fix for bug 82809: comments in bugs no longer have &#013; where the linefeeds should be.
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless@mac.com (no 2nd review needed)
2001-10-03 07:49:19 +00:00
terry%mozilla.org 356edd8c39 Fix for bug 102723: If genstats dies trying to change databases it will now include the name of the statistic it was trying to generate in addition to the name of the database it was trying to change to in the error message.
Patch by Myk Melez <myk@mozilla.org>.
r=dmose
2001-10-02 22:56:50 +00:00
zach%zachlipton.com 428f579276 Fix for bug 52885: automatic radio selection for reassign shouldn't
trigger if new text is same as original owner or empty.

Patch by Christopher Aillon (caillon@returnzero.com). R=Bradley Baetz
(bbaetz@cs.mcgill.ca). No 2nd review needed.
2001-10-02 01:20:52 +00:00
myk%mozilla.org 25a870a14d Fix for bug 98744: No more software error when the user clicks "remove cc" without specifying users to remove.
Fix by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.
2001-09-28 19:49:53 +00:00
myk%mozilla.org ef0940e2f5 Fix for bug 73959: Make buglist.cgi display the "Show Votes" link at the bottom of the screen.
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.
2001-09-28 19:17:27 +00:00
myk%mozilla.org 6253da57b9 Fix for bug #53612: The milestone URL appears correctly when deleting a product or a component.
Patch by Jake <jake@acutex.net>.
r=gerv@mozilla.org,myk@mozilla.org
2001-09-27 23:49:07 +00:00
zach%zachlipton.com 12be070deb Partil fix for bug 102032: Fix tinderbox test errors and warnings. This patch adds some -w and use strict; work to clean up
most of the '002goodperl.t' errors.

r=Dave Miller <justdave@syndicomm.com> no 2nd review required.
2001-09-27 23:19:33 +00:00
justdave%syndicomm.com 18eab3e1d2 Fix for bug 101659: emailsuffix was missing from the component owner mailto tag on sites that use emailsuffix.
Patch by Steve Naldrett <snaldrett@transparentnetworks.com>
r= justdave@syndicomm.com x2
2001-09-26 02:37:29 +00:00
zach%zachlipton.com afa2da21cc Fix for bug 93388: Full name should be trimmed of whitespace before going
into database.

r1=Zach Lipton <zach@zachlipton.com> r2=Andreas Franke
<afranke@ags.uni-sb.de>. Patch by Christopher Aillon
<caillon@returnzero.com>.
2001-09-23 17:20:50 +00:00
zach%zachlipton.com 4d9df09144 Fix for bug 97588: localconfig should mention access.conf as well as
httpd.conf (for old apache). Simple 2line comment addition to localconfig
to inform the user they may need to look at access.conf in addition to
httpd.conf if they are using an older version of apache.

Patch by Gavin Shelley <gavins@iplbath.com> r=Zach Lipton
<zach@zachlipton.com> no 2nd review needed for this patch.
2001-09-23 17:07:55 +00:00
zach%zachlipton.com be566d9a28 Have checksetup.pl block web-access to runtests.sh (by .htaccess) and
chmod +x runtests.sh so that it can be run with ./

r=bbaetz on irc, no 2nd review needed. No bug filed.
2001-09-23 04:28:17 +00:00
zach%zachlipton.com e51f621218 Renaming *.t to be 00*.t to solve any sorting issues down the road as per
bug 97976.

No review required for tests at this time. NOT_PART_OF_BUILD
2001-09-23 04:08:44 +00:00
zach%zachlipton.com 027423a2f9 *** empty log message *** 2001-09-23 04:02:19 +00:00
ian%hixie.ch 8e3c09a895 The first ContactMethod, namely Email. 2001-09-19 18:56:05 +00:00
ian%hixie.ch d5e036ecd2 Added a hook for installing new user fields so that setupInstall handlers don't have to go through the same process multiple times. Also corrected an obvious error (using a variable after checking that it couldn't be used...). 2001-09-19 18:43:06 +00:00
ian%hixie.ch 7c5a6e0734 Correcting the misspelling of the package names ('Components' not 'Component') to match the directory. 2001-09-19 18:29:39 +00:00
ian%hixie.ch f650602a79 Corrected the order of return values (newPassword) and removed the extraneous argument (output). 2001-09-19 18:11:03 +00:00
ian%hixie.ch 25c3d3b7f3 Cached the SMTP object to improve performance. 2001-09-19 18:05:28 +00:00
ian%hixie.ch 00afd76821 Made the outputter be a simple service rather than a service instance to improve performance. 2001-09-19 18:01:23 +00:00
ian%hixie.ch e18f084c7e Corrected an oversight in the service instance creation code: if a service acts as both a service instance and a normal service, it needs a special constructor to force the creation of the instance, otherwise if the service is created first it will be used again for the instances. 2001-09-19 17:56:15 +00:00
jake%acutex.net aaebfe1839 Fix for bug 97971 - Sanity check should check statuses, resolutions, everconfirmed & number of votes.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-09-19 15:06:43 +00:00
mcafee%netscape.com a20ddcac97 Adding branch page 2001-09-18 23:24:28 +00:00
rginda%netscape.com 9945e649fa patch from Pavel Hlavnicka pavel@gingerall.cz
fix ordering of user footer and menu
2001-09-17 18:58:14 +00:00
myk%mozilla.org fba452acb3 Fix for bug 90333: Bugzilla now displays an appropriate error message if a user hits process_bug.cgi without specifying any bugs to change.
Patch by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
2001-09-17 18:55:31 +00:00
ian%hixie.ch 592ee5528d Fixed error messages to be more accurate. 2001-09-17 00:13:16 +00:00
zach%zachlipton.com a43434e27e Fix to make the tests generate the list of files to test instead of having to update the list manually whenever a file is added
or removed. The main logic is in t/Support/Files.pm, changes to the test files are needed to allow it to function properly.

NOT_PART_OF_BUILD. No review needed for tests at this time.
2001-09-16 18:35:18 +00:00
zach%zachlipton.com 6953c1e8f3 Make this file test for exec calls in addition to system calls that are
one-argument and are therefore insecure.

NOT_PART_OF_BUILD, no review needed.
2001-09-16 17:52:19 +00:00
myk%mozilla.org 13bed907d6 Fix for bug 97877: changed* operators now work for attachment statuses on query form.
Fix by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
2001-09-15 07:26:21 +00:00
jake%acutex.net c524d1adcb Fix for bug 30731 - Reassigning closed bugs from the mass change page caused their status to be set to new.
r= myk@mozilla.org, zach@zachlipton.com
2001-09-14 21:50:08 +00:00
timeless%mac.com d8400a256e bugzilla wasn't catching mozilla on 98 which was annoying. r=jake 2001-09-13 20:41:59 +00:00
jake%acutex.net 1b759fae9a Fix for bug 58436 - javascript strict warnings in query.cgi
Patch by Christian Reis <kiko@async.com.br>
r= caillon@returnzero.com, jake@acutex.net
2001-09-13 20:04:40 +00:00
timeless%mac.com 84e5eab357 Bugzilla Bug 99465 FreeBSD not recognized!
r=jake
2001-09-13 18:21:07 +00:00
gerv%gerv.net 383f5cba05 Make Bugzilla support <link> tag for buglists. Bug 87818. r=jake, caillon. 2001-09-10 21:26:05 +00:00
jake%acutex.net 732604001c Fix for bug 76140 - Adding some more sanity checks.
Patch by Matthew Tuck <matty@chariot.net.au>
r= caillon@returnzero.com, jake@acutex.net
2001-09-10 15:20:11 +00:00
jake%acutex.net 831a0dc3ba Fix for bug 97657 - in defparams.pl, the sillyness sub should be called defparams_pl_sillyness
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
r= jake@acutex.net
2001-09-10 14:57:12 +00:00
jake%acutex.net f9d35d29b3 Fix for bug 71664 - Don't complain about a bad keyword cache for a bug that doesn't exist.
Patch by Matthew Tuck <matty@chariot.net.au>
r= afranke@ags.uni-sb.de, jake@acutex.net
2001-09-10 14:12:10 +00:00
jake%acutex.net 598b67df77 Fix for bug 95060 - Correct the instructions on how to view your current votes.
Patch by Gavin Shelley <gavins@iplbath.com>
r= jake@acutex.net x2
2001-09-10 14:00:48 +00:00
jake%acutex.net f1977072a4 Fix for bug 8647 - Add an option to the query page to sort by Last Changed date.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net x2
2001-09-10 13:49:26 +00:00
ian%hixie.ch 9035927484 First stab at an e-mail output service. Also added support for checking addresses for validity and used that when creating a new account. 2001-09-09 21:02:33 +00:00
zach%zachlipton.com eb7921111d Oops. Forgot to check this is. 2001-09-09 19:48:15 +00:00
ian%hixie.ch 1bdb52ce4f Reduced the ErrorContext from 2 to 1. 2 is too much. 2001-09-09 19:48:14 +00:00
ian%hixie.ch b09d3910bb corrected a comment, corrected the spelling of a method call, and added a placeholder in 'login.failed' which will eventually have to be replaced by code which finds the list of contact methods. 2001-09-09 19:47:04 +00:00
ian%hixie.ch 573aee3d11 Added ErrorContext to the Expat arguments so that well formedness errors are easier to track down. 2001-09-09 19:38:24 +00:00
ian%hixie.ch c128f0735b Corrected and improved some comments.
Corrected a problem with scope and the 'escape' attribute of <text> elements.
Renamed 'shrink' and 'expand' to the slightly more accurate 'flatten' and 'rounden'. (ahem)
Changed the ordering of symbol unescaping in roundening to be less (not?) susceptible to incorrect expansion.
Changed the ordering of symbol escaping in flattening to be consistent with the unescape order when roundening.
Made <text> trim one leading and one trailing newline in text nodes if xml:space="default" (makes COSES files neater).
Added a 'coses: original keys' hash to values whose keys are sanitised
Made the 'escape' values be lower case instead of upper case (makes COSES files neater).
2001-09-09 19:36:23 +00:00
ian%hixie.ch 93e947211d Corrected the SQL for 'SHOW COLUMNS FROM' so that it actually works... 2001-09-09 19:21:17 +00:00
ian%hixie.ch 10ba6f53e5 Added a string data source which gets the strings from a file instead of from the database, useful as a fallback. 2001-09-09 19:19:05 +00:00
ian%hixie.ch 8a6d55c4de Made the error message printed when no string expander can be found more explicit (it now mentions the name and type of the string). 2001-09-09 19:08:58 +00:00
ian%hixie.ch 2d98944b83 Added a comment clarification. 2001-09-09 19:06:13 +00:00
ian%hixie.ch d571cc1375 Changed the magic piping array so that it is more consistent by removing the special casing of when there is only one return value. 2001-09-09 19:04:37 +00:00
ian%hixie.ch e40dafc029 Added the message level number to the debug output to help gauge what level is useful. 2001-09-09 17:55:21 +00:00
ian%hixie.ch 2418906f94 Added header and stylistic note.
Clarified some of the text.
Made the use of quotes more consistent.
Wrote Chapter 5, "USING GET SERVICE".
Added an empty Chapter 10, "THE SERVICE REFERENCE".
2001-09-09 17:48:07 +00:00
justdave%syndicomm.com e4012ce728 Fix for bug 98468: sample email regexp for username-only address changed from ^[^@]*$ to ^[^@]+$ and the default emailregexp changed from ^[^@]*@[^@]*\\.[^@]*$ to ^[^@]+@[^@]+\\.[^@]+$
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net x2
2001-09-07 03:25:33 +00:00
justdave%syndicomm.com 9ec346a74d refix for bug 91808: previous patch for this bug used an INNER JOIN construct in the SQL, which is not supported by the
minimum version of MySQL that we require.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2
2001-09-07 01:32:13 +00:00
kestes%walrus.com c8107279a3 better documentation both internal and external. Reevaluate the steps
to make a build each iteration to allow builds to create time stamped output.
catch some errrors using eval so that they will appear in the tinderbox mail and not as fatal errors. Strip a few more 'dangerous variables' from the environment.
2001-09-06 18:15:53 +00:00
jake%acutex.net 2ed0e662aa Fix for bug 30597 - Hyperlinking the number of votes was causing some confusion because it was such a small link, yet the most useful. Instead, we now have a link labeled "Show votes for this bug".
Patch by Matthew Tuck <matty@chariot.net.au>
r= louie@ximian.com, jake@acutex.net
2001-09-06 12:42:47 +00:00
justdave%syndicomm.com 3a1384b065 Fix for bug 42337: Adding the usual red box for errors uploading attachments.
Patch by Matthew Tuck <matty@chariot.net.au>
r= louie@ximian.com, justdave@syndicomm.com
2001-09-06 03:20:34 +00:00
justdave%syndicomm.com efcb9c7db1 Fix for bug 69616: If you have tweakparams privs, the "Sanity check" link was listed with a group of items that said "Edit" so
it appeared as if you were going to edit the sanity checks if you clicked on it, when in fact you were going to run them.
This patch rewords the links so Sanity check is in a group by itself in the block of links on the right.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2
2001-09-06 02:19:04 +00:00
zach%zachlipton.com b91182e74e Adding a test for safe system and exec calls. Part of this code by Dave. 2001-09-05 01:43:25 +00:00
zach%zachlipton.com cbc7b5ba25 Add a little 1; to the end of this. 2001-09-04 04:28:24 +00:00
zach%zachlipton.com 5b949c45ef Actually make the strict checking work. 2001-09-03 22:11:43 +00:00
zach%zachlipton.com ac55bba9b4 add tests for use strict; 2001-09-03 22:04:09 +00:00
zach%zachlipton.com eb7cb06e59 Enforce -w. This file will also be used to enforce use strict; 2001-09-03 21:43:22 +00:00
zach%zachlipton.com d65dd7c7ac Rename 1.t to 1compile.t as per bug 97976. 2001-09-03 20:17:40 +00:00
zach%zachlipton.com a154cf3f21 Remove processmail from the list. It was causing problems with taint. 2001-09-03 19:39:37 +00:00
zach%zachlipton.com e96fdf8569 Ok, really this time. This should work :) 2001-09-03 19:26:58 +00:00
zach%zachlipton.com 4fc953535a Backout of this to get things back to normal 2001-09-03 18:50:56 +00:00
zach%zachlipton.com a9bf8e83e2 Use Support::Files for the test items. No review needed at this time for tests as per Dave. 2001-09-03 18:35:19 +00:00
zach%zachlipton.com 744c3c158b Addition of Files.pm which will be used shortly by 1.t (soon to be 1compile.t) which contains the list of files to test. This is important so that we can bring it into other tests which check files for content, etc... No review required for tests as of now as per Dave. 2001-09-03 18:33:03 +00:00
zach%zachlipton.com 2c55fae775 Fix for bug 98024: t/1.t should use $^X instead of hard-coded path to perl.
Patch by ddkilzer@theracingworld.com (David D. Kilzer, ddk). Review by Zach Lipton (zach@zachlipton.com) no 2nd review required.
2001-09-03 17:58:53 +00:00
justdave%syndicomm.com eed4aabd7a Fix for bug 91808: Additional sanitycheck tests for the duplicates table.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net, caillon@returnzero.com
2001-09-03 01:08:05 +00:00
justdave%syndicomm.com 5c71444e32 Added a --verbose option to runtests.sh that the tinderbox scripts can use to get all the warnings and errors and whatnot into the build log. Also corrected several syntax and logic errors in the 1.t test file. 2001-09-01 03:06:15 +00:00
jake%acutex.net 8a4dfb84a5 Fix for bug 42810 - Bugzilla would choke if your product name contained a ' mark.
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com, caillon@returnzero.com
2001-08-31 23:51:35 +00:00
zach%zachlipton.com 825d57d288 Fix for bug 96603: Grammatical error in bug_status.html. Simple one word fix.
Patch by Christopher Aillon (caillon@returnzero.com). r1=Christian Reis (kiko@async.com.br),
r2=Zach Lipton (zach@zachlipton.com) though not really needed for this patch.
2001-08-31 23:37:36 +00:00
myk%mozilla.org dbd90ba1be Fix for bug 97764: Fixes errant sending of mail on attachment changes to users who do not want to receive mail about their own changes.
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org; no second review needed.
2001-08-31 21:40:33 +00:00
zach%zachlipton.com 23212ed017 Adding runtests.sh and 1.t to start the testing suite. No bug has been
filed on this issue. NOT_PART_OF_BUILD.
2001-08-31 17:41:38 +00:00
justdave%syndicomm.com 4c94f5c6c3 Fix for bug 97721: Bugzilla now requires Perl 5.005 (previous requirement was Perl 5.004). This is due to the use of Template Toolkit for templatizing the pages for easier local customization. The new attachment tracker that was checked in earlier tonight uses the templates. Also included on this patch is a check for AppConfig, which is a prerequisite for Template Toolkit, because the Makefile.PL for Template Toolkit won't run without it, and it doesn't tell CPAN that it has prereqs, which causes confusion if you're installing from CPAN.
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-31 06:08:43 +00:00
justdave%syndicomm.com 19a5a3e365 Fix for bug 75840: syncshadowdb -syncall now properly shuts down Bugzilla during the sync process so mysql doesn't get overloaded while the tables are locked. This patch also adds some funtionality to the script to allow you to specify an alternate temp directory on the command line, in case you have a large database and need it made to a different filesystem for space reasons.
Patch by Dawn Endico <endico@mozilla.org> and Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-31 05:49:01 +00:00
myk%mozilla.org 41268ed110 Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com
2001-08-31 04:19:32 +00:00
myk%mozilla.org 34ed0df3d8 Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com
2001-08-31 03:54:37 +00:00
myk%mozilla.org 70b600ce7e Fix for bug 26189: "cannot view images with lxr". The image-handling code was running too early and didn't have access to the "raw" URL parameter by which images get displayed.
Patch by Dawn Endico <endico@mozilla.org>
r=myk@mozilla.org
2001-08-31 00:46:09 +00:00
justdave%syndicomm.com 983ad23402 Fix for bug 96534: The version, component, and milestone select lists on the query page were slow to reflow when you changed the product in the first select list. This patch is a complete rewrite from scratch of the javascript used on query.cgi, which results in an approximately 700% speed increase in the reflow time when changing the selected product.
Patch by Chris Lahey <clahey@ximian.com> and Christian Reis <kiko@async.com.br>
Javascript changes r= caillon@returnzero.com, louie@ximian.com
Perl changes r= jake@acutex.net, justdave@syndicomm.com
2001-08-30 22:56:53 +00:00
kestes%walrus.com c6459e2072 merge this sample with code I am really using, to demonstrate how to build
tar files for each build and use the -D in CVS.
2001-08-30 18:54:25 +00:00
jake%acutex.net 94050ac3cb Fix for bug 28736 - Bugmail will now show the summary for the bug that changed in the "This bug depends on bug X, which changed state" messages.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-08-30 03:14:24 +00:00
justdave%syndicomm.com 7d1487e8ed Bumping version to 2.15 for development 2001-08-29 21:41:50 +00:00
justdave%syndicomm.com 72c5f424e5 moving version to 2.14 (golden) to roll the tarball. 2001-08-29 19:52:13 +00:00
jake%acutex.net 4a68b9ae59 Updating release notes for 2.14
Release Notes written by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com, jake@acutex.net
2001-08-29 19:39:01 +00:00
barnboy%trilobyte.net 423e261089 Typo in perl modify string, added "#!" to /usr/bin/perl strings. 2001-08-29 18:13:42 +00:00
barnboy%trilobyte.net e9d3e04bff Buncha' release updates. Moved all images to
./images so we don't have multiple copies of the
same image, fixed these doc bugs (in no particular order):
94949
97070
97071
97114
96498
95970
96677
94953
96501
96679
97068
97191
97192
2001-08-29 17:25:41 +00:00
kestes%walrus.com 6929a0dcaf *** empty log message *** 2001-08-29 16:07:08 +00:00
justdave%syndicomm.com 1296d0bf87 Fixing a couple typoes 2001-08-28 17:55:14 +00:00
justdave%syndicomm.com 8b3f62a485 Re-fix for bug 87769: the original patch checked in for this prevented any votes from being changed at all. This corrects that so votes can be changed again while still trapping the error the original patch was designed to catch.
Patch by Christoper Aillon <caillon@returnzero.com>
r= justdave@syndicomm.com
2001-08-28 09:19:16 +00:00
justdave%syndicomm.com af99f4f812 All code patches targetted for 2.14 have been checked in. Bumping version
number to 2.14rc to indicate release candidate status.
2001-08-26 23:06:45 +00:00
justdave%syndicomm.com 796b6cf561 Fix for bug 92266: Prevent dataloss in the bugs_activity table by wrapping
entries into additional entries if they're too long to fit.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-08-26 22:58:34 +00:00
jake%acutex.net 0c11288732 Bug 96085 - bypassing group security checks using duplicate bugs
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
2001-08-26 18:51:45 +00:00
jake%acutex.net 83ff039814 Fix for bug 87769 - doeditvotes.cgi can nuke votes
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
2001-08-25 18:53:31 +00:00
jake%acutex.net 51d56e60fb Fix for bug 95634 - Improvements to Param('voteremovedmail')
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-08-25 00:12:12 +00:00
justdave%syndicomm.com 5206e0b6ac Fix for bug 95235: variables with untrusted content were being echoed back to the user in error messages. Those variables are now run through html_quote() first.
Patch by Gavin Shelley <gavins@iplbath.com>
r= justdave@syndicomm.com
2001-08-24 17:32:25 +00:00
barnboy%trilobyte.net 1e367845e7 Adding some pretty images for the Bugzilla Guide warning,
note, caution, and tip entries.
2001-08-23 14:30:20 +00:00
barnboy%trilobyte.net 4eb813cb2d Big checkin of docs to resolve every
known outstanding doc bug! Yay release.
Still many things to fix. Aren't there always?
2001-08-22 03:44:35 +00:00
gerv%gerv.net f22a315477 Bug 96063 - the old method of doing this barfed on long URL strings. 2001-08-21 00:36:54 +00:00
myk%mozilla.org 94ad120a76 Fix for bug 96085: don't allow unauthorized users to access restricted bugs that do not have a QA contact.
Patch by Myk Melez <myk@mozilla.org>
r=Jake <jake@acutex.net>
2001-08-20 20:36:10 +00:00
kestes%walrus.com 87e2b74b56 current as of mon aug 20 2001-08-20 18:59:56 +00:00
kestes%walrus.com 262f3cf591 catch io errors from storable and give better discriptions. 2001-08-20 18:57:12 +00:00
myk%mozilla.org caf8704094 Fix for bug 95890: Correctly convert/record keyword changes in the bugs_activity table for keywords containing a plus sign or other
regular expression meta-characters.  Myk's first ever Bugzilla checkin!
Patch by Dave Miller <justdave@syndicomm.com> and Myk Melez <myk@mozilla.org>.
r=myk@mozilla.org,justdave@syndicomm.com
2001-08-19 18:26:21 +00:00
jake%acutex.net 65e904febe Refixing bug 95875 - The code that breakes the typed in CC list into individual lists is now slightly more robust and allows perl to handle the splitting more efficiently (by using a space as the delimiter).
r= myk@mozilla.org
2001-08-18 03:35:36 +00:00
justdave%syndicomm.com 4655038d3a Fix for bug 95857: process_bugs.cgi sees blank address in cc: line (would show up as __UNKNOWN__)
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-18 01:49:02 +00:00
jake%acutex.net 2f772f1b84 Fix for bug 95747 - CC List validation (for additions) wasn't happening until after the bug's changes were in the process of being commited. This caused problems if a typo was made in the e-mail address.
r= myk@mozilla.org
2001-08-17 20:18:33 +00:00
jake%acutex.net 1f0d8fe308 Fix for bug 95731: "INSERT INTO shadowlog" failed because "Table 'shadowlog' not locked", fixed typo in lock tables command.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-08-17 12:42:34 +00:00
justdave%syndicomm.com 44f95ac895 Fix for bug 95743: the role-accessible checkboxes were getting cleared if a user with group access had to log in to make changes to a public bug.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-17 11:15:04 +00:00
justdave%syndicomm.com a70b156a17 Fix for bug 95731: "INSERT INTO shadowlog" failed because "Table 'shadowlog' not locked", fixed typo in lock tables command.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-17 08:38:54 +00:00
jake%acutex.net c44843283c Fix for bug 95546. MySQL versions before 3.23 don't support INNER JOINs
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-08-16 15:28:33 +00:00
justdave%syndicomm.com 007829877b Fix for bug 95535: the token generator for password resets is allowing the & character to be used for tokens, but wasn't escaping them for the URL it emailed to users to use to get in to reset their password.
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-16 06:52:55 +00:00
justdave%syndicomm.com d12bd21adf Fix for bug 87779: thanks to the new password reset code, there was no clear way to create a new Bugzilla account from the login screen. There is now a link to createaccount.cgi from the login screen, and the text around the password reset button has been edited so it doesn't sound like you can get a new account by using it (because you can't)
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-16 06:43:21 +00:00
justdave%syndicomm.com ea3bc4ddbb Fix for bug 95304: Add a buglist link to the top of duplicates.cgi
Patch by Gervase Markham <gerv@mozilla.org>
r= justdave@syndicomm.com
2001-08-16 02:54:49 +00:00
justdave%syndicomm.com 8b40d3d395 Fix for bug 92593: Changing a bugs product will no longer remove the votes from that bug unless the number of votes for a given user is beyond what is allowed per-bug on the new product. Only the per-bug vote count is checked. If the user is beyond the per-product vote limit for the new product, it is left alone, on the theory that it's better to preserve the votes on the bug. The user will be forced to reduce their votes to fit the product limit the next time they try to vote on something.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-16 02:46:15 +00:00
justdave%syndicomm.com 9397cee068 Re-fix for bug 95082: allow syncshadowdb to continue to make queries while Bugzilla is shut down.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-15 02:38:02 +00:00
rginda%netscape.com aa90ad2a9c commiting changes from Pavel Hlavnicka <pavel@gingerall.cz>, to add seperate "grouped" and "alphabetical" TOCs, as well as automatic <C> linkage in <SYNTAX> blocks.
Fixed navToGroup to work in the new world.
2001-08-15 00:41:43 +00:00
jake%acutex.net 448f3d1e24 Fix for bug 72951 - oopsbot should have flooder defences
r= zach@zachlipton.com
a= hixie
2001-08-14 16:53:30 +00:00
kestes%walrus.com 554a6f0c6e clean the same ENV variables that sudo does at start time. 2001-08-14 16:34:36 +00:00
kestes%walrus.com 08ad49dcaa the estimate of the time remaining was broken (variable name changed in
some code and not others).
2001-08-14 15:57:43 +00:00
kestes%walrus.com a06166fb63 fix a typo. Try to auto update the status page when admin functions
are performed.
2001-08-13 20:11:55 +00:00
kestes%walrus.com 8de442942b reject bug tickets for trees we do not know about. This allows
BTData to not depend on TreeData
2001-08-13 20:03:10 +00:00
kestes%walrus.com d1758bf024 generalize the interface of BTData::bug_id2bug_url. we he a bug tracking
system which does not have a simple mapping of bugid to url.
2001-08-13 20:01:36 +00:00
kestes%walrus.com dd158be05b generalize the interface of BTData::bug_id2bug_url we have a bug tracking
system which does not have a clear mapping from bugid to url.
2001-08-13 20:00:24 +00:00
kestes%walrus.com 3709a9534b generalize split_cgi_args so that other programs can use it. now it accepts
an argument.
2001-08-13 19:56:41 +00:00
kestes%walrus.com c76e8f2812 generalize split_cgi_args so that other scripts can use it. Add an
argument.
2001-08-13 19:55:25 +00:00
kestes%walrus.com d1df4373a4 the calls to save_structure used to pass a scalar variable and not a reference. this was just wrong and broke when used with storable. 2001-08-13 19:52:34 +00:00
kestes%walrus.com 95a486b119 add code to call the bonsai save state functions. this does not work yet. 2001-08-13 19:50:46 +00:00
kestes%walrus.com b01934cfd9 add code to call the Bonsai save state functions. this does not work yet. 2001-08-13 19:49:36 +00:00
jake%acutex.net 5fe79aa986 Fix for bug 95082 - Param('shutdownhtml') doesn't completely shut down bugzilla.
r= justdave@syndicomm.com
2001-08-13 19:11:35 +00:00
justdave%syndicomm.com c56dabc3aa Fix for bug 26194: There are now substitution parameters available for use in newchangedmail which will include the reason(s)
that the person is receiving the mail in either an email header, the body of the message, or both.  The default newchangedmail
parameter includes these in it.  If you have an existing installation you will need to either hit "reset" next to the
newchangedmail parameter, or add the substitution parameters where you like them according to the instructions given in
editparams.cgi viewed from the web.
Patch by Matthew Tuck <matty@chariot.net.au> and Zach Lipton <zach@zachlipton.com>
r= justdave@syndicomm.com
2001-08-13 17:06:38 +00:00
justdave%syndicomm.com 15919620d2 Fix silly syntax error I missed. 2001-08-13 00:48:45 +00:00
justdave%syndicomm.com 210fb412d3 Fix for bug 39816: Anyone in CC, Reporter, QA Contact, or Asigned To fields can now be given access to view a bug even if the permissions on that bug are set to a group that would normally exclude those people.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-13 00:46:20 +00:00
justdave%syndicomm.com 1c10cce037 Fix for bug 95008: duplicates page no longer ignores verified INVALID/WONTFIX bugs
Patch by Gervase Markham <gervase.markham@univ.ox.ac.au>
r= justdave@syndicomm.com
2001-08-13 00:19:37 +00:00
zach%zachlipton.com 76616604cb More bug 26194: move the reason to the top of the email so that it doesn't look like part of the comment. a=dave 2001-08-12 01:11:21 +00:00
zach%zachlipton.com a78ae48b1a patch for bug 26194: Header explaining reason d'etre for email in New email notification scheme. Patch by MattyT <matty@chariot.net.au>, r=zach@zachlipton.com. 2001-08-11 23:16:16 +00:00
jake%acutex.net 2d4bccef0c Updates to README from bug 94846.
Patch by Matthew Tuck <matty@chariot.net.au>
2001-08-11 19:56:40 +00:00
justdave%syndicomm.com 27be6d253e Fix for bug 94618: remove restrictions on valid characters in passwords. If crypt() takes it, why shouldn't we?
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-11 01:51:05 +00:00
zach%zachlipton.com 3e202c2d5f fix for bug 66235: process_bug.cgi: multiple product change misses the groupset bit. Patch by Myk <myk@mozilla.org> r=Jake, oh, and it's my first checkin, yahoo! 2001-08-11 01:18:24 +00:00
barnboy%trilobyte.net 41422b4bcf CHANGES move to "UPGRADING-pre-2.8" 2001-08-10 22:35:22 +00:00
barnboy%trilobyte.net 849098f553 Compiled HTML/TXT check-in. For some reason, it keeps thinking my darn
dbschema.jpg file is changing, though.
2001-08-10 22:27:11 +00:00
barnboy%trilobyte.net a7c29834ca Removal of HTML from docs temporarily due to massive renaming
in the latest restructuring of the Bugzilla Guide.
2001-08-10 22:15:55 +00:00
barnboy%trilobyte.net de3254008a Checkin for 2.14 release. Still some problems; this cannot yet
be used for 2.14 documentation due to inconsistencies.
2001-08-10 22:13:55 +00:00
justdave%syndicomm.com 25d56d5f96 Re-fix for bug 55161 - if data is partial in activity table, prepend a ? to indicate that we don't know for sure what got dropped.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-09 06:12:18 +00:00
kestes%walrus.com d7e341a8dd Major bug in the untainting code. It seems that $1 is not cleared if
a pattern match fails.  I need to go and explicity add lots of if then else
clauses to ensure that variables are properly clean.  This unleashes a torrent of bugs.  Also split the check for valid filenames into two.  One checks
that each character is a valid character the other checks that
the directories which are pointed to are subdirectories of well known
 directories.
2001-08-02 20:11:03 +00:00
kestes%walrus.com c396b4145e fix bug in the untainting code by splitting the checks into two parts
one checks for valid characters in a filename the other checks
for both valid characters and valid directories as well.
2001-08-02 20:06:02 +00:00
kestes%walrus.com 0cfc60c491 fix bug in untainting code by splitting up the file checks into two pieces
one checks for legal characters and the other checks for legal characters AND
legal directories.
2001-08-02 20:04:25 +00:00
kestes%walrus.com fad5a324d4 version number had a space when the day of the month was less then 10,
now it has a zero.
2001-08-02 20:02:17 +00:00
endico%mozilla.org 9a48968d9f change zcat to cat. don't assume that the file is compressed 2001-08-01 04:03:18 +00:00
endico%mozilla.org b4c6f37786 weed out cruft. two years of data contained 5 million urls most of which were various bonsai and htdig queries. This is insane. Crop off everything in the url after a question mark. Crop off "index.html". Crop off trailing slashes except the root of the web site which is a lone slash. Added a shell script to preprocess the log data since that code was reused from another web analizer script. 2001-08-01 03:52:22 +00:00
jake%acutex.net 55642aed86 Fix for bug 92713, show_activity.pl displays zeros as non-breaking spaces.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-07-30 12:52:21 +00:00
ian%hixie.ch 6b213c5b12 Added support for string escaping, and shrinking (flattening) and expanding of hashes of arrays (such as the data.input.arguments hash), to COSES. These features are necessary for making the UI layer of an application. 2001-07-30 06:29:25 +00:00
ian%hixie.ch 73704b6765 * Abstracted out the string expander logic so that now strings have to say what string expanded they expect to be processed with (e.g., 'COSES', 'XSLT', 'Template' or whatever). This required one field 'type' to be added to every default string and a new field 'type' to be added to the string data source.
* Changed the COSES editor to support the abstracted logic mentioned above (note: maybe "COSES editor" is no longer an apt name...).
* Made the parseNS method of the XML service actually do something.
* Made the COSES processor namespace aware.
* Changed <coses:embed string=""> to <coses:include href="">. I was going to change it to an XInclude, but it turns out the processing model is wrong for that (XInclude, for instance, bans recursive nesting). Added support for a 'parse' attribute just like for XInclude (support three values: 'xml', 'text' and 'x-auto').
* Added columnExists() to the DBI database helper.
* Added string caching to the strings data source. Should be particularly helpful for Apache mod_perl installations.
2001-07-29 22:38:30 +00:00
kestes%walrus.com 7acbdf2b93 added explanations so that others may avoid installation problems I had. 2001-07-27 20:46:10 +00:00
kestes%walrus.com 0ea3f91c86 fixes because the default bonsai directory conventions were wrong and
I was not getting good treestates.
2001-07-27 20:44:45 +00:00
kestes%walrus.com 80385db79a show an example of how to use the new bonsai default parameter. 2001-07-27 20:42:56 +00:00
kestes%walrus.com a8b1bcf470 change the 'show next' links to 'show previous' links, too many
users ask me dumb questions about the future (really!)
2001-07-27 20:41:31 +00:00
kestes%walrus.com fc5d0aff02 a useful example to show how to write buildcf files. 2001-07-27 20:39:18 +00:00
kestes%walrus.com 0a4f3289ae errors in the system3 and the chdir are now caught and sent to the server.
give and example of the command line arguments.
2001-07-27 20:38:50 +00:00
ian%hixie.ch 9a26cf12c7 Added a hash of the user's rights to the user hash to make it easier to enable or disable UI elements 2001-07-26 03:40:56 +00:00
ian%hixie.ch 840a7e70c4 Added better handling for error conditions in the Database code, and fixed the 'addRight' method to use it.
Pasted in excerpts from the DBI man pages with sections highlighted in order to keep track of what will need fixing.
2001-07-26 00:54:37 +00:00
ian%hixie.ch ea14628a29 * Added a section on common errors to Documentation.txt
* Added more comments to a few modules
* Changed the semantics of adding and removing user fields ("user data types")
* Implemented a factory service to perform those semantics ('registerField', 'removeField' and the convenience 'registerSetting')
* Added a missing return in the MySQL implementation of the user data source
* Added an assert in the MySQL version of 'addRight' to catch an easy error
* Added XXX comment in the MySQL version of 'addRight' (will fix this in the next patch)
* Fixed a case where sending an undefined value to the DBI database implementation would fail during the untainting
* Fixed MySQLID to actually work (in the DBI ResultsFrame)
* Fixed two typos in the user service ('settings' to 'setting')
* Added the requirement that a user must have certain rights to use the COSES editor
* Added a setupInstall implementation to the COSES editor
2001-07-25 23:54:32 +00:00
justdave%syndicomm.com 0b4e32b4e4 fix for bug 91903: insecure dependency in require in importxml.pl under taint mode only in Perl 5.005.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-25 20:12:00 +00:00
justdave%syndicomm.com 73729302e9 Fix for bug 90933: inconsistant field types for profiles.disabledtext
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-25 17:55:29 +00:00
ian%hixie.ch 2d8ad22f72 Mainly changes to make it compile and easier to debug:
* Made the start of an execution start clearer in the error log. This depends on the debug level; just makes it easier to determine what is a single execution block in a 70MB error log.
* Changed a stray semicolon into a comma, and fixed other misspellings or typos.
* Added the default strings to the CosesEditor component.
2001-07-25 09:32:28 +00:00
justdave%syndicomm.com b653371b07 re-fix bug 76154: permissions weren't being set correctly on the .htaccess files when checksetup.pl was run again. Also adding .htaccess to .cvsignore so it won't show up as ? in cvs diffs and updates.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-07-25 07:26:42 +00:00
jake%acutex.net 39493163bc Remove the code for rejecting the version of MySQL with broken encryption (as bugzilla no longer uses MySQL's encrypt routine). Also, point to mysql.com for downloading newer versions.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-07-23 14:33:04 +00:00
justdave%syndicomm.com 238fc00d62 re-fix for bug 55161: buglist works again if you search for change history on a bug
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-23 02:34:08 +00:00
justdave%syndicomm.com d5d9a021f0 Fix for bug 76154: Bugzilla can now optionally provide .htaccess files for Apache to help restrict viewing of private data
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-07-22 05:23:33 +00:00
justdave%syndicomm.com 29355c8359 fix "used only once" error reported by tinderbox 2001-07-22 00:43:34 +00:00
justdave%syndicomm.com 7694170df1 Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to)
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com
2001-07-22 00:29:45 +00:00
justdave%syndicomm.com 76d4f8f765 Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to)
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com
2001-07-22 00:22:36 +00:00
kestes%walrus.com 2806b1c6ab Change work email address to new company. 2001-07-20 19:05:22 +00:00
kestes%walrus.com 53c9483d50 Fix handling of trees other then default. This is still a bit broken
for the default tree, but all others work now.
2001-07-20 18:59:35 +00:00
kestes%walrus.com e5debd345c Must pass the treename through to BonsaiData. 2001-07-20 18:56:39 +00:00
kestes%walrus.com ad65247cfe Show the users that there is a treeheader_bonsai module: 2001-07-20 18:55:44 +00:00
kestes%walrus.com 285f9a7aaf Update the specfiles to work with the RedHat conventions for RH 7.1. 2001-07-20 18:43:11 +00:00
kestes%walrus.com 387f33e515 add RedHat Package Managment (RPM) spec files. So that users of
this package managment system can easily deploy prepacked version of
bonsai.
2001-07-20 18:16:30 +00:00
kestes%walrus.com bfb5083c70 clarify details about the installation which gave me trouble.:wq 2001-07-20 18:14:53 +00:00
jake%acutex.net 9e27da07a4 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com ad9910175d Re-fix for bug 77699: the undefined error affected other browsers than just IE5, so work around it for all browsers.
Patch by Stephen Lee <slee@uk.bnsmc.com>
r= afranke@ags.uni-sb.de
2001-07-20 08:25:30 +00:00
timeless%mac.com b3128f1fb0 Bugzilla Bug 90704 there is a correct spelling for gobbeldygook and this is not it
r=terry [C=WP, A=OED]
2001-07-16 20:15:03 +00:00
jake%acutex.net 7b4eabd282 Correcting the URL for MySQL's web page. Bug 90553.
Patch by Myk Melez <myk@mozilla.org>
2001-07-16 19:50:17 +00:00
justdave%syndicomm.com 91e042867e Fixing minor problem caused by the original bug 77473 checkin where an SQL error was being produced if you tried to log in
with an invalid username.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-07-16 19:38:34 +00:00
timeless%mac.com b28e18d445 Bugzilla Bug 90598 spelling and minor syntactic correctness [doeHs]
r=mpt a=terry. [C=WP, A=OED]
2001-07-13 17:45:52 +00:00
justdave%syndicomm.com 7bbb20c84e Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net
2001-07-11 05:29:21 +00:00
justdave%syndicomm.com 69d9e7ef30 Fix for bug 87701: Invalid username in bug changes echoed back without escaping HTML data
Patch by Gervase Markham <gervase.markham@univ.ox.ac.uk>
r= justdave@syndicomm.com
2001-07-04 07:06:00 +00:00
justdave%syndicomm.com 221a000a29 Killing the "used only once" error that suddenly popped up out of nowhere on tinderbox. 2001-07-04 05:33:37 +00:00
justdave%syndicomm.com 54e70bd943 removing "Use Carp" and "sub die_with_dignity" that I was supposed to remove from the previous patch before checking it in. 2001-07-04 05:28:39 +00:00
justdave%syndicomm.com 15cf3536a8 Fix for bug 59349: Processmail now runs in taint (perl -T and $db->{Taint}=1) mode. Hooks also added to globals.pl to make converting other files in Bugzilla to run in Taint mode easier.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-04 04:41:27 +00:00
gerv%gerv.net b07434e0b5 Add strikethrough to resolved bug numbers. Bug 79816. r=jake. 2001-07-01 20:17:28 +00:00
gerv%gerv.net a0cc8282f1 Make bug chart filenames other-OS friendly by removing colons. Bug 88179. r=jake. 2001-07-01 19:09:29 +00:00
justdave%syndicomm.com 5959477189 Fix for bug 87596: improper definition of $::components in globals.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-07-01 02:00:56 +00:00
justdave%syndicomm.com bf9843744b Fix for bug 76183 and bug 71555: consolidates chmod activity in one place in checksetup.pl and also provides permission setting for bugzilla installations installed in a personal user directory as opposed to the server's main web space. (makes the files world-readable so the webserver can see them, since you can't set the group)
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com
2001-06-29 03:47:56 +00:00
justdave%syndicomm.com f321dcd882 Fix for but 76073: - and + didn't work in quicksearch in IE and Opera
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-28 16:27:37 +00:00
jake%acutex.net e95335dcaf Refix bug 80289. Don't print header for groups if there aren't any groups to display (was printing a header without groups in rare instances).
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-06-28 15:42:30 +00:00
justdave%syndicomm.com b89f413d7c Fix for bug 87983: backdoor.cgi is Netscape-specific, and not part of the bugzilla package. Removing from CVS. 2001-06-28 06:49:06 +00:00
justdave%syndicomm.com bd2fb60405 Fixing "used only once" errors flagged by tinderbox on the last checkin. 2001-06-27 02:31:55 +00:00
justdave%syndicomm.com 790d95d351 Fix for bug 80289: Group restrictions are now identified with checkboxes instead of select widgets. Also, product groups are now only offered if they are either already set, or match the current product (i.e. the option to set a product bit for a product other than the one the bug is in is no longer available) This results in much less clutter for the admin folks on sites with lots of products.
Patch by Joe Robbins <jmrobins@tgix.com>
r= justdave@syndicomm.com
2001-06-27 01:44:34 +00:00
ian%hixie.ch 276a4fa320 * Implemented dispatcher.output service in CosesEditor.pm
* Implemented dispatcher.output.generic service in CosesEditor.pm
* Fixed a semantic error in the string data source
2001-06-23 04:07:21 +00:00
ian%hixie.ch b3fa6accc6 (this checkin comment applies to the previous checkin on this file as well)
* Added some comments to various files indicating work to do and documenting some methods
* Fleshed out the Strings Data Source API (and implemented it in the MySQL version)
* Added the name "MySQL" to the MySQL-specific ID method of the Database Helper
* Factored out the XML parser dependency into an XML service
* Added a generic content sink implementation to the XML service
* Added a convenience method for manipulating user settings
* Added and implemented all the COSES commands
* Removed trailing spaces
2001-06-23 00:20:22 +00:00
ian%hixie.ch d21968d31c * Added some comments to various files indicating work to do and documenting some methods
*
2001-06-23 00:10:43 +00:00
justdave%syndicomm.com 612f397227 Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checksetup.pl, so the change to them during doeditparams was nullified if you updated. Other recent changes have nullified the reason for changing it in editparams anyway, so just backing that part out.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-21 15:03:11 +00:00
justdave%syndicomm.com d0985be7f8 Fix for "used only once" error reported by tinderbox after the last checkin. (Aaargh!) 2001-06-21 02:42:41 +00:00
justdave%syndicomm.com 208706e674 Fix for bug 47914: buglist.cgi always had a not-logged-in footer if you were unlucky enough to have a login cookie that got corrupted in the shadow database. This patch makes buglist.cgi switch back to the primary database before looking up your login cookie for the footer.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-21 02:02:30 +00:00
jake%acutex.net 336f1bf129 Fix for bug 86447 - ChangeFieldType() wasn't dealing with 'not null' properly.
r= justdave@syndicomm.com
2001-06-20 01:37:19 +00:00
justdave%syndicomm.com 1e6085864c Fix for bug 85833: show_bug.cgi (and probably others) now allow leading or trailing spaces in the bug id, to allow for user input error. This used to work, and recent bug validation changes broke it.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-19 22:48:21 +00:00
justdave%syndicomm.com e9d91b0a04 Fix for bug 45918: the old password field on the userprefs page is now used to log you back in if you try to change your password with cookies turned off, which avoids the confusing login screen after entering your new password in which you used to have to enter your old password one more time in order to let it set your new password (yes, it used to be as confusing as that just sounded :)
r= tara@tequilarista.org
2001-06-19 22:02:53 +00:00
dmose%mozilla.org 4b69b94fcd Changing despot owner to endico@mozilla.org with her permission 2001-06-19 04:04:34 +00:00
jake%acutex.net 1a56480df1 Running a query using the Added Comment option was very slow (bug 57350).
Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-19 02:05:08 +00:00
jake%acutex.net 06a95c3b47 Refixing bug 71396. Each PushGlobalSQLState() needs a PopGlobalSQLState() and this file instead had two "pushes". 2001-06-19 01:37:02 +00:00
jake%acutex.net b56688d21e Allow '\' as a path delimiter (bug 29064)
Patch Concept by <timeless@mac.com>
r= jake@acutex.net
2001-06-18 23:13:18 +00:00
jake%acutex.net 46dd08d79f Fix for bug 85832 - QuickSearch should strip leading and trailing spaces.
Patch by Andreas Franke <afranke@ags.uni-sb.de>
2001-06-18 19:24:17 +00:00
tara%tequilarista.org 7d0248c021 applying handy patch to refix version table to be 64 instead of 16--partial fix of bug 9352 2001-06-16 23:01:12 +00:00
jake%acutex.net 583e8ba725 Fix for bug 71396 - $::db->do isn't needed anymore
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net
2001-06-16 14:51:16 +00:00
jake%acutex.net 4c159e297e Fix for bug 83619 - QuickSearch was crashing Netscape 4.76 and 4.77 on Unix
Patch by Andreas Franke <afranke@ags.uni-sb.de>
2001-06-15 20:16:59 +00:00
jake%acutex.net aced5efdec Checking in the cleaner version of the fix for "No Available Products". This was attached to bug 65311.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-14 20:02:31 +00:00
jake%acutex.net 11d8239204 Backing out previous changes as there was a better patch already attached to a different bug 2001-06-14 20:00:03 +00:00
jake%acutex.net c52c3207f3 Bugzilla shouldn't display empty header in the New: email notifications (bug 85734)
r=timeless
2001-06-14 14:16:27 +00:00
justdave%syndicomm.com d12c665fae Fix for bug 84596: Syncshadowdb wasn't using the db_user and db_pass from localconfig, which meant that it previously wouldn't run unless it was running under a user that had access to the bugs and shadowbugs dbs and didn't have a password. It now looks for db_user and db_pass and specifies them on the command line to mysqldump and mysql if they're in use.
r= tara
2001-06-10 17:38:15 +00:00
justdave%syndicomm.com 0caf63ff4b Re-fix for bug 21253: fix calling conventions for syncshadowdb so that a phony parameter to get past the multi-param system() test in tinderbox actually works.
r= tara
2001-06-10 17:15:56 +00:00
jake%acutex.net f3b1e25aea Give a logical error message if no products are available to a user for bug entry (bug 84285).
Patch by Paul Thomas <paul.thomas@sse.ie>
r= jake@acutex.net
2001-06-08 13:12:13 +00:00
justdave%syndicomm.com 89f9bad83e Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache.
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-07 21:26:49 +00:00
justdave%syndicomm.com e5c14c816c Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com 88476cc75c fix typo 2001-06-07 01:31:51 +00:00
justdave%syndicomm.com 8da17e3922 Fix "used only once" error, per tinderbox build log. 2001-06-06 23:09:54 +00:00
justdave%syndicomm.com 6a4944b94c Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-06 21:17:42 +00:00
justdave%syndicomm.com fa59d128b6 Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net, tara@tequilarista.org
2001-06-06 21:10:47 +00:00
jake%acutex.net 48ffd8c640 Users should only be able to view attachments if they can view the bug that the file is attached to (bug 70189)
r=tara
2001-06-06 18:36:25 +00:00
jake%acutex.net 79fc592bf7 Fixing typo. Attachments isn't spelled 'Attachemnts' (bug 84295). 2001-06-06 14:25:18 +00:00
justdave%syndicomm.com 7337f9ee7a Fix for bug 39557: doeditvotes.cgi will no longer create a vote record for a nonexistant bug if the HTML is tampered with or other bugs cause bad bug numbers in the submitted form.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 04:51:55 +00:00
justdave%syndicomm.com 16951bbe32 Fix for bug 82781: describecomponents.cgi now checks viewing permissions to make sure you can see a product
Patch by Myk Melez <myk@mozilla.org>
r= tara@tequilarista.org
2001-06-06 04:32:45 +00:00
justdave%syndicomm.com 1e4536e632 Fix for bug 28458: "NEW" bugs were not getting CC or QA Contact information displayed.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-06 04:28:52 +00:00
justdave%syndicomm.com 72e876fa2d Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 03:16:52 +00:00
ian%hixie.ch b0ae801a6f * Improved the helpfulness of the extremely verbose debugging information of PLIF.pm by quoting embedded variables
* Implemented MagicCollectingArray, which acts like MagicPipingArray except that the result is collected into one big array instead of multiple arrayrefs
* Added the relevant getCollecting*List methods to the Controller class
* Added DESTROY methods to the magic array to prevent DESTROY method calls from being propagated
* Made the debug.dumpVars string more robust when the data hash includes one of the three magic characters '(', '.' or ')'
* Implemented sanitation in COSES so that any keys in the data hash containing one of the three magic characters '(', '.' or ')' will have them transliterated to '[', ':' and ']' respectively (sanitation is optional and can be bypassed)
* Changed the API of the generic output module's 'output' method to take the optional $session argument last, thus simplifying the call sites a lot
* Implemented the 'dispatcher.output' service in several classes to return strings that must be support in variants (required for a good UI in the COSES editor)
* Renamed the Login module's strings so that they use the dot-notation separating significant parts
2001-06-04 06:13:22 +00:00
ian%hixie.ch 008ca7535f Stub implementation of a COSES editor component, plus added 'component.nameOfComponent' to the list of services provided by the other two components 2001-06-03 23:06:09 +00:00
ian%hixie.ch 4e83d4d77b Moved AdminCommands.pm and Login.pm to a Component directory 2001-06-03 22:45:37 +00:00
ian%hixie.ch eb1fb18fb5 Minor bug fixes required to make the code run without crashing... 2001-06-03 16:14:41 +00:00
ian%hixie.ch 17da5d7b8a Some more minor corrections to get it to run as well as compile... (removes some XXX comments and adds some error checking) 2001-06-03 15:27:16 +00:00
ian%hixie.ch f71bddbcc2 Fixing a gazillion syntax, logic and XML errors and adding some debug code. It compiles! 2001-06-03 14:49:41 +00:00
ian%hixie.ch 0157ac85b3 * Added some comments (including some XXX comments where I realised we had missing code)
* Added implicit data to the hash passed to the string expander from the generic output service
* To support the implicit data, added a |hash| stub method to the Session.pm module (and changed the already implemented version in the descendant user service to take this into account)
* To support the implicit data, added |hash| and |getArguments| methods to the Input.pm module (and implemented |getArguments| in the Arguments.pm module)
* To support the implicit data, made the Program.pm module keep track of the executing command
* To support the implicit data, added |hash| and |name| methods to the Program.pm module (actually, |name| was already assumed to exist in other parts of the codebase)
* Corrected trivial semantic mistake in Program.pm's |verifyInput| method
* Added a way to get a user not by username but by a specific address (modifies the user service and the user data source and it's MySQL implementation)
* Implemented GenericOutputs.pm, an implementation of 'dispatcher.output.generic' and 'dataSource.strings.default' for some strings used by other parts of PLIF (currently only supports 'stdout' and 'http' protocols, and minimally at that)
* Implemented Login.pm, a helper module that implements user authentication, user creation and the sending of a new password if it is forgotten, a utility method |hasRight| to ensure that the authenticated user has a particular right (resulting in a message if not), and various routines to support all this.
2001-06-03 10:11:58 +00:00
tara%tequilarista.org 71c26619d6 Landing Myk's patch for bug #71767 2001-06-02 22:02:02 +00:00
jake%acutex.net 7e84b3b87a sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556).
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-02 14:24:45 +00:00
justdave%syndicomm.com bf46713283 Fix for bug 65190: add comparison type "all words as substrings" and "any words as substrings" to the text fields in query.cgi
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-02 04:02:13 +00:00
justdave%syndicomm.com 6887947dcb Fix for bug 78407: extra safeguard against overpopping the email list when pruning people who aren't supposed to get mail.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-02 03:19:26 +00:00
justdave%syndicomm.com c6f5cbc4aa Fix for bug 83596: optional dependency on XML::Parser now checked in checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:57:22 +00:00
justdave%syndicomm.com 16c44fa582 Fix for bug 83618: checksetup.pl crashes if DBI module isn't already installed.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:53:01 +00:00
jake%acutex.net 40da63cff5 More leak pluggin. This one fixes bug 39526.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-01 13:38:01 +00:00
justdave%syndicomm.com 6e938b4597 Fix for bug 83633: perl warnings in 5.6
r= Hixie
2001-06-01 10:03:52 +00:00
justdave%syndicomm.com 53e52cbe8b Fix for bug 73249: perl warnings under 5.6.0.
Patch by Chris Yeh <Chris.Yeh@nokia.com>
r= justdave@syndicomm.com
2001-06-01 08:34:45 +00:00
justdave%syndicomm.com 1b32170af6 Fix for bug 79317: dependency on CGI::Carp not caught by checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-01 03:13:28 +00:00
justdave%syndicomm.com db91c9e3ba backing out previous fix to importxml.pl. It fixed it on Perl 5.6 and broke it on Perl 5.005. Will need to investigate. 2001-06-01 02:27:52 +00:00
justdave%syndicomm.com 63ca1160dd Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl 2001-06-01 02:14:23 +00:00
justdave%syndicomm.com f1b8abb8a9 Fix for bug 57848, perl warnings in several files.
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= justdave@syndicomm.com
2001-06-01 02:07:28 +00:00
ian%hixie.ch 8d91c20844 * fixing some syntactic errors
* added addUserGroup and removeUserGroup to the data source interface for users
* added some comments
* changed many double quotes |"| to single quotes |'| where double quotes were not needed
* implemented the remaining methods for the MySQL implementation of the user data source
* added a mode flag to user fields (idea from MattyT) so that fields can be disabled, hidden, etc
2001-06-01 00:32:35 +00:00
jake%acutex.net e5f7a1dd6e Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
2001-05-31 15:52:25 +00:00
jake%acutex.net 277b5d0fd0 Bug 80388 - cvsblame shouldn't require layers for popups
r=baloo
2001-05-30 22:13:03 +00:00
jake%acutex.net 477a26a860 Fix for bug 45164 - New users created by the admin were not subject to the userregexp for groupsets.
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-05-30 15:47:30 +00:00
justdave%syndicomm.com e5bf5d6659 Dummy commit so I can put the attributions I forgot in the previous one.
Patch from bug 65290 was by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-29 21:27:12 +00:00
justdave%syndicomm.com d7cf4940e2 Fix for bug 65290: can now edit user-regexps for system groups 2001-05-29 21:25:02 +00:00