Note that the fullscreen shortcut could be used in the starting page.
However, that would hide the navigation bar and no room could then be
joined, so it would not make much sense. Therefore, the shortcuts are
totally disabled in the starting page instead of fixing calling
"get('participantFlags')" on a null room.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When a participant is not in the call a Peer object should not be
created for her; besides being incorrect, that would also create a
VideoView for that participant, which will basically stay there as a
ghost without never connecting to her. Due to this when a participant
leaves the call the delayed peer creation for that participant, if any,
has to be cancelled; otherwise once the timeout expires the peer would
be created with the issue just described.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the current participant lefts a call WebRTC is not properly
tore down; signaling events are still handled, so if an offer message is
received after leaving a call (which in general should not happen, but
in some strange cases it could) a new Peer object was created. Although
the proper fix would be to disconnect WebRTC and the signaling events
after leaving a call that would require deeper changes, so for now
offers received when not in a call are ignored.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
"OC.Notification.showTemporary" expects a string as its first parameter
(even if it contains HTML markup), but a jQuery object was passed
instead; until now this just happened to work due to the internal
implementation of that method, but this no longer works since the switch
to Toastify in Nextcloud 17.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The author row was covering the date on the right side of the chat view
and preventing the date tooltip to be triggered by hovering on the date.
This fix makes the author row slightly narrower (which was the same
approach already used when the date is shown next to a message) in
order to expose the date, thus allowing the date tooltip to be shown
properly.
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
The ".systemMessage" class is set on ".comment" elements, but not on
".comments" elements, so ".comments:not(.systemMessage)" is always the
same as ".comments".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The /compile bot first installs the NPM packages with "npm init" and
then performs the build with "npm run build", which executes the command
defined in "scripts->build" in "package.json".
Currently "npm init" does not install all the NPM packages needed by
Talk; it is necessary to run it both in the root folder and in the
"/vue" folder. Due to this "make npm-init" needs to be run from the
build script to install all the needed packages before performing the
actual build.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Since 7.2.5 the "main" property in the "package.json" of WebRTC adapter
points to an ES6 file which does not provide "module.exports" but
"exports.default". Due to this uses of "var adapter =
require('webrtc-adapter');" now fail, as the properties of the module
are loaded in "adapter.default" instead of in "adapter". To restore the
previous and expected behaviour a Babel plugin is now used to also add
"module.exports" if "exports.default" exists.
As WebRTC adapter still provides an ES5 file an alternative solution
would have been to alias "webrtc-adapter" to that file with
'--transform [ aliasify --global --aliases [ --webrtc-adapter
"webrtc-adapter/dist/adapter_core5.js" ] ]'.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Ivan Sein
Joas Schilling
Joas Schilling
Roeland Jago Douma
Nextcloud bot
Artur Weigandt
Daniel Calviño Sánchez
dependabot-preview[bot]
Marco Ambrosini