2 Website PR validation

Tyler Butler редактировал(а) эту страницу 2021-09-10 10:16:51 -07:00

Содержание

• GitHub Action workflow design
• Extending the validation

The repo includes a GitHub action that will review PRs that change the /docs folder. This action does the following validation of the changes in the PR:

1. Builds the site using the PR changes and the latest API reference docs.

   Source: /.github/workflows/website-validation.yml#L14-L34

2. Checks the built site for broken internal links. Internal means links within the site itself. Links to other sites are not checked.

   Source: .github/workflows/website-validation.yml#L36-L61

GitHub Action workflow design

For security reasons, the website validation uses the pull_request trigger and runs with a read-only access token. It builds the untrusted code in the PR and loads it in a local web server for link checking. The results of the site build and link check are output as build artifacts.

When it completes, the website validation workflow triggers a separate workflow to handle "reporting" the link check results to the PR. More precisely, the completion causes a workflow_run event to be raised, the which is the trigger the reporter workflow is configured to trigger on.

Source: .github/workflows/linkcheck-reporter.yml

The reporter workflow runs with a write-access token, so it can post comments to the PR. It takes the report output from the website validation workflow and posts a success/failure comment to the PR. The only input it uses is the report output from the earlier workflow.

Drawback: Because the reporter is not triggered by the PR directly, it doesn't show up in the "checks" UI in GitHub. You have to navigate directly to the Actions section to view it manually.

Extending the validation

Not yet documented. Contact @tylerbutler in the meantime.

Overview

• Wiki Home
• Usage Documentation (fluidframework.com)
• FAQ (fluidframework.com)

Contributing

• Submitting Bugs and Feature Requests
• Contributing to the Repo
  • Repo Basics
  • Common Workflows and Patterns
  • Managing dependencies
  • Client Code
  • Server Code
  • PR Guidelines
  • CI Pipelines
  • Breaking vs Non-Breaking Changes
    • API Type Validation
    • Communicating Breaking Changes
    • Changesets
  • Branches, Versions, and Releases
  • Compatibility & Versioning
  • Testing
    • Bundle Size Tests
  • Debugging
  • npm package scopes
  • Maintaining API support levels
  • Developer Tooling Maintenance
  • API Deprecation
  • Working with the Website (fluidframework.com)
    • Building Documentation Locally
• Coding Guidelines
• Documentation Guidelines
  • Where To Put Documentation
  • Documentation Dos and Don'ts
  • Fluid Terminology
  • Documenting TypeScript
    • TSDoc Guidelines
    • Release Tags
  • Documenting JavaScript
  • Markdown Best Practices
• CLA

Using Fluid Framework

This wiki is focused on contributing to the Fluid Framework codebase.

For information on using Fluid Framework or building applications on it, please refer to fluidframework.com.