Shadow stacks use -finstrument-functions to hook all function entry/exit.
But mmx-related functions expect to be inlined so the compiler can
compile them out into mmx instructions.
This change excludes the mmx intrinsics header file from instrumentation.
Without it, builds wil fail with errors like the following:
../../third_party/gold/gold64: obj/media/libyuv_convert.a(obj/media/base/yuv_convert.yuv_convert.o): in function media::EmptyRegisterState():yuv_convert.cc(.text._ZN5media18EmptyRegisterStateEv+0x29): error: undefined reference to '_mm_empty()'
(_mm_empty() is an mmx intrinsic function.)
Review URL: http://codereview.chromium.org/9416068
git-svn-id: http://src.chromium.org/svn/trunk/src/build@123289 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
On a Google-internal ChromeOS builder make seems to exit with a
failure code no error message I can identify.
git-svn-id: http://src.chromium.org/svn/trunk/src/build@121264 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
[This CL was backed out speculatively due to failures on the cros trunk bot. But this CL
was not the cause of that problem, so I'm un-doing the revert.]
Currently, gyp attempts to autodetect whether the linker supports
the --icf flag. It's more predictable to just require the caller
to specify whether they're using gold.
As a first demonstration of this, drop LINKER_USES_ICF code in the
Chrome build. (I'll follow up with a gyp patch to remove the
LINKER_USES_ICF stuff in gyp.)
Review URL: https://chromiumcodereview.appspot.com/9368015TBR=evan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9372012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@121175 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently, gyp attempts to autodetect whether the linker supports
the --icf flag. It's more predictable to just require the caller
to specify whether they're using gold.
As a first demonstration of this, drop LINKER_USES_ICF code in the
Chrome build. (I'll follow up with a gyp patch to remove the
LINKER_USES_ICF stuff in gyp.)
Review URL: http://codereview.chromium.org/9316110
git-svn-id: http://src.chromium.org/svn/trunk/src/build@121068 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
(Reland of r120385 with newer third_party/gold.)
Rather than forcing everyone to configure their search paths etc.
we should just make this work by default. You can set
the gyp variable linux_use_gold_binary=0 to turn it off.
Review URL: https://chromiumcodereview.appspot.com/9316002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@120424 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
WebUI Task Manager does not ship on M18 on Desktop Chromes (Win/Mac/Linux) so that task manager have been disabled temporary. On Chrome OS and Aura, it is still enabled.
BUG=97429
TEST=manual on linux and aura
Review URL: http://codereview.chromium.org/9290042
git-svn-id: http://src.chromium.org/svn/trunk/src/build@119612 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This allows text drawing entirely through Skia, since RenderText ultimately uses
Skia to draw character glyphs.
This CL adds the new code, but does not yet enable it on any platforms. That
will be done in later CLs.
Note: Some functions, such as CanvasSkia::DrawStringWithHalo() and
PixelShouldGetHalo() are taken almost verbatim from the canvas_skia_win.cc
implementation.
BUG=105550
TEST=none
Review URL: http://codereview.chromium.org/9074005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@119086 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Rather than globally defining NO_HEAPCHECKER and then checking
that in build_config.h, let builds that opt in to heap checking
directly set USE_HEAPCHECKER.
Result should be equivalent builds but less stuff in the build
files.
Review URL: http://codereview.chromium.org/9146022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@118823 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This replaces the aura_show_about_flag_window_mode and
chromeos_legacy_power_button GYP flags with
--aura-force-compact-window-mode and
--aura-legacy-power-button command-line switches. There is
concern that using compile-time flags to control these
features will greatly increase the workload on the Chrome OS
builders; we apparently currently share Chrome binaries
across all Chrome OS boards with the same architecture.
BUG=109209,109052,chrome-os-partner:7570
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9264025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@118522 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change toggles the build_webkit_exes_from_webkit_gyp file to 0,
so that we try to build DumpRenderTree and webkit_unit_tests from their
corresponding .gyp files (WebKitUnitTests.gyp and Tools.gyp) rather than
the old WebKit.gyp file. This breaks the circular dependencies between
the executables which depend on webkit_support, which depends on
WebKit.gyp. We now only use the 'webkit' target itself in WebKit.gyp.
R=tony@chromium.org
BUG=105826
TEST=waterfall stays green
Review URL: https://chromiumcodereview.appspot.com/8889039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@118366 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
According to my testing, VS 2010 does not have problem (b) documented
at http://code.google.com/p/chromium/wiki/WindowsPrecompiledHeaders,
i.e. it rebuilds the PCH file when necessary because of
e.g. preprocessor flag changes.
Since we aren't using VS 2010 for official builds, if problem (a) (out
of memory) is encountered with VS 2010 when we make the switch to
using it for official builds, we can simply turn PCH off explicitly in
the include.gypi for the official bots.
This change has no effect on VS 2008 bots or users.
BUG=110001
Review URL: http://codereview.chromium.org/9139059
git-svn-id: http://src.chromium.org/svn/trunk/src/build@117845 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1) Actually turn off ASLR for Debug build.
Despite the comments, this was not happening in reality
because the /dynamicbase linker flag overrode the
VCLinkerTool.RandomizedBaseAddress setting.
2) Make the ASLR setting configurable from outside
(target usage is for particular Dr. Memory builds).
TEST=Built googleurl_unittests and ensured its ALSR setting matched that requested, both for default and for custom via new gyp var
BUG=109767
Review URL: http://codereview.chromium.org/9169020TBR=bruening@chromium.org
Review URL: http://codereview.chromium.org/9194003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@117586 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1) Actually turn off ASLR for Debug build.
Despite the comments, this was not happening in reality
because the /dynamicbase linker flag overrode the
VCLinkerTool.RandomizedBaseAddress setting.
2) Make the ASLR setting configurable from outside
(target usage is for particular Dr. Memory builds).
TEST=Built googleurl_unittests and ensured its ALSR setting matched that requested, both for default and for custom via new gyp var
BUG=109767
Review URL: http://codereview.chromium.org/9169020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@117533 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Most official Chrome OS hardware reports power button
releases correctly, but on standard x86 systems, we'll always
receive a button up event just after the button down. This
change adds a chromeos_legacy_power_button gyp flag; when
set, we lock the screen or shut down immediately when the
button is pressed instead of providing interactive
animations.
BUG=109209
TEST=added tests; also did manual testing
Review URL: http://codereview.chromium.org/9110044
git-svn-id: http://src.chromium.org/svn/trunk/src/build@116993 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This fixes a regression that caused fullscreen
RenderWidgetHostViewAuras to decline the focus, resulting in
them not receiving key events.
BUG=107804
TEST=manually checked that Space and Escape now work in fullscreen YouTube videos; also added a test
Review URL: http://codereview.chromium.org/9026013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@115855 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We've been getting a bunch of extra gpu-related crashes recently, and while they don't seem to be related to swiftshader (the timing is a bit off) it's possible, so try to rule that out.
BUG=26001
TEST=
Review URL: http://codereview.chromium.org/9021039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@115534 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- "size"; optimizes for minimal code size, the default.
- "speed"; optimizes for speed over code size.
- "max"; turns on link time code generation and whole
program optimization, which is very expensive and should
be used sparingly.
Note that this change by itself lowers the optimization level to "size" for all targets. Separate changes to the V8 and WebKit repos will be needed to bring up their optimization levels to WPO.
BUG=108167
TEST=
Review URL: http://codereview.chromium.org/8983002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@115187 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Register with the component updater service if it's discovered that WebGL is blacklisted. Then register the swiftshader library with the GPU data manager.
BUG=26001
TEST=Start up chrome on a blacklisted windows machine, wait a while, and open a webgl page
Review URL: http://codereview.chromium.org/8897008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@114885 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is intended to make it easier to test Breakpad crash dumping on
the buildbots. Crash dumping will be disabled in Chromium by default
at run time unless CHROME_HEADLESS is set.
The bots set CHROME_HEADLESS, but we don't really want the bots to be
uploading crash dumps that are useless without symbols, so uploading
is disabled except for official builds and when building with
mac_breakpad_uploads=1.
This should not affect stack backtraces that occur in tests (such as
browser_tests) via StackDumpSignalHandler(). Although Breakpad would
normally take priority over this signal handler, Breakpad does not get
enabled in these test suites because is_browser is false inside
InitCrashReporter().
This change leaves the Gyp option "mac_breakpad" for enabling the
creation of Breakpad files. This remains off by default for Chromium
builds, because the symbol dumping is slow and because it has problems
in the makefile-based Mac builds.
BUG=105778
TEST=run Chromium with --crash-test and CHROME_HEADLESS=1; a *.dmp file
should appear in ~/Library/Application Support/Chromium/Crash Reports
Review URL: http://codereview.chromium.org/8824003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@114468 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The chromeos-chrome ebuild strips Chrome tests after the build, but it
can run significantly faster if we strip them during the build. This
changelist reduces the time it takes to build Chrome by allowing
developers to remove unnecessary debug symbols.
Performance comparison on z600 LOCAL_SOURCE build:
Before: 24m31s (257m04s user, 23m19s sys)
After: 20m55s (236m12s user, 22m10s sys)
Companion CL for updating Chrome OS to use strip_tests by default is here:
https://gerrit.chromium.org/gerrit/11517
BUG=chromium-os:22844
TEST=Build with and without debug symbols. Confirm speed difference.
Review URL: http://codereview.chromium.org/8526022TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/8659015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@111778 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
-- pass the -faddress-sanitizer flag to enable ASan;
-- pass the -fasan flag for backward compatibility;
-- pass the -DADDRESS_SANITIZER which soon won't be defined by ASan;
-- mark several functions missing in the 10.5 SDK as dynamic_lookup
Whitespace fix.
TBR=thakis
Review URL: http://codereview.chromium.org/8676002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@111575 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The chromeos-chrome ebuild strips Chrome tests after the build, but it
can run significantly faster if we strip them during the build. This
changelist reduces the time it takes to build Chrome by allowing
developers to remove unnecessary debug symbols.
Performance comparison on z600 LOCAL_SOURCE build:
Before: 24m31s (257m04s user, 23m19s sys)
After: 20m55s (236m12s user, 22m10s sys)
Companion CL for updating Chrome OS to use strip_tests by default is here:
https://gerrit.chromium.org/gerrit/11517
BUG=chromium-os:22844
TEST=Build with and without debug symbols. Confirm speed difference.
Review URL: http://codereview.chromium.org/8526022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@110948 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This version fixes a problem with the windows incremental linking build. We can't incrementally link chrome when content is being built as a DLL because chrome links in webkit_glue and webkit_glue depends on symbols defined in content. We can remove this when we fix glue.
R=jam@chromium.org
BUG=90442, 98755.
Review URL: http://codereview.chromium.org/8570024
git-svn-id: http://src.chromium.org/svn/trunk/src/build@110360 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The os_bsd variable is only available on FreeBSD and OpenBSD.
Later on others like NetBSD and DragonflyBSD can be added.
This variable was introduced in order to have shorter
conditions in the gyp files.
BUG=
TEST=compile
Patch by Robert Nagy <robert.nagy@gmail.com>
Review URL: http://codereview.chromium.org/8567001
git-svn-id: http://src.chromium.org/svn/trunk/src/build@109929 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
For other configurations it can also be set by a command line option at run-time (also as before).
What changes is that we are removing use_only_pure_views as a separate GYP flag which we no longer really need.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8528014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@109571 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change makes it use webkit_glue::ImageDecoder instead
of gdk-pixbuf and hides various GTK+ theme-related code
behind TOOLKIT_USES_GTK ifdefs. Chrome OS is currently
loading its own icons from resources (see r86936 and
http://crosbug.com/129) instead of using IconLoader and
IconManager, so this only removes NOTIMPLEMENTED()s on
non-Chrome-OS Linux Aura builds (along with simplifying the
GTK+ version of the code).
BUG=99494
TEST=manual: download icons are still visible on a gtk+ build
Review URL: http://codereview.chromium.org/8501030
git-svn-id: http://src.chromium.org/svn/trunk/src/build@109527 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
base/base.gyp:
- exclude test/test_file_util_linux.cc on OpenBSD because of
missing fdatasync()
base/base.gypi:
- include linux_util.cc on OpenBSD too
- exclude some linux specific files from the OpenBSD build
because the openbsd implementation is different
base/file_util_posix.cc:
- Use file_util::GetTempDir directly to get the shm dir
on !linux
base/sys_info_freebsd.cc:
- return 0 and do a NOTREACHED() in case sysctlbyname() fails
base/sys_info_openbsd.cc:
- cleanup includes
- use arraysize() in the sysctl() call
- implement SysInfo::MaxSharedMemorySize()
build/common.gypi:
- -Wno-deprecated is C++ only flag so move it to cflags_cc
- Do not exclude linux specific files, dirs on OpenBSD since
90% of it is sharable
base/sys_info_linux.cc:
- DCHECK if the read string is empty
- Use base::StringToInt64() to convert the string
to an int64
- DCHECK if the returned int64 is okay for a size_t
- call NOTREACHED() and return 0 if fails
BUG=
TEST=runs on linux?
Review URL: http://codereview.chromium.org/8382001
git-svn-id: http://src.chromium.org/svn/trunk/src/build@106984 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Also, remove the Optimization hard-coded flags that turned out not to be adjustable as well.
TEST=vimdiff against ipc\ipc.vcproj of three different versions:
1) old
2) new (matches "old" except for the addition of OmitFramePointers="true" for Release x64)
3) new with `GYP_DEFINES=win_release_OmitFramePointers=0 win_release_Optimization=2`
BUG=99446,96326
Review URL: http://codereview.chromium.org/8227011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@104904 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
On setting disable_pie=1 would only build Chrome with the PIE flag disabled. This helped debugging Chrome but browser_tests, ui_tests and other tests + executables were still built with PIE making remote debugging them not possible.
Now when disable_pie=1 is specified, all executables will be built non-PIE.
R=zelidrag@chromium.org,thakis@chromium.org
BUG=None.
TEST=Tested with a complete build. Only and all executables are being linked with '-nopie' with disable_pie=1 specified.
Review URL: http://codereview.chromium.org/8207010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@104609 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add a gyp variable use_virtual_keyboard
Add a cpp define USE_VIRTUAL_KEYBOARD
Add a grit define use_virtual_keyboard
BUG=chromium-os:10620
TEST=chrome and browser_tests compile successfully with GYP_DEFINES="touchui=1" and GYP_DEFINES="use_virtual_keyboard=1 use_only_pure_views=1". they run with a virtual keyboard with command-line option --views-desktop
Review URL: http://codereview.chromium.org/8051010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@103926 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Not all multilibs install into /usr/lib/, so when building for one which
doesn't, we hit errors where the detected python arch does not match the
detected target arch. Like x86_64/powerpc64/sparc64/etc... which use
/usr/lib64/.
Review URL: http://codereview.chromium.org/8018002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@103422 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
the build/installer output.
This change undoes the revert of 99878. This change was originally reverted
because it was decided to push this change to M16.
BUG=94920
TEST=Do an Official build in mac, linux and win. Ensure that after installing
the app, you can find the default apps under the install's directory
structure. For win, this is under a default_apps directory, for mac, this is
under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/8041033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@103078 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
I would have preferred if precompiled headers could be enabled by
default. The motivation for this change is primarily that Visual
Studio does the wrong thing on preprocessor flag changes - instead of
rebuilding precompiled headers, it errors out on any file that uses
them, saying that the precompiled header was built with different
flags! This causes a world of hurt on our infrastructure stuff,
particularly on trybots as they may be jumping back and forth between
revisions before and after a flag change.
Prior to this change, only Debug builds used precompiled headers and
Release builds did not. The reason Release builds did not was that
official builds were running out of memory with precompiled headers
enabled. The distinction of Debug vs. Release is no longer necessary
after the flag is added, so removing that extra bit of complexity from
the .gyp files.
BUG=none
TEST=it builds
Review URL: http://codereview.chromium.org/8041022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102839 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Use XI2 multitouch events instead of mouse events as touch event input for touchui build.
Note: XI MT will be supported in X server 1.12 and XI2.2. Please use build switch "use_xi2_mt=<minor version number>" to specify the minimum XI2 minor version. It is useful to test on experimental XI2.1 with MT support (e.g. build with use_xi2_mt=1).
BUG=95150
TEST=(1) build with touchui=1 use_xi2_mt=1 (2) test on ubuntu 11.04 (X server 1.10 and XI2.1 with experimental MT support). (3) manually test if touch works on browser UI and JS touch events.
Review URL: http://codereview.chromium.org/7792094
Patch from Ningxin Hu <ningxin.hu@intel.com>.
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102668 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This allows develoeprs to build from any sln file and not have to rebuild the
world. This is more like how XCode projects are generated.
We choose src/build/{Debug,Release} because this is where all.sln generates
files and this is what the bots use. This shouldn't require any changes to
the bots.
BUG=95278
Review URL: http://codereview.chromium.org/7835006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102514 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Removes the dependency on chromeos-specific code in the extension-based file picker. Compiles and links, but does not yet run - the extension subsystem is not finding the resources for the file_manager component extension. The Aura build currently won't process keyboard or mouse events, so I don't have a good way to debug this. For now, added logging, and we'll get back to it when Aura is in better shape.
BUG=chromium-os:20583
TEST=On plain ChromeOS, can still open a file with control-O file picker.
Review URL: http://codereview.chromium.org/7941014TBR=jamescook@chromium.org
Review URL: http://codereview.chromium.org/7976025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102116 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Removes the dependency on chromeos-specific code in the extension-based file picker. Compiles and links, but does not yet run - the extension subsystem is not finding the resources for the file_manager component extension. The Aura build currently won't process keyboard or mouse events, so I don't have a good way to debug this. For now, added logging, and we'll get back to it when Aura is in better shape.
BUG=chromium-os:20583
TEST=On plain ChromeOS, can still open a file with control-O file picker.
Review URL: http://codereview.chromium.org/7941014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102113 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG=96935
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Review URL: http://codereview.chromium.org/7957002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102071 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7904034
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102005 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG=96935
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101581
Review URL: http://codereview.chromium.org/7670041
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101785 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert: Broke compile on linux touch.
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG=None
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Review URL: http://codereview.chromium.org/7670041TBR=flackr@chromium.org
Review URL: http://codereview.chromium.org/7919028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101585 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG=None
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Review URL: http://codereview.chromium.org/7670041
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101581 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL splits out creation of the context from channel creation. The
WebGraphicsContext3D will not be fully initialized until MakeCurrent is called
on it, at which point it is tied to the calling thread.
As compared to previous land attempts, this has:
- Protection against isContextLost being called on a dead context
- WebKit-side protection to ensure that GraphicsContext3Ds get made current
- Pepper modified to makeCurrent new contexts
Original review URL: http://codereview.chromium.org/7713015
Review URL: http://codereview.chromium.org/7860028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@100955 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The ultimate goal is to have toolkit_views <==> use_only_pure_views when all the GTK code has been removed from Views.
Note: as a side-effect this should reduce the need to use #ifdef TOUCH_UI which in many cases shall be replaced by USE_ONLY_PURE_VIEWS.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7780012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@100846 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- introduces JavaRef<> base class to allow passing refs without knowledge of their scope
- makes the ScopedJavaLocalRef and ScopedJavaGlobalRef consistent, in name, in methods available, and in conversions allowed.
Also updates some other minor base API changes whilst I'm in those files.
BUG=
TEST=doesn't break build...
Review URL: http://codereview.chromium.org/7828084
git-svn-id: http://src.chromium.org/svn/trunk/src/build@100383 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes it a lot easier to build with clang, since setting the GYP_DEFINES
is now the only thing one has to do. The rest is set automatically.
In preparation of setting clang=1 in build/common.gypi on mac.
Depends on http://codereview.chromium.org/7779041/ . Idea and xcode
part of the patch by Mark.
BUG=none
TEST= Set GYP_DEFINES=clang=1, create xcode and make projects
1.) Building with Xcode 3.2 uses clang
2.) Building with Xcode 4 gives functional fixits
3.) Building with make uses clang both for host and target
4.) Building with xcodebuild and goma still works on mac
5.) Building with make and goma still works
Review URL: http://codereview.chromium.org/7779039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@99835 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This confuses a few unit tests, so add some machinery to disable the feature in tests and do so in the tests that need it.
BUG=61140,575
TEST=Go to en.wikipedia.org, hit space. Scroll should be animated.
Review URL: http://codereview.chromium.org/7693019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@99186 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Client loader processes.
Some plug-ins depend on having an executable heap. They write code to data
pages and attempt to execute it without calling mprotect to mark this code
as executable.
Native Client needs to allocate a contiguous 1GB of address space. ASLR may
interfere with there being a "hole" this large in the address space by the
time NaCl makes its request.
Non-executable heaps are only available in 10.7 and later for 32-bit
processes.
PIE/ASLR was formerly disabled for all processes other than the browser
process. This change reenables it for all processes other than the NaCl
loader. PIE/ASLR is available on 10.5 and later, although the implementation
is stronger in 10.7 than in earlier releases.
This change results in two new helpers in addition to the existing
Chromium Helper.app: Chromium Helper EH.app (for executable heaps) and
Chromium Helper NP.app (for no PIE). libplugin_carbon_interpose.dylib moves
out of the helper .app and directly into the versioned directory. The
InfoPlist.strings have been removed from the helper app, but empty .lproj
directories remain.
BUG=90221, 93551
TEST=everything
Review URL: http://codereview.chromium.org/7714018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@97984 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Hardlink from different dir for chrome.exe caused annoyance when running from
Visual Studio because $(TargetPath) the default in the .user file is not the
correct path. So, instead do the hardlink on the dll. To avoid the possible
expense on non-NTFS, and to enable a trybot in the future, do this hardlink
based on a gyp define.
BUG=92528, 92685
TEST=No link problems
Review URL: http://codereview.chromium.org/7670031
git-svn-id: http://src.chromium.org/svn/trunk/src/build@97341 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is the first phase towards being able to replace Bookmark Editor with the WebUI Bookmark Manager as part of the GTK removal effort on ChromeOS. It does not yet have a means of selecting a folder to bookmark all of your tabs in and as such can't yet replace all calls to BookmarkEditor::Show.
BUG=None
TEST=Tested editing bookmarks from the popup bubble and bookmark bar in Linux and TouchUI builds.
Review URL: http://codereview.chromium.org/7572022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@97186 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL and WM_GESTURE (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary.
One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported).
BUG=86810
TEST=None.
Review URL: http://codereview.chromium.org/7617019TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/7648011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@96661 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL and WM_GESTURE (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary.
One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported).
BUG=86810
TEST=None.
Review URL: http://codereview.chromium.org/7617019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@96592 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
And fixes the code of task manager and following tests which didn't work correctly on WebUI TaskManager.
- TaskManagerBrowserTest.ShutdownWhileOpen
- ExtensionApiTest.ProcessesVsTaskManager
- PrerenderBrowserTest.PrerenderTaskManager
BUG=chromium-os:13885
TEST=trybots
Review URL: http://codereview.chromium.org/7550004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@95567 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
And fixes the code of task manager and following tests which didn't work correctly on WebUI TaskManager.
- TaskManagerBrowserTest.ShutdownWhileOpen
- ExtensionApiTest.ProcessesVsTaskManager
- PrerenderBrowserTest.PrerenderTaskManager
BUG=chromium-os:13885
TEST=trybots
Review URL: http://codereview.chromium.org/7520011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@95015 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
* Added --enable-web-intents switch.
* Added enable_web_intents build variable, for use in WebKit mostly.
* Added registration InfoBar and piping to the WebKit side, which is not hooked
up on that side yet.
BUG=none
TEST=RegisterIntentHandlerInfoBarDelegateTest.*
Review URL: http://codereview.chromium.org/7461093
git-svn-id: http://src.chromium.org/svn/trunk/src/build@94867 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is essentially a OO wrapper over the Wayland library. It will be used to
add Wayland support for Chrome.
This was written with the intent of being as standalone as possible and it
should not require any external Chrome dependencies.
BUG=None
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7457023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@94492 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
g++ -Wall includes -Wsign-compare on C++ source, but clang++ doesn't.
(this is a 2nd attempt to land this change, after 79846 had to be rolled back
because clang's -Wsign-compare semantics were different from gcc's; this has
been fixed in clang 135664)
BUG=none
TEST=chrome builds w/ rolled clang, trybots
Review URL: http://codereview.chromium.org/7493029
git-svn-id: http://src.chromium.org/svn/trunk/src/build@93837 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
alexeypa@chromium.org
cevans@chromium.org
glider@chromium.org
tony@chromium.org
evan@chromium.org
fsamuel@chromium.org
yoshiki@chromium.org
erg@chromium.org
eugenis@google.com
jrg@chromium.org
asvitkine@chromium.org
wjia@chromium.org
csilv@chromium.org
gman@chromium.org
mark@chromium.org
saintlou@chromium.org
ivankr@chromium.org
tim@chromium.org
junov@chromium.org
piman@chromium.org
thakis@chromium.org
gbillock@chromium.org
glotov@google.com
dpranke@chromium.org
derat@chromium.org
bauerb@chromium.org
joi@chromium.org
mazda@chromium.org
thestig@chromium.org
wez@chromium.org
bruening@chromium.org
alicet@chromium.org
jbauman@chromium.org
cpu@chromium.org
ben@chromium.org
podivilov@chromium.org
aarya@google.com
siggi@chromium.org
mseaborn@chromium.org
robert.nagy@gmail.com
robertm@google.com
maruel@chromium.org
peter@chromium.org
kalman@chromium.org
bradnelson@google.com
davemoore@chromium.org
epoger@chromium.org
aa@chromium.org
noelallen@google.com
scottmg@chromium.org
jingzhao@chromium.org
reed@google.com
vollick@chromium.org
dmaclach@chromium.org
jknotten@chromium.org
rogerta@chromium.org
steveblock@chromium.org
rsesek@chromium.org
lipalani@chromium.org
jasonwkim@google.com
backer@chromium.org
sky@chromium.org
phajdan.jr@chromium.org
dmichael@chromium.org
timurrrr@chromium.org
scottbyer@chromium.org
jamesr@chromium.org
rkc@chromium.org
mattm@chromium.org
hashimoto@chromium.org
vapier@google.com
michaelbai@google.com
epoger@google.com
jschuh@chromium.org
sadrul@chromium.org
jamescook@chromium.org
flackr@chromium.org
nsylvain@chromium.org
scherkus@chromium.org
rsimha@chromium.org
rsleevi@chromium.org
nduca@chromium.org
mihaip@chromium.org
joth@chromium.org
pkasting@chromium.org
fta@sofaraway.org
kerz@chromium.org
jeanluc@chromium.org
tzik@chromium.org
dnicoara@chromium.org
jhawkins@chromium.org
fischman@chromium.org
ofri@google.com