Граф коммитов

1259 Коммитов

Автор SHA1 Сообщение Дата
Jan de Mooij b8c43d4666 Bug 1390147 - Remove getProperty Class hook from StatementJSHelper and AsyncStatementJSHelper. r=mrbkap 2017-08-15 16:16:07 +02:00
Andrew Sutherland 1a8a11ff09 Bug 1388584 - Part 1: Bind ATTACH DATABASE path argument. r=adw r=markh a=Aryx
This is for the trunk/nightly landing only, and approval was explicitly
requested from #sheriffs to land without tests as a preliminary stop-gap.

Tests and a proper fix will land as part of bug 1389660, but that will be a few
days.

--HG--
extra : rebase_source : 5849f2f37d735387e13ac0486f1fae7906725111
extra : source : 908a4bb55a039985473e1565d88abebfe024c44c
2017-08-12 02:33:09 -04:00
Andrew Sutherland 040a64f28b Bug 1389279 - storage::Service needs a death grip when removing strong observer references. r=bkelly
The observer references were the only thing guranteed to keep the Service
alive, leading to potential use-after-free during the iteration loop to
make sure all the connections were closed.  (Ironically, if they were
fully closed and their instances destroyed, that's when bad things would
happen.)

--HG--
extra : rebase_source : 6c8d6f9e0b75751b10166d7e2c63d5a3cb27d28e
2017-08-10 23:26:25 -04:00
Phil Ringnalda 858a553b02 Backed out 2 changesets (bug 1386103) for Android x86 build bustage
Backed out changeset eec506d87d03 (bug 1386103)
Backed out changeset 3f9ec011c9bd (bug 1386103)

MozReview-Commit-ID: 8ak71R7vUOC
2017-08-08 22:08:54 -07:00
Nicholas Nethercote e9daf4d245 Bug 1386103 (part 1) - Specify nsAuto[C]String storage size via template parameter. r=dbaron.
This patch parameterizes nsAuto[C]String, renames them as nsAuto[C]StringN, and
redefines nsAuto[C]String as typedefs for nsAuto[C]StringN<64>.

(The alternative would be to templatize nsAuto[C]String and use a default
parameter, but that would require writing "nsAuto[C]String<>" everywhere.)
2017-08-01 11:58:45 +10:00
Masatoshi Kimura 12ab2931a7 Bug 645049 - Remove [deprecated] methods on mozIStorageBaseStatement.idl. r=asuth
MozReview-Commit-ID: AB1VBuhxi8

--HG--
extra : rebase_source : e5062b532370ab4d82fb33a258e447fc66cf09f6
2017-08-06 09:17:50 +09:00
Nathan Froyd a6c96367a7 Bug 1347963 - part 1 - introduce mozilla::RecursiveMutex; r=erahm
Having a proper recursively-acquirable mutex type makes intent clearer,
and RecursiveMutex also happens to be somewhat faster than
ReentrantMonitor.
2017-03-14 14:05:51 -04:00
Andrea Marchesini 50f9ea47a3 Bug 1350958 - Finish labeling ProxyReleaseEvent, r=billm 2017-07-14 08:49:22 +02:00
Olli Pettay 4244505f99 Bug 1378218 - Don't register visited callback if we have pending link update, r=ehsan,baku 2017-07-07 13:06:52 +03:00
Sylvestre Ledru 4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E) af77ddf71b Bug 1376202 - Release sharedDBMutex prior to post-auto-finalizing sqlite3_close(). r=asuth
MozReview-Commit-ID: 9aRqQPDfeD7

--HG--
extra : rebase_source : 6ff3a16cc530c630d2fd9733af419485d45fe80b
2017-06-29 15:59:02 -07:00
Bill McCloskey f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book 259377b6ab merge mozilla-inbound to mozilla-central a=merge 2017-06-26 13:25:51 +02:00
Florian Quèze 2924991bf6 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Nicholas Nethercote 58786e1ea7 Bug 1375392 - Tweak the PROFILER_LABEL* macros. r=mstange.
This patch makes the following changes to the macros.

- Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside
  classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was
  mostly misused.

- Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is
  universally available now anyway.

- Combines the first two string literal arguments of PROFILER_LABEL and
  PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for
  them to be separate, and it forced a '::' in the label, which isn't always
  appropriate. Also, the meaning of the "name_space" argument was interpreted
  in an interesting variety of ways.

- Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make
  it clearer they construct RAII objects rather than just being function calls.
  (I myself have screwed up the scoping because of this in the past.)

- Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so
  the caller doesn't need to. This makes a *lot* more of the uses fit onto a
  single line.

The patch also makes the following changes to the macro uses (beyond those
required by the changes described above).

- Fixes a bunch of labels that had gotten out of sync with the name of the
  class and/or function that encloses them.

- Removes a useless PROFILER_LABEL use within a trivial scope in
  EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving
  any useful purpose. It also serves as extra evidence that the AUTO_ prefix is
  a good idea.

- Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is
  done within them, instead of at their callsites, because that's a more
  standard way of doing things.

--HG--
extra : rebase_source : 318d1bc6fc1425a94aacbf489dd46e4f83211de4
2017-06-22 17:08:53 +10:00
Marco Bonardo 53fe12fd9d Bug 1375217 - Avoid raw pointers in mozStorageAsyncStatementExecution.cpp. r=asuth
MozReview-Commit-ID: Lshd1HUjXSq

--HG--
extra : rebase_source : 0327588f9cbbfac4e3b5ffdcb62025ee930107aa
2017-06-21 18:47:26 +02:00
Florian Quèze 5b8f8b884c Bug 1374282 - script generated patch to remove Promise.defer calls, r=Mossop. 2017-06-22 12:51:42 +02:00
Florian Quèze 66f6d259bc Bug 1374282 - script generated patch to remove Task.jsm calls, r=Mossop. 2017-06-22 12:51:42 +02:00
Nathan Froyd 452dc60022 Bug 1372670 - part 4 - use nsIThreadManager::dispatchToMainThread more from JS; r=florian
We did an automated conversion for many of these in another bug, but
these instances were either missed or have been added since then.
2017-06-21 12:59:28 -04:00
Nathan Froyd 27c58cf89f Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian 2017-06-21 12:59:28 -04:00
Carsten "Tomcat" Book 8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey 6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Wes Kocher c0e1236f1a Merge autoland to m-c a=merge
MozReview-Commit-ID: LFtpTAueYrF
2017-06-20 18:24:29 -07:00
Carsten "Tomcat" Book de892834ed Merge mozilla-central to mozilla-inbound 2017-06-20 11:31:34 +02:00
Doug Thayer d65c88d3f0 Bug 1166166 - Shrink storage cache off main thread r=mak
Per bug: it can take around 200ms to shrink memory for
Places.sqlite. This can end up janking the browser if we hit a
memory-pressure. This patch simply removes the #if DEBUG guards
around the mAsyncExecutionThreadIsAlive boolean which is already
being updated and exposes it so that we can shrink memory off
the main thread when possible.

MozReview-Commit-ID: LoDGKrOXs8u

--HG--
extra : rebase_source : adf03f187e7297835566f3bac92a8be8a6147131
2017-06-01 14:46:53 -07:00
Marco Bonardo 8d20cc6802 Bug 1355561 - Add a new API to spinningly close the database when strictly needed, and ensure Close() does what it's named after. r=asuth
Introduce a new SpinningSynchronousClose API that allows to synchronously close
a connection that executed asynchronous statements, by spinning the events loop.
This is expected to be used rarely in particular cases like database corruption.
It is currently [noscript] since the only consumer is cpp, in the future we can
evaluate removing that, if we find more uses for it.

MozReview-Commit-ID: 7SPqutoF9jJ

--HG--
extra : rebase_source : d053e308192f335dfdca089668e56115b068ff8c
2017-04-12 17:44:39 +02:00
Carsten "Tomcat" Book ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey 4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bevis Tseng d1637b9c5a Bug 1372453 - Part 2: Name the caller of ProxyReleaseEvent. r=billm
MozReview-Commit-ID: LYhSWnZkq0i
2017-06-14 09:27:17 +08:00
Marco Bonardo 1d88de7d2f Bug 1371945 - Avoid a possible thread-safety problem with unfinalized statements. r=asuth
Avoids a thread-safety race condition on shutdown where we could try to finalize a statement twice.
Allows the async thread to be referenced until ShutdownAsyncThread, so async finalizers can make use of it.
Removes the no more useful mAsyncExecutionThreadIsAlive.
Nullifies the sqlite3_mutex pointer when the connection is closed, since it would be a dangling pointer.
Use a ScopeExit to ensure the connection and the mutex pointers are always nullified on failure.
Makes asyncClose bailout early if a Close method was already invoked before.
Makes AsyncInitDatabase not use AsyncClose to just shutdown the async thread.
Fixes various unfinalized statements in consumers code.
Makes mConnectionClosed better follow mDBConn status.
Replaces some mutex locking isClosed() calls with lockless isConnectionReadyOnThisThread.

MozReview-Commit-ID: 6sftFehsQTt

--HG--
extra : rebase_source : 2bf3088b500376e58e62e8f078d9950588adc649
2017-06-16 17:43:23 +02:00
Mark Banner 0ce286101c Bug 1359011 - Make the mozilla/recommended eslint configuration the default for the whole tree. r=mossop
MozReview-Commit-ID: HtUW43tCli1

--HG--
extra : rebase_source : 6496bc47860d9c1ab522a78e73b41550700021cb
2017-04-25 20:12:21 +01:00
Mike Hommey 1a9d4c6f33 Bug 1363992 - Remove support for system jemalloc. r=njn
--HG--
extra : rebase_source : 9141402b6f9e84c67afc14303633d328eb5b652c
2017-05-11 13:03:20 +09:00
Nathan Froyd c1d1748428 Bug 1359490 - add an event loop spinning abstraction function; r=gerald
This function is arguably nicer than calling NS_ProcessNextEvent
manually, is slightly more efficient, and will enable better auditing
for NS_ProcessNextEvent when we do Quantum DOM scheduling changes.
2017-05-15 09:34:19 -04:00
Tom Tromey 99f4608655 Bug 1334278 - change mozilla::Smprintf to return a UniquePtr; r=froydnj
Change mozilla::Smprintf and friends to return a UniquePtr, rather than
relying on manual memory management.  (Though after this patch there are
still a handful of spots needing SmprintfFree.)

MozReview-Commit-ID: COa4nzIX5qa

--HG--
extra : rebase_source : ab4a11b4d2e758099bd0794d5c25d799a7e42680
2017-03-03 08:17:27 -07:00
Florian Queze f935ddc4b3 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze 37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst 738d097aae Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze 3c564a2b02 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze 95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Mark Banner 585bf398ea Bug 1342459 - Enable no-undef on browser/base, and clean up unnecessary no-undef references. r=mossop
MozReview-Commit-ID: KVrAnAjMD1E

--HG--
extra : rebase_source : 7a9651c055e2c6e959d42d08e5be9de2e2265346
2017-04-03 11:46:56 +01:00
Sajid Ahmed 591da76059 Bug 1007034 - Add console warnings for the deprecated BindXXXParameter methods in mozIStorageBaseStatement and replace calls to the deprecated methods in dom/indexedDB/ActorsParent.cpp. r=mak
--HG--
extra : rebase_source : ac32534d36959ff7f3a1c3a382319e6de4225c2f
2017-04-05 14:08:25 -04:00
Randell Jesup 41c4f44c15 Bug 1350752: Cleanup async mozStorage callback management r=layzell
MozReview-Commit-ID: 6LS1Strqu6s
2017-03-28 06:54:02 -04:00
Mark Banner d7d8be9285 Bug 1347712 - Move toolkit/.eslintrc.js rules into a 'recommended' set within eslint-plugin-mozilla. r=jaws
MozReview-Commit-ID: Jy4apKnmWcV

--HG--
rename : toolkit/.eslintrc.js => tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
extra : rebase_source : ae0c740c1c2a9cf620c1ac34024622ade12e6fd4
2017-03-22 10:43:00 +01:00
Mark Banner bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
David Major dc67bfc9a3 Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());

This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.

I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.

MozReview-Commit-ID: Kh1rUziVllo

--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae
2017-03-14 15:26:27 +13:00
Iris Hsiao 5cece96e1c Backed out 12 changesets (bug 1344629) for stylo build bustage
Backed out changeset cf4273d3ac30 (bug 1344629)
Backed out changeset a96390e044e0 (bug 1344629)
Backed out changeset d9b330f9bc24 (bug 1344629)
Backed out changeset 2b460fe020af (bug 1344629)
Backed out changeset 0ada91b0452e (bug 1344629)
Backed out changeset 083304fcd6bd (bug 1344629)
Backed out changeset 53d7d1ce2c97 (bug 1344629)
Backed out changeset 55eee7078ae4 (bug 1344629)
Backed out changeset 7d3c06b3eca9 (bug 1344629)
Backed out changeset e5df14c3db61 (bug 1344629)
Backed out changeset 636095ff2815 (bug 1344629)
Backed out changeset 0be052ad24c1 (bug 1344629)
2017-03-14 11:52:24 +08:00
David Major 40f4821701 Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());

This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.

I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.

MozReview-Commit-ID: Kh1rUziVllo

--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae
2017-03-14 15:26:27 +13:00
Marco Bonardo 34e590459b Bug 1342441 - Improve the Wrong Sqlite Version message. r=asuth
MozReview-Commit-ID: FVFw9XjpzOb

--HG--
extra : rebase_source : ddb91ba2fba1b19927200832a6e0b119f9547b91
2017-02-24 17:39:30 +01:00
Joel Maher d637db915a Bug 1341799 - annotate storage/* with BUG_COMPONENT in moz.build files. r=mak
MozReview-Commit-ID: 3g7WuMN6hR7
2017-02-23 08:01:50 -05:00
Wes Kocher 8c4ce17711 Merge inbound to m-c a=merge
MozReview-Commit-ID: DCUf7VEDrTt
2017-02-17 13:38:51 -08:00
Vedant Sareen 7d4bd52fae Bug 1330907 - Rename Telemetry::ID to Telemetry::HistogramID. r=dexter
Changed |print("enum ID : uint32_t {", file=output)| to |print("enum HistogramID : uint32_t {", file=output)| at line 53 of the file |toolkit/components/telemetry/gen-histogram-enum.py|, and then replaced all the textual occurrences of |Telemetry::ID| to |Telemetry::HistogramID| and |ID| to |HistogramID| in 43 other files.
2017-02-16 00:45:15 +05:30
Tom Tromey 5f8f360823 Bug 1060419 - make log_print use Printf.h, r=froydnj
MozReview-Commit-ID: BIZ1GQEZ1vs

--HG--
extra : rebase_source : 2f1f0aa12493c44f352d9a7e8683e7bb72d2d75b
2016-12-15 20:16:31 -07:00
Tom Tromey 42eaec768d Bug 1060419 - make mozStorageConnection.cpp and mozStorageStatement.cpp use Printf.h, r=froydnj
MozReview-Commit-ID: Gy2CLg9AVpG

--HG--
extra : rebase_source : 06f66468d0d11346efab403729a2f62c437c5206
2016-12-09 10:27:17 -10:00
Zibi Braniecki b8f991e41b Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame
MozReview-Commit-ID: 5GEnL7Kihpj

--HG--
extra : rebase_source : 413d880035b49da82db0530379425d31ac31a82e
2017-02-07 12:52:03 -08:00
Wes Kocher a9ce32d9a5 Backed out 2 changesets (bug 1335983) for build bustage a=backout
Backed out changeset 5a9559ded976 (bug 1335983)
Backed out changeset de2b0d90e2da (bug 1335983)

MozReview-Commit-ID: 377KQDU1QqJ
2017-02-07 12:34:30 -08:00
Zibi Braniecki 6d98bad59d Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame
MozReview-Commit-ID: bJVrVj2dAS

--HG--
extra : rebase_source : f3a28e003415f0c58462a73b5fd987455e102fc5
2017-02-06 14:57:09 -08:00
Nicholas Nethercote 22b6d342d7 Bug 1333296 (part 1) - Rename MOZ_ENABLE_PROFILER_SPS as MOZ_GECKO_PROFILER. r=mstange,glandium.
--HG--
extra : rebase_source : 223f3a17f009645369be503392cc1f0cea7f19a1
2017-01-24 14:15:12 +11:00
Bill McCloskey ef3d0f1c2e Bug 1331804 - Add more runnable names (r=ehsan)
MozReview-Commit-ID: 1QBmqfgY6WI
2017-01-24 16:34:37 -08:00
Wes Kocher f7ccafcb58 Backed out 8 changesets (bug 1331804, bug 1332100) for windows vm debug dt5 failures a=backout
Backed out changeset 8bf7f0e27c6c (bug 1331804)
Backed out changeset 600c0b9026c2 (bug 1331804)
Backed out changeset 3a5b5b9ecace (bug 1331804)
Backed out changeset c76432c9954e (bug 1331804)
Backed out changeset 46a9096745e7 (bug 1332100)
Backed out changeset 8b751230fa23 (bug 1331804)
Backed out changeset 2810212347fd (bug 1331804)
Backed out changeset be72b7763910 (bug 1331804)

MozReview-Commit-ID: Ywdsr4GZ4a
2017-01-24 15:12:21 -08:00
Bill McCloskey 80aaeed2fc Bug 1331804 - Add more runnable names (r=ehsan)
MozReview-Commit-ID: 1QBmqfgY6WI
2017-01-24 10:04:55 -08:00
Nicholas Nethercote bf48aecf29 Bug 1332172 - Remove XPC_MAP_WANT_*. r=mccr8.
nsIXPCScriptable flags handling in xpc_map_end.h is a bit of a mess.

- Half the flags relate to whether various functions are defined (PreCreate,
  GetProperty, etc). These are set using the XPC_MAP_WANT_* macros;
  for each one xpc_map_end.h  inserts the corresponding flag using the
  preprocessor (see XPC_MAP_CLASSNAME::GetScriptableFlags()).

- The other half of the flags relate to other things (IS_GLOBAL_OBJECT,
  DONT_REFLECT_INTERFACE_NAMES, etc). These are set using the XPC_MAP_FLAGS
  macro.

Having two similar but different mechanisms to set the flags for a class is
confusing. (Indeed, until recently we had some classes where a single flag was
redundantly specified via both mechanisms.) Note also that the classes done in
dom/base/nsIDOMClassInfo.h also specify all the flags in a single value,
similar to how XPC_MAP_FLAGS works.

This patch removes the XPC_MAP_WANT_* macros. All flags are now set
via XPC_MAP_FLAGS. This is a significant simplification to xpc_map_end.h and
all the places that use it.

The downside of this change is that I had to change the flag constants from
class constants (i.e. nsIXPCScriptable::FOO) to macros (i.e.
NSIXPCSCRIPTABLE_FOO) because they need to be used in #if statements like this
in xpc_map_end.h:

  #if !((XPC_MAP_FLAGS) & NSIXPCSCRIPTABLE_WANT_PRECREATE)

and you can't use a '::'-qualified name inside a #if. I think this downside is
outweighed by the simplification described above.

Overall the patch removes 80 lines of code.

--HG--
extra : rebase_source : 6d5c341d0deba8f1529d81c17bb8819e09620b05
2017-01-23 13:33:58 +11:00
Mark Banner 16e6d381ac Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ

--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
2017-01-18 10:30:39 +00:00
Jan Beich 13885f1a7b Bug 1330359 - Fix building with -Werror for non-SPS platforms. r=mstange
MozReview-Commit-ID: Ifb3zyGHn7U

--HG--
extra : rebase_source : 9b0e06b7f9e984d5c475e59ad7864a039eb8a695
2017-01-11 17:22:19 +00:00
Jared Wein 43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Markus Stange 9c6944dca7 Bug 1323100 - Use nsThreadPoolNaming::GetNextThreadName and NS_NewNamedThread for the mozStorage thread. r=froydnj
MozReview-Commit-ID: 145CjwiQawB

--HG--
extra : rebase_source : 81a22eb81ba02ae822e95b6def4b34e112e79abe
2016-12-20 14:20:15 +01:00
Markus Stange 692210bd80 Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
MozReview-Commit-ID: 7W1dt2BBKJZ

--HG--
extra : rebase_source : c7e335dac2e0f02782f0eb229a7181c8d01317a2
2016-12-21 11:43:50 +01:00
Mark Banner 80afb72ae6 Bug 1328851 - Enable eslint rule no-undef for storage/. r=mak
MozReview-Commit-ID: AemgF8H2ySH

--HG--
extra : rebase_source : dcbc2210fcfc9abf0e96b38b9306fd158f9dcfed
2017-01-05 11:54:49 +00:00
Jared Wein 9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Wes Kocher 26a1ba5c14 Backed out 27 changesets (bug 1323100) for clipboard leaktest failures a=backout
Backed out changeset 84fb749698ab (bug 1323100)
Backed out changeset d6d25e8bd001 (bug 1323100)
Backed out changeset 1b0855bb0c38 (bug 1323100)
Backed out changeset b6953e3f5739 (bug 1323100)
Backed out changeset 5572f3b63215 (bug 1323100)
Backed out changeset 12fb4c533659 (bug 1323100)
Backed out changeset c36524e4e919 (bug 1323100)
Backed out changeset 1e3b3eddbe26 (bug 1323100)
Backed out changeset 061110f1ae12 (bug 1323100)
Backed out changeset 413dbd31725b (bug 1323100)
Backed out changeset 06550f7eca62 (bug 1323100)
Backed out changeset 940933b13b36 (bug 1323100)
Backed out changeset a6d75c1cd724 (bug 1323100)
Backed out changeset 681cacbbaa3b (bug 1323100)
Backed out changeset 3d53787293f6 (bug 1323100)
Backed out changeset c0340dfe4766 (bug 1323100)
Backed out changeset 9f554991549d (bug 1323100)
Backed out changeset 757539e7039a (bug 1323100)
Backed out changeset a3c9b45aa917 (bug 1323100)
Backed out changeset 23d69df98a66 (bug 1323100)
Backed out changeset 1297ded6a01d (bug 1323100)
Backed out changeset f4235b97257f (bug 1323100)
Backed out changeset 93419cb4f29f (bug 1323100)
Backed out changeset 865d1b81c804 (bug 1323100)
Backed out changeset 54acf4ef8e84 (bug 1323100)
Backed out changeset 88d17bcd8205 (bug 1323100)
Backed out changeset 0c466e5e8933 (bug 1323100)
2016-12-29 16:28:36 -08:00
Markus Stange 882a11ecd0 Bug 1323100 - Use nsThreadPoolNaming::GetNextThreadName and NS_NewNamedThread for the mozStorage thread. r=froydnj
MozReview-Commit-ID: 145CjwiQawB

--HG--
extra : rebase_source : 9403849151907d2437f6874f8a7bd4d539394417
2016-12-20 14:20:15 +01:00
Markus Stange 1b72f37c98 Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
MozReview-Commit-ID: 7W1dt2BBKJZ

--HG--
extra : rebase_source : ad47978ef81d048a90b9803803201eee32974024
2016-12-21 11:43:50 +01:00
Jared Wein ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher 0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein 7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Nicholas Nethercote df925b776c Bug 1321374 - Simplify js::Class handling relating to nsIXPCScriptable. r=mccr8, sr=bholley.
This patch removes XPCNativeScriptableShared and XPCNativeScriptableSharedMap,
which results in a net reduction of ~100 lines of code.
2016-12-14 08:33:46 +11:00
Mark Banner 4f94e4bd68 Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop
MozReview-Commit-ID: CiIsUjQzp4D

--HG--
extra : rebase_source : 1b98e88673625a52ef82c1fad5d56aec3e2e8e80
2016-11-09 22:06:32 +00:00
Tomislav Jurin 348bfffc19 Bug 1296189 - Replace NS_RUNTIMEABORT("some string literal message") with MOZ_CRASH(). r=froydnj 2016-12-02 13:46:53 -08:00
Phil Ringnalda feef954874 Merge m-i to m-c, a=merge
MozReview-Commit-ID: EDVoIcyWOhi

--HG--
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
2016-11-22 20:03:03 -08:00
Nicholas Nethercote 7e1a8cf56c Bug 1315138 - gtestify storage/test/*.cpp. r=mak,erahm.
This change is mostly straightforward, except for the following.

- It removes all the printing from the do_check_* macros because gtest macros
  do appropriate printing.

- test_StatementCache.cpp needs some special gtest magic for the type
  parameterization.

- It merges the four tests in test_unlock_notify.cpp because they rely on being
  executed in order, and so aren't independent.

- storage_test_harness_tail.h is no longer necessary because gtest provides the
  test looping functionality.

- It uses #include and the preprocessor to remove the duplication between
  test_deadlock_detector.cpp and xpcom/tests/DeadlockDetector.cpp.

- It makes the test in test_service_init_background_thread.cpp a death test to
  force it to be the first storage gtest, because it fails otherwise.

- It adds code to undo the SQLite mutex hooking as necessary, so that tests
  don't interfere with each other.

- It de-virtualizes Spinner's destructor (as identified in bug 1318282).

--HG--
rename : storage/test/storage_test_harness.h => storage/test/gtest/storage_test_harness.h
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_StatementCache.cpp => storage/test/gtest/test_StatementCache.cpp
rename : storage/test/test_asyncStatementExecution_transaction.cpp => storage/test/gtest/test_asyncStatementExecution_transaction.cpp
rename : storage/test/test_async_callbacks_with_spun_event_loops.cpp => storage/test/gtest/test_async_callbacks_with_spun_event_loops.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_deadlock_detector.cpp => storage/test/gtest/test_deadlock_detector.cpp
rename : storage/test/test_file_perms.cpp => storage/test/gtest/test_file_perms.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
rename : storage/test/test_service_init_background_thread.cpp => storage/test/gtest/test_service_init_background_thread.cpp
rename : storage/test/test_statement_scoper.cpp => storage/test/gtest/test_statement_scoper.cpp
rename : storage/test/test_transaction_helper.cpp => storage/test/gtest/test_transaction_helper.cpp
rename : storage/test/test_true_async.cpp => storage/test/gtest/test_true_async.cpp
rename : storage/test/test_unlock_notify.cpp => storage/test/gtest/test_unlock_notify.cpp
extra : rebase_source : dbb695c112564efa1945116be1a8435988982e74
2016-11-11 09:59:23 +11:00
Andi-Bogdan Postelnicu 64312a6104 Bug 1318282 - Use C++11's override and remove virtual where applicable in storage/. r=mak
MozReview-Commit-ID: AXchuOpF65X

--HG--
extra : rebase_source : 47536d5918bdb66cd467a1c31ca6545817e922d3
2016-11-17 12:36:25 +02:00
Andi-Bogdan Postelnicu 7f5f07c638 Bug 1318282 - Replace string literals containing escaped characters with raw string literals in storage/. r=mak
MozReview-Commit-ID: 7iVr1Ug0Oot

--HG--
extra : rebase_source : 7590b2f78454d2497dcc7f9c4275e463a2fe6c81
2016-11-17 12:35:02 +02:00
Andi-Bogdan Postelnicu e874c4bda7 Bug 1318282 - Replace default bodies of special member functions with = default; in storage/. r=mak
MozReview-Commit-ID: DLgi8Oa7X2b

--HG--
extra : rebase_source : b18f05c361469d5d276c8a80b371aa001ec58cd4
2016-11-17 12:34:23 +02:00
Andi-Bogdan Postelnicu a71b3f4e14 Bug 1318282 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in storage/. r=mak
MozReview-Commit-ID: HuudUDUcQYu

--HG--
extra : rebase_source : 2b7591b118fea1e0a1b42ae929106191e2b2e1f6
2016-11-17 12:33:18 +02:00
Dave Townsend 8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Marco Bonardo a587089548 Bug 1313021 - Use a MEMORY SQLITE_TEMP_STORE on Android and 64bit builds. r=asuth
MozReview-Commit-ID: IeXOY3tTStq

--HG--
extra : rebase_source : a5457303a07751cc9d3c1861630636b15cce8a9f
2016-11-03 22:11:59 +01:00
Sebastian Hengst f8c9d72cfd Bug 1310297 - Remove test annotations using b2g, mulet or gonk: storage. r=RyanVM
MozReview-Commit-ID: D3QcehYvTpx

--HG--
extra : rebase_source : 842c9bd007676e1d760eaca67e3eb30cb751d5de
2016-11-05 11:29:21 +01:00
Marco Bonardo 100acd6188 Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. r=asuth
MozReview-Commit-ID: 2QR8P7ylg9m

--HG--
extra : rebase_source : 37ed75d0cf724a6c373df6d12df1f36fddc0a646
2016-11-03 21:04:00 +01:00
Marco Bonardo 1dd813abd5 Bug 835796 - Negative value in about:memory storage/sqlite/other due to double-counting of shared-cache connections. r=asuth
MozReview-Commit-ID: 2rO5sApv6rn

--HG--
extra : rebase_source : bf1150a3c00b1a8f66cc86ec5fff8d4d1dd24360
2016-11-03 23:14:35 +01:00
Marco Bonardo 462eaac7b8 Bug 1313310 - Use SQLITE_OMIT_DEPRECATED. r=asuth
MozReview-Commit-ID: C4pZ6EP799G

--HG--
extra : rebase_source : 5d213471d4d6785abe5ac79a6696b47b6681cc6e
2016-11-03 20:14:03 +01:00
Jared Wein 87b2d4c295 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY

--HG--
extra : rebase_source : 2f05e2f275ac7f293f9c650bdec8943189e3ce01
2016-11-03 14:42:06 -04:00
Marco Bonardo 792726a2c3 Bug 1310152 - AsyncClone may try to reuse a freed Critical Section in Sqlite. r=asuth
MozReview-Commit-ID: LW0esWlNfQQ

--HG--
extra : rebase_source : 59e2510a9d4c2343dcde91a572a3d354a15c162f
2016-11-03 15:31:31 +01:00
Jared Wein 5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Jan Varga 1ec718d61d Bug 964561 - Part 10: Fix a possible leak in BindAdoptedBlobByName()/BindAdoptedBlobByIndex(); r=mak 2016-10-25 21:18:37 +02:00
Mark Banner 56a7b3961a Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I

--HG--
rename : .eslintrc => .eslintrc.js
rename : accessible/.eslintrc => accessible/.eslintrc.js
rename : accessible/tests/browser/.eslintrc => accessible/tests/browser/.eslintrc.js
rename : browser/.eslintrc => browser/.eslintrc.js
rename : browser/base/content/test/alerts/.eslintrc => browser/base/content/test/alerts/.eslintrc.js
rename : browser/base/content/test/chrome/.eslintrc => browser/base/content/test/chrome/.eslintrc.js
rename : browser/base/content/test/general/.eslintrc => browser/base/content/test/general/.eslintrc.js
rename : browser/base/content/test/newtab/.eslintrc => browser/base/content/test/newtab/.eslintrc.js
rename : browser/base/content/test/plugins/.eslintrc => browser/base/content/test/plugins/.eslintrc.js
rename : browser/base/content/test/popupNotifications/.eslintrc => browser/base/content/test/popupNotifications/.eslintrc.js
rename : browser/base/content/test/referrer/.eslintrc => browser/base/content/test/referrer/.eslintrc.js
rename : browser/base/content/test/social/.eslintrc => browser/base/content/test/social/.eslintrc.js
rename : browser/components/contextualidentity/test/browser/.eslintrc => browser/components/contextualidentity/test/browser/.eslintrc.js
rename : browser/components/customizableui/test/.eslintrc => browser/components/customizableui/test/.eslintrc.js
rename : browser/components/dirprovider/tests/unit/.eslintrc => browser/components/dirprovider/tests/unit/.eslintrc.js
rename : browser/components/downloads/test/browser/.eslintrc => browser/components/downloads/test/browser/.eslintrc.js
rename : browser/components/downloads/test/unit/.eslintrc => browser/components/downloads/test/unit/.eslintrc.js
rename : browser/components/extensions/.eslintrc => browser/components/extensions/.eslintrc.js
rename : browser/components/extensions/test/browser/.eslintrc => browser/components/extensions/test/browser/.eslintrc.js
rename : browser/components/extensions/test/xpcshell/.eslintrc => browser/components/extensions/test/xpcshell/.eslintrc.js
rename : browser/components/feeds/test/.eslintrc => browser/components/feeds/test/.eslintrc.js
rename : browser/components/feeds/test/chrome/.eslintrc => browser/components/feeds/test/chrome/.eslintrc.js
rename : browser/components/feeds/test/unit/.eslintrc => browser/components/feeds/test/unit/.eslintrc.js
rename : browser/components/migration/tests/unit/.eslintrc => browser/components/migration/tests/unit/.eslintrc.js
rename : browser/components/newtab/tests/browser/.eslintrc => browser/components/newtab/tests/browser/.eslintrc.js
rename : browser/components/newtab/tests/xpcshell/.eslintrc => browser/components/newtab/tests/xpcshell/.eslintrc.js
rename : browser/components/originattributes/test/browser/.eslintrc => browser/components/originattributes/test/browser/.eslintrc.js
rename : browser/components/places/tests/browser/.eslintrc => browser/components/places/tests/browser/.eslintrc.js
rename : browser/components/places/tests/chrome/.eslintrc => browser/components/places/tests/chrome/.eslintrc.js
rename : browser/components/places/tests/unit/.eslintrc => browser/components/places/tests/unit/.eslintrc.js
rename : browser/components/preferences/in-content/tests/.eslintrc => browser/components/preferences/in-content/tests/.eslintrc.js
rename : browser/components/privatebrowsing/test/browser/.eslintrc => browser/components/privatebrowsing/test/browser/.eslintrc.js
rename : browser/components/safebrowsing/content/test/.eslintrc => browser/components/safebrowsing/content/test/.eslintrc.js
rename : browser/components/search/test/.eslintrc => browser/components/search/test/.eslintrc.js
rename : browser/components/selfsupport/test/.eslintrc => browser/components/selfsupport/test/.eslintrc.js
rename : browser/components/sessionstore/test/.eslintrc => browser/components/sessionstore/test/.eslintrc.js
rename : browser/components/sessionstore/test/unit/.eslintrc => browser/components/sessionstore/test/unit/.eslintrc.js
rename : browser/components/shell/test/.eslintrc => browser/components/shell/test/.eslintrc.js
rename : browser/components/shell/test/unit/.eslintrc => browser/components/shell/test/unit/.eslintrc.js
rename : browser/components/tests/browser/.eslintrc => browser/components/tests/browser/.eslintrc.js
rename : browser/components/translation/test/.eslintrc => browser/components/translation/test/.eslintrc.js
rename : browser/components/translation/test/unit/.eslintrc => browser/components/translation/test/unit/.eslintrc.js
rename : browser/components/uitour/test/.eslintrc => browser/components/uitour/test/.eslintrc.js
rename : browser/experiments/test/xpcshell/.eslintrc => browser/experiments/test/xpcshell/.eslintrc.js
rename : browser/extensions/formautofill/.eslintrc => browser/extensions/formautofill/.eslintrc.js
rename : browser/extensions/formautofill/test/browser/.eslintrc => browser/extensions/formautofill/test/browser/.eslintrc.js
rename : browser/extensions/pdfjs/test/.eslintrc => browser/extensions/pdfjs/test/.eslintrc.js
rename : browser/modules/test/.eslintrc => browser/modules/test/.eslintrc.js
rename : browser/modules/test/unit/social/.eslintrc => browser/modules/test/unit/social/.eslintrc.js
rename : browser/modules/test/xpcshell/.eslintrc => browser/modules/test/xpcshell/.eslintrc.js
rename : devtools/.eslintrc => devtools/.eslintrc.js
rename : devtools/.eslintrc.mochitests => devtools/.eslintrc.mochitests.js
rename : devtools/.eslintrc.xpcshell => devtools/.eslintrc.xpcshell.js
rename : devtools/client/aboutdebugging/test/.eslintrc => devtools/client/aboutdebugging/test/.eslintrc.js
rename : devtools/client/animationinspector/test/.eslintrc => devtools/client/animationinspector/test/.eslintrc.js
rename : devtools/client/animationinspector/test/unit/.eslintrc => devtools/client/animationinspector/test/unit/.eslintrc.js
rename : devtools/client/canvasdebugger/test/.eslintrc => devtools/client/canvasdebugger/test/.eslintrc.js
rename : devtools/client/commandline/test/.eslintrc => devtools/client/commandline/test/.eslintrc.js
rename : devtools/client/debugger/new/test/mochitest/.eslintrc => devtools/client/debugger/new/test/mochitest/.eslintrc.js
rename : devtools/client/debugger/test/.eslintrc => devtools/client/debugger/test/.eslintrc.js
rename : devtools/client/dom/.eslintrc => devtools/client/dom/.eslintrc.js
rename : devtools/client/dom/test/.eslintrc => devtools/client/dom/test/.eslintrc.js
rename : devtools/client/framework/test/.eslintrc => devtools/client/framework/test/.eslintrc.js
rename : devtools/client/inspector/.eslintrc => devtools/client/inspector/.eslintrc.js
rename : devtools/client/inspector/components/test/.eslintrc => devtools/client/inspector/components/test/.eslintrc.js
rename : devtools/client/inspector/computed/test/.eslintrc => devtools/client/inspector/computed/test/.eslintrc.js
rename : devtools/client/inspector/fonts/test/.eslintrc => devtools/client/inspector/fonts/test/.eslintrc.js
rename : devtools/client/inspector/markup/test/.eslintrc => devtools/client/inspector/markup/test/.eslintrc.js
rename : devtools/client/inspector/rules/test/.eslintrc => devtools/client/inspector/rules/test/.eslintrc.js
rename : devtools/client/inspector/shared/test/.eslintrc => devtools/client/inspector/shared/test/.eslintrc.js
rename : devtools/client/inspector/test/.eslintrc => devtools/client/inspector/test/.eslintrc.js
rename : devtools/client/jsonview/.eslintrc => devtools/client/jsonview/.eslintrc.js
rename : devtools/client/jsonview/test/.eslintrc => devtools/client/jsonview/test/.eslintrc.js
rename : devtools/client/memory/test/browser/.eslintrc => devtools/client/memory/test/browser/.eslintrc.js
rename : devtools/client/memory/test/unit/.eslintrc => devtools/client/memory/test/unit/.eslintrc.js
rename : devtools/client/netmonitor/.eslintrc => devtools/client/netmonitor/.eslintrc.js
rename : devtools/client/netmonitor/har/test/.eslintrc => devtools/client/netmonitor/har/test/.eslintrc.js
rename : devtools/client/netmonitor/test/.eslintrc => devtools/client/netmonitor/test/.eslintrc.js
rename : devtools/client/performance/test/.eslintrc => devtools/client/performance/test/.eslintrc.js
rename : devtools/client/performance/test/unit/.eslintrc => devtools/client/performance/test/unit/.eslintrc.js
rename : devtools/client/projecteditor/test/.eslintrc => devtools/client/projecteditor/test/.eslintrc.js
rename : devtools/client/promisedebugger/test/.eslintrc => devtools/client/promisedebugger/test/.eslintrc.js
rename : devtools/client/responsive.html/test/browser/.eslintrc => devtools/client/responsive.html/test/browser/.eslintrc.js
rename : devtools/client/responsive.html/test/unit/.eslintrc => devtools/client/responsive.html/test/unit/.eslintrc.js
rename : devtools/client/responsivedesign/test/.eslintrc => devtools/client/responsivedesign/test/.eslintrc.js
rename : devtools/client/scratchpad/test/.eslintrc => devtools/client/scratchpad/test/.eslintrc.js
rename : devtools/client/shadereditor/test/.eslintrc => devtools/client/shadereditor/test/.eslintrc.js
rename : devtools/client/shared/components/.eslintrc => devtools/client/shared/components/.eslintrc.js
rename : devtools/client/shared/components/test/browser/.eslintrc => devtools/client/shared/components/test/browser/.eslintrc.js
rename : devtools/client/shared/components/test/mochitest/.eslintrc => devtools/client/shared/components/test/mochitest/.eslintrc.js
rename : devtools/client/shared/shim/test/.eslintrc => devtools/client/shared/shim/test/.eslintrc.js
rename : devtools/client/shared/test/.eslintrc => devtools/client/shared/test/.eslintrc.js
rename : devtools/client/shared/test/unit/.eslintrc => devtools/client/shared/test/unit/.eslintrc.js
rename : devtools/client/sourceeditor/.eslintrc => devtools/client/sourceeditor/.eslintrc.js
rename : devtools/client/sourceeditor/test/.eslintrc => devtools/client/sourceeditor/test/.eslintrc.js
rename : devtools/client/storage/test/.eslintrc => devtools/client/storage/test/.eslintrc.js
rename : devtools/client/styleeditor/test/.eslintrc => devtools/client/styleeditor/test/.eslintrc.js
rename : devtools/client/webaudioeditor/test/.eslintrc => devtools/client/webaudioeditor/test/.eslintrc.js
rename : devtools/client/webconsole/net/.eslintrc => devtools/client/webconsole/net/.eslintrc.js
rename : devtools/client/webconsole/net/test/mochitest/.eslintrc => devtools/client/webconsole/net/test/mochitest/.eslintrc.js
rename : devtools/client/webconsole/net/test/unit/.eslintrc => devtools/client/webconsole/net/test/unit/.eslintrc.js
rename : devtools/client/webconsole/new-console-output/test/.eslintrc => devtools/client/webconsole/new-console-output/test/.eslintrc.js
rename : devtools/client/webconsole/test/.eslintrc => devtools/client/webconsole/test/.eslintrc.js
rename : devtools/client/webide/test/.eslintrc => devtools/client/webide/test/.eslintrc.js
rename : devtools/server/tests/browser/.eslintrc => devtools/server/tests/browser/.eslintrc.js
rename : devtools/server/tests/mochitest/.eslintrc => devtools/server/tests/mochitest/.eslintrc.js
rename : devtools/server/tests/unit/.eslintrc => devtools/server/tests/unit/.eslintrc.js
rename : devtools/shared/heapsnapshot/tests/unit/.eslintrc => devtools/shared/heapsnapshot/tests/unit/.eslintrc.js
rename : devtools/shared/platform/content/.eslintrc => devtools/shared/platform/content/.eslintrc.js
rename : devtools/shared/platform/content/test/.eslintrc => devtools/shared/platform/content/test/.eslintrc.js
rename : devtools/shared/security/tests/unit/.eslintrc => devtools/shared/security/tests/unit/.eslintrc.js
rename : devtools/shared/tests/browser/.eslintrc => devtools/shared/tests/browser/.eslintrc.js
rename : devtools/shared/tests/unit/.eslintrc => devtools/shared/tests/unit/.eslintrc.js
rename : devtools/shared/transport/tests/unit/.eslintrc => devtools/shared/transport/tests/unit/.eslintrc.js
rename : devtools/shared/webconsole/test/unit/.eslintrc => devtools/shared/webconsole/test/unit/.eslintrc.js
rename : devtools/shared/worker/tests/browser/.eslintrc => devtools/shared/worker/tests/browser/.eslintrc.js
rename : mobile/android/components/extensions/.eslintrc => mobile/android/components/extensions/.eslintrc.js
rename : mobile/android/components/extensions/test/mochitest/.eslintrc => mobile/android/components/extensions/test/mochitest/.eslintrc.js
rename : security/manager/.eslintrc.json => security/manager/.eslintrc.js
rename : security/manager/ssl/tests/.eslintrc.json => security/manager/ssl/tests/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/browser/.eslintrc.json => security/manager/ssl/tests/mochitest/browser/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/mixedcontent/.eslintrc.json => security/manager/ssl/tests/mochitest/mixedcontent/.eslintrc.js
rename : security/manager/ssl/tests/mochitest/stricttransportsecurity/.eslintrc.json => security/manager/ssl/tests/mochitest/stricttransportsecurity/.eslintrc.js
rename : security/manager/ssl/tests/unit/.eslintrc.json => security/manager/ssl/tests/unit/.eslintrc.js
rename : security/manager/tools/.eslintrc.json => security/manager/tools/.eslintrc.js
rename : storage/.eslintrc => storage/.eslintrc.js
rename : testing/mochitest/browser.eslintrc => testing/mochitest/browser.eslintrc.js
rename : testing/mochitest/chrome.eslintrc => testing/mochitest/chrome.eslintrc.js
rename : testing/mochitest/mochitest.eslintrc => testing/mochitest/mochitest.eslintrc.js
rename : testing/xpcshell/xpcshell.eslintrc => testing/xpcshell/xpcshell.eslintrc.js
rename : toolkit/.eslintrc => toolkit/.eslintrc.js
rename : toolkit/components/aboutmemory/tests/.eslintrc => toolkit/components/aboutmemory/tests/.eslintrc.js
rename : toolkit/components/aboutperformance/tests/browser/.eslintrc => toolkit/components/aboutperformance/tests/browser/.eslintrc.js
rename : toolkit/components/addoncompat/tests/browser/.eslintrc => toolkit/components/addoncompat/tests/browser/.eslintrc.js
rename : toolkit/components/alerts/test/.eslintrc => toolkit/components/alerts/test/.eslintrc.js
rename : toolkit/components/asyncshutdown/tests/xpcshell/.eslintrc => toolkit/components/asyncshutdown/tests/xpcshell/.eslintrc.js
rename : toolkit/components/autocomplete/tests/unit/.eslintrc => toolkit/components/autocomplete/tests/unit/.eslintrc.js
rename : toolkit/components/captivedetect/test/unit/.eslintrc => toolkit/components/captivedetect/test/unit/.eslintrc.js
rename : toolkit/components/commandlines/test/unit/.eslintrc => toolkit/components/commandlines/test/unit/.eslintrc.js
rename : toolkit/components/commandlines/test/unit_unix/.eslintrc => toolkit/components/commandlines/test/unit_unix/.eslintrc.js
rename : toolkit/components/commandlines/test/unit_win/.eslintrc => toolkit/components/commandlines/test/unit_win/.eslintrc.js
rename : toolkit/components/contentprefs/tests/mochitest/.eslintrc => toolkit/components/contentprefs/tests/mochitest/.eslintrc.js
rename : toolkit/components/contentprefs/tests/unit/.eslintrc => toolkit/components/contentprefs/tests/unit/.eslintrc.js
rename : toolkit/components/contentprefs/tests/unit_cps2/.eslintrc => toolkit/components/contentprefs/tests/unit_cps2/.eslintrc.js
rename : toolkit/components/crashes/tests/xpcshell/.eslintrc => toolkit/components/crashes/tests/xpcshell/.eslintrc.js
rename : toolkit/components/crashmonitor/test/unit/.eslintrc => toolkit/components/crashmonitor/test/unit/.eslintrc.js
rename : toolkit/components/ctypes/tests/chrome/.eslintrc => toolkit/components/ctypes/tests/chrome/.eslintrc.js
rename : toolkit/components/ctypes/tests/unit/.eslintrc => toolkit/components/ctypes/tests/unit/.eslintrc.js
rename : toolkit/components/downloads/test/unit/.eslintrc => toolkit/components/downloads/test/unit/.eslintrc.js
rename : toolkit/components/extensions/.eslintrc => toolkit/components/extensions/.eslintrc.js
rename : toolkit/components/extensions/test/mochitest/.eslintrc => toolkit/components/extensions/test/mochitest/.eslintrc.js
rename : toolkit/components/extensions/test/xpcshell/.eslintrc => toolkit/components/extensions/test/xpcshell/.eslintrc.js
rename : toolkit/components/feeds/test/.eslintrc => toolkit/components/feeds/test/.eslintrc.js
rename : toolkit/components/filepicker/test/unit/.eslintrc => toolkit/components/filepicker/test/unit/.eslintrc.js
rename : toolkit/components/filewatcher/tests/xpcshell/.eslintrc => toolkit/components/filewatcher/tests/xpcshell/.eslintrc.js
rename : toolkit/components/formautofill/test/browser/.eslintrc => toolkit/components/formautofill/test/browser/.eslintrc.js
rename : toolkit/components/formautofill/test/chrome/.eslintrc => toolkit/components/formautofill/test/chrome/.eslintrc.js
rename : toolkit/components/formautofill/test/xpcshell/.eslintrc => toolkit/components/formautofill/test/xpcshell/.eslintrc.js
rename : toolkit/components/jsdownloads/test/browser/.eslintrc => toolkit/components/jsdownloads/test/browser/.eslintrc.js
rename : toolkit/components/jsdownloads/test/data/.eslintrc => toolkit/components/jsdownloads/test/data/.eslintrc.js
rename : toolkit/components/jsdownloads/test/unit/.eslintrc => toolkit/components/jsdownloads/test/unit/.eslintrc.js
rename : toolkit/components/lz4/tests/xpcshell/.eslintrc => toolkit/components/lz4/tests/xpcshell/.eslintrc.js
rename : toolkit/components/mediasniffer/test/unit/.eslintrc => toolkit/components/mediasniffer/test/unit/.eslintrc.js
rename : toolkit/components/narrate/.eslintrc => toolkit/components/narrate/.eslintrc.js
rename : toolkit/components/narrate/test/.eslintrc => toolkit/components/narrate/test/.eslintrc.js
rename : toolkit/components/osfile/tests/mochi/.eslintrc => toolkit/components/osfile/tests/mochi/.eslintrc.js
rename : toolkit/components/osfile/tests/xpcshell/.eslintrc => toolkit/components/osfile/tests/xpcshell/.eslintrc.js
rename : toolkit/components/passwordmgr/.eslintrc => toolkit/components/passwordmgr/.eslintrc.js
rename : toolkit/components/passwordmgr/test/.eslintrc => toolkit/components/passwordmgr/test/.eslintrc.js
rename : toolkit/components/passwordmgr/test/browser/.eslintrc => toolkit/components/passwordmgr/test/browser/.eslintrc.js
rename : toolkit/components/passwordmgr/test/unit/.eslintrc => toolkit/components/passwordmgr/test/unit/.eslintrc.js
rename : toolkit/components/perf/.eslintrc => toolkit/components/perf/.eslintrc.js
rename : toolkit/components/perfmonitoring/tests/browser/.eslintrc => toolkit/components/perfmonitoring/tests/browser/.eslintrc.js
rename : toolkit/components/places/tests/.eslintrc => toolkit/components/places/tests/.eslintrc.js
rename : toolkit/components/places/tests/bookmarks/.eslintrc => toolkit/components/places/tests/bookmarks/.eslintrc.js
rename : toolkit/components/places/tests/browser/.eslintrc => toolkit/components/places/tests/browser/.eslintrc.js
rename : toolkit/components/places/tests/chrome/.eslintrc => toolkit/components/places/tests/chrome/.eslintrc.js
rename : toolkit/components/places/tests/expiration/.eslintrc => toolkit/components/places/tests/expiration/.eslintrc.js
rename : toolkit/components/places/tests/favicons/.eslintrc => toolkit/components/places/tests/favicons/.eslintrc.js
rename : toolkit/components/places/tests/history/.eslintrc => toolkit/components/places/tests/history/.eslintrc.js
rename : toolkit/components/places/tests/migration/.eslintrc => toolkit/components/places/tests/migration/.eslintrc.js
rename : toolkit/components/places/tests/network/.eslintrc => toolkit/components/places/tests/network/.eslintrc.js
rename : toolkit/components/places/tests/queries/.eslintrc => toolkit/components/places/tests/queries/.eslintrc.js
rename : toolkit/components/places/tests/unifiedcomplete/.eslintrc => toolkit/components/places/tests/unifiedcomplete/.eslintrc.js
rename : toolkit/components/places/tests/unit/.eslintrc => toolkit/components/places/tests/unit/.eslintrc.js
rename : toolkit/components/promiseworker/tests/xpcshell/.eslintrc => toolkit/components/promiseworker/tests/xpcshell/.eslintrc.js
rename : toolkit/components/prompts/test/.eslintrc => toolkit/components/prompts/test/.eslintrc.js
rename : toolkit/components/remotebrowserutils/tests/browser/.eslintrc => toolkit/components/remotebrowserutils/tests/browser/.eslintrc.js
rename : toolkit/components/satchel/test/.eslintrc => toolkit/components/satchel/test/.eslintrc.js
rename : toolkit/components/satchel/test/browser/.eslintrc => toolkit/components/satchel/test/browser/.eslintrc.js
rename : toolkit/components/satchel/test/unit/.eslintrc => toolkit/components/satchel/test/unit/.eslintrc.js
rename : toolkit/components/search/tests/xpcshell/.eslintrc => toolkit/components/search/tests/xpcshell/.eslintrc.js
rename : toolkit/components/social/test/xpcshell/.eslintrc => toolkit/components/social/test/xpcshell/.eslintrc.js
rename : toolkit/components/sqlite/tests/xpcshell/.eslintrc => toolkit/components/sqlite/tests/xpcshell/.eslintrc.js
rename : toolkit/components/startup/tests/browser/.eslintrc => toolkit/components/startup/tests/browser/.eslintrc.js
rename : toolkit/components/startup/tests/unit/.eslintrc => toolkit/components/startup/tests/unit/.eslintrc.js
rename : toolkit/components/telemetry/tests/unit/.eslintrc => toolkit/components/telemetry/tests/unit/.eslintrc.js
rename : toolkit/components/terminator/tests/xpcshell/.eslintrc => toolkit/components/terminator/tests/xpcshell/.eslintrc.js
rename : toolkit/components/thumbnails/test/.eslintrc => toolkit/components/thumbnails/test/.eslintrc.js
rename : toolkit/components/timermanager/tests/unit/.eslintrc => toolkit/components/timermanager/tests/unit/.eslintrc.js
rename : toolkit/components/url-classifier/tests/mochitest/.eslintrc => toolkit/components/url-classifier/tests/mochitest/.eslintrc.js
rename : toolkit/components/url-classifier/tests/unit/.eslintrc => toolkit/components/url-classifier/tests/unit/.eslintrc.js
rename : toolkit/components/urlformatter/tests/unit/.eslintrc => toolkit/components/urlformatter/tests/unit/.eslintrc.js
rename : toolkit/components/viewsource/test/.eslintrc => toolkit/components/viewsource/test/.eslintrc.js
rename : toolkit/components/viewsource/test/browser/.eslintrc => toolkit/components/viewsource/test/browser/.eslintrc.js
rename : toolkit/components/workerloader/tests/.eslintrc => toolkit/components/workerloader/tests/.eslintrc.js
rename : toolkit/components/xulstore/tests/chrome/.eslintrc => toolkit/components/xulstore/tests/chrome/.eslintrc.js
rename : toolkit/components/xulstore/tests/xpcshell/.eslintrc => toolkit/components/xulstore/tests/xpcshell/.eslintrc.js
rename : toolkit/content/tests/browser/.eslintrc => toolkit/content/tests/browser/.eslintrc.js
rename : toolkit/content/tests/chrome/.eslintrc => toolkit/content/tests/chrome/.eslintrc.js
rename : toolkit/content/tests/unit/.eslintrc => toolkit/content/tests/unit/.eslintrc.js
rename : toolkit/content/tests/widgets/.eslintrc => toolkit/content/tests/widgets/.eslintrc.js
rename : toolkit/crashreporter/test/browser/.eslintrc => toolkit/crashreporter/test/browser/.eslintrc.js
rename : toolkit/crashreporter/test/unit/.eslintrc => toolkit/crashreporter/test/unit/.eslintrc.js
rename : toolkit/crashreporter/test/unit_ipc/.eslintrc => toolkit/crashreporter/test/unit_ipc/.eslintrc.js
rename : toolkit/forgetaboutsite/test/browser/.eslintrc => toolkit/forgetaboutsite/test/browser/.eslintrc.js
rename : toolkit/forgetaboutsite/test/unit/.eslintrc => toolkit/forgetaboutsite/test/unit/.eslintrc.js
rename : toolkit/identity/tests/chrome/.eslintrc => toolkit/identity/tests/chrome/.eslintrc.js
rename : toolkit/identity/tests/unit/.eslintrc => toolkit/identity/tests/unit/.eslintrc.js
rename : toolkit/modules/addons/.eslintrc => toolkit/modules/addons/.eslintrc.js
rename : toolkit/modules/subprocess/.eslintrc => toolkit/modules/subprocess/.eslintrc.js
rename : toolkit/modules/subprocess/test/xpcshell/.eslintrc => toolkit/modules/subprocess/test/xpcshell/.eslintrc.js
rename : toolkit/modules/tests/browser/.eslintrc => toolkit/modules/tests/browser/.eslintrc.js
rename : toolkit/modules/tests/chrome/.eslintrc => toolkit/modules/tests/chrome/.eslintrc.js
rename : toolkit/modules/tests/mochitest/.eslintrc => toolkit/modules/tests/mochitest/.eslintrc.js
rename : toolkit/modules/tests/xpcshell/.eslintrc => toolkit/modules/tests/xpcshell/.eslintrc.js
rename : toolkit/mozapps/downloads/tests/chrome/.eslintrc => toolkit/mozapps/downloads/tests/chrome/.eslintrc.js
rename : toolkit/mozapps/downloads/tests/unit/.eslintrc => toolkit/mozapps/downloads/tests/unit/.eslintrc.js
rename : toolkit/mozapps/extensions/.eslintrc => toolkit/mozapps/extensions/.eslintrc.js
rename : toolkit/mozapps/extensions/test/browser/.eslintrc => toolkit/mozapps/extensions/test/browser/.eslintrc.js
rename : toolkit/mozapps/extensions/test/mochitest/.eslintrc => toolkit/mozapps/extensions/test/mochitest/.eslintrc.js
rename : toolkit/mozapps/extensions/test/xpcshell/.eslintrc => toolkit/mozapps/extensions/test/xpcshell/.eslintrc.js
rename : toolkit/mozapps/extensions/test/xpinstall/.eslintrc => toolkit/mozapps/extensions/test/xpinstall/.eslintrc.js
rename : toolkit/mozapps/update/tests/chrome/.eslintrc => toolkit/mozapps/update/tests/chrome/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_aus_update/.eslintrc => toolkit/mozapps/update/tests/unit_aus_update/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_base_updater/.eslintrc => toolkit/mozapps/update/tests/unit_base_updater/.eslintrc.js
rename : toolkit/mozapps/update/tests/unit_service_updater/.eslintrc => toolkit/mozapps/update/tests/unit_service_updater/.eslintrc.js
rename : toolkit/profile/test/.eslintrc => toolkit/profile/test/.eslintrc.js
rename : toolkit/themes/osx/mochitests/.eslintrc => toolkit/themes/osx/mochitests/.eslintrc.js
rename : toolkit/xre/test/.eslintrc => toolkit/xre/test/.eslintrc.js
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc.js
extra : rebase_source : 60affc4b9bf436bba7e0e21a8da3a85d16c9fc06
2016-10-18 08:38:10 +01:00
Tooru Fujisawa a274ab4345 Bug 1290337 - Part 20: Replace Value parameter to const Value& in storage. r=mak 2016-09-11 18:21:36 +09:00
Tooru Fujisawa 6d493d48ec Bug 1289050 - Part 1: Use ASCII variant of JS_ReportError in simple case. r=jwalden 2016-08-14 20:39:28 +09:00
Thomas Wisniewski ba6cb5196e Bug 1305202 - Use NullString() more and remove superfluous Truncates(). r=smaug 2016-09-23 21:10:01 -04:00
Gijs Kruitbosch ae4301ef96 Bug 1285041 - ignore locking when trying to read chrome DB file, r=mak
MozReview-Commit-ID: 89f0YCxxgC8

--HG--
extra : rebase_source : 53efa0f0258728df54fc17a773cbf74c712b51e4
2016-07-18 16:46:45 +01:00
Phil Ringnalda 7287d4600d Backed out changeset ef7939c0332e (bug 1285041) for failures in test_storage_connection.js
CLOSED TREE
2016-09-15 20:04:30 -07:00
Gijs Kruitbosch fff8403f8a Bug 1285041 - ignore locking when trying to read chrome DB file, r=mak
MozReview-Commit-ID: 89f0YCxxgC8

--HG--
extra : rebase_source : be3ee58b00b4c8ae6ec41db9459f50abdce816f6
2016-07-18 16:46:45 +01:00
Michael Layzell 60651a924f Bug 1301127 - Make nsNavHistoryFolderResultNode QueryInterface to mozIStorageStatementCallback, r=smaug
MozReview-Commit-ID: 5CPNIz3w4Iy
2016-09-07 14:46:27 -04:00
Michael Layzell 4da0c5f485 Bug 1301124 - Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run(), r=smaug
MozReview-Commit-ID: 28K4VmKoqgO
2016-09-07 13:29:17 -04:00
Michael Layzell 36e08437d0 Bug 1018486 - Part 8: Various other changes, r=smaug
MozReview-Commit-ID: B0dsomkWgEk
2016-09-07 10:50:45 -04:00
Nicholas Nethercote b71747b2ac Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.

--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Nicholas Nethercote c2306345d5 Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.

The patch also does some associated clean-up.

- Replaces some uses of nsIMemoryReporterCallback with the preferred
  nsIHandleReportCallback typedef.

- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
  parameter names, for consistency.

- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.

- Uses the MOZ_COLLECT_REPORT macro in all suitable places.

Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.

--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
2016-08-24 15:23:45 +10:00
Kan-Ru Chen b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Akshay CV dbb1f7d62f Bug 1296182 - Replace PR_Abort() with MOZ_CRASH("SQLite Version Error"). r=asuth 2016-08-23 21:36:24 -07:00
Nicholas Nethercote bab6d17ebf Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj.
This patch makes the following changes on many in-class methods.

- NS_IMETHODIMP F() override;      --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final;         --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...}    --> NS_IMETHOD F() final {...}

Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.

--HG--
extra : rebase_source : 386ee4e4ea2ecd8d5001efabc3ac87b4d6c0659f
2016-08-08 10:54:47 +10:00
Nicholas Nethercote e7f10a07fd Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.

--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
Tom Tromey 5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Thomas Zimmermann 67abb05afa Bug 1287739: Always set 'len' variable in storage test, r=mak
MozReview-Commit-ID: 8EpGeakICWY
2016-07-20 16:12:31 +02:00
Chris Peterson 43c2748f66 Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj 2016-07-08 14:39:53 -07:00
Marco Bonardo 949197fdb7 Bug 1283083 - Cloning a connection should re-attach databases to the clone. r=asuth
MozReview-Commit-ID: CSZqvJNWthB

--HG--
extra : rebase_source : 9213a9e73052e7d87cf12c64af2ad1a15496ace1
2016-06-29 17:33:15 +02:00
Aidin Gharibnavaz 523608513b Bug 1247972 - specialize NS_ProxyRelease for nsISupports to be out-of-line; r=erahm
NS_ProxyRelease's current implementation requires a lot of code.  We can
reduce the impact of this by providing an out-of-line implementation for
classes based on nsISupports.  This change reduces codesize by ~60K on
a Linux x86-64 build.
2016-06-29 18:56:41 -04:00
Chris Peterson 6a5ea85fa5 Bug 1278468 - Fix -Wshadow warnings in storage/ directory. r=mak
storage/TelemetryVFS.cpp:81:44 [-Wshadow] declaration shadows a field of '(anonymous namespace)::IOThreadAutoTimer'
storage/VacuumManager.cpp:192:25 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:248:13 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:249:14 [-Wshadow] declaration shadows a local variable
storage/VacuumManager.cpp:251:19 [-Wshadow] declaration shadows a local variable
storage/mozStorageConnection.cpp:971:15 [-Wshadow] declaration shadows a local variable
storage/mozStorageStatement.cpp:449:19 [-Wshadow] declaration shadows a local variable
storage/variantToSQLiteT_impl.h:97:16 [-Wshadow] declaration shadows a local variable

--HG--
extra : rebase_source : 4e966f23ff352b6f8ea8e992278ab8a952c69e01
2016-06-07 22:08:41 -07:00
Chris Peterson 8a9e2d2bd4 Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium 2016-05-14 00:54:55 -07:00
Chris Peterson 353ee65255 Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium 2016-05-11 00:00:01 -07:00
Randell Jesup 477adfcd7e Bug 1271514: clean up threads in test_unlock_notify r=froydnj
MozReview-Commit-ID: EbCnWFzLMca
2016-05-11 00:09:53 -04:00
Kyle Huey 941ab1f522 Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-05-05 01:45:00 -07:00
Carsten "Tomcat" Book ba3fe0975c Backed out changeset 85ce8cb0639a (bug 1268313)
--HG--
extra : rebase_source : 56d1cf41a2dc4959b67f834e07192a5c772176a8
2016-04-29 14:21:16 +02:00
Kyle Huey 48a594a09e Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-04-28 14:08:25 -07:00
Kyle Huey c73656947b Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
Kyle Huey d9265a3eaf Bug 1259294: Part 2 - Use MOZ_ALWAYS_SUCCEEDS. r=froydnj 2016-03-28 10:28:15 -07:00
Jan Varga 7bb929b877 Bug 1182987 - Part 2: Add getQuotaObjects() to mozIStorageConnection; r=mak 2016-03-15 07:00:28 +01:00
Ted Mielczarek 68bd5e8c4d bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r=gps
MozReview-Commit-ID: 9ip3qeAXFEe

--HG--
extra : commitid : H6aEkHprVyX
extra : rebase_source : e20d5f4b297caf66711c72cd55dd76f7f9ef9d9c
extra : histedit_source : 47545e0ea61eb66f16545f70e6d3792a389bedb1
2016-02-01 10:49:34 -05:00
sajitk 823704b8d6 Bug 1219482: Replace PRLogModuleInfo with LazyLogModule in various files.r=benjamin 2016-01-28 10:35:00 -08:00
Jonathan Watt ccf5c4c6dc Bug 1253094, part 7 - Stop using DebugOnly for class/struct members in storage/. r=mak
MozReview-Commit-ID: 72nH7FVfUtZ
2016-02-26 15:52:08 +00:00
Xidorn Quan 2ad2ca17e9 Bug 1248757 followup - Release blob after assignment in DoGetBlobAsString on CLOSED TREE.
MozReview-Commit-ID: HOsMvsjBJKF

--HG--
extra : source : cac755e67ad9739d72f78a184f20bafd845e514f
2016-02-17 11:57:59 +08:00
Ben Kelly 124248a8ad Bug 1248757 Use string ::Assign() instead of Adopt() when reading blobs as strings. r=asuth 2016-02-16 14:32:00 -08:00
Carsten "Tomcat" Book b1eedbe899 Merge mozilla-central to mozilla-inbound 2016-02-11 11:56:20 +01:00
Jeffrey Tran f139fb05d8 Bug 1230685 - Replace function declarations with add_task statements in test_storage_value_array.js and test_unicode.js. r=mak
--HG--
extra : commitid : GaYkxxYU4Yj
2016-02-10 15:30:34 +01:00
Jeffrey Tran 1a2bff1271 Bug 1230683 - Replace try/catch with Assert.throws in test_storage_connection.js. r=mak
--HG--
extra : commitid : CevJdrYql4m
2016-02-10 15:30:28 +01:00
Dave Townsend 0a6414b898 Bug 1245649: Turn on no-trailing-spaces. r=Gijs
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
2016-02-03 14:22:33 -08:00
Birunthan Mohanathas d7371d07d0 Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-02-02 17:36:30 +02:00
Aidin Gharibnavaz 686438c658 Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley 2016-02-10 08:23:00 +01:00
Carsten "Tomcat" Book 5b358688b7 Backed out changeset c18e29c1b369 (bug 1164581) for cpp unit tests test failures
--HG--
extra : rebase_source : fb6fd434c8e3f4b5fa53ea645a54c07cab207894
2016-02-08 11:17:38 +01:00
Aidin Gharibnavaz 69cf7e035f Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
--HG--
extra : rebase_source : 3c6bba6613a14e48239d302bdd0f7fe2e322265d
2016-02-07 10:56:00 +01:00
Phil Ringnalda d381b4bca6 Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
CLOSED TREE

Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas 373593275e Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-01-31 17:12:12 +02:00
Wes Kocher b9d77f5943 Backed out changeset 2c56aed63687 (bug 1219482) to hopefully fix the intermittent hazard failures CLOSED TREE
--HG--
extra : commitid : 7egFNnxx2ut
2016-01-29 10:15:38 -08:00
sajitk 6fdb9b782e Bug 1219482 - Replace PRLogModuleInfo with LazyLogModule in various files. r=bsmedberg
--HG--
extra : rebase_source : 37e8f53a8aa5242058ab8fc867804cbc8940653e
2016-01-28 10:35:00 -05:00
Carsten "Tomcat" Book 323b54c218 merge mozilla-inbound to mozilla-central a=merge 2016-01-28 12:13:37 +01:00
Nicholas Nethercote d8dd426798 Bug 1187141 - Replace nsBaseHashtable::Enumerate() calls in storage/ with iterators. r=mak. 2016-01-24 18:09:12 -08:00
Jeffrey Tran c601fe0a05 Bug 555087 - Add check for exception when passing undefined parameter. r=adw 2016-01-20 16:37:00 +01:00
Dave Townsend 9b1de02e15 Bug 1239354: Replace old-style generator function with star functions. r=asuth
--HG--
extra : rebase_source : e932378aaf2d08a1ff3b096cdb5770c139c93979
2016-01-13 08:58:15 -08:00
Andrew Sutherland debfaf45f7 Bug 1237601 - Perform storage close synchronously if async thread cannot be started. r=bkelly
Also factors asyncClose tests out into their own file.
2016-01-07 11:18:00 -05:00
Andrew Sutherland 896d9d7315 Bug 1237601 - Centralize storage xpcshell promise helpers (support patch). r=bkelly 2016-01-12 17:27:33 -05:00
Andrea Marchesini caa2f9b456 Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug 2016-01-12 18:16:59 +00:00
Carsten "Tomcat" Book 3589aeeb8a Backed out changeset d6b0ffe1a7b3 (bug 1231378) 2016-01-12 15:48:54 +01:00
Andrea Marchesini 2609a149da Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug 2016-01-12 13:57:37 +00:00
Chris Peterson c0fb08917c Bug 1235237 - Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in storage/. r=mak
storage/mozStoragePrivateHelpers.cpp:234:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-11-22 22:09:23 -08:00
Nicholas Nethercote ec89bbf7f2 Bug 1237151 (part 3) - Remove ignored qualifiers in all remaining code. r=froydnj. 2016-01-05 17:08:45 -08:00
Marco Bonardo 1006b4755f Bug 1230549 - Storage should pass more eslint rules. r=yoric
--HG--
extra : commitid : 9FE8bR3AhsJ
extra : rebase_source : 1d65cc419e9375facb1dc7265e05ee84195153e7
2015-12-04 17:00:03 +01:00
Marco Bonardo 4190a83115 Bug 1230549 - Make Storage pass basic eslint. r=yoric
--HG--
rename : browser/.eslintrc => storage/.eslintrc
extra : commitid : 5RiWGmPFkg2
extra : rebase_source : 54b8a2e9680c37d88c0a501d85422163f4e04fea
2015-12-04 15:52:43 +01:00
Nathan Froyd 8a2948e596 Bug 1225923 - part 1 - convert all needs-to-copy instances of AppendElement(nsDependentString(...)); r=erahm
When people write:

  array.AppendElement(nsDependentString(...));

(resp. nsDependentCString), it's not clear whether they expect the newly
constructed dependent string to live in the array, or whether they're
just making a nsString-like holder whose contents can be freely copied
into the array's newly-created nsString.  Sometimes the latter is what
you prefer, and sometimes the former.  In all cases, however, the latter
behavior is what you get.

Let's try to make that behavior more explicit by pre-constructing
nsString elements and then using Assign to show that copying is taking
place.  This patch involves no functional change in behavior (it ought
to be epsilon faster due to using AppendElements, rather than repeatedly
calling AppendElement).
2015-11-18 10:25:19 -05:00
Nicholas Nethercote 8eb10da71a Bug 1186791 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
--HG--
extra : rebase_source : 8fc71420355baa87b63f6c9c817a27395272cb33
2015-10-29 16:43:34 -07:00
Nicholas Nethercote acb6e8f1f1 Bug 1186791 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
--HG--
extra : rebase_source : defddc0f2e490b5b1b41fd71bebedfc8b31a35bb
2015-10-29 16:04:42 -07:00
Nicholas Nethercote 23e7f15036 Bug 1186791 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.
--HG--
extra : rebase_source : 5781d353bec6bef4b96a6f4f6c734e10594b5643
2015-10-29 16:04:41 -07:00
Nathan Froyd 4bc7fd6e21 Bug 1219238 - remove AutoArray from mozStorageSQLFunctions.cpp; r=mak
nsAutoTArray is practically the same thing; we should just use that and
avoid code duplications.
2015-10-27 21:22:52 -04:00
Tooru Fujisawa 6fc0b6a576 Bug 1217982 - Remove for-each from storage/. r=mak
--HG--
extra : commitid : JkK4BJvCHax
extra : rebase_source : add04bcdd5f6400e8d20f9fdcd3ce57f48fabae1
2015-10-19 03:53:14 +09:00
Nathan Froyd 01583602a9 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi

--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Eric Rahm 1874580339 Bug 1194023 - Part 2: Only check for sort operations if mozStorage logging is enabled. r=mak 2015-09-25 16:33:22 -07:00
Eric Rahm af00644989 Bug 1194023 - Part 1: Filter out warnings about sort operations on CREATE INDEX statements. r=mak 2015-09-25 15:27:48 -07:00
Tooru Fujisawa ee9f17192c Bug 1207499 - Part 9: Remove use of expression closure from storage/. r=mak
--HG--
extra : commitid : CuirUjswj0A
extra : rebase_source : 4368bcee9edccffb48a99a154b13e4625c20d263
2015-09-23 18:42:19 +09:00
Jeff Walden 4046fe1490 Bug 1179003 - Convert the infallible objectClassIs proxy hook into a fallible getBuiltinClass hook that indicates class type via outparam. r=efaust, r=bz on DOM bits, r=billm on IPC bits
--HG--
extra : rebase_source : 6ddc3727c411fdfced6338e5e383a10572575f0f
2015-08-28 21:55:40 -07:00
Andrew McCreight 5446225d17 Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
This leaves alone the AppendElement methods.
2015-09-15 15:30:44 -07:00
Shu-yu Guo 64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Nicholas Nethercote f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Chris Peterson 1416e566de Bug 1198124 - Enable -Wshadow in directories that have no -Wshadow warnings. r=glandium 2015-08-25 09:14:38 -07:00
Nathan Froyd ca51445d31 Bug 1193022 - clean up reference-counting in storage/; r=mak 2015-07-01 13:11:11 -04:00
Marco Bonardo 3d559535cd bug 1189896 - Do not preallocate Sqlite connections caches for now. r=asuth
--HG--
extra : commitid : 9m1uRdbBAxX
2015-08-05 21:54:20 +02:00
Jan de Mooij 9d74419a90 Bug 1184564 part 2 - Use Value instead of jsval in dom/ and storage/. r=bz 2015-07-18 21:45:35 +02:00
Birunthan Mohanathas a8939590de Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Juan Gomez 258ad59e3f Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 2015-07-03 18:29:00 -07:00
Andrew McCreight 53e8d2ac49 Bug 958641 - De-holder nsIXPConnect::WrapNative. r=gabor 2015-07-01 11:17:17 -07:00
Jan de Mooij 303b210317 Bug 1177892 part 3 - Remove OBJECT_TO_JSVAL. r=evilpie 2015-06-30 21:09:46 -07:00
Jan de Mooij 155b1afd35 Bug 1177892 part 1 - Remove BOOLEAN_TO_JSVAL and STRING_TO_JSVAL. r=evilpie 2015-06-30 11:20:56 -07:00
Ryan VanderMeulen 7483c0563e Backed out changesets ad58c270ce87 and 849151330d60 (bug 1177892) for B2G bustage.
CLOSED TREE
2015-06-30 15:48:11 -04:00
Jan de Mooij 731f441d6e Bug 1177892 part 1 - Remove BOOLEAN_TO_JSVAL and STRING_TO_JSVAL. r=evilpie
--HG--
extra : rebase_source : f7ae63c351c82516e7db48a12c4cfb2048a81805
2015-06-30 11:20:56 -07:00
Jan Varga baba1643c1 Bug 1130775 - Convert synchronized ops and storage registration into unified directory locks; r=bent
--HG--
rename : dom/quota/OriginOrPatternString.h => dom/quota/OriginScope.h
2015-06-30 14:59:27 +02:00
Jan de Mooij 976586cb5f Bug 1177825 - Remove JSVAL_* constants. r=evilpie 2015-06-29 18:36:44 -07:00
Ryan VanderMeulen 5f5c327690 Backed out changeset 8b4e4083639e (bug 1171931) for B2G debug emulator bustage. 2015-06-25 19:48:42 -04:00
Juan Gomez 702a59d135 Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj
--HG--
extra : rebase_source : 2ecbe6c1dd8a7ad8dc529b53349ad431cf1116c9
2015-06-24 14:11:00 -04:00
Ben Turner e4ac5e1134 Bug 1149815 - Pass storage function failure codes through to callers, r=asuth. 2015-06-20 09:08:20 -07:00
Eric Rahm 75c4bebb79 Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-03 15:25:57 -07:00
Eric Rahm f50b813989 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-03 15:22:28 -07:00
Carsten "Tomcat" Book 5471309381 Backed out 14 changesets (bug 1165515) for linux x64 e10s m2 test failures
Backed out changeset d68dcf2ef372 (bug 1165515)
Backed out changeset 7c3b45a47811 (bug 1165515)
Backed out changeset b668b617bef2 (bug 1165515)
Backed out changeset d0916e1283a2 (bug 1165515)
Backed out changeset ac4dc7489942 (bug 1165515)
Backed out changeset e9632ce8bc65 (bug 1165515)
Backed out changeset c16d215cc7e4 (bug 1165515)
Backed out changeset e4d474f3c51a (bug 1165515)
Backed out changeset d87680bf9f7c (bug 1165515)
Backed out changeset b3c0a45ba99e (bug 1165515)
Backed out changeset 9370fa197674 (bug 1165515)
Backed out changeset 50970d668ca1 (bug 1165515)
Backed out changeset ffa4eb6d24b9 (bug 1165515)
Backed out changeset 5fcf1203cc1d (bug 1165515)

--HG--
extra : rebase_source : 6fb850d063cbabe738f97f0380302153e3eae97a
2015-06-02 13:05:56 +02:00
Eric Rahm a9afd68cef Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 22:17:33 -07:00
Eric Rahm 141e0ff4a2 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-01 22:17:19 -07:00
Wes Kocher 4e9f80ed2e Backed out 14 changesets (bug 1165515) for b2g mochitest-6 permafail CLOSED TREE
Backed out changeset 9b97e2aa2ed9 (bug 1165515)
Backed out changeset 150606c022a2 (bug 1165515)
Backed out changeset 4e875a488349 (bug 1165515)
Backed out changeset 467e7feeb546 (bug 1165515)
Backed out changeset d6b6cc373197 (bug 1165515)
Backed out changeset 0615265b593c (bug 1165515)
Backed out changeset fafd1dce9f08 (bug 1165515)
Backed out changeset d1df869245f9 (bug 1165515)
Backed out changeset 6876a7c63611 (bug 1165515)
Backed out changeset b7841c94a9a3 (bug 1165515)
Backed out changeset e5e3617f7c73 (bug 1165515)
Backed out changeset 39be3db95978 (bug 1165515)
Backed out changeset 0ec74176f8de (bug 1165515)
Backed out changeset 5b928dd10d71 (bug 1165515)
2015-06-01 17:57:58 -07:00
Eric Rahm f82c0e7caf Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 14:31:01 -07:00
Eric Rahm dc090e3fe5 Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj 2015-06-01 14:31:00 -07:00
Birunthan Mohanathas 470bd9148f Bug 968520 - Add mozilla::fallible to FallibleTArray::AppendElements calls. r=froydnj 2015-05-28 11:07:43 -07:00
Jason Orendorff 112cb52d91 Bug 1140482 - Add JSPROP_RESOLVING. Give NativeDefineProperty standard behavior in cases where a non-resolving define needs to trigger a resolve hook. r=Waldo.
--HG--
extra : rebase_source : c63bb83179ec98e9f93ebb86cb488d65f980a07e
2015-05-01 14:03:17 -05:00
Wes Kocher 72a315a1e1 Backed out changeset 6435d5aab611 (bug 858680) 2015-05-21 16:44:38 -07:00
Eric Rahm 3925a960aa Bug 1165515 - Part 1: Convert PR_LOG to MOZ_LOG. r=froydnj 2015-05-21 13:22:04 -07:00
Ben Turner c769c6825d Bug 858680 - Part 3: Allow mozStorage to access the dbstats virtual table, r=asuth.
--HG--
extra : rebase_source : 250bc47337695abb09e926fb8a21e5df72724fe4
2015-04-30 16:30:57 -07:00
Ben Turner af31caeec8 Bug 1162176, Part 1. r=mak.
--HG--
extra : rebase_source : c980220594475e8c8654802466f9376a11fed616
2015-05-19 09:17:10 -07:00
Birunthan Mohanathas 296aa63730 Bug 1164717 - Flatten storage/src/ directory. r=mak
--HG--
rename : storage/src/FileSystemModule.cpp => storage/FileSystemModule.cpp
rename : storage/src/FileSystemModule.h => storage/FileSystemModule.h
rename : storage/src/IStorageBindingParamsInternal.h => storage/IStorageBindingParamsInternal.h
rename : storage/src/SQLCollations.cpp => storage/SQLCollations.cpp
rename : storage/src/SQLCollations.h => storage/SQLCollations.h
rename : storage/src/SQLiteMutex.h => storage/SQLiteMutex.h
rename : storage/src/StorageBaseStatementInternal.cpp => storage/StorageBaseStatementInternal.cpp
rename : storage/src/StorageBaseStatementInternal.h => storage/StorageBaseStatementInternal.h
rename : storage/src/TelemetryVFS.cpp => storage/TelemetryVFS.cpp
rename : storage/src/VacuumManager.cpp => storage/VacuumManager.cpp
rename : storage/src/VacuumManager.h => storage/VacuumManager.h
rename : storage/src/Variant.h => storage/Variant.h
rename : storage/src/Variant_inl.h => storage/Variant_inl.h
rename : storage/src/mozStorageArgValueArray.cpp => storage/mozStorageArgValueArray.cpp
rename : storage/src/mozStorageArgValueArray.h => storage/mozStorageArgValueArray.h
rename : storage/src/mozStorageAsyncStatement.cpp => storage/mozStorageAsyncStatement.cpp
rename : storage/src/mozStorageAsyncStatement.h => storage/mozStorageAsyncStatement.h
rename : storage/src/mozStorageAsyncStatementExecution.cpp => storage/mozStorageAsyncStatementExecution.cpp
rename : storage/src/mozStorageAsyncStatementExecution.h => storage/mozStorageAsyncStatementExecution.h
rename : storage/src/mozStorageAsyncStatementJSHelper.cpp => storage/mozStorageAsyncStatementJSHelper.cpp
rename : storage/src/mozStorageAsyncStatementJSHelper.h => storage/mozStorageAsyncStatementJSHelper.h
rename : storage/src/mozStorageAsyncStatementParams.cpp => storage/mozStorageAsyncStatementParams.cpp
rename : storage/src/mozStorageAsyncStatementParams.h => storage/mozStorageAsyncStatementParams.h
rename : storage/src/mozStorageBindingParams.cpp => storage/mozStorageBindingParams.cpp
rename : storage/src/mozStorageBindingParams.h => storage/mozStorageBindingParams.h
rename : storage/src/mozStorageBindingParamsArray.cpp => storage/mozStorageBindingParamsArray.cpp
rename : storage/src/mozStorageBindingParamsArray.h => storage/mozStorageBindingParamsArray.h
rename : storage/src/mozStorageConnection.cpp => storage/mozStorageConnection.cpp
rename : storage/src/mozStorageConnection.h => storage/mozStorageConnection.h
rename : storage/src/mozStorageError.cpp => storage/mozStorageError.cpp
rename : storage/src/mozStorageError.h => storage/mozStorageError.h
rename : storage/src/mozStoragePrivateHelpers.cpp => storage/mozStoragePrivateHelpers.cpp
rename : storage/src/mozStoragePrivateHelpers.h => storage/mozStoragePrivateHelpers.h
rename : storage/src/mozStorageResultSet.cpp => storage/mozStorageResultSet.cpp
rename : storage/src/mozStorageResultSet.h => storage/mozStorageResultSet.h
rename : storage/src/mozStorageRow.cpp => storage/mozStorageRow.cpp
rename : storage/src/mozStorageRow.h => storage/mozStorageRow.h
rename : storage/src/mozStorageSQLFunctions.cpp => storage/mozStorageSQLFunctions.cpp
rename : storage/src/mozStorageSQLFunctions.h => storage/mozStorageSQLFunctions.h
rename : storage/src/mozStorageService.cpp => storage/mozStorageService.cpp
rename : storage/src/mozStorageService.h => storage/mozStorageService.h
rename : storage/src/mozStorageStatement.cpp => storage/mozStorageStatement.cpp
rename : storage/src/mozStorageStatement.h => storage/mozStorageStatement.h
rename : storage/src/mozStorageStatementData.h => storage/mozStorageStatementData.h
rename : storage/src/mozStorageStatementJSHelper.cpp => storage/mozStorageStatementJSHelper.cpp
rename : storage/src/mozStorageStatementJSHelper.h => storage/mozStorageStatementJSHelper.h
rename : storage/src/mozStorageStatementParams.cpp => storage/mozStorageStatementParams.cpp
rename : storage/src/mozStorageStatementParams.h => storage/mozStorageStatementParams.h
rename : storage/src/mozStorageStatementRow.cpp => storage/mozStorageStatementRow.cpp
rename : storage/src/mozStorageStatementRow.h => storage/mozStorageStatementRow.h
rename : storage/src/variantToSQLiteT_impl.h => storage/variantToSQLiteT_impl.h
2015-05-19 10:47:33 -07:00
Birunthan Mohanathas 11f2166660 Bug 1164717 - Flatten storage/public/ directory. r=mak
--HG--
rename : storage/public/StatementCache.h => storage/StatementCache.h
rename : storage/public/mozIStorageAggregateFunction.idl => storage/mozIStorageAggregateFunction.idl
rename : storage/public/mozIStorageAsyncConnection.idl => storage/mozIStorageAsyncConnection.idl
rename : storage/public/mozIStorageAsyncStatement.idl => storage/mozIStorageAsyncStatement.idl
rename : storage/public/mozIStorageBaseStatement.idl => storage/mozIStorageBaseStatement.idl
rename : storage/public/mozIStorageBindingParams.idl => storage/mozIStorageBindingParams.idl
rename : storage/public/mozIStorageBindingParamsArray.idl => storage/mozIStorageBindingParamsArray.idl
rename : storage/public/mozIStorageCompletionCallback.idl => storage/mozIStorageCompletionCallback.idl
rename : storage/public/mozIStorageConnection.idl => storage/mozIStorageConnection.idl
rename : storage/public/mozIStorageError.idl => storage/mozIStorageError.idl
rename : storage/public/mozIStorageFunction.idl => storage/mozIStorageFunction.idl
rename : storage/public/mozIStoragePendingStatement.idl => storage/mozIStoragePendingStatement.idl
rename : storage/public/mozIStorageProgressHandler.idl => storage/mozIStorageProgressHandler.idl
rename : storage/public/mozIStorageResultSet.idl => storage/mozIStorageResultSet.idl
rename : storage/public/mozIStorageRow.idl => storage/mozIStorageRow.idl
rename : storage/public/mozIStorageService.idl => storage/mozIStorageService.idl
rename : storage/public/mozIStorageStatement.idl => storage/mozIStorageStatement.idl
rename : storage/public/mozIStorageStatementCallback.idl => storage/mozIStorageStatementCallback.idl
rename : storage/public/mozIStorageStatementParams.idl => storage/mozIStorageStatementParams.idl
rename : storage/public/mozIStorageStatementRow.idl => storage/mozIStorageStatementRow.idl
rename : storage/public/mozIStorageVacuumParticipant.idl => storage/mozIStorageVacuumParticipant.idl
rename : storage/public/mozIStorageValueArray.idl => storage/mozIStorageValueArray.idl
rename : storage/public/mozStorageHelper.h => storage/mozStorageHelper.h
rename : storage/public/storage.h => storage/storage.h
2015-05-19 10:47:29 -07:00
Birunthan Mohanathas 07e65dcc8f Bug 1165731 - Remove unnecessary SetCapacity call in variant_storage_traits::storage_conversion. r=mak 2015-05-19 10:47:25 -07:00
Eric Rahm 4879ae86f4 Bug 1165518 - Part 2: Replace prlog.h with Logging.h. rs=froydnj 2015-05-19 11:15:34 -07:00
Ryan VanderMeulen 87a9bf8ffd Backed out changesets ba117e790ece and e183bcc18cd3 (bug 1162176) for bustage.
CLOSED TREE
2015-05-19 13:17:01 -04:00
Ben Turner 737bc42a61 Bug 1162176, Part 1. r=mak.
--HG--
extra : rebase_source : 80b7c35704b2a1250ffb5936f367baf6ab424294
2015-05-19 09:17:10 -07:00
Eric Rahm 45167dace5 Bug 1164559 - Part 2: Wrap expensive calls in PR_LOG_TEST. r=froydnj 2015-05-14 10:13:24 -07:00
Eric Rahm 8211d94335 Bug 1164559 - Part 1: Remove instances of #ifdef PR_LOGGING in storage. r=froydnj
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-14 10:13:24 -07:00
Mike Hommey 924c9eb636 Bug 1134923 - Remove NS_Alloc/NS_Realloc/NS_Free. r=nfroyd
They are kept around for the sake of the standalone glue, which is used
for e.g. webapprt, which doesn't have direct access to jemalloc, and thus
still needs a wrapper to go through the xpcom function list and get to
jemalloc from there.
2015-05-01 09:40:30 +09:00
Wes Kocher 10fec54e1c Merge fx-team to m-c a=merge CLOSED TREE 2015-04-29 16:46:00 -07:00
Ben Kelly 81dce6f7c5 Bug 1154325 P1 Add convenience routines to bind and get Blobs as strings. r=asuth 2015-04-29 09:03:15 -07:00
Marco Bonardo 7fea255279 Bug 1159303 - Reduce noise due to sort operations warnings. r=bent 2015-04-28 22:35:48 +02:00
Andrea Marchesini ade2831035 Bug 1156632 - Remove unused forward class declarations - patch 6 - the rest of the tree, r=ehsan 2015-04-22 08:29:24 +02:00
Denis Volk 32e981896d Bug 1095098 - move do_QueryObject templates into their own header; r=froydnj 2015-04-15 12:47:03 -04:00
Ben Kelly 38cbbf3fb9 Bug 1155193 Proxy release the Connection in mozStorageService::unregisterConnection(). r=asuth 2015-04-16 19:12:36 -07:00
Marco Bonardo 9239599394 Bug 1149373 - Ensure mozStorage async threads are shut down. r=bent 2015-04-14 16:11:54 +02:00
Chirag Bhatia 8f1a6fdc91 Bug 1067054 - Remove generic SQLITE_ERROR warning & suppress warning if transaction exists. r=mak
--HG--
extra : rebase_source : 126e1918f828eef3374968cde8ca394a0f856376
2015-04-10 13:16:00 +02:00
Ben Turner 630eacc28d Bug 1131776 - Use WITHOUT ROWID tables for IndexedDB, r=janv. 2015-02-16 09:48:14 -08:00
Ben Turner 04cd5da921 Bug 866846 - Use WAL journal mode for IndexedDB databases, r=janv. 2015-01-24 08:16:26 -08:00
Ben Turner 056431018e Bug 1071360 - Fix async storage connection closing when open fails, r=asuth. 2015-03-27 22:45:28 -07:00
Mike Hommey c39e359c7d Bug 1138293 - Use malloc/free/realloc/calloc instead of moz_malloc/moz_free/moz_realloc/moz_calloc. r=njn
The distinction between moz_malloc/moz_free and malloc/free is not
interesting. We are inconsistent in our use of one or the other, and
I wouldn't be surprised if we are mixing them anyways.
2015-03-31 12:32:49 +09:00
Wes Kocher f8f506a4f1 Backed out changeset 8a8e8efa5d38 (bug 866846) 2015-03-30 19:45:59 -07:00
Wes Kocher 23dabfd770 Backed out changeset 14b9b4827805 (bug 1131776) 2015-03-30 19:45:55 -07:00
Wes Kocher 7a4995bb97 Backed out changeset d4fdf509f242 (bug 1071360) 2015-03-30 19:45:53 -07:00
Ben Turner 89115ceb72 Bug 1071360 - Fix async storage connection closing when open fails, r=asuth. 2015-03-30 13:33:39 -07:00
Ben Turner ad62e4a206 Bug 1131776 - Use WITHOUT ROWID tables for IndexedDB, r=janv. 2015-02-16 09:48:14 -08:00
Ben Turner f9c5b7e194 Bug 866846 - Use WAL journal mode for IndexedDB databases, r=janv. 2015-01-24 08:16:26 -08:00
Andrew McCreight 2f48802ae0 Bug 1147572 - Remove implementation language field from DOM class info. r=jst 2015-03-30 10:45:39 -07:00
Phil Ringnalda 74fbc95715 Backed out 5 changesets (bug 866846, bug 1131776, bug 1131766, bug 1144806, bug 1112702) on suspicion of causing Windows debug devtools-4 storage crashes
CLOSED TREE

Backed out changeset 142d9ae5826c (bug 1131776)
Backed out changeset 0b4de21b759f (bug 1112702)
Backed out changeset 1b4ead852ae0 (bug 1131766)
Backed out changeset cbd862dd036f (bug 866846)
Backed out changeset 178412a2fe8b (bug 1144806)
2015-03-29 12:55:11 -07:00
Andrew McCreight 46dfeaba0b Bug 1148070 - Change nsIClassInfo::getHelperForLanguage() to getScriptableHelper(). r=bholley 2015-03-29 07:52:54 -07:00
Ben Turner 98536af974 Bug 1131776 - Use WITHOUT ROWID tables for IndexedDB, r=janv.
--HG--
extra : rebase_source : 9cba58701e0f6bf4c3d6deb784b5c8340fd895ac
2015-02-16 09:48:14 -08:00
Ben Turner 85be2eae91 Bug 866846 - Use WAL journal mode for IndexedDB databases, r=janv.
--HG--
extra : rebase_source : 6bd130ec0bdbeacde6b725ee16736083775f8ca7
2015-01-24 08:16:26 -08:00
Andrea Marchesini e6f385fb3d Bug 1148527 - Indentation fix after bug 1145631, r=ehsan 2015-03-27 18:52:19 +00:00
Marco Bonardo ae5c54db33 Bug 1005991 - trivial fixes for non-unified builds. r=me 2015-03-24 01:09:13 +01:00
Ehsan Akhgari 883849ee32 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Marco Bonardo fbb580fcfc Bug 1005991 - mozStorage should not use XPCVariant off the main thread. r=asuth 2015-03-12 17:55:56 +01:00
Jon Coppeard a451fdfd83 Bug 963921 - Clients of the JS API should use JS_DefineElement where appropriate r=smaug 2015-03-02 13:31:15 +00:00
Nicholas Nethercote 242708cf72 Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo.
--HG--
extra : rebase_source : 488e401ff87e31a2074c4108c4df0572d9536667
2015-02-09 14:34:50 -08:00
Andrew McCreight d3826daa16 Back out Bug 1127201 (part 2) for various problems. 2015-02-06 15:04:32 -08:00
Nicholas Nethercote d34f0301b8 Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo.
--HG--
extra : rebase_source : 99182e70335d2b5ff95f8c528ae992d37294be3a
2015-02-04 20:05:36 -08:00
Marco Bonardo b04ae3b1d2 Bug 998330 - MinimizeMemory should happen on the opener thread, not on main-thread. r=asuth 2015-01-28 00:00:23 +01:00
Ben Turner afaefae6c7 Bug 1126129 - Only enable SQLite tracing when the right environment variable is set, r=asuth. 2015-01-26 19:38:49 -08:00
Ehsan Akhgari 73e2210610 Bug 1118414 - Mark virtual overridden functions as MOZ_OVERRIDE in storage; r=mak 2015-01-24 14:51:49 -05:00
Ehsan Akhgari 1e88271572 Bug 1119268 - Mark virtual overridden functions as MOZ_OVERRIDE in misc code; r=bsmedberg 2015-01-12 23:26:30 -05:00
Wes Kocher 4a8e595770 Backout c034dba7a417 2015-01-12 14:46:48 -08:00
Ehsan Akhgari d517a30886 Bug 1119268 - Mark virtual overridden functions as MOZ_OVERRIDE in misc code; r=bsmedberg 2015-01-12 16:35:06 -05:00
Tom Schuster 9dfe5c2fd4 Bug 1097267 - Change the enumerate hook usage in XPC and browser. r=bholley 2014-12-11 19:31:10 +01:00
Tom Schuster bc28949aec Bug 993026 - Change XPIDLScriptable NewResolve to simpler Resolve. r=bholley 2014-11-08 01:07:12 +01:00
Mike Hommey 47c853314f Bug 1077148 part 4 - Add and use new moz.build templates for Gecko programs and libraries. r=gps
There are, sadly, many combinations of linkage in use throughout the tree.
The main differentiator, though, is between program/libraries related to
Gecko or not. Kind of. Some need mozglue, some don't. Some need dependent
linkage, some standalone.

Anyways, these new templates remove the need to manually define the
right dependencies against xpcomglue, nspr, mozalloc and mozglue
in most cases.

Places that build programs and were resetting MOZ_GLUE_PROGRAM_LDFLAGS
or that build libraries and were resetting MOZ_GLUE_LDFLAGS can now
just not use those Gecko-specific templates.
2014-10-30 13:06:12 +09:00
Bobby Holley 8e4a68387a Bug 857138 - Add some cx parameters. r=bz 2014-10-23 19:53:31 +02:00
Andrew Halberstadt d292ee73f1 Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester 2014-10-07 18:18:28 -04:00